Allon Mureinik has posted comments on this change.
Change subject: core: WIP : RemoveImageDisk - race when updating snapshots ovf
(#828192)
..
Patch Set 5:
If you can show where/how - please do.
If you can't - please suggest a
Michael Kublin has posted comments on this change.
Change subject: core: WIP : RemoveImageDisk - race when updating snapshots ovf
(#828192)
..
Patch Set 5: Do not submit
Will cause to starvation.
--
To view, visit http://gerr
Liron Aravot has posted comments on this change.
Change subject: core: WIP : RemoveImageDisk - race when updating snapshots ovf
(#828192)
..
Patch Set 5: (1 inline comment)
Michael Pasternak has uploaded a new change for review.
Change subject: restapi: fix /Disk backward compatibility issue
..
restapi: fix /Disk backward compatibility issue
removing /type element from disk will cause
backward comp
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engines: improve data integrity in remove quota (#848816)
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/791/ : FA
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: informative message for vm console connect(#833730)
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/790/ :
Moti Asayag has abandoned this change.
Change subject: engine: Add network name to detach error message (#824497)
..
Patch Set 1: Abandoned
The client is not capable to support multiple messages with custom properties.
Message
Doron Fediuck has abandoned this change.
Change subject: engine: Updating the commit template
..
Patch Set 3: Abandoned
Discussion still ongoing.
Will submit a new change based on results.
--
To view, visit http://gerrit.ovirt
Ayal Baron has posted comments on this change.
Change subject: core: WIP : RemoveImageDisk - race when updating snapshots ovf
(#828192)
..
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Deny removal of used network (#824497)
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/789/ : SUCCESS
http
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Add network name to detach error message (#824497)
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/788/ : F
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core, packaging: Don't use JBoss default ports (#831193)
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/786/ : FAI
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Check HTTP response status for Reports.xml
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/785/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Gluster server peer list command
..
Patch Set 9:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/784/ : FAILURE
http://jen
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Refresh gluster data periodically
..
Patch Set 2: I would prefer that you didn't submit this
Build Failed
http://jenkins.ovirt.info/job/patch
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: minor canDoActionMesage simplification
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/781/ : FAILURE
http:/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: cleanup RemoveStoragePoolCommand
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/782/ : FAILURE
http://jenki
Moti Asayag has uploaded a new change for review.
Change subject: engine: Deny removal of used network (#824497)
..
engine: Deny removal of used network (#824497)
https://bugzilla.redhat.com/824497
The patch denies removal of a
Moti Asayag has uploaded a new change for review.
Change subject: engine: Add network name to detach error message (#824497)
..
engine: Add network name to detach error message (#824497)
https://bugzilla.redhat.com/824497
The n
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: do not remove DC if more than one domain (#806952)
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/780/ : FAI
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: cleanup RemoveStoragePoolCommand II
..
Patch Set 1: I would prefer that you didn't submit this
Build Failed
http://jenkins.ovirt.info/job/patch
Juan Hernandez has posted comments on this change.
Change subject: core, packaging: Don't use JBoss default ports (#831193)
..
Patch Set 5: Verified
Rebased and re-verified.
--
To view, visit http://gerrit.ovirt.org/6348
To un
Greg Padgett has posted comments on this change.
Change subject: engine: Exception when updating lun disk properties (#844153)
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/7230
To unsubscribe, visit http:/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engines: improve data integrity in remove quota (#848816)
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/772/ : FA
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: setting proper timeout mechanism for GetRootDSE (#844733)
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/771
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: informative message for vm console connect(#833730)
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/770/ :
Maor Lipchuk has posted comments on this change.
Change subject: core : correct message when suspending vm witout image
disks(#841504)
..
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6797
T
Allon Mureinik has posted comments on this change.
Change subject: core: add toString method to storage_server_connections
(#843112)
..
Patch Set 1: I would prefer that you didn't submit this
http://gerrit.ovirt.org/#/c/7192/
Federico Simoncelli has posted comments on this change.
Change subject: core: Allow to attach V1 and V2 data domains to a DC 3.1
..
Patch Set 3: (1 inline comment)
File
back
Vojtech Szocs has uploaded a new change for review.
Change subject: webadmin: Check HTTP response status for Reports.xml
..
webadmin: Check HTTP response status for Reports.xml
In ReportInit.parseReportsXML method, HTTP response
Maor Lipchuk has posted comments on this change.
Change subject: core: WIP : RemoveImageDisk - race when updating snapshots ovf
(#828192)
..
Patch Set 5: (1 inline comment)
Allon Mureinik has posted comments on this change.
Change subject: core: do not remove DC if more than one domain (#806952)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.o
Allon Mureinik has posted comments on this change.
Change subject: core: cleanup RemoveStoragePoolCommand
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7500
To unsubsc
Allon Mureinik has posted comments on this change.
Change subject: core: cleanup RemoveStoragePoolCommand II
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7508
To unsu
Allon Mureinik has posted comments on this change.
Change subject: core: minor canDoActionMesage simplification
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7510
To u
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Updated backups folder creation
..
packaging: Updated backups folder creation
Change-Id: I0e79b78f4448bbe5f20b4836983e916b60c06acd
Signed-of
Juan Hernandez has posted comments on this change.
Change subject: packaging: Updated backups folder creation
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7499
To unsubscribe, v
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Updated backups folder creation
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7499
To unsub
Alex Lourie has posted comments on this change.
Change subject: packaging: Updated backups folder creation
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
Updated to keep the backups folder owned by ro
Juan Hernandez has posted comments on this change.
Change subject: packaging: Updated backups folder creation
..
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
Just a minor comment inside.
...
Yair Zaslavsky has posted comments on this change.
Change subject: core: remove check for permissions on pool on detach user from
vm (#850741)
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.or
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: WIP : RemoveImageDisk - race when updating snapshots ovf
(#828192)
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Added new column 'ssh_key_fingerprint' in the
vds_static table
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
.
Gilad Chaplik has posted comments on this change.
Change subject: engines: improve data integrity in remove quota (#848816)
..
Patch Set 1:
Noam, please verify and I'll merge it :)
--
To view, visit http://gerrit.ovirt.org/750
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Updated backups folder creation
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7499
To unsub
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Get Server fingerprint query
..
Patch Set 9: I would prefer that you didn't submit this
(1 inline comment)
Changing to -1
Took me 2nd review to see we'
Alex Lourie has posted comments on this change.
Change subject: packaging: Updated backups folder creation
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
Built, installed set1, removed ../backups dir,
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Get Server fingerprint query
..
Patch Set 9: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7034
To unsubscribe, visit http://gerr
Yair Zaslavsky has posted comments on this change.
Change subject: bootstrap: allow retrieve ssh key fingerprint of server
..
Patch Set 6: Looks good to me, but someone else must approve
I would like Doron to review these as we
Yair Zaslavsky has posted comments on this change.
Change subject: core: fix comparison NPE
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7457
To unsubscribe, visit ht
Doron Fediuck has posted comments on this change.
Change subject: core: fix comparison NPE
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7457
To unsubscribe, visit htt
Doron Fediuck has posted comments on this change.
Change subject: common: handle resources if path contains special characters
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7497
To unsubsc
Doron Fediuck has posted comments on this change.
Change subject: engines: improve data integrity in remove quota (#848816)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7505
To unsubscrib
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2314/
Build Number: 2314
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 2,869
-
Changes Since La
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2313/
Build Number: 2313
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 2,868
-
Changes Since
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Deatch network doesn't closed in case of an
error (#849889)
..
webadmin: Deatch network doesn't closed in case of an error (#849889
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Deatch network doesn't closed in case of an
error (#849889)
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http:
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Add confirm dialog to "save network configuration"
(#823922)
..
webadmin: Add confirm dialog to "save network configuration" (#823922)
https:/
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Add confirm dialog to "save network configuration"
(#823922)
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://ger
Liron Aravot has posted comments on this change.
Change subject: core: WIP : RemoveImageDisk - race when updating snapshots ovf
(#828192)
..
Patch Set 4: (1 inline comment)
Gilad Chaplik has posted comments on this change.
Change subject: engines: improve data integrity in remove quota (#848816)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.o
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bootstrap: allow retrieve ssh key fingerprint of server
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/754/ :
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin: Fix potential NPE in MainTabHostView
..
webadmin: Fix potential NPE in MainTabHostView
In Host "Load" column, fixed potential NPE coming from
ge
Einav Cohen has posted comments on this change.
Change subject: webadmin: Fix potential NPE in MainTabHostView
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7498
To unsubscribe,
Juan Hernandez has posted comments on this change.
Change subject: cleanup: remove void statement from cert.conf
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6882
To
Juan Hernandez has posted comments on this change.
Change subject: common: handle resources if path contains special characters
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovi
Oved Ourfali has posted comments on this change.
Change subject: core: setting proper timeout mechanism for GetRootDSE (#844733)
..
Patch Set 4: (1 inline comment)
File backe
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: call AttachDiskToVm with RunAction (#849443)
..
webadmin: call AttachDiskToVm with RunAction (#849443)
https://bugzilla.redhat.com/849443
Calli
Daniel Erez has posted comments on this change.
Change subject: webadmin: call AttachDiskToVm with RunAction (#849443)
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/7503
Oved Ourfali has posted comments on this change.
Change subject: core: setting proper timeout mechanism for GetRootDSE (#844733)
..
Patch Set 4: (1 inline comment)
File backe
Noam Slomianko has uploaded a new change for review.
Change subject: engines: improve data integrity in remove quota (#848816)
..
engines: improve data integrity in remove quota (#848816)
https://bugzilla.redhat.com/848816
Prob
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: call AttachDiskToVm with RunAction (#849443)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7503
To unsubscribe,
Yair Zaslavsky has posted comments on this change.
Change subject: core: setting proper timeout mechanism for GetRootDSE (#844733)
..
Patch Set 4: (1 inline comment)
File bac
Oved Ourfali has posted comments on this change.
Change subject: core: setting proper timeout mechanism for GetRootDSE (#844733)
..
Patch Set 4: (2 inline comments)
minor comments
..
Yair Zaslavsky has posted comments on this change.
Change subject: core: setting proper timeout mechanism for GetRootDSE (#844733)
..
Patch Set 4: Looks good to me, approved
Looks good.
However, we should work on the exception
Daniel Erez has posted comments on this change.
Change subject: webadmin: Add confirm dialog to "save network configuration"
(#823922)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7501
T
Daniel Erez has posted comments on this change.
Change subject: webadmin: Deatch network doesn't closed in case of an
error (#849889)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7
Oved Ourfali has posted comments on this change.
Change subject: [WIP] core: setting proper timeout mechanism for GetRootDSE
(#844733)
..
Patch Set 3:
good work indeed!
--
To view, visit http://gerrit.ovirt.org/7479
To unsubs
Yair Zaslavsky has posted comments on this change.
Change subject: [WIP] core: setting proper timeout mechanism for GetRootDSE
(#844733)
..
Patch Set 3:
Looks good,
One last issue -
WIP stands for work in progress.
Please rem
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Added functions references for cleaner code.
..
packaging: Added functions references for cleaner code.
Change-Id: Ic8fec87bf8dc99e990cb62d8
Juan Hernandez has posted comments on this change.
Change subject: packaging: Added functions references for cleaner code.
..
Patch Set 3: Verified; Looks good to me, approved
Merging based on previous acks and verification.
-
Daniel Erez has posted comments on this change.
Change subject: webadmin: call AttachDiskToVm with RunAction (#849443)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7503
To unsubscribe, visit http://gerrit.
Juan Hernandez has posted comments on this change.
Change subject: packaging: Added functions references for cleaner code.
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7465
To unsubscribe
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: call AttachDiskToVm with RunAction (#849443)
..
webadmin: call AttachDiskToVm with RunAction (#849443)
https://bugzilla.redhat.com/849443
Calling Attac
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: Deatch network doesn't closed in case of an
error (#849889)
..
webadmin: Deatch network doesn't closed in case of an error (#849889)
https
oVirt Jenkins CI Server has posted comments on this change.
Change subject: common: handle resources if path contains special characters
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/752/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: webadmin: Fix potential NPE in MainTabHostView
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/753/ : FAILURE
http
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: informative message for vm console connect(#833730)
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/751/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: remove check for permissions on pool on detach user from
vm (#850741)
..
Patch Set 2: I would prefer that you didn't submit this
Build Failed
Yair Zaslavsky has posted comments on this change.
Change subject: [WIP] core: setting proper timeout mechanism for GetRootDSE
(#844733)
..
Patch Set 2: (6 inline comments)
Some comments, general concept and CORRECT usage (for
Omer Frenkel has posted comments on this change.
Change subject: engine: informative message for vm console connect(#833730)
..
Patch Set 1: (1 inline comment)
comment inside, also missing changes to properties files, please fo
Oved Ourfali has posted comments on this change.
Change subject: [WIP] core: setting proper timeout mechanism for GetRootDSE
(#844733)
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7479
T
Shireesh Anjal has posted comments on this change.
Change subject: engine: informative message for vm console connect(#833730)
..
Patch Set 1: Looks good to me, but someone else must approve
Changes in couple of gluster related
Noam Slomianko has posted comments on this change.
Change subject: engine: informative message for vm console connect(#833730)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7496
To unsubscribe, visit http:/
Liron Aravot has posted comments on this change.
Change subject: core: WIP : RemoveImageDisk - race when updating snapshots ovf
(#828192)
..
Patch Set 4: (3 inline comments)
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: Add confirm dialog to "save network configuration"
(#823922)
..
webadmin: Add confirm dialog to "save network configuration" (#823922)
https://bugzill
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: check and peer probe gluster servers
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_gwt_admin/748/ : SUCCESS
http:/
Alex Lourie has uploaded a new change for review.
Change subject: packaging: Updated backups folder creation
..
packaging: Updated backups folder creation
Change-Id: I0e79b78f4448bbe5f20b4836983e916b60c06acd
Signed-off-by: Alex
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: use cached /filter argument rather than demanding it in
methods
..
sdk: use cached /filter argument rather than demanding it in methods
Filter
Michael Pasternak has posted comments on this change.
Change subject: sdk: use cached /filter argument rather than demanding it in
methods
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ov
1 - 100 of 194 matches
Mail list logo
