Moti Asayag has posted comments on this change.
Change subject: core: Use StringUtils and getDbFacade (#824497)
..
Patch Set 2: (1 inline comment)
File
backend/manager/modul
Noam Slomianko has uploaded a new change for review.
Change subject: webadmin: adding map porting indication to network interface
(#845991)
..
webadmin: adding map porting indication to network interface (#845991)
https://bugzi
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Comment out MonitoringStrategyFactoryTest
..
core: Comment out MonitoringStrategyFactoryTest
As per the decision to remove PowerMock dependencies f
Oved Ourfali has posted comments on this change.
Change subject: core: Comment out MonitoringStrategyFactoryTest
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7123
To unsubscribe
Livnat Peer has posted comments on this change.
Change subject: core: Use StringUtils and getDbFacade (#824497)
..
Patch Set 2: Looks good to me, approved
(1 inline comment)
Moti Asayag has posted comments on this change.
Change subject: core: Use StringUtils and getDbFacade (#824497)
..
Patch Set 2: (1 inline comment)
File
backend/manager/modul
Livnat Peer has posted comments on this change.
Change subject: core: Use StringUtils and getDbFacade (#824497)
..
Patch Set 2: (1 inline comment)
File
backend/manager/modul
Einav's patch is indeed unrelated (only, perhaps, due to some butterfly effect).
Fix is pending review.
- Original Message -
> From: "Einav Cohen"
> To: ee...@redhat.com, "Allon Mureinik" , "Oved Ourfalli"
>
> Cc: engine-patches@ovirt.org
> Sent: Monday, August 13, 2012 8:18:38 AM
> Sub
Allon Mureinik has posted comments on this change.
Change subject: core: Comment out MonitoringStrategyFactoryTest
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7123
To unsubscribe, visit http://gerrit.ovir
Allon Mureinik has uploaded a new change for review.
Change subject: core: Comment out MonitoringStrategyFactoryTest
..
core: Comment out MonitoringStrategyFactoryTest
As per the decision to remove PowerMock dependencies from th
Moti Asayag has posted comments on this change.
Change subject: core: Use StringUtils and getDbFacade (#824497)
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/7106
To unsubscribe, visit http://gerrit.ovirt.o
Not sure how a pure GUI patch (http://gerrit.ovirt.org/#/c/6874/) caused the
following vdsbroker tests to fail:
testMonitoringStrategyFactoryGlusterStrategy(org.ovirt.engine.core.vdsbroker.MonitoringStrategyFactoryTest)
testMonitoringStrategyFactoryBothStrategy(org.ovirt.engine.core.vdsbroker.Mon
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/2099/
Build Number: 2099
Build Status: Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 2,716
-
Changes Sin
Einav Cohen has submitted this change and it was merged.
Change subject: userportal: VM/Pool/Template component element IDs
..
userportal: VM/Pool/Template component element IDs
This patch adds IDs to following UserPortal visua
Einav Cohen has posted comments on this change.
Change subject: userportal: VM/Pool/Template component element IDs
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6958
To unsubscri
Alon Bar-Lev has posted comments on this change.
Change subject: build: sync packaging with engine
..
Patch Set 1:
Not perfect, but a good base.
Yaniv, I would appreciate if you test this package, most probably I missed some
Alon Bar-Lev has uploaded a new change for review.
Change subject: build: sync packaging with engine
..
build: sync packaging with engine
1. Support branding.
2. Support rpmbuild -tb for tarball.
3. Accept file locations from
Moti Asayag has posted comments on this change.
Change subject: core: Deny removing network which is used by VMs (#824497)
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/7107
To unsubscribe, visit http://ger
Ayal Baron has posted comments on this change.
Change subject: core: AsyncTaskDAO: Replaced FCQNs with imports
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Ayal Baron has posted comments on this change.
Change subject: core: AsyncTaskDAO: make log final
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7111
To unsubscribe, vi
Ayal Baron has posted comments on this change.
Change subject: core: SPMAsyncTask: Make logger final
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7110
To unsubscribe,
Itamar Heim has uploaded a new change for review.
Change subject: dummy patch to test NewChange email template
..
dummy patch to test NewChange email template
Change-Id: I7a1a0fa7129a011922b6c0f6079a6d43e6cab532
Signed-off-by: I
Itamar Heim has abandoned this change.
Change subject: dummy patch to test NewChange email template
..
Patch Set 1: Abandoned
test
--
To view, visit http://gerrit.ovirt.org/7121
To unsubscribe, visit http://gerrit.ovirt.org/se
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: ImportVmCommand - added method getUpdatedVmForOperation()
..
Patch Set 15:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_manager/76/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: enable import/export of diskless VM/VM with no snappable
disks(#838937)
..
Patch Set 14:
Build Failed
http://jenkins.ovirt.info/job/patch_engi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: ImportVmCommand -remove EndImportCommand() method
..
Patch Set 17:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_manager/73/ : FAILUR
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: ImportVmCommand - added method getUpdatedVmForOperation()
..
Patch Set 15:
Build Started http://jenkins.ovirt.info/job/patch_engine_manager/76/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: enable import/export of diskless VM/VM with no snappable
disks(#838937)
..
Patch Set 14:
Build Started http://jenkins.ovirt.info/job/patch_engin
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: ImportVmCommand -remove EndImportCommand() method
..
Patch Set 17:
Build Started http://jenkins.ovirt.info/job/patch_engine_manager/73/
--
To vi
Juan Hernandez has posted comments on this change.
Change subject: pki: remove the need to store ssh public key
..
Patch Set 10: (15 inline comments)
File backend/manager/con
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/2097/
Build Number: 2097
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 2,714
-
Changes Since
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVmCommand - added method getUpdatedVmForOperation()
..
Patch Set 15: I would prefer that you didn't submit this
Please either address my comments fo
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVmCommand -remove EndImportCommand() method
..
Patch Set 17: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.o
Allon Mureinik has posted comments on this change.
Change subject: core: enable import/export of diskless VM/VM with no snappable
disks(#838937)
..
Patch Set 14: Looks good to me, but someone else must approve
--
To view, visi
Gilad Chaplik has posted comments on this change.
Change subject: userportal: VM/Pool/Template component element IDs
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6958
To unsubscribe, visi
Allon Mureinik has posted comments on this change.
Change subject: core: AsyncTaskDAO: Replaced FCQNs with imports
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7117
To unsubscribe, visit http://gerrit.ovir
Allon Mureinik has posted comments on this change.
Change subject: core: AsyncTaskDAO: Made private methods static
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7116
To unsubscribe, visit http://gerrit.ovir
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Updating the commit template
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_manager/49/ : FAILURE
--
To view, visit
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/2096/
Build Number: 2096
Build Status: Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 2,713
-
Changes Sin
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core : create template from VM with no snappable disks (#841534)
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.info/job/patch_engine_manager/47/
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: fix remove-quota test (#844652)
..
core: fix remove-quota test (#844652)
https://bugzilla.redhat.com/844652
Fix the remove quota test.
Change-Id
Gilad Chaplik has posted comments on this change.
Change subject: core: fix remove-quota test (#844652)
..
Patch Set 2: Verified
reviewed
--
To view, visit http://gerrit.ovirt.org/7118
To unsubscribe, visit http://gerrit.ovirt
Roy Golan has posted comments on this change.
Change subject: core: fix remove-quota test (#844652)
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7118
To unsubscribe, visit http://gerrit.o
Gilad Chaplik has posted comments on this change.
Change subject: core: fix remove-quota test (#844652)
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7118
To unsubscri
ofri masad has uploaded a new change for review.
Change subject: core: fix remove-quota test (#844652)
..
core: fix remove-quota test (#844652)
https://bugzilla.redhat.com/844652
Fix the remove quota test.
Change-Id: I1c190bf0
Maor Lipchuk has posted comments on this change.
Change subject: core:Add connection to DB after connectVds(#815083)
..
Patch Set 2: (2 inline comments)
File
backend/manager
Gilad Chaplik has submitted this change and it was merged.
Change subject: backend: Fix 'remove-quota' canDo logic (#844652)
..
backend: Fix 'remove-quota' canDo logic (#844652)
https://bugzilla.redhat.com/844652
The logic of
Gilad Chaplik has posted comments on this change.
Change subject: backend: Fix 'remove-quota' canDo logic (#844652)
..
Patch Set 4: Verified; Looks good to me, approved
rebased & reviewed
--
To view, visit http://gerrit.ovirt.
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Bad formatting in dialog (#835404)
..
webadmin: Bad formatting in dialog (#835404)
https://bugzilla.redhat.com/835404
When the user trys to "
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Bad formatting in dialog (#835404)
..
Patch Set 2: Verified; Looks good to me, approved
rebased & reviewed
--
To view, visit http://gerrit.ovirt.org/6
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: misleading info in edit quota (#838594)
..
webadmin: misleading info in edit quota (#838594)
https://bugzilla.redhat.com/838594
Change-Id: Ib
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: misleading info in edit quota (#838594)
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/7104
To
Daniel Erez has posted comments on this change.
Change subject: webadmin: Allow edit of Direct LUN VM disks
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/7069
To unsubsc
Maor Lipchuk has posted comments on this change.
Change subject: engine:Remaining disks of deleted VM will be ILLEGAL.(#822051)
..
Patch Set 8: (4 inline comments)
File
back
Allon Mureinik has uploaded a new change for review.
Change subject: core: AsyncTaskDAO: Made private methods static
..
core: AsyncTaskDAO: Made private methods static
Wherever possible, made private methods static, as this enti
Allon Mureinik has uploaded a new change for review.
Change subject: core: AsyncTaskDAO: Replaced FCQNs with imports
..
core: AsyncTaskDAO: Replaced FCQNs with imports
Replaced FQCN references with imports in order to clean up t
Allon Mureinik has abandoned this change.
Change subject: core: AsyncTaskDAO: Made private methods static
..
Patch Set 1: Abandoned
submitted by git foobar
--
To view, visit http://gerrit.ovirt.org/7114
To unsubscribe, visit h
Allon Mureinik has abandoned this change.
Change subject: core: AsyncTaskDAO: Replaced FCQNs with imports
..
Patch Set 1: Abandoned
submitted by git foobar
--
To view, visit http://gerrit.ovirt.org/7115
To unsubscribe, visit h
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: ERROR: managed non pluggable device (#845207)
..
core: ERROR: managed non pluggable device (#845207)
https://bugzilla.redhat.com/show_bug.cgi?id=
Yair Zaslavsky has posted comments on this change.
Change subject: core: ERROR: managed non pluggable device (#845207)
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6983
To unsub
Daniel Erez has posted comments on this change.
Change subject: webadmin: misleading info in edit quota (#838594)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7104
To unsubscribe, visit h
oVirt Jenkins CI Server has posted comments on this change.
Change subject: engine: Updating the commit template
..
Patch Set 2:
Build Started http://jenkins.ovirt.info/job/patch_engine_manager/49/
--
To view, visit http://ger
Allon Mureinik has posted comments on this change.
Change subject: core: AsyncTaskDAO: Made private methods static
..
Patch Set 1: Verified; No score
--
To view, visit http://gerrit.ovirt.org/7114
To unsubscribe, visit http://g
Allon Mureinik has posted comments on this change.
Change subject: core: AsyncTaskDAO: Made private methods static
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7114
T
Allon Mureinik has posted comments on this change.
Change subject: core: AsyncTaskDAO: static AsyncTaskRowMapper instance
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7113
To unsubscribe, visit http://gerr
Allon Mureinik has posted comments on this change.
Change subject: core: AsyncTaskDAO: static IdRowMapper instance
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7112
To unsubscribe, visit http://gerrit.ovir
Allon Mureinik has posted comments on this change.
Change subject: core: AsyncTaskDAO: make log final
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7111
To unsubscribe, visit http://gerrit.ovirt.org/setting
Allon Mureinik has posted comments on this change.
Change subject: core: SPMAsyncTask: Make logger final
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7110
To unsubscribe, visit http://gerrit.ovirt.org/sett
Allon Mureinik has posted comments on this change.
Change subject: core: AsyncTaskManager: Useless @SuppressWarnings
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7109
To unsubscribe, visit http://gerrit.ov
Gilad Chaplik has posted comments on this change.
Change subject: backend: Fix 'remove-quota' canDo logic (#844652)
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6926
To unsubscribe, visit
Allon Mureinik has uploaded a new change for review.
Change subject: core: AsyncTaskDAO: Made private methods static
..
core: AsyncTaskDAO: Made private methods static
Wherever possible, made private methods static, as this enti
Allon Mureinik has uploaded a new change for review.
Change subject: core: AsyncTaskDAO: Replaced FCQNs with imports
..
core: AsyncTaskDAO: Replaced FCQNs with imports
Replaced FQCN references with imports in order to clean up t
Allon Mureinik has uploaded a new change for review.
Change subject: core: AsyncTaskDAO: make log final
..
core: AsyncTaskDAO: make log final
Made the logger final to stress that it's immutable.
If we can also gain a slight perf
Allon Mureinik has uploaded a new change for review.
Change subject: core: AsyncTaskDAO: static IdRowMapper instance
..
core: AsyncTaskDAO: static IdRowMapper instance
Added and used a static instance for the IdRowMapper class,
Allon Mureinik has uploaded a new change for review.
Change subject: core: AsyncTaskDAO: static AsyncTaskRowMapper instance
..
core: AsyncTaskDAO: static AsyncTaskRowMapper instance
Added and used a static instance for the Async
Allon Mureinik has uploaded a new change for review.
Change subject: core: SPMAsyncTask: Make logger final
..
core: SPMAsyncTask: Make logger final
Flagged the logger as final to stress the fact that it's immutable.
In addition,
Allon Mureinik has uploaded a new change for review.
Change subject: core: AsyncTaskManager: Useless @SuppressWarnings
..
core: AsyncTaskManager: Useless @SuppressWarnings
Removed a useless @SuppressWarnings("unchecked") annotat
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core : create template from VM with no snappable disks (#841534)
..
Patch Set 4:
Build Started http://jenkins.ovirt.info/job/patch_engine_manager/47/
Allon Mureinik has posted comments on this change.
Change subject: engine:Remaining disks of deleted VM will be ILLEGAL.(#822051)
..
Patch Set 8: Looks good to me, but someone else must approve
(2 inline comments)
looks reason
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Bad formatting in dialog (#835404)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6910
To unsubscribe, visit http
ofri masad has posted comments on this change.
Change subject: backend: Fix 'remove-quota' canDo logic (#844652)
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/6926
To unsubscribe, visit http://gerrit.ovirt.
Daniel Erez has submitted this change and it was merged.
Change subject: core: fix removal of lun disk with no vm (#841265)
..
core: fix removal of lun disk with no vm (#841265)
https://bugzilla.redhat.com/841265
when trying t
Daniel Erez has posted comments on this change.
Change subject: core: fix removal of lun disk with no vm (#841265)
..
Patch Set 4: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/6566
To
Daniel Erez has submitted this change and it was merged.
Change subject: core: added ReconstructMasterDomain execution message (#841528)
..
core: added ReconstructMasterDomain execution message (#841528)
the ReconstructMasterDo
Daniel Erez has posted comments on this change.
Change subject: core: added ReconstructMasterDomain execution message (#841528)
..
Patch Set 4: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt
Daniel Erez has submitted this change and it was merged.
Change subject: core : NewTemplateVmModelBehavior - added Override annotation
..
core : NewTemplateVmModelBehavior - added Override annotation
InitStorageDomains() method
Daniel Erez has posted comments on this change.
Change subject: core : NewTemplateVmModelBehavior - added Override annotation
..
Patch Set 4: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.o
Daniel Erez has submitted this change and it was merged.
Change subject: core: ImportVmCommand - changed method UpdateVmImSpm() name
..
core: ImportVmCommand - changed method UpdateVmImSpm() name
changed the method's name to up
Daniel Erez has posted comments on this change.
Change subject: core: ImportVmCommand - changed method UpdateVmImSpm() name
..
Patch Set 17: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.or
Yair Zaslavsky has posted comments on this change.
Change subject: core: ERROR: managed non pluggable device (#845207)
..
Patch Set 3:
Rebase, already approved by Moti Asayag
--
To view, visit http://gerrit.ovirt.org/6983
To u
Yair Zaslavsky has posted comments on this change.
Change subject: core: ERROR: managed non pluggable device (#845207)
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6983
To unsubscribe, vi
Moti Asayag has uploaded a new change for review.
Change subject: core: Deny removing network which is used by VMs (#824497)
..
core: Deny removing network which is used by VMs (#824497)
https://bugzilla.redhat.com/824497
The p
Moti Asayag has uploaded a new change for review.
Change subject: core: Deny removing network which is used by VMs (#824497)
..
core: Deny removing network which is used by VMs (#824497)
https://bugzilla.redhat.com/824497
The p
Kiril Nesenko has posted comments on this change.
Change subject: packaging: Do not allow whitespaces in passwords (#BZ835363)
..
Patch Set 5: Verified; Looks good to me, but someone else must approve
--
To view, visit http://g
Michael Kublin has posted comments on this change.
Change subject: core: SPM election loop if auto-recovery tries to activate
non-existing storage domain (#821634)
..
Patch Set 2:
Activate can be triggered from couple of place
Michael Kublin has posted comments on this change.
Change subject: engine:Remaining disks of deleted VM will be ILLEGAL.(#822051)
..
Patch Set 8: (2 inline comments)
small remarks
..
Michael Kublin has posted comments on this change.
Change subject: core:Add connection to DB after connectVds(#815083)
..
Patch Set 2: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/3784
To
Michael Kublin has posted comments on this change.
Change subject: core: RemoveDiskCommand - added TODO comments
..
Patch Set 2: (1 inline comment)
Commit Message
Line 21:
i
Michael Kublin has posted comments on this change.
Change subject: core: RemoveDiskCommand - added TODO comments
..
Patch Set 2: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/6604
To unsub
Michael Kublin has posted comments on this change.
Change subject: core: RemoveDiskCommand - added TODO comments
..
Patch Set 2: (1 inline comment)
File
backend/manager/modu
1 - 100 of 233 matches
Mail list logo
