[Engine-patches] Change in ovirt-engine[master]: core: simplify 'is null' sql expression

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: simplify 'is null' sql expression .. Patch Set 3: Build Successful http://jenkins.ovirt.info/job/patch_ovirt_engine/58/ : SUCCESS -- To view,

[Engine-patches] Change in ovirt-engine[master]: core: add unused variable

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: add unused variable .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_ovirt_engine/57/ : SUCCESS -- To view, visit http://g

[Engine-patches] Change in ovirt-engine[master]: core: simplify 'is null' sql expression

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: simplify 'is null' sql expression .. Patch Set 3: Build Started http://jenkins.ovirt.info/job/patch_ovirt_engine/58/ -- To view, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: core: add unused variable

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: add unused variable .. Patch Set 1: Build Started http://jenkins.ovirt.info/job/patch_ovirt_engine/57/ -- To view, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: engine: Get Host fingerprint query

2012-08-09 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: engine: Get Host fingerprint query .. Patch Set 2: (1 inline comment) File backend/manager/modules/common/

[Engine-patches] Change in ovirt-engine[master]: bootstrap: move node id creation command to configuration

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: bootstrap: move node id creation command to configuration .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_ovirt_engine/56/ : SUC

[Engine-patches] Change in ovirt-engine[master]: bootstrap: move node id creation command to configuration

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: bootstrap: move node id creation command to configuration .. Patch Set 2: Build Started http://jenkins.ovirt.info/job/patch_ovirt_engine/56/ -- To vie

[Engine-patches] Change in ovirt-engine[master]: bootstrap: move node id creation command to configuration

2012-08-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: move node id creation command to configuration .. Patch Set 1: You are so right! I am very sorry, don't know how it built for me... strange! Thanks!

[Engine-patches] Change in ovirt-engine[master]: bootstrap: move node id creation command to configuration

2012-08-09 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: bootstrap: move node id creation command to configuration .. Patch Set 1: I would prefer that you didn't submit this (2 inline comments) Please look at inline c

[Engine-patches] Change in ovirt-engine[master]: core: Option with empty name and value ...

2012-08-09 Thread emesika
Eli Mesika has submitted this change and it was merged. Change subject: core: Option with empty name and value ... .. core: Option with empty name and value ... Option with empty name and value in the request's xml to rest-api

[Engine-patches] Change in ovirt-engine[master]: core: Option with empty name and value ...

2012-08-09 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: Option with empty name and value ... .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5656 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core: Option with empty name and value ...

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Option with empty name and value ... .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_ovirt_engine/55/ : SUCCESS -- To vie

[Engine-patches] Change in ovirt-engine[master]: core: Option with empty name and value ...

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Option with empty name and value ... .. Patch Set 2: Build Started http://jenkins.ovirt.info/job/patch_ovirt_engine/55/ -- To view, visit http:/

[Engine-patches] Change in ovirt-engine[master]: core: misleading error when trying to fen(#843168)

2012-08-09 Thread emesika
Eli Mesika has submitted this change and it was merged. Change subject: core: misleading error when trying to fen(#843168) .. core: misleading error when trying to fen(#843168) ovirt-engine-backend: misleading error when trying

[Engine-patches] Change in ovirt-engine[master]: core: misleading error when trying to fen(#843168)

2012-08-09 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: misleading error when trying to fen(#843168) .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/6879 To unsubscribe, visit http://gerrit.ovirt

[Engine-patches] Change in ovirt-engine[master]: core: misleading error when trying to fen(#843168)

2012-08-09 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: misleading error when trying to fen(#843168) .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6879 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: core: misleading error when trying to fen(#843168)

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: misleading error when trying to fen(#843168) .. Patch Set 3: Build Successful http://jenkins.ovirt.info/job/patch_ovirt_engine/54/ : SUCCESS -

[Engine-patches] Change in ovirt-engine[master]: core: misleading error when trying to fen(#843168)

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: misleading error when trying to fen(#843168) .. Patch Set 3: Build Started http://jenkins.ovirt.info/job/patch_ovirt_engine/54/ -- To view, visi

[Engine-patches] Change in ovirt-engine[master]: core:we do not clean alerts from the weba(#840495)

2012-08-09 Thread emesika
Eli Mesika has submitted this change and it was merged. Change subject: core:we do not clean alerts from the weba(#840495) .. core:we do not clean alerts from the weba(#840495) we do not clean alerts from the webadmin once fixe

[Engine-patches] Change in ovirt-engine[master]: core:we do not clean alerts from the weba(#840495)

2012-08-09 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core:we do not clean alerts from the weba(#840495) .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6880 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: core:we do not clean alerts from the weba(#840495)

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core:we do not clean alerts from the weba(#840495) .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_ovirt_engine/53/ : SUCCESS -

[Engine-patches] Change in ovirt-engine[master]: core:we do not clean alerts from the weba(#840495)

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core:we do not clean alerts from the weba(#840495) .. Patch Set 2: Build Started http://jenkins.ovirt.info/job/patch_ovirt_engine/53/ -- To view, visi

[Engine-patches] Change in ovirt-engine[master]: webadmin: Allow edit of Direct LUN VM disks

2012-08-09 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Allow edit of Direct LUN VM disks .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7069 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: core: Improve error message on failed host install.

2012-08-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: core: Improve error message on failed host install. .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/7076 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: core: Improve error message on failed host install.

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Improve error message on failed host install. .. Patch Set 1: Build Started http://jenkins.ovirt.info/job/patch_ovirt_engine/52/ -- To view, vis

[Engine-patches] Change in ovirt-engine[master]: core: Improve error message on failed host install.

2012-08-09 Thread Sharad Mishra
Sharad Mishra has uploaded a new change for review. Change subject: core: Improve error message on failed host install. .. core: Improve error message on failed host install. I ran into this issue earlier this week when adding a

[Engine-patches] Change in ovirt-engine[master]: core: Improve error message on failed host install.

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Improve error message on failed host install. .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_ovirt_engine/52/ : SUCCESS

[Engine-patches] Change in ovirt-engine[master]: cleanup: remove org.ovirt.engine.core.utils.hostinstall.Cred...

2012-08-09 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: cleanup: remove org.ovirt.engine.core.utils.hostinstall.Credentials .. Patch Set 11: Looks good to me, but someone else must approve -- To view, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: bootstrap: move node id creation command to configuration

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: bootstrap: move node id creation command to configuration .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_ovirt_engine/45/ : SUC

[Engine-patches] Change in ovirt-engine[master]: webadmin: Allow edit of Direct LUN VM disks

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Allow edit of Direct LUN VM disks .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_ovirt_engine/46/ : SUCCESS -- To vi

[Engine-patches] Change in ovirt-engine[master]: core : WIP : added ReconstructMasterDomain to InitVdsOnUpCom...

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core : WIP : added ReconstructMasterDomain to InitVdsOnUpCommand (#840838) .. Patch Set 7: Build Successful http://jenkins.ovirt.info/job/patch_ovir

[Engine-patches] Change in ovirt-engine[master]: webadmin: Allow edit of Direct LUN VM disks

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Allow edit of Direct LUN VM disks .. Patch Set 1: Build Started http://jenkins.ovirt.info/job/patch_ovirt_engine/46/ -- To view, visit http:

[Engine-patches] Change in ovirt-engine[master]: bootstrap: move node id creation command to configuration

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: bootstrap: move node id creation command to configuration .. Patch Set 1: Build Started http://jenkins.ovirt.info/job/patch_ovirt_engine/45/ -- To vie

[Engine-patches] Change in ovirt-engine[master]: core: when iso domain is inactive we still go to the cache

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: when iso domain is inactive we still go to the cache .. Patch Set 4: Build Successful http://jenkins.ovirt.info/job/patch_ovirt_engine/39/ : SU

[Engine-patches] Change in ovirt-engine[master]: core: Support undoing diskless previews

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Support undoing diskless previews .. Patch Set 9: Build Successful http://jenkins.ovirt.info/job/patch_ovirt_engine/38/ : SUCCESS -- To view,

[Engine-patches] Change in ovirt-engine[master]: core : WIP : added ReconstructMasterDomain to InitVdsOnUpCom...

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core : WIP : added ReconstructMasterDomain to InitVdsOnUpCommand (#840838) .. Patch Set 7: Build Started http://jenkins.ovirt.info/job/patch_ovirt_eng

[Engine-patches] Change in ovirt-engine[master]: core:encrypt vds_static pm_password field on upgrade to 3.1

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core:encrypt vds_static pm_password field on upgrade to 3.1 .. Patch Set 3: Build Successful http://jenkins.ovirt.info/job/patch_ovirt_engine/34/ : S

[Engine-patches] Change in ovirt-engine[master]: core: db function extensions

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: db function extensions .. Patch Set 3: Build Successful http://jenkins.ovirt.info/job/patch_ovirt_engine/33/ : SUCCESS -- To view, visit http:

[Engine-patches] Change in ovirt-engine[master]: core: when iso domain is inactive we still go to the cache

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: when iso domain is inactive we still go to the cache .. Patch Set 4: Build Started http://jenkins.ovirt.info/job/patch_ovirt_engine/39/ -- To vi

[Engine-patches] Change in ovirt-engine[master]: core: Support undoing diskless previews

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Support undoing diskless previews .. Patch Set 9: Build Started http://jenkins.ovirt.info/job/patch_ovirt_engine/38/ -- To view, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: core:encrypt vds_static pm_password field on upgrade to 3.1

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core:encrypt vds_static pm_password field on upgrade to 3.1 .. Patch Set 3: Build Started http://jenkins.ovirt.info/job/patch_ovirt_engine/34/ -- To v

[Engine-patches] Change in ovirt-engine[master]: webadmin: Allow edit of Direct LUN VM disks

2012-08-09 Thread gpadgett
Greg Padgett has uploaded a new change for review. Change subject: webadmin: Allow edit of Direct LUN VM disks .. webadmin: Allow edit of Direct LUN VM disks https://bugzilla.redhat.com/847094 When editing a Direct LUN VM disk,

[Engine-patches] Change in ovirt-engine[master]: core: db function extensions

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: db function extensions .. Patch Set 3: Build Started http://jenkins.ovirt.info/job/patch_ovirt_engine/33/ -- To view, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: bootstrap: move node id creation command to configuration

2012-08-09 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: bootstrap: move node id creation command to configuration .. bootstrap: move node id creation command to configuration This will enable to modify the command on

[Engine-patches] Change in ovirt-engine[master]: webadmin: Updated SPICE cab download fix (#846341)

2012-08-09 Thread ecohen
Einav Cohen has submitted this change and it was merged. Change subject: webadmin: Updated SPICE cab download fix (#846341) .. webadmin: Updated SPICE cab download fix (#846341) https://bugzilla.redhat.com/846341 Before this p

[Engine-patches] Change in ovirt-engine[master]: webadmin: Updated SPICE cab download fix (#846341)

2012-08-09 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: webadmin: Updated SPICE cab download fix (#846341) .. Patch Set 2: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/7065 To

[Engine-patches] Change in ovirt-engine[master]: core:we do not clean alerts from the weba(#840495)

2012-08-09 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: core:we do not clean alerts from the weba(#840495) .. Patch Set 1: sounds good. -- To view, visit http://gerrit.ovirt.org/6880 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: core:No need to call super method for job properties(#818295...

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core:No need to call super method for job properties(#818295) .. Patch Set 3: Build Successful http://jenkins.ovirt.info/job/patch_ovirt_engine/25/ :

[Engine-patches] Change in ovirt-engine[master]: core:No need to call super method for job properties(#818295...

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core:No need to call super method for job properties(#818295) .. Patch Set 3: Build Started http://jenkins.ovirt.info/job/patch_ovirt_engine/25/ -- To

[Engine-patches] Change in ovirt-engine[master]: core: BaseConditionFieldAutoCompleter cleanup

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: BaseConditionFieldAutoCompleter cleanup .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_ovirt_engine/24/ : SUCCESS -- To

[Engine-patches] Change in ovirt-engine[master]: core: SyntaxChecker cleanup IV

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: SyntaxChecker cleanup IV .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_ovirt_engine/23/ : SUCCESS -- To view, visit htt

[Engine-patches] Change in ovirt-engine[master]: core: BaseConditionFieldAutoCompleter cleanup

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: BaseConditionFieldAutoCompleter cleanup .. Patch Set 2: Build Started http://jenkins.ovirt.info/job/patch_ovirt_engine/24/ -- To view, visit htt

[Engine-patches] Change in ovirt-engine[master]: core: SyntaxChecker cleanup III

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: SyntaxChecker cleanup III .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_ovirt_engine/22/ : SUCCESS -- To view, visit ht

[Engine-patches] Change in ovirt-engine[master]: core: SyntaxChecker cleanup IV

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: SyntaxChecker cleanup IV .. Patch Set 2: Build Started http://jenkins.ovirt.info/job/patch_ovirt_engine/23/ -- To view, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: core: SyntaxChecker cleanup III

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: SyntaxChecker cleanup III .. Patch Set 2: Build Started http://jenkins.ovirt.info/job/patch_ovirt_engine/22/ -- To view, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: engine: Get Host fingerprint query

2012-08-09 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: engine: Get Host fingerprint query .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7034 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: core: cleanup DiskConditionFieldAutoCompleter

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: cleanup DiskConditionFieldAutoCompleter .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_ovirt_engine/19/ : SUCCESS -- To

[Engine-patches] Change in ovirt-engine[master]: core: fix null-support in search queries (#845297)

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: fix null-support in search queries (#845297) .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_ovirt_engine/18/ : SUCCESS -

[Engine-patches] Change in ovirt-engine[master]: core: cleanup DiskConditionFieldAutoCompleter

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: cleanup DiskConditionFieldAutoCompleter .. Patch Set 2: Build Started http://jenkins.ovirt.info/job/patch_ovirt_engine/19/ -- To view, visit htt

[Engine-patches] Change in ovirt-engine[master]: core: fix null-support in search queries (#845297)

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: fix null-support in search queries (#845297) .. Patch Set 2: Build Started http://jenkins.ovirt.info/job/patch_ovirt_engine/18/ -- To view, visi

[Engine-patches] Change in ovirt-engine[master]: core: quota search for vms (#845297)

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: quota search for vms (#845297) .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_ovirt_engine/17/ : SUCCESS -- To view, vis

[Engine-patches] Change in ovirt-engine[master]: core: Option with empty name and value ...

2012-08-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Option with empty name and value ... .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5656 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: core:we do not clean alerts from the weba(#840495)

2012-08-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core:we do not clean alerts from the weba(#840495) .. Patch Set 1: Looks good to me, approved After talking with Eli he explained me why this is the fix. The ti

[Engine-patches] Change in ovirt-engine[master]: core: misleading error when trying to fen(#843168)

2012-08-09 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: misleading error when trying to fen(#843168) .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6879 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: core: quota search for vms (#845297)

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: quota search for vms (#845297) .. Patch Set 2: Build Started http://jenkins.ovirt.info/job/patch_ovirt_engine/17/ -- To view, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: core: autocompletion support for NULL (#845297)

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: autocompletion support for NULL (#845297) .. Patch Set 5: Build Successful http://jenkins.ovirt.info/job/patch_ovirt_engine/16/ : SUCCESS -- T

[Engine-patches] Change in ovirt-engine[master]: webadmin: Updated SPICE cab download fix (#846341)

2012-08-09 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Updated SPICE cab download fix (#846341) .. Patch Set 1: Verified; Looks good to me, approved Nice catch! -- To view, visit http://gerrit.ovirt.org/7065

[Engine-patches] Change in ovirt-engine[master]: core: quota search for templates (#845297)

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: quota search for templates (#845297) .. Patch Set 5: Build Successful http://jenkins.ovirt.info/job/patch_ovirt_engine/15/ : SUCCESS -- To vie

[Engine-patches] Change in ovirt-engine[master]: core: autocompletion support for NULL (#845297)

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: autocompletion support for NULL (#845297) .. Patch Set 5: Build Started http://jenkins.ovirt.info/job/patch_ovirt_engine/16/ -- To view, visit h

[Engine-patches] Change in ovirt-engine[master]: core: cleanup VmConditionFieldAutoCompleter

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: cleanup VmConditionFieldAutoCompleter .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_ovirt_engine/14/ : SUCCESS -- To vi

[Engine-patches] Change in ovirt-engine[master]: core: quota search for templates (#845297)

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: quota search for templates (#845297) .. Patch Set 5: Build Started http://jenkins.ovirt.info/job/patch_ovirt_engine/15/ -- To view, visit http:/

[Engine-patches] Change in ovirt-engine[master]: webadmin: text fix engine->Engine (#845430)

2012-08-09 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: webadmin: text fix engine->Engine (#845430) .. webadmin: text fix engine->Engine (#845430) https://bugzilla.redhat.com/845430 "Verify connectivity betwee

[Engine-patches] Change in ovirt-engine[master]: webadmin: text fix engine->Engine (#845430)

2012-08-09 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: text fix engine->Engine (#845430) .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7067 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: webadmin: bug fix in unmanaged networks (#820504)

2012-08-09 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: webadmin: bug fix in unmanaged networks (#820504) .. webadmin: bug fix in unmanaged networks (#820504) https://bugzilla.redhat.com/820504 If a network is

[Engine-patches] Change in ovirt-engine[master]: webadmin: bug fix in unmanaged networks (#820504)

2012-08-09 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: bug fix in unmanaged networks (#820504) .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7064 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: core: quota search for disks (#845297)

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: quota search for disks (#845297) .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_ovirt_engine/13/ : SUCCESS -- To view, v

[Engine-patches] Change in ovirt-engine[master]: core: cleanup VmConditionFieldAutoCompleter

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: cleanup VmConditionFieldAutoCompleter .. Patch Set 2: Build Started http://jenkins.ovirt.info/job/patch_ovirt_engine/14/ -- To view, visit http:

[Engine-patches] Change in ovirt-engine[master]: webadmin: bug fix in unmanaged networks (#820504)

2012-08-09 Thread alkaplan
Alona Kaplan has posted comments on this change. Change subject: webadmin: bug fix in unmanaged networks (#820504) .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/7064 To unsubscribe, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: webadmin: text fix engine->Engine (#845430)

2012-08-09 Thread alkaplan
Alona Kaplan has posted comments on this change. Change subject: webadmin: text fix engine->Engine (#845430) .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/7067 To unsubscribe, visit http://gerrit.ovirt.org/

[Engine-patches] Change in ovirt-engine[master]: core: simplify 'is null' sql expression

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: simplify 'is null' sql expression .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_ovirt_engine/12/ : SUCCESS -- To view,

[Engine-patches] Change in ovirt-engine[master]: core: quota search for disks (#845297)

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: quota search for disks (#845297) .. Patch Set 2: Build Started http://jenkins.ovirt.info/job/patch_ovirt_engine/13/ -- To view, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: core : WIP : added ReconstructMasterDomain to InitVdsOnUpCom...

2012-08-09 Thread laravot
Liron Aravot has posted comments on this change. Change subject: core : WIP : added ReconstructMasterDomain to InitVdsOnUpCommand (#840838) .. Patch Set 7: the patch looks like this because of problem with eclipse formatter, w

[Engine-patches] Change in ovirt-engine[master]: webadmin: text fix engine->Engine (#845430)

2012-08-09 Thread alkaplan
Alona Kaplan has uploaded a new change for review. Change subject: webadmin: text fix engine->Engine (#845430) .. webadmin: text fix engine->Engine (#845430) https://bugzilla.redhat.com/845430 "Verify connectivity between Host

[Engine-patches] Change in ovirt-engine[master]: core: Support undoing diskless previews

2012-08-09 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Support undoing diskless previews .. Patch Set 9: Verified addressed abaron's comments I agreed with, answered inline the ones I don't -- To view, visit

[Engine-patches] Change in ovirt-engine[master]: core: simplify 'is null' sql expression

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: simplify 'is null' sql expression .. Patch Set 2: Build Started http://jenkins.ovirt.info/job/patch_ovirt_engine/12/ -- To view, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: webadmin: bug fix in unmanaged networks (#820504)

2012-08-09 Thread masayag
Moti Asayag has posted comments on this change. Change subject: webadmin: bug fix in unmanaged networks (#820504) .. Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) .

[Engine-patches] Change in ovirt-engine[master]: core: cleanup VmConditionFieldAutoCompleter

2012-08-09 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: cleanup VmConditionFieldAutoCompleter .. Patch Set 2: I would prefer that you didn't submit this (1 inline comment) .

[Engine-patches] Change in ovirt-engine[master]: core: cleanup DiskConditionFieldAutoCompleter

2012-08-09 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: cleanup DiskConditionFieldAutoCompleter .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7041 To

[Engine-patches] Change in ovirt-engine[master]: core: fix null-support in search queries (#845297)

2012-08-09 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: fix null-support in search queries (#845297) .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/704

[Engine-patches] Change in ovirt-engine[master]: core: BaseConditionFieldAutoCompleter cleanup

2012-08-09 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: BaseConditionFieldAutoCompleter cleanup .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7039 To

[Engine-patches] Change in ovirt-engine[master]: engine:Remaining disks of deleted VM will be ILLEGAL.(#82205...

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine:Remaining disks of deleted VM will be ILLEGAL.(#822051) .. Patch Set 8: Build Successful http://jenkins.ovirt.info/job/patch_ovirt_engine/8/ :

[Engine-patches] Change in ovirt-engine[master]: core: autocompletion support for NULL (#845297)

2012-08-09 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: autocompletion support for NULL (#845297) .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6952 T

[Engine-patches] Change in ovirt-engine[master]: core: SyntaxChecker cleanup IV

2012-08-09 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: SyntaxChecker cleanup IV .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7038 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: core: SyntaxChecker cleanup III

2012-08-09 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: SyntaxChecker cleanup III .. Patch Set 2: I get the encapsulation, I'm not quite clear as to why you'd move the escaping to a later part of the flow. Ca

[Engine-patches] Change in ovirt-engine[master]: engine:Remaining disks of deleted VM will be ILLEGAL.(#82205...

2012-08-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine:Remaining disks of deleted VM will be ILLEGAL.(#822051) .. Patch Set 8: Build Started http://jenkins.ovirt.info/job/patch_ovirt_engine/8/ -- To

[Engine-patches] Change in ovirt-engine[master]: webadmin: Updated SPICE cab download fix (#846341)

2012-08-09 Thread ecohen
Einav Cohen has uploaded a new change for review. Change subject: webadmin: Updated SPICE cab download fix (#846341) .. webadmin: Updated SPICE cab download fix (#846341) https://bugzilla.redhat.com/846341 Before this patch, th

[Engine-patches] Change in ovirt-engine[master]: core:No need to call super method for job properties(#818295...

2012-08-09 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core:No need to call super method for job properties(#818295) .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: core: db function extensions

2012-08-09 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: db function extensions .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7021 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: core: db function extensions

2012-08-09 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: db function extensions .. Patch Set 2: (1 inline comment) File backend/manager/dbscripts/dbfunctions.sh L

[Engine-patches] Change in ovirt-engine[master]: webadmin: bug fix in unmanaged networks (#820504)

2012-08-09 Thread alkaplan
Alona Kaplan has uploaded a new change for review. Change subject: webadmin: bug fix in unmanaged networks (#820504) .. webadmin: bug fix in unmanaged networks (#820504) https://bugzilla.redhat.com/820504 If a network is vlan-e

  1   2   3   >