[Engine-patches] Change in ovirt-engine[master]: tools: Improving engine-config logging

2012-07-25 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Improving engine-config logging .. tools: Improving engine-config logging 1. Introducing file appender - the created file will be /var/log/engin

[Engine-patches] Change in ovirt-engine[master]: tools: Improving engine-config logging

2012-07-25 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: tools: Improving engine-config logging .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6569 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core: revert 5fc51d2f89cb9e5ec90868f30bd6987ba6a58185

2012-07-25 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: revert 5fc51d2f89cb9e5ec90868f30bd6987ba6a58185 .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6622 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: core: number_of_vms search - support all operators

2012-07-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: number_of_vms search - support all operators .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6630 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: core: Remove regression caused by GetVdsToRun query

2012-07-25 Thread rgolan
Roy Golan has abandoned this change. Change subject: core: Remove regression caused by GetVdsToRun query .. Patch Set 1: Abandoned 6622 is reverting the change the caused the problem this patch is trying to fix. -- To view, vi

[Engine-patches] Change in ovirt-engine[master]: core: revert 5fc51d2f89cb9e5ec90868f30bd6987ba6a58185

2012-07-25 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: revert 5fc51d2f89cb9e5ec90868f30bd6987ba6a58185 .. Patch Set 2: checked diffs using git diff 5fc51d2f89cb9e5ec90868f30bd6987ba6a58185~1 backend/manager/modul

[Engine-patches] Change in ovirt-engine[master]: Revert "core: filter the vds by query"

2012-07-25 Thread rgolan
Roy Golan has abandoned this change. Change subject: Revert "core: filter the vds by query" .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/6635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit

[Engine-patches] Change in ovirt-engine[master]: Revert "core: filter the vds by query"

2012-07-25 Thread rgolan
Roy Golan has uploaded a new change for review. Change subject: Revert "core: filter the vds by query" .. Revert "core: filter the vds by query" This reverts commit 5fc51d2f89cb9e5ec90868f30bd6987ba6a58185. Conflicts:

[Engine-patches] Change in ovirt-engine[master]: core: number_of_vms search - support all operators

2012-07-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: number_of_vms search - support all operators .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/663

[Engine-patches] Change in ovirt-engine[master]: core: Animal-sniffer to check JDK6 compatibility

2012-07-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Animal-sniffer to check JDK6 compatibility .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/6540 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: core: Animal-sniffer to check JDK6 compatibility

2012-07-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Animal-sniffer to check JDK6 compatibility .. Patch Set 3: made execution of animal sniffer optional - now this patch only provides a convenient tool for

[Engine-patches] Change in ovirt-engine[master]: core: revert 5fc51d2f89cb9e5ec90868f30bd6987ba6a58185

2012-07-25 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: revert 5fc51d2f89cb9e5ec90868f30bd6987ba6a58185 .. Patch Set 1: Do not submit (1 inline comment) File ba

[Engine-patches] Change in ovirt-engine[master]: core: Add BLOB servlet

2012-07-25 Thread gmurphy
Grant Murphy has posted comments on this change. Change subject: core: Add BLOB servlet .. Patch Set 3: (2 inline comments) File backend/manager/modules/utils/src/main/java/

[Engine-patches] Change in ovirt-engine[master]: wip - don't submit - core: fixing import storage domain to s...

2012-07-25 Thread abaron
Ayal Baron has posted comments on this change. Change subject: wip - don't submit - core: fixing import storage domain to save additional NFS options (#835961) .. Patch Set 2: Looks good to me, but someone else must approve Ev

[Engine-patches] Change in ovirt-engine[master]: UI: Wrong cluster level version when editing the cluster

2012-07-25 Thread derez
Daniel Erez has posted comments on this change. Change subject: UI: Wrong cluster level version when editing the cluster .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6567 To unsubscribe,

[Engine-patches] Change in ovirt-engine[master]: webadmin: disks tab - adding Attached To column

2012-07-25 Thread derez
Daniel Erez has uploaded a new change for review. Change subject: webadmin: disks tab - adding Attached To column .. webadmin: disks tab - adding Attached To column Adding 'Attached To' column: * Disks main-tab * VMs -> disks su

[Engine-patches] Change in ovirt-engine[master]: core: number_of_vms search - support all operators

2012-07-25 Thread derez
Daniel Erez has uploaded a new change for review. Change subject: core: number_of_vms search - support all operators .. core: number_of_vms search - support all operators Use NumericConditionRelationAutoCompleter for 'number_of_

[Engine-patches] Change in ovirt-engine[master]: engine: Import linux VM with legacy usb policy (#834254)

2012-07-25 Thread abaron
Ayal Baron has posted comments on this change. Change subject: engine: Import linux VM with legacy usb policy (#834254) .. Patch Set 1: I would prefer that you didn't submit this (2 inline comments) ...

[Engine-patches] Change in ovirt-engine[master]: core: cleanup SearchObjectAutoCompleter

2012-07-25 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: cleanup SearchObjectAutoCompleter .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6411 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-engine[master]: webadmin: V3 storage domain as default (#842656)

2012-07-25 Thread derez
Daniel Erez has uploaded a new change for review. Change subject: webadmin: V3 storage domain as default (#842656) .. webadmin: V3 storage domain as default (#842656) https://bugzilla.redhat.com/842656 New/Import storage domain

[Engine-patches] Change in ovirt-engine[master]: webadmin: empty quota isn't blocked (#838343)

2012-07-25 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: webadmin: empty quota isn't blocked (#838343) .. webadmin: empty quota isn't blocked (#838343) https://bugzilla.redhat.com/838343 allow at least one limi

[Engine-patches] Change in ovirt-engine[master]: Revert "webadmin: separate storage & cluster quota"

2012-07-25 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: Revert "webadmin: separate storage & cluster quota" .. Revert "webadmin: separate storage & cluster quota" This reverts commit 1d4d3b278d6ee9285215b98c6ca

[Engine-patches] Change in ovirt-engine[master]: webadmin: empty quota isn't blocked (#838343)

2012-07-25 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: empty quota isn't blocked (#838343) .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6628 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: Revert "webadmin: separate storage & cluster quota"

2012-07-25 Thread derez
Daniel Erez has posted comments on this change. Change subject: Revert "webadmin: separate storage & cluster quota" .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6627 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core: RemoveDiskCommand - added TODO comments

2012-07-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: RemoveDiskCommand - added TODO comments .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment) ...

[Engine-patches] Change in ovirt-engine[master]: core: cleanup SearchObjectAutoCompleter

2012-07-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: cleanup SearchObjectAutoCompleter .. Patch Set 3: Looks good to me, approved Just verify it -- To view, visit http://gerrit.ovirt.org/6411 To unsubscribe

[Engine-patches] Change in ovirt-engine[master]: webadmin: empty quota isn't blocked (#838343)

2012-07-25 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: empty quota isn't blocked (#838343) .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/6628 To unsubscribe, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: Revert "webadmin: separate storage & cluster quota"

2012-07-25 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: Revert "webadmin: separate storage & cluster quota" .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/6627 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: Revert "webadmin: separate storage & cluster quota"

2012-07-25 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: Revert "webadmin: separate storage & cluster quota" .. Revert "webadmin: separate storage & cluster quota" This reverts commit 1d4d3b278d6ee9285215b98c6ca915b4e

[Engine-patches] Change in ovirt-engine[master]: webadmin: empty quota isn't blocked (#838343)

2012-07-25 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: webadmin: empty quota isn't blocked (#838343) .. webadmin: empty quota isn't blocked (#838343) https://bugzilla.redhat.com/838343 allow at least one limitation

[Engine-patches] Change in ovirt-engine[master]: core: remove validation for shared bootable disk (#832977)

2012-07-25 Thread gchaplik
Gilad Chaplik has submitted this change and it was merged. Change subject: core: remove validation for shared bootable disk (#832977) .. core: remove validation for shared bootable disk (#832977) https://bugzilla.redhat.com/832

[Engine-patches] Change in ovirt-engine[master]: core: remove validation for shared bootable disk (#832977)

2012-07-25 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: core: remove validation for shared bootable disk (#832977) .. Patch Set 3: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: webadmin: Add vnic- shouldn't have non vm networks

2012-07-25 Thread gchaplik
Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Add vnic- shouldn't have non vm networks .. webadmin: Add vnic- shouldn't have non vm networks https://bugzilla.redhat.com/842249 If you edit

[Engine-patches] Change in ovirt-engine[master]: webadmin: Add vnic- shouldn't have non vm networks

2012-07-25 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: Add vnic- shouldn't have non vm networks .. Patch Set 2: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/6623 T

[Engine-patches] Change in ovirt-engine[master]: core : WIP : prevent adding SD to DC which is not up (#84114...

2012-07-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core : WIP : prevent adding SD to DC which is not up (#841148) .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment) ..

[Engine-patches] Change in ovirt-engine[master]: core : WIP : prevent adding SD to DC which is not up (#84114...

2012-07-25 Thread laravot
Liron Aravot has uploaded a new change for review. Change subject: core : WIP : prevent adding SD to DC which is not up (#841148) .. core : WIP : prevent adding SD to DC which is not up (#841148) https://bugzilla.redhat.com/show

[Engine-patches] Change in ovirt-engine[master]: webadmin: added missing hashNames for some dialogs

2012-07-25 Thread ecohen
Einav Cohen has submitted this change and it was merged. Change subject: webadmin: added missing hashNames for some dialogs .. webadmin: added missing hashNames for some dialogs In this patch: - Added hashNames for New/Edit Ne

[Engine-patches] Change in ovirt-engine[master]: webadmin: added missing hashNames for some dialogs

2012-07-25 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: webadmin: added missing hashNames for some dialogs .. Patch Set 2: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/6615 To

[Engine-patches] Change in ovirt-engine[master]: core: remove validation for shared bootable disk (#832977)

2012-07-25 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: remove validation for shared bootable disk (#832977) .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6611 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: core:Replace vm id with number of vms in views.

2012-07-25 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: core:Replace vm id with number of vms in views. .. core:Replace vm id with number of vms in views. Remove vm_guid and vm_id from all the images views. Si

[Engine-patches] Change in ovirt-engine[master]: core:Replace vm id with number of vms in views.

2012-07-25 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core:Replace vm id with number of vms in views. .. Patch Set 12: Verified; Looks good to me, approved Acked by mkublin, verified with automation tests -- To view

[Engine-patches] Change in ovirt-engine[master]: webadmin: Add vnic- shouldn't have non vm networks

2012-07-25 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: Add vnic- shouldn't have non vm networks .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6623 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: core: store the username owning the current spice session ti...

2012-07-25 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core: store the username owning the current spice session ticket .. Patch Set 3: (1 inline comment) File b

[Engine-patches] Change in ovirt-engine[master]: webadmin: Add vnic- shouldn't have non vm networks

2012-07-25 Thread alkaplan
Alona Kaplan has posted comments on this change. Change subject: webadmin: Add vnic- shouldn't have non vm networks .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/6623 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: webadmin: Disable storage type selectbox when editing DC (#8...

2012-07-25 Thread asaf
Asaf Shakarchi has uploaded a new change for review. Change subject: webadmin: Disable storage type selectbox when editing DC (#834890) .. webadmin: Disable storage type selectbox when editing DC (#834890) https://bugzilla.redh

[Engine-patches] Change in ovirt-engine[master]: core: store the username owning the current spice session ti...

2012-07-25 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: store the username owning the current spice session ticket .. Patch Set 3: (1 inline comment) just minor question .

[Engine-patches] Change in ovirt-engine[master]: webadmin: Add vnic- shouldn't have non vm networks

2012-07-25 Thread alkaplan
Alona Kaplan has uploaded a new change for review. Change subject: webadmin: Add vnic- shouldn't have non vm networks .. webadmin: Add vnic- shouldn't have non vm networks https://bugzilla.redhat.com/842249 If you edit NIC on V

[Engine-patches] Change in ovirt-engine[master]: webadmin: don't alow bridge_non_Vlan with vlan

2012-07-25 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: don't alow bridge_non_Vlan with vlan .. Patch Set 2: next time, in the commit message, the bugzilla url should be before the patch desc -- To view, v

[Engine-patches] Change in ovirt-engine[master]: core:Replace vm id with number of vms in views.

2012-07-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core:Replace vm id with number of vms in views. .. Patch Set 11: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5216 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: webadmin: don't alow bridge_non_Vlan with vlan

2012-07-25 Thread gchaplik
Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: don't alow bridge_non_Vlan with vlan .. webadmin: don't alow bridge_non_Vlan with vlan Poosible combination of networks on a nic- vlan(*) nonV

[Engine-patches] Change in ovirt-engine[master]: webadmin: don't alow bridge_non_Vlan with vlan

2012-07-25 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: don't alow bridge_non_Vlan with vlan .. Patch Set 2: Verified; Looks good to me, approved rebased & reviewed -- To view, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: Revert "engine: Edit Pool shows different RAM than defined (...

2012-07-25 Thread gchaplik
Gilad Chaplik has submitted this change and it was merged. Change subject: Revert "engine: Edit Pool shows different RAM than defined (#833829)" .. Revert "engine: Edit Pool shows different RAM than defined (#833829)" introduc

[Engine-patches] Change in ovirt-engine[master]: Revert "engine: Edit Pool shows different RAM than defined (...

2012-07-25 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: Revert "engine: Edit Pool shows different RAM than defined (#833829)" .. Patch Set 2: Verified; Looks good to me, approved rebased. -- To view, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: core: cleanup SearchObjectAutoCompleter

2012-07-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: cleanup SearchObjectAutoCompleter .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6411 To unsubs

[Engine-patches] Change in ovirt-engine[master]: webadmin: added missing hashNames for some dialogs

2012-07-25 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: added missing hashNames for some dialogs .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6615 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: core: ImportVmCommand - changed method UpdateVmImSpm() name

2012-07-25 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: core: ImportVmCommand - changed method UpdateVmImSpm() name .. Patch Set 6: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt

[Engine-patches] Change in ovirt-engine[master]: core:Replace vm id with number of vms in views.

2012-07-25 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core:Replace vm id with number of vms in views. .. Patch Set 11: Looks good to me, approved Acked by derez -- To view, visit http://gerrit.ovirt.org/5216 To unsu

[Engine-patches] Change in ovirt-engine[master]: api: user can set port mirroring without network id

2012-07-25 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: api: user can set port mirroring without network id .. Patch Set 2: Fails -- To view, visit http://gerrit.ovirt.org/6547 To unsubscribe, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: cleanup:Fix test message

2012-07-25 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: cleanup:Fix test message .. cleanup:Fix test message Fix test message to indicate the correct number of disks. Signed-off-by: Maor Lipchuk Change-Id: I

[Engine-patches] Change in ovirt-engine[master]: cleanup:Fix test message

2012-07-25 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: cleanup:Fix test message .. Patch Set 4: Verified; Looks good to me, approved Acked by mkublin -- To view, visit http://gerrit.ovirt.org/6352 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: core : create template from VM with no snappable disks (#841...

2012-07-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core : create template from VM with no snappable disks (#841534) .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment) flaged +1 by mis

[Engine-patches] Change in ovirt-engine[master]: core : create template from VM with no snappable disks (#841...

2012-07-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core : create template from VM with no snappable disks (#841534) .. Patch Set 1: Looks good to me, but someone else must approve (2 inline comments) ..

[Engine-patches] Change in ovirt-engine[master]: webadmin: add disk - update default format

2012-07-25 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: webadmin: add disk - update default format .. webadmin: add disk - update default format Disks main-tab -> Add Disk dialog: update default format when cha

[Engine-patches] Change in ovirt-engine[master]: webadmin: add disk - update default format

2012-07-25 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: add disk - update default format .. Patch Set 2: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/6596 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: core:Replace vm id with number of vms in views.

2012-07-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core:Replace vm id with number of vms in views. .. Patch Set 10: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5216

[Engine-patches] Change in ovirt-engine[master]: webadmin: don't alow bridge_non_Vlan with vlan

2012-07-25 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: don't alow bridge_non_Vlan with vlan .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6616 To unsubscribe, visit http

[Engine-patches] Change in ovirt-engine[master]: core: Fix node .iso upgrade/installation (#840356)

2012-07-25 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: core: Fix node .iso upgrade/installation (#840356) .. Patch Set 1: (1 inline comment) File backend/manager/

[Engine-patches] Change in ovirt-engine[master]: wip - don't submit - core: fixing import storage domain to s...

2012-07-25 Thread oourfali
Oved Ourfali has uploaded a new change for review. Change subject: wip - don't submit - core: fixing import storage domain to save additional NFS options .. wip - don't submit - core: fixing import storage domain to save additio

[Engine-patches] Change in ovirt-engine[master]: core: fix removal of lun disk with no vm (#841265)

2012-07-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: fix removal of lun disk with no vm (#841265) .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/656

[Engine-patches] Change in ovirt-engine[master]: core: RemoveDiskCommand - added TODO comments

2012-07-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: RemoveDiskCommand - added TODO comments .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6604 To

[Engine-patches] Change in ovirt-engine[master]: core: ImportVmCommand -remove EndImportCommand() method

2012-07-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: ImportVmCommand -remove EndImportCommand() method .. Patch Set 8: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: cleanup:Fix test message

2012-07-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: cleanup:Fix test message .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6352 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: core: ImportVmCommand - changed method UpdateVmImSpm() name

2012-07-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: ImportVmCommand - changed method UpdateVmImSpm() name .. Patch Set 6: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: core:Replace vm id with number of vms in views.

2012-07-25 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core:Replace vm id with number of vms in views. .. Patch Set 10: Looks good to me, approved Acked by derez -- To view, visit http://gerrit.ovirt.org/5216 To unsu

[Engine-patches] Change in ovirt-engine[master]: core: ImportVmCommand - added method getUpdatedVmForOperatio...

2012-07-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: ImportVmCommand - added method getUpdatedVmForOperation() .. Patch Set 6: Looks good to me, but someone else must approve -- To view, visit http://gerrit.

[Engine-patches] Change in ovirt-engine[master]: core: ImportVmCommand - added method getUpdatedVmForOperatio...

2012-07-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: ImportVmCommand - added method getUpdatedVmForOperation() .. Patch Set 6: mkublin - you can cherry pick regradless of pachsets/dependencies. not to mentio

[Engine-patches] Change in ovirt-engine[master]: core: enable export/import of diskless VM/VM with no snappab...

2012-07-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: enable export/import of diskless VM/VM with no snappable disks(#838937) .. Patch Set 8: I would prefer that you didn't submit this (4 inline comments) .

[Engine-patches] Change in ovirt-engine[master]: core: added information to ConnectStorageVDScommand logs (#8...

2012-07-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: added information to ConnectStorageVDScommand logs (#835546) .. Patch Set 4: I would prefer that you didn't submit this (1 inline comment) .

[Engine-patches] Change in ovirt-engine[master]: engine: Replace StringHelper with StringUtils in UpdateSpmHo...

2012-07-25 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: engine: Replace StringHelper with StringUtils in UpdateSpmHostNameVDSCommand. .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit

[Engine-patches] Change in ovirt-engine[master]: core: Disconnect on reconstruct also for domain V3

2012-07-25 Thread mkublin
Michael Kublin has submitted this change and it was merged. Change subject: core: Disconnect on reconstruct also for domain V3 .. core: Disconnect on reconstruct also for domain V3 Reconstructing a master while connected to the

[Engine-patches] Change in ovirt-engine[master]: core: Disconnect on reconstruct also for domain V3

2012-07-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: Disconnect on reconstruct also for domain V3 .. Patch Set 4: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/6603

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 1907 - Failure!

2012-07-25 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/1907/ Build Number: 1907 Build Status: Failure Triggered By: Started by upstream project "ovirt_engine" build number 2,455 - Changes Since

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 1905 - Fixed!

2012-07-25 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/1905/ Build Number: 1905 Build Status: Fixed Triggered By: Started by upstream project "ovirt_engine" build number 2,453 - Changes Since La

[Engine-patches] Change in ovirt-engine[master]: webadmin: don't alow bridge_non_Vlan with vlan

2012-07-25 Thread alkaplan
Alona Kaplan has posted comments on this change. Change subject: webadmin: don't alow bridge_non_Vlan with vlan .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/6616 To unsubscribe, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: core: Disconnect on reconstruct also for domain V3

2012-07-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: Disconnect on reconstruct also for domain V3 .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6603 To unsubs

[Engine-patches] Change in ovirt-engine[master]: webadmin: don't alow bridge_non_Vlan with vlan

2012-07-25 Thread alkaplan
Alona Kaplan has uploaded a new change for review. Change subject: webadmin: don't alow bridge_non_Vlan with vlan .. webadmin: don't alow bridge_non_Vlan with vlan Poosible combination of networks on a nic- vlan(*) nonVlan-nonbr

[Engine-patches] Change in ovirt-engine[master]: core: Fix node .iso upgrade/installation (#840356)

2012-07-25 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core: Fix node .iso upgrade/installation (#840356) .. Patch Set 1: (1 inline comment) File backend/manager

[Engine-patches] Change in ovirt-engine[master]: core: Fix node .iso upgrade/installation (#840356)

2012-07-25 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: core: Fix node .iso upgrade/installation (#840356) .. Patch Set 1: (1 inline comment) File backend/manager/

[Engine-patches] Change in ovirt-engine[master]: Revert "engine: Edit Pool shows different RAM than defined (...

2012-07-25 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: Revert "engine: Edit Pool shows different RAM than defined (#833829)" .. Patch Set 1: Verified; Looks good to me, but someone else must approve verified: it cor

[Engine-patches] Change in ovirt-engine[master]: core: store the username owning the current spice session ti...

2012-07-25 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core: store the username owning the current spice session ticket .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: core: store the username owning the current spice session ti...

2012-07-25 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: store the username owning the current spice session ticket .. Patch Set 3: s/tabs/spaces -- To view, visit http://gerrit.ovirt.org/6546 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: packaging: Disable HTTP and HTTPS when using Apache as proxy

2012-07-25 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: Disable HTTP and HTTPS when using Apache as proxy .. Patch Set 6: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt

[Engine-patches] Change in ovirt-engine[master]: packaging: Disable HTTP and HTTPS when using Apache as proxy

2012-07-25 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: Disable HTTP and HTTPS when using Apache as proxy .. Patch Set 6: Rebased and re-added the engine-service.sysconfig changes lost in the previous pat

[Engine-patches] Change in ovirt-engine[master]: core: RegisterVdsQuery - change logger to be final field

2012-07-25 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: RegisterVdsQuery - change logger to be final field .. Patch Set 9: I would prefer that you didn't submit this (1 inline comment)

[Engine-patches] Change in ovirt-engine[master]: core: store the username owning the current spice session ti...

2012-07-25 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: core: store the username owning the current spice session ticket .. Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) Just a mino

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 1908 - Fixed!

2012-07-25 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/1908/ Build Number: 1908 Build Status: Fixed Triggered By: Started by upstream project "ovirt_engine" build number 2,456 - Changes Since La

[Engine-patches] Change in ovirt-engine[master]: packaging: Disable HTTP and HTTPS when using Apache as proxy

2012-07-25 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: packaging: Disable HTTP and HTTPS when using Apache as proxy .. Patch Set 5: (1 inline comment) The changes to the sysconfig file were lost in the rebase proces

[Engine-patches] Change in ovirt-engine[master]: packaging: Disable HTTP and HTTPS when using Apache as proxy

2012-07-25 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: packaging: Disable HTTP and HTTPS when using Apache as proxy .. Patch Set 5: (1 inline comment) Any reason not to update the sysconfig file to have the new *PRO

[Engine-patches] Change in ovirt-engine[master]: packaging: Modify user interface of engine-setup (#832767)

2012-07-25 Thread oschreib
Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Modify user interface of engine-setup (#832767) .. packaging: Modify user interface of engine-setup (#832767) https://bugzilla.redhat.com/sh

[Engine-patches] Change in ovirt-engine[master]: packaging: Modify user interface of engine-setup (#832767)

2012-07-25 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: packaging: Modify user interface of engine-setup (#832767) .. Patch Set 6: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6592 T

  1   2   >