Kanagaraj M has posted comments on this change.
Change subject: restapi: filtering the api according to ApplicationMode
..
Patch Set 4: Verified
Rebase and Verified.
--
To view, visit http://gerrit.ovirt.org/5353
To unsubscrib
Michael Kublin has posted comments on this change.
Change subject: core: Cleanup in TimeoutBase
..
Patch Set 1:
Allon, I think all your patch set is connected, I think it can be sent at one
patch, I don't see any reason why to
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fixing running vm from pool at UserPoral
..
Patch Set 4: (1 inline comment)
File
backend/manager/mod
Omer Frenkel has posted comments on this change.
Change subject: core: Fixing running vm from pool at UserPoral
..
Patch Set 4: (1 inline comment)
File
backend/manager/modul
Allon Mureinik has posted comments on this change.
Change subject: engine: Remove unused variable 'numberOfValidRecords'.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
Allon Mureinik has posted comments on this change.
Change subject: engine: Replace StringHelper with StringUtils in
VmPropertiesUtils
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://ger
Allon Mureinik has posted comments on this change.
Change subject: engine: Replace StringHelper with StringUtils in
CreateVmVDSCommand
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://ge
Allon Mureinik has posted comments on this change.
Change subject: engine: Replacing StringHelper with StringUtils in
VirtMonitoringStrategy.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit ht
Allon Mureinik has posted comments on this change.
Change subject: core: some StringHelper removal
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
+1 on the concept - please remove the two occurr
Allon Mureinik has posted comments on this change.
Change subject: engine: Replace StringHelper with StringUtils in
UpdateSpmHostNameVDSCommand.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup in AddNetworkVDSCommand
..
Patch Set 1:
Note: this patch may become [almost] redundant by I82671284 - the only
difference is making the log final
Allon Mureinik has posted comments on this change.
Change subject: engine: Replace StringHelper with StringUtils in
AddNetworkVDSCommand.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http:/
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup in HSMGetStorageDomainInfoVDSCommand
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5880
To unsubscribe, visit http://gerrit.o
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup in ConnectStorageServerVDSCommand
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5879
To unsubscribe, visit http://gerrit.ovir
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup in AddNetworkVDSCommand
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5878
To unsubscribe, visit http://gerrit.ovirt.org/sett
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup in EditNetworkVDSCommand
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5877
To unsubscribe, visit http://gerrit.ovirt.org/set
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup in FenceVdsVDSCommand
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5876
To unsubscribe, visit http://gerrit.ovirt.org/settin
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup in VmInfoBuilder
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5874
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup in VmOldInfoBuilder
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5873
To unsubscribe, visit http://gerrit.ovirt.org/settings
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup in VmInfoBuilderBase
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5872
To unsubscribe, visit http://gerrit.ovirt.org/setting
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup in CreateVmFromSysPrepVDSCommand
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5871
To unsubscribe, visit http://gerrit.ovirt
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup in SetupNetworksVDSCommand
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5870
To unsubscribe, visit http://gerrit.ovirt.org/s
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup in GetStorageDomainStatsVDSCommand
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5869
To unsubscribe, visit http://gerrit.ovi
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup in BrokerCommandBase
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5868
To unsubscribe, visit http://gerrit.ovirt.org/setting
Allon Mureinik has posted comments on this change.
Change subject: core: Clenaup in GetDeviceListVDSCommand
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5867
To unsubscribe, visit http://gerrit.ovirt.org/s
Allon Mureinik has posted comments on this change.
Change subject: core: Clenaup in SysprepHandler
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5866
To unsubscribe, visit http://gerrit.ovirt.org/settings
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup in VdsBrokerObjectsBuilder
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5865
To unsubscribe, visit http://gerrit.ovirt.org/s
Sharad Mishra has uploaded a new change for review.
Change subject: engine: Replace StringHelper with StringUtils in
AddNetworkVDSCommand.
..
engine: Replace StringHelper with StringUtils in AddNetworkVDSCommand.
StringHelper i
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup in DbUserDAODbFacadeImpl
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5864
To unsubscribe, visit http://gerrit.ovirt.org/set
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup in AuditLogableBase
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5863
To unsubscribe, visit http://gerrit.ovirt.org/settings
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup in AuditLogDirector
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5862
To unsubscribe, visit http://gerrit.ovirt.org/settings
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup in TimeoutBase
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5861
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ger
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Removing unused 'KEY_PATTERN'.
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5856
To unsubscribe, visit
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine: Removing unused 'KEY_PATTERN'.
..
engine: Removing unused 'KEY_PATTERN'.
The value of the field VmPropertiesUtils.KEY_PATTERN is not used.
Cha
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Removing unused 'KEY_PATTERN'.
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5856
To unsubscribe, visit
Allon Mureinik has uploaded a new change for review.
Change subject: core: Cleanup in AddNetworkVDSCommand
..
core: Cleanup in AddNetworkVDSCommand
* Removed dependency on the deprecated StringHelper class
* Made the log final
Allon Mureinik has uploaded a new change for review.
Change subject: core: Cleanup in ConnectStorageServerVDSCommand
..
core: Cleanup in ConnectStorageServerVDSCommand
* Removed dependency on the deprecated StringHelper class
*
Allon Mureinik has uploaded a new change for review.
Change subject: core: Cleanup in HSMGetStorageDomainInfoVDSCommand
..
core: Cleanup in HSMGetStorageDomainInfoVDSCommand
* Removed dependency on the deprecated StringHelper cl
Allon Mureinik has uploaded a new change for review.
Change subject: core: Cleanup in VmInfoBuilder
..
core: Cleanup in VmInfoBuilder
Some java cleanup:
* Removed dependency on deprecated StringHelper class
* Solved a potentital
Sharad Mishra has uploaded a new change for review.
Change subject: engine: Replace StringHelper with StringUtils in
UpdateSpmHostNameVDSCommand.
..
engine: Replace StringHelper with StringUtils in UpdateSpmHostNameVDSCommand.
Allon Mureinik has uploaded a new change for review.
Change subject: core: Cleanup in EditNetworkVDSCommand
..
core: Cleanup in EditNetworkVDSCommand
Removed dependency on deprecated StringHelper class.
Change-Id: I25b3058645e1
Allon Mureinik has uploaded a new change for review.
Change subject: core: Cleanup in VmInfoBuilderBase
..
core: Cleanup in VmInfoBuilderBase
Removed dependency on the deprecated StringHelper class.
Change-Id: I4c49d5bafd2da642
Allon Mureinik has uploaded a new change for review.
Change subject: core: Cleanup in VmOldInfoBuilder
..
core: Cleanup in VmOldInfoBuilder
Removed dependency on deprecarted StringHelper class.
Change-Id: Idbc9b5be2a134881ac20a
Allon Mureinik has uploaded a new change for review.
Change subject: core: Cleanup in FenceVdsVDSCommand
..
core: Cleanup in FenceVdsVDSCommand
Some java cleanup:
* Removed dependency on deprecated StringHelper class
* Solved a
Allon Mureinik has uploaded a new change for review.
Change subject: core: Cleanup in CreateVmFromSysPrepVDSCommand
..
core: Cleanup in CreateVmFromSysPrepVDSCommand
Removed dependency on deprecated StringHelper class.
Change-I
Allon Mureinik has uploaded a new change for review.
Change subject: core: Cleanup in GetStorageDomainStatsVDSCommand
..
core: Cleanup in GetStorageDomainStatsVDSCommand
Some java cleanup:
* Removed dependency on the deprecated
Allon Mureinik has uploaded a new change for review.
Change subject: core: Cleanup in SetupNetworksVDSCommand
..
core: Cleanup in SetupNetworksVDSCommand
Some java cleanup:
* Removed dependency on the deprecated StringHelper cla
Allon Mureinik has uploaded a new change for review.
Change subject: core: Clenaup in GetDeviceListVDSCommand
..
core: Clenaup in GetDeviceListVDSCommand
Removed dependency on deprecated StringHelper.
Change-Id: I3659159a7ea631
Allon Mureinik has uploaded a new change for review.
Change subject: core: Cleanup in BrokerCommandBase
..
core: Cleanup in BrokerCommandBase
Some java cleanup:
* Removed dependency on the deprecated StringHelper class.
* Remove
Allon Mureinik has uploaded a new change for review.
Change subject: core: Clenaup in SysprepHandler
..
core: Clenaup in SysprepHandler
Some general java cleanup:
* Removed dependency on deprecated StringHelper
* Replaced FQCNs
Allon Mureinik has uploaded a new change for review.
Change subject: core: Cleanup in VdsBrokerObjectsBuilder
..
core: Cleanup in VdsBrokerObjectsBuilder
Some general java cleanup:
* Removed usages of deprecated StringHelper
* R
Allon Mureinik has uploaded a new change for review.
Change subject: core: Cleanup in AuditLogableBase
..
core: Cleanup in AuditLogableBase
Did some general java cleanups:
* Added final to immutable members
* Removed dependency
Allon Mureinik has uploaded a new change for review.
Change subject: core: Cleanup in DbUserDAODbFacadeImpl
..
core: Cleanup in DbUserDAODbFacadeImpl
Did some general java cleanups:
* Removed dependency on the deprecated StringH
Allon Mureinik has uploaded a new change for review.
Change subject: core: Cleanup in AuditLogDirector
..
core: Cleanup in AuditLogDirector
Did some general java cleanups:
* Added final to immutable members
* Removed dependency
Allon Mureinik has uploaded a new change for review.
Change subject: core: Cleanup in TimeoutBase
..
core: Cleanup in TimeoutBase
Did some general java cleanup:
* Replaced FQCNs with imports
* Added final to immutable members
*
Sharad Mishra has uploaded a new change for review.
Change subject: engine: Replacing StringHelper with StringUtils in
VirtMonitoringStrategy.
..
engine: Replacing StringHelper with StringUtils in VirtMonitoringStrategy.
String
Sharad Mishra has uploaded a new change for review.
Change subject: engine: Replace StringHelper with StringUtils in
CreateVmVDSCommand
..
engine: Replace StringHelper with StringUtils in CreateVmVDSCommand
StringHelper is depr
Sharad Mishra has uploaded a new change for review.
Change subject: engine: Removing unused 'KEY_PATTERN'.
..
engine: Removing unused 'KEY_PATTERN'.
The value of the field VmPropertiesUtils.KEY_PATTERN is not used.
Change-Id: I
Sharad Mishra has uploaded a new change for review.
Change subject: engine: Replace StringHelper with StringUtils in
VmPropertiesUtils
..
engine: Replace StringHelper with StringUtils in VmPropertiesUtils
StringHelper is deprec
Sharad Mishra has uploaded a new change for review.
Change subject: engine: Removing unused local variables from ManageDomains.
..
engine: Removing unused local variables from ManageDomains.
Three variables removed are not being
Sharad Mishra has posted comments on this change.
Change subject: engine: Replacing StringHelper with Apache StringUtils.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5853
To unsubscribe, visit http://gerr
Sharad Mishra has uploaded a new change for review.
Change subject: engine: Replacing StringHelper with Apache StringUtils.
..
engine: Replacing StringHelper with Apache StringUtils.
StringHelper is deprecated.
Change-Id: I49e0
Asaf Shakarchi has submitted this change and it was merged.
Change subject: core: Supply Action/Type params in VDS activation error
messages (#783457)
..
core: Supply Action/Type params in VDS activation error messages (#783457
Asaf Shakarchi has posted comments on this change.
Change subject: core: Supply Action/Type params in VDS activation error
messages (#783457)
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit
Moran Goldboim has posted comments on this change.
Change subject: packaging: engine-setup - Replace hardcoded ovirt string
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.o
Sharad Mishra has posted comments on this change.
Change subject: engine: Removed unused log in KDCLocator
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5852
To unsubscribe, visit http://gerrit.ovirt.org/se
Sharad Mishra has uploaded a new change for review.
Change subject: engine: Removed unused log in KDCLocator
..
engine: Removed unused log in KDCLocator
'log' is not used in this class.
Change-Id: I01698a0166a2cb28a954e181aef55
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Take care of PreStarted VMs and ExectuionContext
..
core: Take care of PreStarted VMs and ExectuionContext
This patch fixes a potential to get NP
Yair Zaslavsky has posted comments on this change.
Change subject: core: Take care of PreStarted VMs and ExectuionContext
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5845
To un
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fixing running vm from pool at UserPoral
..
core: Fixing running vm from pool at UserPoral
The following fix attaches a new defined step of takin
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fixing running vm from pool at UserPoral
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5837
To unsubscrib
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fixing addSubStep at CommandBase
..
core: Fixing addSubStep at CommandBase
A subStep should added also in case there is no job associated with th
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fixing addSubStep at CommandBase
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5836
To unsubscribe, visit
Sharad Mishra has posted comments on this change.
Change subject: engine: Remove unused variable 'numberOfValidRecords'.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5851
To unsubscribe, visit http://gerri
Sharad Mishra has uploaded a new change for review.
Change subject: engine: Remove unused variable 'numberOfValidRecords'.
..
engine: Remove unused variable 'numberOfValidRecords'.
This is a private variable that is incremented
Eli Mesika has posted comments on this change.
Change subject: core: Take care of PreStarted VMs and ExectuionContext
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5845
To unsubscribe, vis
Eli Mesika has posted comments on this change.
Change subject: core: Fixing running vm from pool at UserPoral
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5837
To unsubscribe, visit http:
Eli Mesika has posted comments on this change.
Change subject: core: Fixing addSubStep at CommandBase
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5836
To unsubscribe, visit http://gerrit
Sharad Mishra has posted comments on this change.
Change subject: engine: Replacing StringHelper with Apache StringUtils.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5850
To unsubscribe, visit http://gerr
Sharad Mishra has uploaded a new change for review.
Change subject: engine: Replacing StringHelper with Apache StringUtils.
..
engine: Replacing StringHelper with Apache StringUtils.
StringHelper is deprecated.
Change-Id: I1649
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine: Remove unused log.
..
engine: Remove unused log.
'log' variable is not used in this class.
Change-Id: Ic087b0605b471d17274ea8d122f7dafe73591ec
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Remove unused log.
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5849
To unsubscribe, visit http://gerr
Sharad Mishra has uploaded a new change for review.
Change subject: engine: Remove unused log.
..
engine: Remove unused log.
'log' variable is not used in this class.
Change-Id: Ic087b0605b471d17274ea8d122f7dafe73591ec8
Signed-
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/1526/
Build Number: 1526
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 2,032,
Started by upstream project "ovirt_engine" build numb
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/1524/
Build Number: 1524
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 2,029
-
Changes Since
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/1525/
Build Number: 1525
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 2,030,
Started by upstream project "ovirt_engine" bu
Daniel Erez has posted comments on this change.
Change subject: core: Supply Action/Type params in VDS activation error
messages (#783457)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/58
Vojtech Szocs has uploaded a new change for review.
Change subject: webadmin,userportal: Clean gen directory before GWT compilation
..
webadmin,userportal: Clean gen directory before GWT compilation
WebAdmin and UserPortal POM f
Vojtech Szocs has uploaded a new change for review.
Change subject: webadmin,userportal: GWT localization interface cleanup
..
webadmin,userportal: GWT localization interface cleanup
To make oVirt UI translation process as simpl
Kiril Nesenko has posted comments on this change.
Change subject: packaging: engine-setup - Replace hardcoded ovirt string
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerri
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Force creation support for block storage
..
webadmin: Force creation support for block storage
New iSCSI/FCP storage domain Dialog / DataCenter
Daniel Erez has posted comments on this change.
Change subject: webadmin: Force creation support for block storage
..
Patch Set 3: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/5731
To
Daniel Erez has submitted this change and it was merged.
Change subject: restapi: LunStatus Enum and CreateVG force flag
..
restapi: LunStatus Enum and CreateVG force flag
** Added 'LunStatus' Enum: Free, Used, Unusable.
* Modi
Daniel Erez has posted comments on this change.
Change subject: restapi: LunStatus Enum and CreateVG force flag
..
Patch Set 9: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/5732
To uns
Daniel Erez has submitted this change and it was merged.
Change subject: core: Adding LunStatus to LUNs business entity
..
core: Adding LunStatus to LUNs business entity
* LunStatus enum: Free, Used, Unusable
* Parsing LUNs sta
Daniel Erez has posted comments on this change.
Change subject: core: Adding LunStatus to LUNs business entity
..
Patch Set 3: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/5730
To unsu
Daniel Erez has submitted this change and it was merged.
Change subject: core: Adding force creation support to CreateVG
..
core: Adding force creation support to CreateVG
* Added 'SupportForceCreateVG' configuration value
(tru
Daniel Erez has posted comments on this change.
Change subject: core: Adding force creation support to CreateVG
..
Patch Set 3: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/5729
To uns
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fixing running vm from pool at UserPoral
..
Patch Set 3:
Omer- You're correct, and I'm addressing this now (see also next patch).
--
To view, visit http
Juan Hernandez has posted comments on this change.
Change subject: packaging: Improvements for the engine start/stop script
..
Patch Set 11:
Rebased.
--
To view, visit http://gerrit.ovirt.org/5355
To unsubscribe, visit http://
1 - 100 of 250 matches
Mail list logo
