Michael Pasternak has posted comments on this change.
Change subject: restapi: Wrong href on Template Disks
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/r
Michael Pasternak has posted comments on this change.
Change subject: restapi: Wrong href on Template Disks
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Michael Pasternak has posted comments on this change.
Change subject: rest: Allow user level login (#816240)
..
Patch Set 2: Looks good to me, approved
+2 for api
--
To view, visit http://gerrit.ovirt.org/5812
To unsubscribe,
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/1515/
Build Number: 1515
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 2,019
-
Changes Since La
Grant Murphy has posted comments on this change.
Change subject: webadmin: Use an absolute URL for spice CABs
..
Patch Set 4:
PST security reviewed 2012-06-29
--
To view, visit http://gerrit.ovirt.org/5612
To unsubscribe, visi
Grant Murphy has posted comments on this change.
Change subject: core: Use file servlet to serve documentation
..
Patch Set 2: (1 inline comment)
File
backend/manager/module
Eyal Edri has posted comments on this change.
Change subject: core: Simplify use of generics to avoid cobertura bug
..
Patch Set 1: Verified
verified patch with cobertura run on storag sanity iscsi job:
http://loki01.eng.lab.tl
Daniel Erez has posted comments on this change.
Change subject: webadmin: Added sorting to disk list when attaching to a VM
(#834346)
..
Patch Set 1: (1 inline comment)
File
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: calling GetLunsByVgId query by Host ID
..
webadmin: calling GetLunsByVgId query by Host ID
Edit Block Storage dialog:
* Fetching LUNs stored in DB using
Daniel Erez has submitted this change and it was merged.
Change subject: core: GetLunsByVgId - update LUNs path count
..
core: GetLunsByVgId - update LUNs path count
GetLunsByVgId query should return a list of LUNs by a VG ID:
Daniel Erez has posted comments on this change.
Change subject: core: GetLunsByVgId - update LUNs path count
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/5797
To unsubs
Matthias Schmitz has uploaded a new change for review.
Change subject: core: Fix small format error in engine-manage-domains output
..
core: Fix small format error in engine-manage-domains output
* Insert space in error message:
Yair Zaslavsky has posted comments on this change.
Change subject: core: new function to list vds' that have all required network
(#826593)
..
Patch Set 3: (1 inline comment)
...
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fix small format error in engine-manage-domains output
..
core: Fix small format error in engine-manage-domains output
* Insert space in error me
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fix small format error in engine-manage-domains output
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5811
To unsubscribe, visit http:
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fix small format error in engine-manage-domains output
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5811
To unsubs
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/1510/
Build Number: 1510
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 2,013,
Started by upstream project "ovirt_engine" build numb
Oved Ourfali has posted comments on this change.
Change subject: rest: Allow user level login (#816240)
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5812
To unsubscri
Asaf Shakarchi has uploaded a new change for review.
Change subject: rest: Allow user level login (#816240)
..
rest: Allow user level login (#816240)
https://bugzilla.redhat.com/816240
- Support for user level login by supporti
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: NPE due to mismatch between command and params (#805897)
..
core: NPE due to mismatch between command and params (#805897)
https://bugzilla.redha
Yair Zaslavsky has posted comments on this change.
Change subject: core: NPE due to mismatch between command and params (#805897)
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32
Allon Mureinik has posted comments on this change.
Change subject: engine:Delete image should roll forward.(#822051)
..
Patch Set 1: I would prefer that you didn't submit this
(4 inline comments)
I'm not sure I'm a fan of this
Allon Mureinik has posted comments on this change.
Change subject: core: Bootable attribute for LUN disk is always null (#834352)
..
Patch Set 1: Looks good to me, but someone else must approve
assuming this is tested, +1.
--
Tal Nisan has uploaded a new change for review.
Change subject: webadmin: Added sorting to disk list when attaching to a VM
(#834346)
..
webadmin: Added sorting to disk list when attaching to a VM (#834346)
https://bugzilla.red
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Fixing 2 keys at engine-config conf file
..
core: Fixing 2 keys at engine-config conf file
1. MaxDiskSize does not exist in vdc_options
2. JobClean
Oved Ourfali has posted comments on this change.
Change subject: core: Fixing 2 keys at engine-config conf file
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5809
To unsubscribe,
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Fixing 2 keys at engine-config conf file
..
core: Fixing 2 keys at engine-config conf file
1. MaxDiskSize does not exist in vdc_options
2. JobCleanupRate
Michael Kublin has posted comments on this change.
Change subject: core: Adding LunStatus to LUNs business entity
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5730
To unsubscribe, visit h
Oved Ourfali has submitted this change and it was merged.
Change subject: utilities: adding an error log print in engine-manage-domains
..
utilities: adding an error log print in engine-manage-domains
This patch adds an error l
Oved Ourfali has posted comments on this change.
Change subject: utilities: adding an error log print in engine-manage-domains
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5807
Tal Nisan has uploaded a new change for review.
Change subject: core: Bootable attribute for LUN disk is always null (#834352)
..
core: Bootable attribute for LUN disk is always null (#834352)
https://bugzilla.redhat.com/834352
Roy Golan has posted comments on this change.
Change subject: utilities: adding an error log print in engine-manage-domains
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5807
To unsubscrib
Michael Kublin has posted comments on this change.
Change subject: core: Adding force creation support to CreateVG
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5729
To unsubscribe, visit
Oved Ourfali has uploaded a new change for review.
Change subject: utilities: adding an error log print in engine-manage-domains
..
utilities: adding an error log print in engine-manage-domains
This patch adds an error log print
Shahar Havivi has submitted this change and it was merged.
Change subject: Engine: Handle missing/invalid mac address on import Vm/Template
..
Engine: Handle missing/invalid mac address on import Vm/Template
On importing VM/Tem
Shahar Havivi has posted comments on this change.
Change subject: Engine: Handle missing/invalid mac address on import Vm/Template
..
Patch Set 8: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5
Shahar Havivi has submitted this change and it was merged.
Change subject: UI: Fix NPE when Disk have no storage-domain id
..
UI: Fix NPE when Disk have no storage-domain id
Change-Id: I6b5fbce50de3e05c9e16576cd0714cd2c4dfa732
Shahar Havivi has posted comments on this change.
Change subject: UI: Fix NPE when Disk have no storage-domain id
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5801
To unsubscrib
Maor Lipchuk has uploaded a new change for review.
Change subject: engine:Delete image should roll forward.(#822051)
..
engine:Delete image should roll forward.(#822051)
When removing a VM, the images of the VM are being removed
Shahar Havivi has posted comments on this change.
Change subject: Fix NPE when Disk have no storage-domain id
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5801
To unsubscribe, visit http:
Shahar Havivi has submitted this change and it was merged.
Change subject: Engine: Set correct storage id for snapshots
..
Engine: Set correct storage id for snapshots
Snapshots are stored with storage id, but the storage id ca
Shahar Havivi has posted comments on this change.
Change subject: Engine: Set correct storage id for snapshots
..
Patch Set 8: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5322
To unsubscribe,
Shahar Havivi has submitted this change and it was merged.
Change subject: Fix Index out of bound exception in import VM
..
Fix Index out of bound exception in import VM
Change-Id: I1b6cf1d1773fd510c599909af509cb60e1f61432
Sign
Shahar Havivi has posted comments on this change.
Change subject: Fix Index out of bound exception in import VM
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5805
To unsubscribe,
Shahar Havivi has posted comments on this change.
Change subject: Fix Index out of bound exception in import VM
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5805
To unsubscribe,
Einav Cohen has posted comments on this change.
Change subject: webadmin: Typo "storages"->"storage" in the system tree
(#834929)
..
Patch Set 1:
No real need in "storagesTitle"; please remove it and use "storageTitle"
instea
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Fixing Error handling at engine-manage-domains
..
core: Fixing Error handling at engine-manage-domains
In case there is an exception during initial
Oved Ourfali has posted comments on this change.
Change subject: core: Fixing Error handling at engine-manage-domains
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5722
To unsubs
Roy Golan has posted comments on this change.
Change subject: Fix Index out of bound exception in import VM
..
Patch Set 1: Looks good to me, approved
(1 inline comment)
Fil
Shahar Havivi has posted comments on this change.
Change subject: Fix Index out of bound exception in import VM
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5805
To unsubscribe, visit http://gerrit.ovirt.o
Shahar Havivi has uploaded a new change for review.
Change subject: Fix Index out of bound exception in import VM
..
Fix Index out of bound exception in import VM
Change-Id: I1b6cf1d1773fd510c599909af509cb60e1f61432
Signed-off-b
Daniel Erez has posted comments on this change.
Change subject: Fix NPE when Disk have no storage-domain id
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5801
To unsubscribe, visit http://
Oved Ourfali has posted comments on this change.
Change subject: wip core: validating cluster level when using bridgeless network
..
Patch Set 2:
changed to test the DC and not cluster level, as logical networks are DC-level
e
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/1506/
Build Number: 1506
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 2,007,
Started by upstream project "ovirt_engine" build numb
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/1426/
Build Number: 1426
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 2,005
-
Changes Since
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/1427/
Build Number: 1427
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 2,007
-
Changes Since La
Ori Liel has uploaded a new change for review.
Change subject: restapi: Add Floating Disks Tests
..
restapi: Add Floating Disks Tests
Signed-off-by: Ori Liel
Change-Id: I1f41e7b5000d29c3d44ecbee06572aa83ae7bcc0
---
M
backend/m
Project: http://jenkins.ovirt.org/job/ovirt_engine/
Build: http://jenkins.ovirt.org/job/ovirt_engine/2006/
Build Number: 2006
Build Status: Failure
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Chang
Alexey Chub has uploaded a new change for review.
Change subject: webadmin: Typo "storages"->"storage" in the system tree
(#834929)
..
webadmin: Typo "storages"->"storage" in the system tree (#834929)
Change-Id: I08fd87ea82bd33
Mike Kolesnik has posted comments on this change.
Change subject: Engine: Set correct storage id for snapshots
..
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5322
To unsubscribe, visit http
Project: http://jenkins.ovirt.org/job/ovirt_engine_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt_engine_create_rpms/1237/
Build Number: 1237
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 2,005
-
Changes Si
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Added externalized override tags to VmDiskPopupWidget
..
webadmin: Added externalized override tags to VmDiskPopupWidget
Change-Id: I1ed0b418389
Daniel Erez has posted comments on this change.
Change subject: webadmin: Added externalized override tags to VmDiskPopupWidget
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5802
Kiril Nesenko has posted comments on this change.
Change subject: userportal: List all templates according to user permissions.
..
Patch Set 2:
Verified the patch.
--
To view, visit http://gerrit.ovirt.org/5440
To unsubscribe,
Tal Nisan has uploaded a new change for review.
Change subject: webadmin: Added externalized override tags to VmDiskPopupWidget
..
webadmin: Added externalized override tags to VmDiskPopupWidget
Change-Id: I1ed0b418389d2c2628fa8
Shahar Havivi has posted comments on this change.
Change subject: Fix NPE when Disk have no storage-domain id
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5801
To unsubscribe, visit http://gerrit.ovirt.org
Shahar Havivi has uploaded a new change for review.
Change subject: Fix NPE when Disk have no storage-domain id
..
Fix NPE when Disk have no storage-domain id
Change-Id: I6b5fbce50de3e05c9e16576cd0714cd2c4dfa732
Signed-off-by: S
Shahar Havivi has posted comments on this change.
Change subject: Engine: Set correct storage id for snapshots
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/5322
To unsubscribe, visit http://gerrit.ovirt.or
Shahar Havivi has posted comments on this change.
Change subject: Engine: Set correct storage id for snapshots
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/5322
To unsubscribe, visit http://gerrit.ovirt.or
Michael Pasternak has posted comments on this change.
Change subject: restapi: Remove spring framework
..
Patch Set 7: Looks good to me, approved
+2 for api
--
To view, visit http://gerrit.ovirt.org/1390
To unsubscribe, visit
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Disable changing of DC when adding a new external
disk (#833120)
..
webadmin: Disable changing of DC when adding a new external disk (#833120)
ht
Tal Nisan has posted comments on this change.
Change subject: webadmin: Disable changing of DC when adding a new external
disk (#833120)
..
Patch Set 3: Verified; Looks good to me, approved
No change, just rebase
--
To view,
Tal Nisan has posted comments on this change.
Change subject: webadmin: Added disk description to attach disk (#834341)
..
Patch Set 2: Verified; Looks good to me, approved
No change, just rebase
--
To view, visit http://gerri
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Added disk description to attach disk (#834341)
..
webadmin: Added disk description to attach disk (#834341)
https://bugzilla.redhat.com/834341
W
Yair Zaslavsky has posted comments on this change.
Change subject: core: RegisterVdsQuery - BitSet instead of indexOf
..
Patch Set 4: (1 inline comment)
Please see my comment.
..
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:Validate snapshot when detach a disk
..
core:Validate snapshot when detach a disk
When detaching a disk, there should be a validation if the disk is
Maor Lipchuk has posted comments on this change.
Change subject: core:Validate snapshot when detach a disk
..
Patch Set 4: Verified; Looks good to me, approved
Acked by mkublin and Allon
--
To view, visit http://gerrit.ovirt.o
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/1502/
Build Number: 1502
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 2,002
-
Changes Since La
Doron Fediuck has posted comments on this change.
Change subject: packaging: Updated default encryption key size to 2048
..
Patch Set 2: (1 inline comment)
File backend/manag
Oved Ourfali has submitted this change and it was merged.
Change subject: userportal: List User VMs according to user permissions
..
userportal: List User VMs according to user permissions
List User VMs according to the standar
Oved Ourfali has posted comments on this change.
Change subject: userportal: List User VMs according to user permissions
..
Patch Set 2: Verified; Looks good to me, approved
Rebased Asaf's patch.
Submitting.
--
To view, visit
Roy Golan has posted comments on this change.
Change subject: core: Added images check builder to ImagesHandler
..
Patch Set 1:
I think the builder isn't conventional or trivial.
go the Josh way:
new ImagesHandler.builder().ch
Michael Kublin has submitted this change and it was merged.
Change subject: core: RestAPI can create two or more VMs with the same
characteristics
..
core: RestAPI can create two or more VMs with the same characteristics
The f
Michael Kublin has submitted this change and it was merged.
Change subject: core: Refactoring of using locks ids
..
core: Refactoring of using locks ids
The following patch is a change of API, instead of passing pair Guid,Stri
Michael Kublin has posted comments on this change.
Change subject: core: RestAPI can create two or more VMs with the same
characteristics
..
Patch Set 3: Verified; Looks good to me, approved
rebase
--
To view, visit http://ge
Michael Kublin has posted comments on this change.
Change subject: core: Refactoring of using locks ids
..
Patch Set 3: Verified; Looks good to me, approved
rebase
--
To view, visit http://gerrit.ovirt.org/5799
To unsubscribe,
Eli Mesika has abandoned this change.
Change subject: core: db - adding db schema dependencies graph
..
Patch Set 1: Abandoned
got no feedback on that for a while so maybe nobody thinks it is useful except
me. abandoned
--
To
Roy Golan has submitted this change and it was merged.
Change subject: webadmin: replace sysprep tab with intial run
..
webadmin: replace sysprep tab with intial run
introducing "Initial Run" tab instead of sysprep tab. The tab
Roy Golan has posted comments on this change.
Change subject: webadmin: replace sysprep tab with intial run
..
Patch Set 9: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5387
To unsubscribe, vis
Roy Golan has submitted this change and it was merged.
Change subject: core: make the getTimeZone query OS bounded
..
core: make the getTimeZone query OS bounded
this query will return different timezone for windows OS (the def
Roy Golan has posted comments on this change.
Change subject: core: make the getTimeZone query OS bounded
..
Patch Set 11: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5326
To unsubscribe, visi
Roy Golan has submitted this change and it was merged.
Change subject: core: replace GetTimeZoneQuery with a static block
..
core: replace GetTimeZoneQuery with a static block
move the syncronyzed init code block a static block
Roy Golan has posted comments on this change.
Change subject: core: replace GetTimeZoneQuery with a static block
..
Patch Set 11: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5274
To unsubscrib
Daniel Erez has posted comments on this change.
Change subject: webadmin: Disable changing of DC when adding a new external
disk (#833120)
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/57
Daniel Erez has posted comments on this change.
Change subject: webadmin: Added disk description to attach disk (#834341)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5780
To unsubscribe,
Muli Salem has submitted this change and it was merged.
Change subject: core: Remove SetConfigurationValueCommand
..
core: Remove SetConfigurationValueCommand
This patch removes the SetConfigurationValueCommand.
Change-Id: I4b
Muli Salem has posted comments on this change.
Change subject: core: Remove SetConfigurationValueCommand
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5778
To unsubscribe, visit
Muli Salem has posted comments on this change.
Change subject: core: Remove SetConfigurationValueCommand
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5778
To unsubscribe, visit
Michael Kublin has posted comments on this change.
Change subject: core: GetLunsByVgId - update LUNs path count
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5797
To unsubscribe, visit htt
1 - 100 of 128 matches
Mail list logo
