Oved Ourfali has posted comments on this change.
Change subject: restapi: Remove spring framework
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1390
To unsubscribe, vi
Michael Kublin has posted comments on this change.
Change subject: core: expose the V3 domain format in dc 3.1
..
Patch Set 15: Looks good to me, but someone else must approve
For engine part, please wait for +1 rest part (I ad
Liron Aravot has posted comments on this change.
Change subject: core: added snapshot id to attached disk (#834004)
..
Patch Set 2: (3 inline comments)
replied to comments by amureini
..
Michael Pasternak has posted comments on this change.
Change subject: restapi: filtering the api according to ApplicationMode
..
Patch Set 2: I would prefer that you didn't submit this
(11 inline comments)
Roy Golan has submitted this change and it was merged.
Change subject: engine: Allow to iterate over remaining ldap servers on
NullPointerException.
..
engine: Allow to iterate over remaining ldap servers on NullPointerExceptio
Roy Golan has posted comments on this change.
Change subject: engine: Allow to iterate over remaining ldap servers on
NullPointerException.
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.o
Allon Mureinik has posted comments on this change.
Change subject: core: expose the V3 domain format in dc 3.1
..
Patch Set 15: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4476
To u
Oved Ourfali has posted comments on this change.
Change subject: core: Fixing Error handling at engine-manage-domains
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5722
To unsubscribe, vis
Allon Mureinik has posted comments on this change.
Change subject: core: GetLunsByVgId - update LUNs path count
..
Patch Set 1: I would prefer that you didn't submit this
(4 inline comments)
...
Roy Golan has posted comments on this change.
Change subject: engine: Allow to iterate over remaining ldap servers on
NullPointerException.
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5
Roy Golan has posted comments on this change.
Change subject: core: Add engine-java script
..
Patch Set 3: (1 inline comment)
File Makefile
Line 367: install -m 755 pac
Allon Mureinik has posted comments on this change.
Change subject: webadmin: calling GetLunsByVgId query by Host ID
..
Patch Set 1: (1 inline comment)
Daniel, I'm not quite on what functionallity you're achieving here - let's
Roy Golan has posted comments on this change.
Change subject: core: Add engine-java script
..
Patch Set 3: (2 inline comments)
File packaging/fedora/engine-java.py
Line 202:
Allon Mureinik has posted comments on this change.
Change subject: core: added snapshot id to attached disk (#834004)
..
Patch Set 2: I would prefer that you didn't submit this
(4 inline comments)
I think you forgot to git add
Allon Mureinik has posted comments on this change.
Change subject: core: changed wrong error message when editing a shared disk
(#835092)
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Look
Sharad Mishra has uploaded a new change for review.
Change subject: core: WIP - Add support for Qemu GA (#830954)
..
core: WIP - Add support for Qemu GA (#830954)
This is a first drft with some pseudo-code in it.
The idea is to
Project: http://jenkins.ovirt.org/job/ovirt_engine_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt_engine_create_rpms/1191/
Build Number: 1191
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 1,942
-
Chan
Project: http://jenkins.ovirt.org/job/ovirt_engine_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt_engine_create_rpms/1190/
Build Number: 1190
Build Status: Still Failing
Triggered By: Started by upstream project "ovirt_engine" build number 1,941
-
Chan
Project: http://jenkins.ovirt.org/job/ovirt_engine_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt_engine_create_rpms/1189/
Build Number: 1189
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 1,903,
Started by upstream project "ovirt_engine" buil
Tal Nisan has posted comments on this change.
Change subject: webadmin: Disable changing of DC when adding a new external
disk (#833120)
..
Patch Set 1: (3 inline comments)
Sharad Mishra has uploaded a new change for review.
Change subject: core: Remove unnecessary checks in
canRemoveDiskBasedOnImageStorageCheck()
..
core: Remove unnecessary checks in canRemoveDiskBasedOnImageStorageCheck()
There
Daniel Erez has uploaded a new change for review.
Change subject: core: Adding LunStatus to LUNs business entity
..
core: Adding LunStatus to LUNs business entity
* LunStatus enum: Free, Used, Unusable
* Parsing LUNs statuses in
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: Force creation support for block storage
..
webadmin: Force creation support for block storage
New iSCSI/FCP storage domain Dialog / DataCenter GuideMe
Daniel Erez has uploaded a new change for review.
Change subject: restapi: LunStatus Enum and CreateVG force flag
..
restapi: LunStatus Enum and CreateVG force flag
** Added 'LunStatus' Enum: Free, Used, Unusable.
* Modified 'St
Daniel Erez has uploaded a new change for review.
Change subject: core: Adding force creation support to CreateVG
..
core: Adding force creation support to CreateVG
* Added 'SupportForceCreateVG' configuration value
(true for ve
Juan Hernandez has posted comments on this change.
Change subject: restapi: Remove spring framework
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/1390
To unsubscribe, visit http://gerrit.ovirt.org/settings
Juan Hernandez has posted comments on this change.
Change subject: core: Update to Spring 3
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/3002
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-
Sharad Mishra has posted comments on this change.
Change subject: core: Fixing Error handling at engine-manage-domains
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/57
Ayal Baron has posted comments on this change.
Change subject: webadmin: Disable changing of DC when adding a new external
disk (#833120)
..
Patch Set 1: (3 inline comments)
Sharad Mishra has posted comments on this change.
Change subject: engine: Allow to iterate over remaining ldap servers on
NullPointerException.
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
Thanks R
Juan Hernandez has posted comments on this change.
Change subject: core: Use file servlet to serve documentation
..
Patch Set 1: Verified
After copying the documentation to /usr/share/ovirt-engine/docs I verified that
webadmin
Juan Hernandez has uploaded a new change for review.
Change subject: core: Use file servlet to serve documentation
..
core: Use file servlet to serve documentation
The documentation will be deployed to the
/usr/share/ovirt-engin
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Move to GWT 2.4
..
Patch Set 1:
GWT 2.4 migration cleanup patch: http://gerrit.ovirt.org/5726
--
To view, visit http://gerrit.ovirt.org/561
Vojtech Szocs has uploaded a new change for review.
Change subject: webadmin: GWT 2.4 migration cleanup
..
webadmin: GWT 2.4 migration cleanup
1. Removed HTML5 drag'n'drop classes that were originally copied
from GWT 2.4 trun
Yair Zaslavsky has posted comments on this change.
Change subject: core: Add engine-java script
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5129
To unsubscribe, visi
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fix engine log rotation
..
core: Fix engine log rotation
Rotation should be set to 10M, not 1M
Acked-by:
Change-Id: I45ad476cb2ccc266740bb9e974b
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fix engine log rotation
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5673
To unsubscribe, visit http://g
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Fixing Error handling at engine-manage-domains
..
core: Fixing Error handling at engine-manage-domains
In case there is an exception during initializion
Liron Aravot has uploaded a new change for review.
Change subject: core: changed wrong error message when editing a shared disk
(#835092)
..
core: changed wrong error message when editing a shared disk (#835092)
https://bugzill
Roy Golan has posted comments on this change.
Change subject: engine: Allow to iterate over remaining ldap servers on
NullPointerException.
..
Patch Set 2:
my mistake formatting is ok. I'll resubmit this patch without the fina
Gilad Chaplik has posted comments on this change.
Change subject: core:upgrade from rhevm is not possible
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5692
To unsubscribe, visit http://ge
Eli Mesika has posted comments on this change.
Change subject: core: database restore fixes
..
Patch Set 3:
Yair, this is just the recommended approach, you can skip step 3) if you want
so, I had just recommended the way with
Roy Golan has posted comments on this change.
Change subject: engine: Allow to iterate over remaining ldap servers on
NullPointerException.
..
Patch Set 2: (1 inline comment)
...
Eli Mesika has posted comments on this change.
Change subject: core:upgrade from rhevm is not possible
..
Patch Set 1: (1 inline comment)
File
frontend/webadmin/modules/uico
Omer Frenkel has posted comments on this change.
Change subject: core: allow snapshots for imported templates
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5720
To unsubscribe, visit http://gerrit.ovirt.org
Omer Frenkel has uploaded a new change for review.
Change subject: core: allow snapshots for imported templates
..
core: allow snapshots for imported templates
when importing template, the AllowSnapshot is not initialized,
so by
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/1381/
Build Number: 1381
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 1,934
-
Changes Since
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: engine-setup-validators - Fix controller decleration
..
packaging: engine-setup-validators - Fix controller decleration
The controller varia
Ofer Schreiber has posted comments on this change.
Change subject: packaging: engine-setup-validators - Fix controller decleration
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5
Ofer Schreiber has posted comments on this change.
Change subject: packaging: engine-setup-validators - Fix controller decleration
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5719
To uns
Juan Hernandez has posted comments on this change.
Change subject: packaging: engine-setup-validators - Fix controller decleration
..
Patch Set 2: Verified
Applied this change manually and it works correctly.
--
To view, visit
Shahar Havivi has posted comments on this change.
Change subject: Engine: Set correct storage id for snapshots
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/5322
To unsubscribe, visit http://gerrit.ovirt.or
Ofer Schreiber has uploaded a new change for review.
Change subject: packaging: engine-setup-validators - Fix controller decleration
..
packaging: engine-setup-validators - Fix controller decleration
The controller variable in v
Juan Hernandez has posted comments on this change.
Change subject: packaging: Improvements for the engine start/stop script
..
Patch Set 9: Verified
Verified that I can build RPMs, install them, run engine-setup and start/stop
Oved Ourfali has submitted this change and it was merged.
Change subject: core: fixes in timezone values in sysprep
..
core: fixes in timezone values in sysprep
This patch fixes some errors in the timezones in the sysprep files
Oved Ourfali has posted comments on this change.
Change subject: core: fixes in timezone values in sysprep
..
Patch Set 2: Verified; Looks good to me, approved
rebased. submitting based on previous ACK.
--
To view, visit http:
Oved Ourfali has posted comments on this change.
Change subject: core: fixes in timezone values in sysprep
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5514
To unsubscribe, visit http://gerrit.ovirt.org/se
Shahar Havivi has posted comments on this change.
Change subject: Engine: Ovf reader will fail if image StorageId doesnt exists
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/5344
To unsubscribe, visit http:
Roy Golan has posted comments on this change.
Change subject: core: fixes in timezone values in sysprep
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5514
To unsubscribe, visit http://gerr
Shahar Havivi has submitted this change and it was merged.
Change subject: UI: edit cluster set first CPU item when the CPU is null
..
UI: edit cluster set first CPU item when the CPU is null
Change-Id: I6baaf89af219ef22b1e3f37
Shahar Havivi has posted comments on this change.
Change subject: UI: edit cluster set first CPU item when the CPU is null
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5674
To u
Juan Hernandez has posted comments on this change.
Change subject: packaging: Improvements for the engine start/stop script
..
Patch Set 9:
Fixed the location of the script in the .spec file.
--
To view, visit http://gerrit.ov
Liron Aravot has uploaded a new change for review.
Change subject: core: added snapshot id to attached disk (#834004)
..
core: added snapshot id to attached disk (#834004)
https://bugzilla.redhat.com/834004
when attaching a dis
Shahar Havivi has submitted this change and it was merged.
Change subject: UI: Add port mirroring action group to configuration manager
..
UI: Add port mirroring action group to configuration manager
Change-Id: I38e402b72751745
Shahar Havivi has posted comments on this change.
Change subject: UI: Add port mirroring action group to configuration manager
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5675
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: calling GetLunsByVgId query by Host ID
..
webadmin: calling GetLunsByVgId query by Host ID
Edit Block Storage dialog:
* Fetching LUNs stored in DB using
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: hourglass on Add-Edit block storage dialog
..
webadmin: hourglass on Add-Edit block storage dialog
* Fixing 'hour-glass' on block storage domain Add-Edi
Daniel Erez has uploaded a new change for review.
Change subject: core: GetLunsByVgId - update LUNs path count
..
core: GetLunsByVgId - update LUNs path count
GetLunsByVgId query should return a list of LUNs by a VG ID:
* The qu
Shahar Havivi has submitted this change and it was merged.
Change subject: UI: wrong capitalization of MAC in error message
..
UI: wrong capitalization of MAC in error message
Change-Id: If4a78cf175771fd813d9799ce3323df138bf3
Shahar Havivi has posted comments on this change.
Change subject: UI: wrong capitalization of MAC in error message
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5642
To unsubscr
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/1380/
Build Number: 1380
Build Status: Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 1,933
-
Changes Sin
Yaniv Dary has posted comments on this change.
Change subject: packaging: changed maven version and group to static values
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5714
To u
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: changed maven version and group to static values
..
packaging: changed maven version and group to static values
This is because it is not standa
Yaniv Dary has uploaded a new change for review.
Change subject: packaging: changed maven version and group to static values
..
packaging: changed maven version and group to static values
This is because it is not standard to us
Tal Nisan has uploaded a new change for review.
Change subject: webadmin: Disable changing of DC when adding a new external
disk (#833120)
..
webadmin: Disable changing of DC when adding a new external disk (#833120)
https://bu
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Correct error string on destroy Storage Domain
..
webadmin: Correct error string on destroy Storage Domain
Change-Id: I88482313b574f6d4264b0e73e81
Tal Nisan has posted comments on this change.
Change subject: webadmin: Correct error string on destroy Storage Domain
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/5683
To unsubscribe, visit http://gerrit.
Daniel Erez has posted comments on this change.
Change subject: webadmin: Correct error string on destroy Storage Domain
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5683
To unsubscribe,
Asaf Shakarchi has submitted this change and it was merged.
Change subject: restapi: List VMs according to user permissions
..
restapi: List VMs according to user permissions
When filtering is enabled, list VMs according to the
Asaf Shakarchi has posted comments on this change.
Change subject: restapi: List VMs according to user permissions
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5706
To unsubscri
Ori Liel has posted comments on this change.
Change subject: restapi: List VMs according to user permissions
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5706
To unsubscribe, visit http:/
Tal Nisan has submitted this change and it was merged.
Change subject: userportal: VM make template option stucks
..
userportal: VM make template option stucks
Caused from a null pointer exception, the model used the Storage
Do
Tal Nisan has posted comments on this change.
Change subject: userportal: VM make template option stucks
..
Patch Set 2: Verified; Looks good to me, approved
No change, just rebase
--
To view, visit http://gerrit.ovirt.org/566
Oved Ourfali has posted comments on this change.
Change subject: restapi: List VMs according to user permissions
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5706
To
Asaf Shakarchi has uploaded a new change for review.
Change subject: restapi: List VMs according to user permissions
..
restapi: List VMs according to user permissions
When filtering is enabled, list VMs according to the standar
Oved Ourfali has posted comments on this change.
Change subject: userportal: List User VMs according to user permissions
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5704
To unsubscribe,
Kanagaraj M has posted comments on this change.
Change subject: webadmin: GlusterOnly - hiding load column in cluster host
subtab
..
Patch Set 3: Verified
Rebase and Verified.
--
To view, visit http://gerrit.ovirt.org/5687
To
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: GlusterOnly - hiding load column in cluster host
subtab
..
Patch Set 3: Verified; Looks good to me, approved
rebased by MK
--
To view, visit http://g
Kanagaraj M has posted comments on this change.
Change subject: webadmin: Adding null check for cluster in VolumePopup
..
Patch Set 3: Verified
Rebase and Verified.
--
To view, visit http://gerrit.ovirt.org/5607
To unsubscribe
Roy Golan has posted comments on this change.
Change subject: core: CDI cleanup
..
Patch Set 1:
thanks a lot for that. during my tests I thought to myself how come I didn't do
it.
By the way I have a long list of pros for ann
Asaf Shakarchi has uploaded a new change for review.
Change subject: userportal: List User VMs according to user permissions
..
userportal: List User VMs according to user permissions
List User VMs according to the standard user
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: GlusterOnly - hiding load column in cluster host
subtab
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org
Kanagaraj M has posted comments on this change.
Change subject: webadmin: GlusterOnly - hiding load column in cluster host
subtab
..
Patch Set 2:
Comments are implemented.
Please review it.
--
To view, visit http://gerrit.ov
Kanagaraj M has posted comments on this change.
Change subject: webadmin: GlusterOnly - hiding load column in cluster host
subtab
..
Patch Set 1: (1 inline comment)
File
fr
Ofer Schreiber has posted comments on this change.
Change subject: packaging: Moving Jboss configuration functions to separate
module
..
Patch Set 6: (3 inline comments)
Fil
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: GlusterOnly - hiding load column in cluster host
subtab
..
Patch Set 1: (1 inline comment)
File
Gilad Chaplik has posted comments on this change.
Change subject: core:upgrade from rhevm is not possible
..
Patch Set 1: (1 inline comment)
File
frontend/webadmin/modules/u
Ofer Schreiber has posted comments on this change.
Change subject: packaging: Moving to use execCmd in all scripts (#731686)
..
Patch Set 5: I would prefer that you didn't submit this
Fix itself should be fine.
The thing is, yo
Ofer Schreiber has posted comments on this change.
Change subject: packaging: added updates to pgpass creation and reading
..
Patch Set 2: Fails
(5 inline comments)
File pac
Eli Mesika has uploaded a new change for review.
Change subject: core:upgrade from rhevm is not possible
..
core:upgrade from rhevm is not possible
upgrade from rhevm is not possible (ISO list is empty)
Removing a redundant chec
1 - 100 of 131 matches
Mail list logo