Shahar Havivi has posted comments on this change.
Change subject: Set correct storage id for snapshots
..
Patch Set 2: (1 inline comment)
Commit Message
Line 7: Set correct s
Michael Kublin has posted comments on this change.
Change subject: core: move/copy disk entity id fix
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
..
Yair Zaslavsky has posted comments on this change.
Change subject: core: UnPowerMock and clean pools with vm commands
..
Patch Set 4: (1 inline comment)
File
backend/manager
Ayal Baron has posted comments on this change.
Change subject: Set correct storage id for snapshots
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/bll/src/m
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/1458/
Build Number: 1458
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 1,897
-
Change
Ayal Baron has posted comments on this change.
Change subject: core: session in
AbstractGetEntitiesWithPermittedActionParametersQueryTest
..
Patch Set 1: (1 inline comment)
Ayal Baron has posted comments on this change.
Change subject: core: session in
AbstractGetEntitiesWithPermittedActionParametersQueryTest
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
.
Ayal Baron has posted comments on this change.
Change subject: core: Clean up casts in SessionDataContainer[Test]
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5649
To
Ayal Baron has posted comments on this change.
Change subject: core: UnPowerMock and clean pools with vm commands
..
Patch Set 4: (3 inline comments)
File
backend/manager/mo
Yair Zaslavsky has posted comments on this change.
Change subject: core: Add a profile to exclude gluster tests
..
Patch Set 1:
After consulting with Allon - removing my questing
--
To view, visit http://gerrit.ovirt.org/5654
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/1457/
Build Number: 1457
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 1,896
-
Chan
Ayal Baron has posted comments on this change.
Change subject: core: refactor UpdateVmCommand
..
Patch Set 3: (1 inline comment)
File
backend/manager/modules/bll/src/main/ja
Yair Zaslavsky has posted comments on this change.
Change subject: core: Introducing engine.powermock.fork build flag
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5653
To unsubscribe, visit http://gerrit.o
Ofer Schreiber has posted comments on this change.
Change subject: packaging: engine-setup - Use semange instead of setsebool
..
Patch Set 3: Fails
Fails on F17, will have to debug it.
--
To view, visit http://gerrit.ovirt.org
Omer Frenkel has submitted this change and it was merged.
Change subject: core: add permission for changing custom properties
..
core: add permission for changing custom properties
in order to change custom properties user need
Omer Frenkel has posted comments on this change.
Change subject: core: add permission for changing custom properties
..
Patch Set 3: Verified; Looks good to me, approved
just rebased and checked addVmFromTemplate works as expec
Yair Zaslavsky has posted comments on this change.
Change subject: core: Add a profile to exclude gluster tests
..
Patch Set 1:
The code looks good to me, however - do we want to automatically disable
gluster tests? (A point t
Yair Zaslavsky has posted comments on this change.
Change subject: core: Add a profile to exclude gluster tests
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5654
To unsubscribe, visit htt
Yair Zaslavsky has posted comments on this change.
Change subject: core: Introducing engine.powermock.fork build flag
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5653
To unsubscribe, vis
Yair Zaslavsky has posted comments on this change.
Change subject: core: Session in GetUserBySessionIdQueryTest
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5652
To unsubscribe, visit htt
Yair Zaslavsky has posted comments on this change.
Change subject: core: Session in CommandBaseTest
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5651
To unsubscribe, visit http://gerrit.
Yair Zaslavsky has posted comments on this change.
Change subject: core: session in
AbstractGetEntitiesWithPermittedActionParametersQueryTest
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org
Yair Zaslavsky has posted comments on this change.
Change subject: core: Clean up casts in SessionDataContainer[Test]
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5649
To unsubscribe, vis
Yair Zaslavsky has posted comments on this change.
Change subject: core: UnPowerMock and clean pools with vm commands
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5517
To unsubscribe, vis
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fixing task monitoring - run stateless
..
core: Fixing task monitoring - run stateless
The following patch fixes task monitoring for run stateles
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fixing task monitoring - run stateless
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5597
To unsubscribe,
Yair Zaslavsky has submitted this change and it was merged.
Change subject: common: Introducing a method to get a direct step.
..
common: Introducing a method to get a direct step.
A direct step is a step that does not have a p
Yair Zaslavsky has posted comments on this change.
Change subject: common: Introducing a method to get a direct step.
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5596
To unsubs
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Adding some helper methods for Task monitoring
..
core: Adding some helper methods for Task monitoring
This patch addeds some helper methods for
Yair Zaslavsky has posted comments on this change.
Change subject: core: Adding some helper methods for Task monitoring
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5586
To unsu
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Adding a few CTORs to CommandContext
..
core: Adding a few CTORs to CommandContext
In order to fix some task monitoring issue it is required to
c
Yair Zaslavsky has posted comments on this change.
Change subject: core: Adding a few CTORs to CommandContext
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5529
To unsubscribe, v
Doron Fediuck has submitted this change and it was merged.
Change subject: core: Close store file after use
..
core: Close store file after use
We need to close the keystore file after using it, otherwise we
will have a file de
Doron Fediuck has posted comments on this change.
Change subject: core: Close store file after use
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5599
To unsubscribe, visit http://gerrit.ov
Ofer Schreiber has posted comments on this change.
Change subject: core: Close store file after use
..
Patch Set 1: Looks good to me, but someone else must approve
ACK from my side to push this into engine_3.1 branch.
since I d
Doron Fediuck has posted comments on this change.
Change subject: core: working CDI solution for backend
..
Patch Set 2: (1 inline comment)
Unsure new artifacts can be added now.
This may need to wait a while.
Michael Pasternak has uploaded a new change for review.
Change subject: cli: do not verify type existence in show
..
cli: do not verify type existence in show
Change-Id: I6fce904317d5899ddbb215dfde04d629cb6a0d9d
Signed-off-by: M
Allon Mureinik has posted comments on this change.
Change subject: core: Add a profile to exclude gluster tests
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5654
To unsubscribe, visit http://gerrit.ovirt.o
Allon Mureinik has posted comments on this change.
Change subject: core: Session in GetUserBySessionIdQueryTest
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5652
To unsubscribe, visit http://gerrit.ovirt.o
Allon Mureinik has posted comments on this change.
Change subject: core: Session in CommandBaseTest
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5651
To unsubscribe, visit http://gerrit.ovirt.org/settings
Allon Mureinik has posted comments on this change.
Change subject: core: session in
AbstractGetEntitiesWithPermittedActionParametersQueryTest
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5650
To unsubscri
Allon Mureinik has posted comments on this change.
Change subject: core: Clean up casts in SessionDataContainer[Test]
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5649
To unsubscribe, visit http://gerrit.o
Allon Mureinik has posted comments on this change.
Change subject: core: UnPowerMock and clean pools with vm commands
..
Patch Set 4: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 r
Allon Mureinik has uploaded a new change for review.
Change subject: core: Session in GetUserBySessionIdQueryTest
..
core: Session in GetUserBySessionIdQueryTest
Properly close the user session defined in GetUserBySessionIdQuery
Allon Mureinik has uploaded a new change for review.
Change subject: core: Introducing engine.powermock.fork build flag
..
core: Introducing engine.powermock.fork build flag
The default behavior of the build is to always fork te
Allon Mureinik has uploaded a new change for review.
Change subject: core: Add a profile to exclude gluster tests
..
core: Add a profile to exclude gluster tests
Gluster tests are the main users of PowerMock, which forces the bu
Allon Mureinik has uploaded a new change for review.
Change subject: core: Clean up casts in SessionDataContainer[Test]
..
core: Clean up casts in SessionDataContainer[Test]
Fix casts to the concrete VdcUser in both SessionDataC
Allon Mureinik has uploaded a new change for review.
Change subject: core: session in
AbstractGetEntitiesWithPermittedActionParametersQueryTest
..
core: session in AbstractGetEntitiesWithPermittedActionParametersQueryTest
Prope
Allon Mureinik has uploaded a new change for review.
Change subject: core: Session in CommandBaseTest
..
core: Session in CommandBaseTest
Properly close the user session defined in CommandBasseTest in an
@After method so it do
Yair Zaslavsky has posted comments on this change.
Change subject: core: add permission for changing custom properties
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5492
To unsubscribe, vi
Michael Pasternak has posted comments on this change.
Change subject: build: Fix build issue on centos 6.2
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4894
To unsubscribe, visi
Michael Pasternak has submitted this change and it was merged.
Change subject: build: Fix build issue on centos 6.2
..
build: Fix build issue on centos 6.2
On centos 6.2 using git 1.7.1, the argument '-c' doesn't
exist. Here, i
Michael Pasternak has submitted this change and it was merged.
Change subject: 'cli: refactor auto-completion to support 3+ deep
collections/resources'
..
'cli: refactor auto-completion to support 3+ deep collections/resources'
Michael Pasternak has posted comments on this change.
Change subject: 'cli: refactor auto-completion to support 3+ deep
collections/resources'
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerri
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: fix broken 2-level context related auto-completion
..
cli: fix broken 2-level context related auto-completion
Change-Id: I5376e5a3f89fae89432b1
Michael Pasternak has posted comments on this change.
Change subject: cli: fix broken 2-level context related auto-completion
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5584
T
Michael Pasternak has posted comments on this change.
Change subject: cli: expend nested types as parameters overloads in show/create
commands
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerri
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: expend nested types as parameters overloads in show/create
commands
..
cli: expend nested types as parameters overloads in show/create commands
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: refactor help/commands to support parameters overloads
..
cli: refactor help/commands to support parameters overloads
Change-Id: Ib1dea2be5c408
Michael Pasternak has posted comments on this change.
Change subject: cli: refactor help/commands to support parameters overloads
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/55
Michael Pasternak has uploaded a new change for review.
Change subject: cli: centralise cli messages
..
cli: centralise cli messages
Change-Id: Ibc0feb0acc826d2d7482496c3aaf1bebadab3ceb
Signed-off-by: Michael Pasternak
---
M sr
Daniel Erez has posted comments on this change.
Change subject: webadmin: adjust event time column width
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5645
To unsubscribe, visit http://ger
Eli Mesika has posted comments on this change.
Change subject: core: Fixing task monitoring - run stateless
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5597
To unsubscribe, visit http://
Eli Mesika has posted comments on this change.
Change subject: common: Introducing a method to get a direct step.
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5596
To unsubscribe, visit h
Eli Mesika has posted comments on this change.
Change subject: core: Adding some helper methods for Task monitoring
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5586
To unsubscribe, visit
Gilad Chaplik has uploaded a new change for review.
Change subject: core: lock dest image in import command
..
core: lock dest image in import command
currently in import VM/Template, the image that is being locked is the source
Gilad Chaplik has uploaded a new change for review.
Change subject: core: move/copy disk entity id fix
..
core: move/copy disk entity id fix
when moving image the entity id of the command's parameters, should
be the dest disk uu
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: adjust event time column width
..
webadmin: adjust event time column width
* in event subtab foreach system entity
* in events main grid (basic view)
Gilad Chaplik has uploaded a new change for review.
Change subject: core: 'Import More Than Once' clean-up
..
core: 'Import More Than Once' clean-up
because of an override to getVm() in import command class, there is no
need for
Omer Frenkel has posted comments on this change.
Change subject: core: add permission for changing custom properties
..
Patch Set 2:
no changes needed in AddVmFromTemplateCommand since getPermissionCheckSubjects
is not overrid
Yaniv Kaul has posted comments on this change.
Change subject: core: Close store file after use
..
Patch Set 2:
I understand where the leak is, but I don't understand why we bother opening
the file again and again (and now wit
Omer Frenkel has posted comments on this change.
Change subject: core: add permission for changing custom properties
..
Patch Set 2: Verified
since in AddVm all inheriting classes override getPermissionCheckSubject i had
to ex
Yair Zaslavsky has posted comments on this change.
Change subject: core: add permission for changing custom properties
..
Patch Set 2:
No handling is required for AddVmFromTemplate?
--
To view, visit http://gerrit.ovirt.org/54
Omer Frenkel has submitted this change and it was merged.
Change subject: core: refactor UpdateVmCommand
..
core: refactor UpdateVmCommand
refactor UpdateVmCommand to make sense and try to be a little more readable
this is done
Omer Frenkel has submitted this change and it was merged.
Change subject: core: added tests to updateVmCommand
..
core: added tests to updateVmCommand
Added some test to UpdateVmCommnad canDoAction as preperation for refactorin
Omer Frenkel has posted comments on this change.
Change subject: core: added tests to updateVmCommand
..
Patch Set 4: Verified; Looks good to me, approved
just rebased and verified
--
To view, visit http://gerrit.ovirt.org/544
Omer Frenkel has posted comments on this change.
Change subject: core: refactor UpdateVmCommand
..
Patch Set 3: Verified; Looks good to me, approved
just rebased and verified
--
To view, visit http://gerrit.ovirt.org/5454
To u
Doron Fediuck has posted comments on this change.
Change subject: core: block vm migration if cpu pinning enabled
..
Patch Set 12: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5065
To unsubscri
Itamar Heim has posted comments on this change.
Change subject: packaging: engine-setup - Don't use httpd proxy when ipa
installed
..
Patch Set 2: (1 inline comment)
File pa
Michael Pasternak has posted comments on this change.
Change subject: restapi: RSDL: Support Links With Optional Body
..
Patch Set 1: (1 inline comment)
File
backend/manager
Yair Zaslavsky has posted comments on this change.
Change subject: Revert "core: Option with empty name and value ..." This
reverts commit 04618248977aa3f649ef938e639ea59e532cfd72
..
Patch Set 1: Looks good to me, approved
--
Eli Mesika has reverted this change.
Change subject: Revert "core: Option with empty name and value ..." This
reverts commit 04618248977aa3f649ef938e639ea59e532cfd72
..
Patch Set 3: Reverted
This patchset was reverted in chang
Ori Liel has posted comments on this change.
Change subject: restapi: RSDL: Support Links With Optional Body
..
Patch Set 1: (2 inline comments)
File
backend/manager/modules
Michael Kublin has submitted this change and it was merged.
Change subject: core: Data Integrity Exception (null in column "command_id")
(#830785)
..
core: Data Integrity Exception (null in column "command_id") (#830785)
https
Michael Kublin has posted comments on this change.
Change subject: core: Data Integrity Exception (null in column "command_id")
(#830785)
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://g
Michael Kublin has posted comments on this change.
Change subject: core: Data Integrity Exception (null in column "command_id")
(#830785)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5641
To unsubscribe,
Shahar Havivi has posted comments on this change.
Change subject: UI: wrong capitalization of MAC in error message
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/5642
To unsubscribe, visit http://gerrit.ovi
Shahar Havivi has uploaded a new change for review.
Change subject: UI: wrong capitalization of MAC in error message
..
UI: wrong capitalization of MAC in error message
Change-Id: If4a78cf175771fd813d9799ce3323df138bf3064
Sign
Yair Zaslavsky has posted comments on this change.
Change subject: core: Data Integrity Exception (null in column "command_id")
(#830785)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/564
Yaniv Kaul has posted comments on this change.
Change subject: packaging: engine-setup - Don't use httpd proxy when ipa
installed
..
Patch Set 2: (1 inline comment)
File pac
Michael Kublin has uploaded a new change for review.
Change subject: core: Data Integrity Exception (null in column "command_id")
(#830785)
..
core: Data Integrity Exception (null in column "command_id") (#830785)
https://bugzi
Oved Ourfali has submitted this change and it was merged.
Change subject: core: using SASL on LDAP queries in utils
..
core: using SASL on LDAP queries in utils
This patch uses javax.security.sasl.qop configuration on the LDAP
Oved Ourfali has posted comments on this change.
Change subject: core: using SASL on LDAP queries in utils
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5638
To unsubscribe, visi
Oved Ourfali has posted comments on this change.
Change subject: core: New query 'GetAllVms' to get all vms with filtering
support (#783087)
..
Patch Set 1: Looks good to me, but someone else must approve
Once addressing Allon
Shahar Havivi has posted comments on this change.
Change subject: Handle missing/invalid mac address on import Vm/Template
..
Patch Set 5: (1 inline comment)
File
backend/ma
Liron Aravot has posted comments on this change.
Change subject: core: RegisterVdsQuery -removed CanDoAction()
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/5631
To unsubscribe, visit http://gerrit.ovirt.or
Project: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/1452/
Build Number: 1452
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 1,890
-
Change
Yair Zaslavsky has posted comments on this change.
Change subject: core: using SASL on LDAP queries in utils
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5638
To unsubscribe, vi
Ori Liel has posted comments on this change.
Change subject: cli: refactor help/commands to support parameters overloads
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/
Juan Hernandez has posted comments on this change.
Change subject: packaging: engine-setup - Use semange instead of setsebool
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt
1 - 100 of 168 matches
Mail list logo
