[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: remove yet not supported collections/resources (3+ deep...

2012-05-27 Thread oliel
Ori Liel has posted comments on this change. Change subject: sdk: remove yet not supported collections/resources (3+ deep URLs) .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: restapi: Cluster schema changes

2012-05-27 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: restapi: Cluster schema changes .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4824 To unsubscribe, visit http://gerrit

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: rebase to latest api

2012-05-27 Thread oliel
Ori Liel has posted comments on this change. Change subject: sdk: rebase to latest api .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4819 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: core: Use ping verb to check connectivity with host

2012-05-27 Thread masayag
Moti Asayag has uploaded a new change for review. Change subject: core: Use ping verb to check connectivity with host .. core: Use ping verb to check connectivity with host The previous check connectivity used the getCapabilitie

[Engine-patches] Change in ovirt-engine[master]: core: Add ReloadConfigurationsCommand

2012-05-27 Thread msalem
Muli Salem has posted comments on this change. Change subject: core: Add ReloadConfigurationsCommand .. Patch Set 5: Added instructions to wiki. -- To view, visit http://gerrit.ovirt.org/4291 To unsubscribe, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: engine: Implemented getBricksByBrickId in GlusterVolumeRemov...

2012-05-27 Thread dgopal
Dhandapani Gopal has uploaded a new change for review. Change subject: engine: Implemented getBricksByBrickId in GlusterVolumeRemoveBricksCommand .. engine: Implemented getBricksByBrickId in GlusterVolumeRemoveBricksCommand - A

[Engine-patches] Change in ovirt-engine[master]: core: Fix handling same network on different nics

2012-05-27 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: core: Fix handling same network on different nics .. core: Fix handling same network on different nics The old check would never catch this scenario, si

[Engine-patches] Change in ovirt-engine[master]: core: Fix handling same network on different nics

2012-05-27 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Fix handling same network on different nics .. Patch Set 3: Verified; Looks good to me, approved Rebased, ack by masayag -- To view, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: core: Change SetupNetworks remove network (#820505)

2012-05-27 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: core: Change SetupNetworks remove network (#820505) .. core: Change SetupNetworks remove network (#820505) https://bugzilla.redhat.com/820505 Setup net

[Engine-patches] Change in ovirt-engine[master]: core: Change SetupNetworks remove network (#820505)

2012-05-27 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Change SetupNetworks remove network (#820505) .. Patch Set 3: Verified; Looks good to me, approved Rebased, ack by masayag -- To view, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: core: Add unmanaged networks to Setup Networks

2012-05-27 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: core: Add unmanaged networks to Setup Networks .. core: Add unmanaged networks to Setup Networks SetupNetworksHelper should keep a list of unmanaged net

[Engine-patches] Change in ovirt-engine[master]: core: Add unmanaged networks to Setup Networks

2012-05-27 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Add unmanaged networks to Setup Networks .. Patch Set 3: Verified; Looks good to me, approved Rebased, ack by masayag -- To view, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: restapi: Cluster schema changes

2012-05-27 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: restapi: Cluster schema changes .. Patch Set 2: Updated rsdl metadata with the new flags. -- To view, visit http://gerrit.ovirt.org/4824 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core: remove obselete scripts (#819806)

2012-05-27 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: remove obselete scripts (#819806) .. Patch Set 2: Looks good to me, approved my bad, the -1 is revoked :). -- To view, visit http://gerrit.ovirt.org/4569 To u

[Engine-patches] Change in ovirt-engine[master]: core: remove obselete scripts (#819806)

2012-05-27 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: remove obselete scripts (#819806) .. Patch Set 2: No score -- To view, visit http://gerrit.ovirt.org/4569 To unsubscribe, visit http://gerrit.ovirt.org/setting

[Engine-patches] Change in ovirt-engine[master]: webadmin: Consolidated error messages (#823282)

2012-05-27 Thread tjelinek
Tomas Jelinek has abandoned this change. Change subject: webadmin: Consolidated error messages (#823282) .. Patch Set 1: Abandoned The requirement changed. -- To view, visit http://gerrit.ovirt.org/4809 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: engine: Used host name instead of vds name in gluster peer d...

2012-05-27 Thread dgopal
Dhandapani Gopal has uploaded a new change for review. Change subject: engine: Used host name instead of vds name in gluster peer detach .. engine: Used host name instead of vds name in gluster peer detach - Added missing error

[Engine-patches] Change in ovirt-engine[master]: engine: Refactor LdapProviderType and LdapVendorNameEnum

2012-05-27 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: engine: Refactor LdapProviderType and LdapVendorNameEnum .. Patch Set 2: Looks good to me, but someone else must approve Good Job! -- To view, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: engine: Update the brick status during add brick

2012-05-27 Thread dgopal
Dhandapani Gopal has uploaded a new change for review. Change subject: engine: Update the brick status during add brick .. engine: Update the brick status during add brick - Updated the brick status up/down depends on the volume

[Engine-patches] Change in ovirt-engine[master]: core: Minor change from ArrayList to List

2012-05-27 Thread yzaslavs
Yair Zaslavsky has abandoned this change. Change subject: core: Minor change from ArrayList to List .. Patch Set 1: Abandoned already merged upstream -- To view, visit http://gerrit.ovirt.org/1916 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: core: Minor change from ArrayList to List

2012-05-27 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Minor change from ArrayList to List .. Patch Set 1: Sharad, thanks for pointing it out. i will abandon this. -- To view, visit http://gerrit.ovirt.org/19

[Engine-patches] Change in ovirt-engine[master]: restapi: Cluster schema changes

2012-05-27 Thread sanjal
Shireesh Anjal has uploaded a new change for review. Change subject: restapi: Cluster schema changes .. restapi: Cluster schema changes Introduced the flags "virt_service" and "gluster_service" in the "Cluster" schema These are

[Engine-patches] Change in ovirt-engine[master]: engine: New validations in add/edit cluster

2012-05-27 Thread sanjal
Shireesh Anjal has uploaded a new change for review. Change subject: engine: New validations in add/edit cluster .. engine: New validations in add/edit cluster - At least one service (virt/gluster) must be enabled - Cannot disab