[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: remove yet not supported collections/resources (3+ deep...

2012-05-25 Thread mpastern
Michael Pasternak has uploaded a new change for review. Change subject: sdk: remove yet not supported collections/resources (3+ deep URLs) .. sdk: remove yet not supported collections/resources (3+ deep URLs) Change-Id: I70e5ca

[Engine-patches] Change in ovirt-engine[master]: Fix warning for StorageHelperDirector

2012-05-25 Thread masayag
Moti Asayag has posted comments on this change. Change subject: Fix warning for StorageHelperDirector .. Patch Set 1: (1 inline comment) File backend/manager/modules/bll/src

[Engine-patches] Change in ovirt-engine[master]: Fix warning for StorageHelperDirector

2012-05-25 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: Fix warning for StorageHelperDirector .. Patch Set 1: (1 inline comment) File backend/manager/modules/bll/

[Engine-patches] Change in ovirt-engine[master]: webadmin: oVirt Modes - Cluster General tab changes

2012-05-25 Thread kmayilsa
Kanagaraj M has uploaded a new change for review. Change subject: webadmin: oVirt Modes - Cluster General tab changes .. webadmin: oVirt Modes - Cluster General tab changes Summary of volume details will be shown in the General

[Engine-patches] Change in ovirt-engine[master]: core: OvfVmWriterTest

2012-05-25 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: core: OvfVmWriterTest .. Patch Set 1: Reviewed the code, applied the patch on latest upstream. Was able to successfully build and deploy engine. Ran the jUnit

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: rebase to latest api

2012-05-25 Thread mpastern
Michael Pasternak has uploaded a new change for review. Change subject: sdk: rebase to latest api .. sdk: rebase to latest api added: = partial gluster support partial quota support remove template disk (by storage domain) v

[Engine-patches] Change in ovirt-engine[master]: Fix warning for StorageHelperDirector

2012-05-25 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: Fix warning for StorageHelperDirector .. Patch Set 1: (1 inline comment) File backend/manager/modules/bll/s

[Engine-patches] Change in ovirt-engine[master]: core: findbugs fix

2012-05-25 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: core: findbugs fix .. Patch Set 1: Looks good to me, but someone else must approve getVmNetworkInterfaceDao() in AbstractDiskVmCommand class is using above metho

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 962 - Still Unstable!

2012-05-25 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/962/ Build Number: 962 Build Status: Still Unstable Triggered By: Started by upstream project "ovirt_engine" build number 1,309 - Changes S

[Engine-patches] Change in ovirt-engine[master]: core: OvfVmWriterTest

2012-05-25 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: OvfVmWriterTest .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4817 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: ISO/Floppy list query replacement

2012-05-25 Thread vszocs
Vojtech Szocs has submitted this change and it was merged. Change subject: userportal,webadmin: ISO/Floppy list query replacement .. userportal,webadmin: ISO/Floppy list query replacement The patch http://gerrit.ovirt.org/#chan

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: ISO/Floppy list query replacement

2012-05-25 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: userportal,webadmin: ISO/Floppy list query replacement .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4664 To uns

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 961 - Still Unstable!

2012-05-25 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/961/ Build Number: 961 Build Status: Still Unstable Triggered By: Started by upstream project "ovirt_engine" build number 1,308 - Changes S

[Engine-patches] Change in ovirt-engine[master]: userportal: When VM Pool and VM has same name, UP freezes (#...

2012-05-25 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: userportal: When VM Pool and VM has same name, UP freezes (#824805) .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: userportal: When VM Pool and VM has same name, UP freezes (#...

2012-05-25 Thread vszocs
Vojtech Szocs has submitted this change and it was merged. Change subject: userportal: When VM Pool and VM has same name, UP freezes (#824805) .. userportal: When VM Pool and VM has same name, UP freezes (#824805) https://bugz

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 960 - Still Unstable!

2012-05-25 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/960/ Build Number: 960 Build Status: Still Unstable Triggered By: Started by upstream project "ovirt_engine" build number 1,307 - Changes S

[Engine-patches] Change in ovirt-engine[master]: userportal: SpiceUsbAutoShare configuration is ignored (#767...

2012-05-25 Thread vszocs
Vojtech Szocs has submitted this change and it was merged. Change subject: userportal: SpiceUsbAutoShare configuration is ignored (#767081) .. userportal: SpiceUsbAutoShare configuration is ignored (#767081) https://bugzilla.re

[Engine-patches] Change in ovirt-engine[master]: userportal: SpiceUsbAutoShare configuration is ignored (#767...

2012-05-25 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: userportal: SpiceUsbAutoShare configuration is ignored (#767081) .. Patch Set 5: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 959 - Still Unstable!

2012-05-25 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/959/ Build Number: 959 Build Status: Still Unstable Triggered By: Started by upstream project "ovirt_engine" build number 1,305, Started by upstream project "ovirt_engine" bui

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 958 - Still Unstable!

2012-05-25 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/958/ Build Number: 958 Build Status: Still Unstable Triggered By: Started by upstream project "ovirt_engine" build number 1,303, Started by upstream project "ovirt_engine" bui

[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Enforce dialog close on Escape key

2012-05-25 Thread vszocs
Vojtech Szocs has uploaded a new change for review. Change subject: webadmin,userportal: Enforce dialog close on Escape key .. webadmin,userportal: Enforce dialog close on Escape key When a model-bound dialog is open and the use

[Engine-patches] Change in ovirt-engine[master]: restapi: Make dependency on servlet API explicit

2012-05-25 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: restapi: Make dependency on servlet API explicit .. restapi: Make dependency on servlet API explicit The LoginValidator class imports classes from the javax.se

[Engine-patches] Change in ovirt-engine[master]: restapi: User JBoss JACC artifact

2012-05-25 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: restapi: User JBoss JACC artifact .. restapi: User JBoss JACC artifact The artifact that we currently use is not available in the Fedora 17 repositories. Chan

[Engine-patches] Change in ovirt-engine[master]: core: Make dependency on commons-collections explicit

2012-05-25 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: core: Make dependency on commons-collections explicit .. core: Make dependency on commons-collections explicit The VmOldInfoBuilder class uses classes from com

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 957 - Still Unstable!

2012-05-25 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/957/ Build Number: 957 Build Status: Still Unstable Triggered By: Started by upstream project "ovirt_engine" build number 1,297, Started by upstream project "ovirt_engine" bui

[Engine-patches] Change in ovirt-engine[master]: core: Don't use Hibernate helper

2012-05-25 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: core: Don't use Hibernate helper .. core: Don't use Hibernate helper The commons-lang StringUtils.isEmpty() method is equivalent and simplifies packaging. Cha

[Engine-patches] [oVirt Jenkins] ovirt_engine_find_bugs - Build # 956 - Unstable!

2012-05-25 Thread Jenkins oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/ Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/956/ Build Number: 956 Build Status: Unstable Triggered By: Started by upstream project "ovirt_engine" build number 1,296 - Changes Since L

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: NotEmptyValidation removal (#823282)

2012-05-25 Thread tjelinek
Tomas Jelinek has abandoned this change. Change subject: userportal,webadmin: NotEmptyValidation removal (#823282) .. Patch Set 2: Abandoned It has been decided that this is not a correct approach and the NotEmptyValidation ha

[Engine-patches] Change in ovirt-engine[master]: webadmin: Consolidated error messages (#823282)

2012-05-25 Thread tjelinek
Tomas Jelinek has uploaded a new change for review. Change subject: webadmin: Consolidated error messages (#823282) .. webadmin: Consolidated error messages (#823282) https://bugzilla.redhat.com/823282 When a RegexValidator als

[Engine-patches] Change in ovirt-engine[master]: userportal: When VM Pool and VM has same name, UP freezes (#...

2012-05-25 Thread derez
Daniel Erez has posted comments on this change. Change subject: userportal: When VM Pool and VM has same name, UP freezes (#824805) .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4754 To u

[Engine-patches] Change in ovirt-engine[master]: userportal: SpiceUsbAutoShare configuration is ignored (#767...

2012-05-25 Thread derez
Daniel Erez has posted comments on this change. Change subject: userportal: SpiceUsbAutoShare configuration is ignored (#767081) .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4653 To unsub

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: ISO/Floppy list query replacement

2012-05-25 Thread derez
Daniel Erez has posted comments on this change. Change subject: userportal,webadmin: ISO/Floppy list query replacement .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/46

[Engine-patches] Change in ovirt-engine[master]: engine: Refactor LdapProviderType and LdapVendorNameEnum

2012-05-25 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: engine: Refactor LdapProviderType and LdapVendorNameEnum .. Patch Set 2: Looks good to me, but someone else must approve Sharad - good work. I would like Oved a

[Engine-patches] Change in ovirt-engine[master]: userportal: When VM Pool and VM has same name, UP freezes (#...

2012-05-25 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: userportal: When VM Pool and VM has same name, UP freezes (#824805) .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: webadmin: oVirt Modes - host general tab changes

2012-05-25 Thread kmayilsa
Kanagaraj M has uploaded a new change for review. Change subject: webadmin: oVirt Modes - host general tab changes .. webadmin: oVirt Modes - host general tab changes Virt related fields in Host General sub tab will be hidden wh