Roy Golan has posted comments on this change.
Change subject: engine: Refactor LdapProviderType and LdapVendorNameEnum
..
Patch Set 1: (3 inline comments)
Sharad this was exactly what we thought. good work.
...
Roy Golan has posted comments on this change.
Change subject: engine: Refactor LdapProviderType and LdapVendorNameEnum
..
Patch Set 1:
excuse us for not putting a nice link with the ovirt code-review wiki (will do
some day soo
Moti Asayag has uploaded a new change for review.
Change subject: restapi: error getting VM NIC with non-exists network (#782437)
..
restapi: error getting VM NIC with non-exists network (#782437)
https://bugzilla.redhat.com/782
Kanagaraj M has uploaded a new change for review.
Change subject: webadmin: Gluster Volume - brick server changes
..
webadmin: Gluster Volume - brick server changes
Add Bricks was using the vds_name as server name.
Now this is c
Sharad Mishra has uploaded a new change for review.
Change subject: engine: Refactor LdapProviderType and LdapVendorNameEnum
..
engine: Refactor LdapProviderType and LdapVendorNameEnum
This patch is still a work in progress. Its
Yair Zaslavsky has posted comments on this change.
Change subject: Move convertToStatusList to
ServerConnectionStatusReturnForXmlRpc
..
Patch Set 1: Looks good to me, approved
One step in making some order.
Too bad it reminded
Yair Zaslavsky has posted comments on this change.
Change subject: Fix warning for StorageHelperDirector
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/bll/
Moti Asayag has posted comments on this change.
Change subject: Fix warning for StorageHelperDirector
..
Patch Set 1: (2 inline comments)
File
backend/manager/modules/bll/sr
Saggi Mizrahi has posted comments on this change.
Change subject: Fix warning for StorageHelperDirector
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/bll/s
Yair Zaslavsky has posted comments on this change.
Change subject: core: remove obselete scripts (#819806)
..
Patch Set 2:
Roy, actually, I'm rebased against master, and do not find the IPA script at
the location (or at any lo
Michael Pasternak has uploaded a new change for review.
Change subject: cli: Implement history browsing mechanism #823512
..
cli: Implement history browsing mechanism #823512
implemented:
1. persistent history stack
2. recursiv
Yair Zaslavsky has posted comments on this change.
Change subject: core : Fixing a release lock for case of MultipleActionRunner
..
Patch Set 1:
Moti - IMHO the question is , is the locking mechanism lets you do that or not.
If
Yair Zaslavsky has posted comments on this change.
Change subject: core: [rmd] OvfManager
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4502
To unsubscribe, visit http://gerrit.ovirt.org/s
Juan Hernandez has posted comments on this change.
Change subject: virt-engine: Support RHEVManager url
..
Patch Set 11:
Forgot to say that after that little change I was able to register a RHEV-H
correctly.
--
To view, visit
Juan Hernandez has posted comments on this change.
Change subject: virt-engine: Support RHEVManager url
..
Patch Set 11:
Did you test this with JBoss AS 7.1.1? When I apply this change the server
complains that the "flags" att
Kanagaraj M has posted comments on this change.
Change subject: webadmin,userportal: PlaceManager refactoring
..
Patch Set 1: Verified
tested it. Working fine.
--
To view, visit http://gerrit.ovirt.org/4708
To unsubscribe, vis
Omer Frenkel has uploaded a new change for review.
Change subject: core: fix jobProperties for delete vm and template from export
(#818111)
..
core: fix jobProperties for delete vm and template from export (#818111)
https://bug
Moti Asayag has posted comments on this change.
Change subject: core: Change extractremoveNetwork return to void
..
Patch Set 1: Looks good to me, approved
(2 inline comments)
..
Moti Asayag has posted comments on this change.
Change subject: core: Change extractremoveNetwork return to void
..
Patch Set 1:
please fix typos
--
To view, visit http://gerrit.ovirt.org/4710
To unsubscribe, visit http://gerr
Moti Asayag has posted comments on this change.
Change subject: core: Change removed networks to list of String
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4709
To unsubscribe, visit htt
Omer Frenkel has posted comments on this change.
Change subject: core: Re-Enable user queries
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4696
To unsubscribe, visit http://gerrit.ovirt.o
Omer Frenkel has submitted this change and it was merged.
Change subject: core: Re-Enable user queries
..
core: Re-Enable user queries
Re-enabled the query permissions mechanism that was disabled due to
stability issues with th
Yair Zaslavsky has posted comments on this change.
Change subject: core: remove obselete scripts (#819806)
..
Patch Set 2:
rgolan - Correct :)
If you don't press enter after typing "git remove..." don't expect it to ber
carrie
Omer Frenkel has posted comments on this change.
Change subject: core:Validate shareable disk which attached to VMs
..
Patch Set 14: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4493
To unsubscribe, visi
Allon Mureinik has posted comments on this change.
Change subject: core: Re-Enable user queries
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebase, no changes since last +2 review.
--
To view, vis
Mike Kolesnik has posted comments on this change.
Change subject: core: Fix handling same network on different nics
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4713
To unsubscribe, visit http://gerrit.ovi
Mike Kolesnik has posted comments on this change.
Change subject: core: Change SetupNetworks remove network (#820505)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4712
To unsubscribe, visit http://gerrit.o
Mike Kolesnik has posted comments on this change.
Change subject: core: Change extractremoveNetwork return to void
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4710
To unsubscribe, visit http://gerrit.ovir
Mike Kolesnik has posted comments on this change.
Change subject: core: Add unmanaged networks to Setup Networks
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4711
To unsubscribe, visit http://gerrit.ovirt.
Mike Kolesnik has uploaded a new change for review.
Change subject: core: Change removed networks to list of String
..
core: Change removed networks to list of String
Change removed networks in SetupNetworks to be list of String
Mike Kolesnik has posted comments on this change.
Change subject: core: Change removed networks to list of String
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4709
To unsubscribe, visit http://gerrit.ovirt
Omer Frenkel has posted comments on this change.
Change subject: core: Re-Enable user queries
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4696
To unsubscribe, visit http://gerrit.ovirt.o
Mike Kolesnik has uploaded a new change for review.
Change subject: core: Fix handling same network on different nics
..
core: Fix handling same network on different nics
The old check would never catch this scenario, since the
Mike Kolesnik has uploaded a new change for review.
Change subject: core: Add unmanaged networks to Setup Networks
..
core: Add unmanaged networks to Setup Networks
SetupNetworksHelper should keep a list of unmanaged networks, s
Mike Kolesnik has uploaded a new change for review.
Change subject: core: Change SetupNetworks remove network (#820505)
..
core: Change SetupNetworks remove network (#820505)
https://bugzilla.redhat.com/820505
Setup networks sh
Mike Kolesnik has uploaded a new change for review.
Change subject: core: Change extractremoveNetwork return to void
..
core: Change extractremoveNetwork return to void
The list is already kept as a field in the SetupNetworksHel
Tal Nisan has submitted this change and it was merged.
Change subject: core: Add origin field for template ovf export/import (#818262)
..
core: Add origin field for template ovf export/import (#818262)
https://bugzilla.redhat.c
Gilad Chaplik has posted comments on this change.
Change subject: webadmin,userportal: PlaceManager refactoring
..
Patch Set 1: Looks good to me, approved
MK, please verify
--
To view, visit http://gerrit.ovirt.org/4708
To uns
Tal Nisan has posted comments on this change.
Change subject: core: Add origin field for template ovf export/import (#818262)
..
Patch Set 3: Verified; Looks good to me, approved
No change, just rebase
--
To view, visit http:/
Moti Asayag has posted comments on this change.
Change subject: core : Fixing a release lock for case of MultipleActionRunner
..
Patch Set 1:
But still, you're doing same operation twice when it doesn't require.
--
To view, vi
Tal Nisan has submitted this change and it was merged.
Change subject: core: Added disk alias to disk command events
..
core: Added disk alias to disk command events
Added disk alias to the event generated upon add/remove/updat
Tal Nisan has posted comments on this change.
Change subject: core: Added disk alias to disk command events
..
Patch Set 4: Verified; Looks good to me, approved
No change, just rebase
--
To view, visit http://gerrit.ovirt.org/
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Adding template vNIC: Add VmDevice (#822129)
..
core: Adding template vNIC: Add VmDevice (#822129)
https://bugzilla.redhat.com/822129
Bug is a re
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Refactor out a method for network devices
..
core: Refactor out a method for network devices
Refactor out a method to add network device as part o
Mike Kolesnik has posted comments on this change.
Change subject: core: Adding template vNIC: Add VmDevice (#822129)
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, ac by masayag
--
To view, visit http://gerrit.o
Mike Kolesnik has posted comments on this change.
Change subject: core: Refactor out a method for network devices
..
Patch Set 2: Verified; Looks good to me, approved
Rebased, ac by masayag
--
To view, visit http://gerrit.ovir
Vojtech Szocs has uploaded a new change for review.
Change subject: webadmin,userportal: PlaceManager refactoring
..
webadmin,userportal: PlaceManager refactoring
WebAdmin's default main section place should depend on current
"U
Alex Lourie has posted comments on this change.
Change subject: packaging: DO NOT MERGE: adding remoteDb support
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.or
Alex Lourie has posted comments on this change.
Change subject: packaging: DO NOT MERGE: adding remoteDb support
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.or
Moti Asayag has posted comments on this change.
Change subject: core: fix job properties in export vm and emplate (#818114)
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4683
To unsubscrib
Alex Lourie has uploaded a new change for review.
Change subject: packaging: DO NOT MERGE: adding remoteDb support
..
packaging: DO NOT MERGE: adding remoteDb support
* Adding remote DB support to dwh.
Signed-off-by: Alex Louri
Maor Lipchuk has posted comments on this change.
Change subject: core: Add origin field for template ovf export/import (#818262)
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4587
To unsub
Yair Zaslavsky has posted comments on this change.
Change subject: core: version fix
..
Patch Set 2:
IMHO, this can work for the current build , as a fixup.
Laszlo, I think you will also need to add 4.9.6 on SupportedVDSMVersio
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: NetworkModel - remove redundant properties
..
webadmin: NetworkModel - remove redundant properties
* Removing unused properties: Address/Subnet/
Daniel Erez has posted comments on this change.
Change subject: webadmin: NetworkModel - remove redundant properties
..
--
To view, visit http://gerrit.ovirt.org/4672
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ger
Daniel Erez has posted comments on this change.
Change subject: webadmin: NetworkModel - remove redundant properties
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/4672
T
Sharad Mishra has posted comments on this change.
Change subject: engine: Add support for IBM Tivoli Directory Server.
..
Patch Set 1: (3 inline comments)
File
backend/manag
Yaniv Dary has submitted this change and it was merged.
Change subject: etl: fixed old row in sample tables (#783787)
..
etl: fixed old row in sample tables (#783787)
ETL didn't check all the rables for more old rows to delete.
Yaniv Dary has posted comments on this change.
Change subject: etl: fixed old row in sample tables (#783787)
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4706
To unsubscribe, vi
Maor Lipchuk has posted comments on this change.
Change subject: core: Added disk alias to disk command events
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4311
To unsubscribe, visit http
Yaniv Dary has uploaded a new change for review.
Change subject: etl: fixed old row in sample tables (#783787)
..
etl: fixed old row in sample tables (#783787)
ETL didn't check all the rables for more old rows to delete.
Added c
Yair Zaslavsky has posted comments on this change.
Change subject: core : Fixing a release lock for case of MultipleActionRunner
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4671
To unsub
Project: http://jenkins.ovirt.org/job/ovirt_engine/
Build: http://jenkins.ovirt.org/job/ovirt_engine/1273/
Build Number: 1273
Build Status: Fixed
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Changes
Alexey Chub has posted comments on this change.
Change subject: webadmin: Posix FS storage type (storage dialog)
..
Patch Set 5: Verified; Looks good to me, approved
Rebase, no changes.
--
To view, visit http://gerrit.ovirt.or
Alexey Chub has submitted this change and it was merged.
Change subject: webadmin: Posix FS storage type (storage dialog)
..
webadmin: Posix FS storage type (storage dialog)
Change-Id: I6124b2594138256e3dce04d87bf5b9c5c18a293b
Allon Mureinik has posted comments on this change.
Change subject: core: [CpuPinning] db support for cpu_pinning
..
Patch Set 4:
the content itself seems fine - no changes required.
I don't want to +1 it so no one will merge i
Maor Lipchuk has posted comments on this change.
Change subject: core:Validate shareable disk which attached to VMs
..
Patch Set 13: Verified; Looks good to me, approved
acked by mkublin
--
To view, visit http://gerrit.ovirt.o
Project: http://jenkins.ovirt.org/job/ovirt_engine/
Build: http://jenkins.ovirt.org/job/ovirt_engine/1272/
Build Number: 1272
Build Status: Still Failing
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Maor Lipchuk has posted comments on this change.
Change subject: core:Use attachable disk for shareable
..
Patch Set 10: Verified; Looks good to me, approved
Acked by mkublin
--
To view, visit http://gerrit.ovirt.org/4488
To u
Sharad Mishra has posted comments on this change.
Change subject: engine: Add support for IBM Tivoli Directory Server.
..
Patch Set 2:
Roy,
I can look at the refactoring work.
--
To view, visit http://gerrit.ovirt.org/4633
Maor Lipchuk has abandoned this change.
Change subject: core:Clean unused method for clone and update image
..
Patch Set 12: Abandoned
Merged with other patch
--
To view, visit http://gerrit.ovirt.org/4642
To unsubscribe, visi
Maor Lipchuk has posted comments on this change.
Change subject: core:Cleanup for BaseImageCommand
..
Patch Set 16: Verified; Looks good to me, approved
acked by mkublin
--
To view, visit http://gerrit.ovirt.org/4644
To unsubs
Michael Kublin has posted comments on this change.
Change subject: core:Validate shareable disk which attached to VMs
..
Patch Set 13: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4493
To unsubscribe, vi
Maor Lipchuk has posted comments on this change.
Change subject: core:Change CDA message to fit shareable disk
..
Patch Set 16: Verified; Looks good to me, approved
acked by mkublin and ofrenkel
--
To view, visit http://gerrit
Yaniv Dary has posted comments on this change.
Change subject: etl: fixed connection issue (#817519)
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4705
To unsubscribe, visit http
Yaniv Dary has submitted this change and it was merged.
Change subject: etl: fixed connection issue (#817519)
..
etl: fixed connection issue (#817519)
ETL opened connections to ovirt engine portal and never
disconnected, which
Maor Lipchuk has posted comments on this change.
Change subject: core:Support remove of shareable disk.
..
Patch Set 15: Verified; Looks good to me, approved
Acked by mkublin
--
To view, visit http://gerrit.ovirt.org/4490
To u
Maor Lipchuk has posted comments on this change.
Change subject: core:Fix images handler CDA.
..
Patch Set 14: Verified; Looks good to me, approved
acked by mkublin and ofrenkel
--
To view, visit http://gerrit.ovirt.org/4638
T
Yaniv Dary has uploaded a new change for review.
Change subject: etl: fixed connection issue (#817519)
..
etl: fixed connection issue (#817519)
ETL opened connections to ovirt engine portal and never
disconnected, which caused i
Maor Lipchuk has posted comments on this change.
Change subject: core:Validate shareable disk which attached to VMs
..
Patch Set 13:
Update test of VmDiskUpate and move the check if disk exists
--
To view, visit http://gerrit.
Maor Lipchuk has posted comments on this change.
Change subject: core:Support move of shareable disk
..
Patch Set 11: Verified; Looks good to me, approved
Acked by mkublin
--
To view, visit http://gerrit.ovirt.org/4492
To unsu
Maor Lipchuk has posted comments on this change.
Change subject: core:Update VmDao to return multiple Vms for disk.
..
Patch Set 9: Verified; Looks good to me, approved
Acked by mkublin
--
To view, visit http://gerrit.ovirt.or
Maor Lipchuk has posted comments on this change.
Change subject: core:Use attachable disk for shareable
..
Patch Set 9: Verified
Acked by mkublin
--
To view, visit http://gerrit.ovirt.org/4488
To unsubscribe, visit http://gerr
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: 'Attach Disk' in VmGuideModel AddDisk
..
webadmin: 'Attach Disk' in VmGuideModel AddDisk
Fixed 'Attach Disk' in 'GuideMe -> New Disk' dialog
Ch
Daniel Erez has posted comments on this change.
Change subject: webadmin: 'Attach Disk' in VmGuideModel AddDisk
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/4699
To uns
Allon Mureinik has posted comments on this change.
Change subject: core: [CpuPinning] cleanup VmStaticDAODbFacadeImpl
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/459
Allon Mureinik has posted comments on this change.
Change subject: core: [CpuPinning] db support for cpu_pinning
..
Patch Set 4:
Please renumber the upgrade script.
1110 has already been merged.
--
To view, visit http://gerrit
Project: http://jenkins.ovirt.org/job/ovirt_engine/
Build: http://jenkins.ovirt.org/job/ovirt_engine/1271/
Build Number: 1271
Build Status: Failure
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Chang
Yaniv Dary has posted comments on this change.
Change subject: etl: fixed minor error in job
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4704
To unsubscribe, visit http://gerri
Yaniv Dary has submitted this change and it was merged.
Change subject: etl: fixed minor error in job
..
etl: fixed minor error in job
Change-Id: Ifb1f634e5808e9bf89a6d134fbfcd72bfee32acb
Signed-off-by: Yaniv Dary
---
M data-w
Yaniv Dary has submitted this change and it was merged.
Change subject: etl: updated tos to version 5.1.0
..
etl: updated tos to version 5.1.0
Change-Id: Ic70039a5de1ad5d4edac74d81f375bf2b743184a
Signed-off-by: Yaniv Dary
---
Yaniv Dary has posted comments on this change.
Change subject: etl: updated tos to version 5.1.0
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4702
To unsubscribe, visit http://g
Yaniv Dary has uploaded a new change for review.
Change subject: etl: fixed minor error in job
..
etl: fixed minor error in job
Change-Id: Ifb1f634e5808e9bf89a6d134fbfcd72bfee32acb
Signed-off-by: Yaniv Dary
---
M data-warehouse
Alexey Chub has posted comments on this change.
Change subject: webadmin: Posix FS storage type (storage dialog)
..
Patch Set 4: Verified; Looks good to me, approved
Rebase, no changes.
--
To view, visit http://gerrit.ovirt.or
Tal Nisan has posted comments on this change.
Change subject: webadmin: Fixed remove storage host list selection
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4701
To unsubscribe, visit http://gerrit.ovirt.
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fixed remove storage host list selection
..
webadmin: Fixed remove storage host list selection
When trying to remove a storage domain, the host to
Alexey Chub has posted comments on this change.
Change subject: webadmin: Fixed remove storage host list selection
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4701
To unsubscribe, visit
Yaniv Dary has uploaded a new change for review.
Change subject: etl: updated tos to version 5.1.0
..
etl: updated tos to version 5.1.0
Change-Id: Ic70039a5de1ad5d4edac74d81f375bf2b743184a
Signed-off-by: Yaniv Dary
---
M
data-
Allon Mureinik has posted comments on this change.
Change subject: core: Re-Enable user queries
..
Patch Set 2: Verified
Changed commit message prefix from userportal to core, as per ecohen's advise.
--
To view, visit http://g
Maor Lipchuk has posted comments on this change.
Change subject: core:Change CDA message to fit shareable disk
..
Patch Set 15: Looks good to me, approved
Acked by mkublin,ofrenkel and +1 from Allon
--
To view, visit http://ge
1 - 100 of 234 matches
Mail list logo
