Roy Golan has posted comments on this change.
Change subject: core: remove obselete scripts (#819806)
..
Patch Set 2: I would prefer that you didn't submit this
delete also localIpatest.sh
--
To view, visit http://gerrit.ovirt
Maor Lipchuk has posted comments on this change.
Change subject: core:Clean unused method for clone and update image
..
Patch Set 12: Looks good to me, but someone else must approve
rebase since last patch +1 from Allon
--
To
Maor Lipchuk has posted comments on this change.
Change subject: core:Change CDA message to fit shareable disk
..
Patch Set 12:
Fixed as Allon commented
--
To view, visit http://gerrit.ovirt.org/4639
To unsubscribe, visit http
Maor Lipchuk has posted comments on this change.
Change subject: core:Use shareable disk only for 3.1 DC version
..
Patch Set 12:
Changes from last review:
1. Removed storage pool from the parameters.
2. Use validation for ver
Moti Asayag has posted comments on this change.
Change subject: webadmin: NetworkModel - remove redundant properties
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovir
Maor Lipchuk has posted comments on this change.
Change subject: core:Fix images handler CDA.
..
Patch Set 10: Looks good to me, approved
Acked by ofrenkel
--
To view, visit http://gerrit.ovirt.org/4638
To unsubscribe, visit h
Maor Lipchuk has posted comments on this change.
Change subject: core:Support remove of shareable disk.
..
Patch Set 11:
Changes from last patch review:
1.Validate image only on first VM iteration
2. Sending null to removeImage
Maor Lipchuk has posted comments on this change.
Change subject: core:Validate shareable disk which attached to VMs
..
Patch Set 9:
Started using locking mechanism for update disk as mKublin suggested in
patchset 5
--
To view
Maor Lipchuk has posted comments on this change.
Change subject: core:Update VmDao to return multiple Vms for disk.
..
Patch Set 6: Looks good to me, approved
Acked by ofrenkel
--
To view, visit http://gerrit.ovirt.org/4491
To
Maor Lipchuk has posted comments on this change.
Change subject: core:Use attachable disk for shareable
..
Patch Set 7: Looks good to me, approved
Acked by ofrenkel
--
To view, visit http://gerrit.ovirt.org/4488
To unsubscribe
Allon Mureinik has posted comments on this change.
Change subject: core:Change CDA message to fit shareable disk
..
Patch Set 11:
Sorry, missed this in the previous patch.
Why did you change ACTION_TYPE_FAILED_IMAGE_ALREADY_EX
Allon Mureinik has posted comments on this change.
Change subject: core:Clean unused method for clone and update image
..
Patch Set 11: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4
Allon Mureinik has posted comments on this change.
Change subject: core: version fix
..
Patch Set 1:
Perhaps we should add a log INFO message that the version string has more parts
that are silently ignored?
In this implement
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: UnPowerMock MultipleServicesMonitoringStrategyTest
..
core: UnPowerMock MultipleServicesMonitoringStrategyTest
Removed useless PowerMockRunner ann
Mike Kolesnik has posted comments on this change.
Change subject: core: UnPowerMock MultipleServicesMonitoringStrategyTest
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4637
To unsubscribe
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: UnPowerMock SessionDataContainerTest
..
core: UnPowerMock SessionDataContainerTest
Removed PowerMock dependency from SessionDataContainerTest by s
Mike Kolesnik has posted comments on this change.
Change subject: core: UnPowerMock SessionDataContainerTest
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4636
To unsubscribe, visit http:/
Allon Mureinik has posted comments on this change.
Change subject: core: UnPowerMock MultipleServicesMonitoringStrategyTest
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/4637
To unsubscribe, visit http://ge
Allon Mureinik has posted comments on this change.
Change subject: core: UnPowerMock SessionDataContainerTest
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/4636
To unsubscribe, visit http://gerrit.ovirt.org
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: UnPowerMock AutoRecoveryManagerTest
..
core: UnPowerMock AutoRecoveryManagerTest
Removed PowerMock dependency from AutoRecoveryManagerTest, by spy
Mike Kolesnik has posted comments on this change.
Change subject: core: UnPowerMock AutoRecoveryManagerTest
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4635
To unsubscribe, visit http://
Allon Mureinik has posted comments on this change.
Change subject: core: UnPowerMock AutoRecoveryManagerTest
..
Patch Set 3: Verified
rebase only, no change since last +2 review.
--
To view, visit http://gerrit.ovirt.org/4635
Allon Mureinik has posted comments on this change.
Change subject: core: [CpuPinning] cleanup VmStaticDAODbFacadeImpl
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/459
Allon Mureinik has posted comments on this change.
Change subject: core: [CpuPinning] db support for cpu_pinning
..
Patch Set 3: Looks good to me, but someone else must approve
Remember to check the upgrade script numbering bef
Allon Mureinik has posted comments on this change.
Change subject: core:Change CDA message to fit shareable disk
..
Patch Set 10:
You missed fixing the message in
backend/manager/modules/dal/src/main/resources/bundles/AppError
Allon Mureinik has posted comments on this change.
Change subject: core:Clean unused method for clone and update image
..
Patch Set 10: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4
Roy Golan has posted comments on this change.
Change subject: engine: Add support for IBM Tivoli Directory Server.
..
Patch Set 2: Looks good to me, approved
we still need to refactor LdapProviderType. Any hands in the air?
--
Allon Mureinik has posted comments on this change.
Change subject: core: Updating roles.is_inheritable properly
..
Patch Set 5: (2 inline comments)
File
backend/manager/modu
Roy Golan has posted comments on this change.
Change subject: core: Avoid aborting the current TX when destroying stateless VM
..
Patch Set 3:
corrections in the commit message
--
To view, visit http://gerrit.ovirt.org/4656
To
Roy Golan has posted comments on this change.
Change subject: core: Avoid aborting the current TX when restoring stateless VM
..
Patch Set 2: Verified
opening a new TX from the current works fine no table locking or other issue
Roy Golan has posted comments on this change.
Change subject: virt-engine: Support RHEVManager url
..
Patch Set 11: Verified
--
To view, visit http://gerrit.ovirt.org/1120
To unsubscribe, visit http://gerrit.ovirt.org/settings
Shireesh Anjal has posted comments on this change.
Change subject: engine: Fixed findbugs issue
..
Patch Set 2: Verified
rebased and verified.
--
To view, visit http://gerrit.ovirt.org/4678
To unsubscribe, visit http://gerrit.
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Fixed findbugs issue
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4678
To unsubscribe, visit http://gerrit.ovirt
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Add support for IBM Tivoli Directory Server.
..
Patch Set 1: (2 inline comments)
File
backend/mana
Sharad Mishra has posted comments on this change.
Change subject: engine: Add support for IBM Tivoli Directory Server.
..
Patch Set 1: (3 inline comments)
File
backend/manag
Moti Asayag has posted comments on this change.
Change subject: core: [CpuPinning] vdsm broker support
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/common
Moti Asayag has posted comments on this change.
Change subject: Fix warning for StorageHelperDirector
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/bll/src
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/928/
Build Number: 928
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 1,258
-
Changes S
Sharad Mishra has posted comments on this change.
Change subject: engine: Allow to iterate over remaining ldap servers on
NullPointerException.
..
Patch Set 2: Verified
To verify/test this patch, I had to jump some hoops. Sinc
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/889/
Build Number: 889
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 1,258
-
Changes
Saggi Mizrahi has uploaded a new change for review.
Change subject: Fix warning for StorageHelperDirector
..
Fix warning for StorageHelperDirector
Change-Id: Iab0652d83b6fffa28fd4bc37a84ab616647cf813
Signed-off-by: Saggi Mizrahi
Saggi Mizrahi has uploaded a new change for review.
Change subject: Move convertToStatusList to
ServerConnectionStatusReturnForXmlRpc
..
Move convertToStatusList to ServerConnectionStatusReturnForXmlRpc
Change-Id: I8b2202c76605
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/888/
Build Number: 888
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 1,257
-
Changes
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/927/
Build Number: 927
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 1,257
-
Changes S
Douglas Schilling Landgraf has posted comments on this change.
Change subject: virt-engine: Support RHEVManager url
..
Patch Set 11: Looks good to me, but someone else must approve
Roy, can you please tick the button verify in
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/887/
Build Number: 887
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 1,256
-
Changes
Vojtech Szocs has submitted this change and it was merged.
Change subject: userportal: Guide link doesn't work [ERROR 404] (#809738)
..
userportal: Guide link doesn't work [ERROR 404] (#809738)
https://bugzilla.redhat.com/80973
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Guide link doesn't work [ERROR 404] (#809738)
..
Patch Set 4: Verified; Looks good to me, approved
Good job on extracting common Configuration code!
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: DirectLun - DiskModel and Disks main-tab
..
webadmin: DirectLun - DiskModel and Disks main-tab
* Update DataCenters list in DiskModel.
* Display
Daniel Erez has posted comments on this change.
Change subject: webadmin: DirectLun - DiskModel and Disks main-tab
..
Patch Set 4: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/4667
To
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/926/
Build Number: 926
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 1,256
-
Changes S
Daniel Erez has posted comments on this change.
Change subject: webadmin: NetworkModel - remove redundant properties
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4672
To unsubscribe, visit http://gerrit.ov
Shireesh Anjal has uploaded a new change for review.
Change subject: engine: Removed curly braces from type definitions
..
engine: Removed curly braces from type definitions
${type} -> $type
as it was resulting in type not getti
Shireesh Anjal has uploaded a new change for review.
Change subject: restapi: Gluster Volume resource implementation
..
restapi: Gluster Volume resource implementation
Implementation of BackendGlusterVolumeResource
- get
- sta
Shireesh Anjal has uploaded a new change for review.
Change subject: engine: Removed unnecessary constructor argument
..
engine: Removed unnecessary constructor argument
in GlusterVolumeRebalanceParameters, and it's references i
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/886/
Build Number: 886
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 1,253,
Started by upstream project "ovirt_engine" b
Sharad Mishra has posted comments on this change.
Change subject: engine: Add support for IBM Tivoli Directory Server.
..
Patch Set 1: (4 inline comments)
File
backend/manag
Alona Kaplan has posted comments on this change.
Change subject: webadmin: NetworkModel - remove redundant properties
..
Patch Set 1: No score
--
To view, visit http://gerrit.ovirt.org/4672
To unsubscribe, visit http://gerrit.o
Michael Kublin has posted comments on this change.
Change subject: restapi: Support Floating Disks
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/common/src
Maor Lipchuk has posted comments on this change.
Change subject: core:Support remove of shareable disk.
..
Patch Set 9:
See patch set 7, it was answered there.
I try to move null to the removeImage, and send the patch, other co
Moti Asayag has posted comments on this change.
Change subject: core: Adding template vNIC: Add VmDevice (#822129)
..
Patch Set 1: Looks good to me, approved
(1 inline comment)
please fix typo
Michael Kublin has posted comments on this change.
Change subject: core:Support remove of shareable disk.
..
Patch Set 9: No score
waiting for fixing
--
To view, visit http://gerrit.ovirt.org/4490
To unsubscribe, visit http://
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/925/
Build Number: 925
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 1,254,
Started by upstream project "ovirt_engine" bui
Michael Kublin has posted comments on this change.
Change subject: core:Support remove of shareable disk.
..
Patch Set 9: Do not submit
I wrote my comments, not response just override?
--
To view, visit http://gerrit.ovirt.org
Omer Frenkel has posted comments on this change.
Change subject: core:Change CDA message to fit shareable disk
..
Patch Set 8: (1 inline comment)
File backend/manager/modules
Michael Kublin has posted comments on this change.
Change subject: core:Support remove of shareable disk.
..
Patch Set 8: I would prefer that you didn't submit this
(3 inline comments)
I don't see any reason for iteration of p
Omer Frenkel has posted comments on this change.
Change subject: core:Fix images handler CDA.
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4638
To unsubscribe, visit http://gerrit.ovirt.o
Kanagaraj M has posted comments on this change.
Change subject: engine,webadmin: oVirt Modes - Event Notifier changes
..
Patch Set 2:
Updated the header.
--
To view, visit http://gerrit.ovirt.org/4659
To unsubscribe, visit htt
Maor Lipchuk has posted comments on this change.
Change subject: core:Support remove of shareable disk.
..
Patch Set 7: (4 inline comments)
File
backend/manager/modules/bll/
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/885/
Build Number: 885
Build Status: Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 1,251,
Started by upstream project "ovirt_engine" build n
Alona Kaplan has posted comments on this change.
Change subject: webadmin: NetworkModel - remove redundant properties
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovi
Michael Kublin has posted comments on this change.
Change subject: core:Validate shareable disk which attached to VMs
..
Patch Set 6: (1 inline comment)
File
backend/manager
Michael Kublin has posted comments on this change.
Change subject: core:Validate shareable disk which attached to VMs
..
Patch Set 6: I would prefer that you didn't submit this
Response for my comment?
The following method is
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/924/
Build Number: 924
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 1,252,
Started by upstream project "ovirt_engine" bui
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: NetworkModel - remove redundant properties
..
webadmin: NetworkModel - remove redundant properties
* Removing unused properties: Address/Subnet/Gateway.
Michael Kublin has submitted this change and it was merged.
Change subject: core : Fixing a list parameters for direct Lun scenario
..
core : Fixing a list parameters for direct Lun scenario
Fixing a list of parameters at direc
Michael Kublin has posted comments on this change.
Change subject: core : Fixing a list parameters for direct Lun scenario
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4668
To u
Michael Kublin has posted comments on this change.
Change subject: core:Support remove of shareable disk.
..
Patch Set 7: (4 inline comments)
File
backend/manager/modules/bl
Maor Lipchuk has posted comments on this change.
Change subject: core:Support move of shareable disk
..
Patch Set 5: (1 inline comment)
File
backend/manager/modules/bll/src/
Daniel Erez has posted comments on this change.
Change subject: webadmin: edit & remove default quota
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4624
To unsubscribe, visit http://gerrit
Michael Kublin has posted comments on this change.
Change subject: core:Support move of shareable disk
..
Patch Set 5: (1 inline comment)
File
backend/manager/modules/bll/sr
Michael Kublin has posted comments on this change.
Change subject: core:Validate shareable disk which attached to VMs
..
Patch Set 5: I would prefer that you didn't submit this
The following method is not cover a case of update
Omer Frenkel has posted comments on this change.
Change subject: core:Update VmDao to return multiple Vms for disk.
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4491
To unsubscribe, visit
Michael Kublin has posted comments on this change.
Change subject: core:Support remove of shareable disk.
..
Patch Set 6: (1 inline comment)
File
backend/manager/modules/bll
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Guide link doesn't work [ERROR 404] (#809738)
..
Patch Set 2:
Rebased (no changes since last patch set).
--
To view, visit http://gerrit.ovirt.org/4
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: DirectLun - DiskModel and Disks main-tab
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4667
To unsubscribe, visi
Omer Frenkel has posted comments on this change.
Change subject: core:Use attachable disk for shareable
..
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4488
To unsubscribe, visit http://gerr
Michael Kublin has uploaded a new change for review.
Change subject: core : Fixing a release lock for case of MultipleActionRunner
..
core : Fixing a release lock for case of MultipleActionRunner
When a frontend is performing a
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/923/
Build Number: 923
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 1,251
-
Changes S
Maor Lipchuk has posted comments on this change.
Change subject: core:Use attachable disk for shareable
..
Patch Set 6:
Moved abstract disk command to next patch
--
To view, visit http://gerrit.ovirt.org/4488
To unsubscribe, v
Oved Ourfali has posted comments on this change.
Change subject: core: added HotPlugEnabled config option for 2.2 cluster level
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4670
To unsubscribe, visit http:
Oved Ourfali has submitted this change and it was merged.
Change subject: core: added HotPlugEnabled config option for 2.2 cluster level
..
core: added HotPlugEnabled config option for 2.2 cluster level
Previous patch added thi
Omer Frenkel has posted comments on this change.
Change subject: core: added HotPlugEnabled config option for 2.2 cluster level
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4670
To unsubs
Oved Ourfali has uploaded a new change for review.
Change subject: core: added HotPlugEnabled config option for 2.2 cluster level
..
core: added HotPlugEnabled config option for 2.2 cluster level
Previous patch added this option
Michael Kublin has posted comments on this change.
Change subject: core : Fixing a list parameters for direct Lun scenario
..
Patch Set 1: Verified; Looks good to me, approved
small change
--
To view, visit http://gerrit.ovirt
Michael Kublin has uploaded a new change for review.
Change subject: core : Fixing a list parameters for direct Lun scenario
..
core : Fixing a list parameters for direct Lun scenario
Fixing a list of parameters at direct lun sc
Maor Lipchuk has posted comments on this change.
Change subject: core:Refactor locking mechanism
..
Patch Set 2:
Fixed inMemoryLockManagerTest
--
To view, visit http://gerrit.ovirt.org/4663
To unsubscribe, visit http://gerrit.
Maor Lipchuk has abandoned this change.
Change subject: core:Support remove of shared disk.
..
Patch Set 1: Abandoned
Merged with other snapshot
--
To view, visit http://gerrit.ovirt.org/4494
To unsubscribe, visit http://gerri
Maor Lipchuk has abandoned this change.
Change subject: core:Remove use of container id for snapshot
..
Patch Set 1: Abandoned
Merged with other patch
--
To view, visit http://gerrit.ovirt.org/4489
To unsubscribe, visit http:/
Omer Frenkel has posted comments on this change.
Change subject: core:Use attachable disk for shareable
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4488
To unsubscribe, visit http://gerr
1 - 100 of 284 matches
Mail list logo
