Yair Zaslavsky has posted comments on this change.
Change subject: core: Added command ID field to async tasks
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4126
To un
Yair Zaslavsky has posted comments on this change.
Change subject: core: Added command ID field to async tasks
..
Patch Set 1:
Ignore my comment.
At http://gerrit.ovirt.org/#change,4125 you use parent command ID, if exists as
Yair Zaslavsky has posted comments on this change.
Change subject: core: Added command id to parameters
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4125
To unsubscribe, visit http://gerr
Yair Zaslavsky has posted comments on this change.
Change subject: core: Added command ID field to async tasks
..
Patch Set 1:
When I thought of this, I thought about sending the parent command ID , i.e -
when you look at asyn
Yair Zaslavsky has posted comments on this change.
Change subject: core: Set parameters task success only for command
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/412
Juan Hernandez has posted comments on this change.
Change subject: Run upgradeStoragePool on cluster compatibility change
..
Patch Set 10:
Forgot to suggest to use the commit template:
core: Run upgradeStoragePool ...
--
To v
Juan Hernandez has posted comments on this change.
Change subject: Add storage_format_type to Updatestorage_domain_static
..
Patch Set 7:
No whitespace noise now, nice!
Can you change the commit message to use the standard tem
Juan Hernandez has posted comments on this change.
Change subject: Run upgradeStoragePool on cluster compatibility change
..
Patch Set 10: Looks good to me, but someone else must approve
(1 inline comment)
Ori Liel has posted comments on this change.
Change subject: api: changes to support posix-fs
..
Patch Set 18:
pls rebase and send again
--
To view, visit http://gerrit.ovirt.org/3681
To unsubscribe, visit http://gerrit.ovirt.
Ori Liel has posted comments on this change.
Change subject: api: changes to support posix-fs
..
Patch Set 18: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3681
To unsubscribe, visit http://ger
Alex Lourie has posted comments on this change.
Change subject: packaging: Fixed size calculations and dirname parsing in
validation
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit
Alex Lourie has uploaded a new change for review.
Change subject: packaging: Fixed size calculations and dirname parsing in
validation
..
packaging: Fixed size calculations and dirname parsing in validation
* Changed the way
Mike Kolesnik has uploaded a new change for review.
Change subject: core: Set parameters task success only for command
..
core: Set parameters task success only for command
Set the task success only for the commands that actuall
Mike Kolesnik has uploaded a new change for review.
Change subject: core: Added command id to parameters
..
core: Added command id to parameters
Added command ID to parameters, so it will get persisted when calling
async tasks i
Mike Kolesnik has uploaded a new change for review.
Change subject: core: Added command ID field to async tasks
..
core: Added command ID field to async tasks
Added the command ID field to the entity and table in order to be
abl
Mike Kolesnik has uploaded a new change for review.
Change subject: core: Change RemoveSnapshot end command behavior
..
core: Change RemoveSnapshot end command behavior
Change that this command will not automatically fail all ch
Juan Hernandez has posted comments on this change.
Change subject: core: Event when power down fails
..
Patch Set 2: Verified
It works correctly and doesn't break anything.
--
To view, visit http://gerrit.ovirt.org/870
To unsu
Michael Kublin has posted comments on this change.
Change subject: core: Adding Configurable Delay Job
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3815
To unsubscribe, visit ht
Muli Salem has uploaded a new change for review.
Change subject: tools: Add action reload to engine-config
..
tools: Add action reload to engine-config
This patch adds the "reload" action to the engine-config tool.
The new actio
Omer Frenkel has posted comments on this change.
Change subject: core: Add console reconnect
..
Patch Set 15: Looks good to me, approved
please verify it works well and nothing else breaks, then i'll merge it
--
To view, visit
Tal Nisan has submitted this change and it was merged.
Change subject: frontend: Converter comments removal
..
frontend: Converter comments removal
Signed-off-by: Tal Nisan
Change-Id: I383fba845e43672e588964ce23b8e42597031cb4
Tal Nisan has posted comments on this change.
Change subject: frontend: Converter comments removal
..
Patch Set 2: Verified; Looks good to me, approved
No change, just rebase
--
To view, visit http://gerrit.ovirt.org/4113
To u
Moti Asayag has uploaded a new change for review.
Change subject: restapi: Change test code to bypass javac7 bug
..
restapi: Change test code to bypass javac7 bug
The patch modifies the way reference narrowing is handled due to
Omer Frenkel has posted comments on this change.
Change subject: core: license usage cleanup
..
Patch Set 1:
i thought create_tables.sql shouldn't be changed. are we sure there is no
upgrade script that refers to this table? i
Gilad Chaplik has posted comments on this change.
Change subject: frontend: Converter comments removal
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4113
To unsubscribe, visit http://gerri
Oved Ourfali has posted comments on this change.
Change subject: wip - engine: adding new support for native USB
..
Patch Set 1:
Also, this patch doesn't contain the device changes yet, as the API with VDSM
wasn't closed yet.
Oved Ourfali has posted comments on this change.
Change subject: wip - engine: adding new support for native USB
..
Patch Set 1:
1. don't submit yet, it is work in progress.
2. I didn't split it into patches, as the rename in t
Oved Ourfali has uploaded a new change for review.
Change subject: wip - backend: adding config entry for number of USB slots
..
wip - backend: adding config entry for number of USB slots
This patch adds NumberOfUSBSlots config
Oved Ourfali has uploaded a new change for review.
Change subject: wip - engine: adding new support for native USB
..
wip - engine: adding new support for native USB
This patch adds support for a new type of USB, native USB.
Cha
Yaniv Dary has uploaded a new change for review.
Change subject: history: added vm_device dwh view
..
history: added vm_device dwh view
Change-Id: I0b2602041570a3b4b5dcd1e1e486327597968fac
Signed-off-by: Yaniv Dary
---
M backen
Yaniv Dary has uploaded a new change for review.
Change subject: etl: added vm_device history table.
..
etl: added vm_device history table.
Change-Id: I68014b1729db7c7bbaa9572eaa04becdfa2239dc
Signed-off-by: Yaniv Dary
---
M
d
Tomas Jelinek has posted comments on this change.
Change subject: core: some NFS mount options cleanup and test
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4091
To u
Michael Kublin has posted comments on this change.
Change subject: core : Adding option to add direct lun disk
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4114
To unsubscribe,
Michael Kublin has submitted this change and it was merged.
Change subject: core : Adding option to add direct lun disk
..
core : Adding option to add direct lun disk
The following patch will add option to add a disk which is d
Yair Zaslavsky has posted comments on this change.
Change subject: core: [kpm] AbstractSysprepQueryTest rewrite
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3962
To unsubscribe, visit htt
Michael Kublin has posted comments on this change.
Change subject: core : Adding option to add direct lun disk
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4114
To unsubscribe, visit http://gerrit.ovirt.or
Yair Zaslavsky has posted comments on this change.
Change subject: core : Adding option to add direct lun disk
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4114
To unsubscribe, visit http
Ori Liel has posted comments on this change.
Change subject: restapi: Poll Job-Id on Restore-Snapshot
..
Patch Set 1:
Do not submit, I want pre-integration testing first
--
To view, visit http://gerrit.ovirt.org/4117
To unsubs
Ori Liel has uploaded a new change for review.
Change subject: restapi: Poll Job-Id on Restore-Snapshot
..
restapi: Poll Job-Id on Restore-Snapshot
Restoring a snapshot involves two Backend calls. The second call
should only be
Ofer Schreiber has posted comments on this change.
Change subject: packaging: Fixed permissions for local storage in AIO (#817360)
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/4033
To unsubscribe, visit ht
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: Fixed permissions for local storage in AIO (#817360)
..
packaging: Fixed permissions for local storage in AIO (#817360)
https://bugzilla.red
Ofer Schreiber has posted comments on this change.
Change subject: packaging: Fixed permissions for local storage in AIO (#817360)
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4033
To uns
Tomas Jelinek has uploaded a new change for review.
Change subject: userportal: cloning VM creates VM with wrong permissions
(#809778)
..
userportal: cloning VM creates VM with wrong permissions (#809778)
https://bugzilla.redha
Eli Mesika has uploaded a new change for review.
Change subject: core: license usage cleanup
..
core: license usage cleanup
Completes the work done in http://gerrit.ovirt.org/#change,4056
Removes unused table / sp from the datta
Omer Frenkel has posted comments on this change.
Change subject: core: Cleanup IsoDomainListSyncronizer
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4077
To unsubscribe, visit http://gerr
Omer Frenkel has posted comments on this change.
Change subject: core: Event when power down fails
..
Patch Set 2: Looks good to me, approved
please verify it works and nothing breaks, then i'll merge it.
--
To view, visit htt
Michael Kublin has uploaded a new change for review.
Change subject: core : Adding option to add direct lun disk
..
core : Adding option to add direct lun disk
The following patch will add option to add a disk which is direct lu
Tal Nisan has posted comments on this change.
Change subject: core: Cleanup 'public abstract' declarations in interfaces
..
Patch Set 2: Verified; Looks good to me, approved
No change, just rebase
--
To view, visit http://gerr
Tal Nisan has submitted this change and it was merged.
Change subject: core: Cleanup 'public abstract' declarations in interfaces
..
core: Cleanup 'public abstract' declarations in interfaces
Removing the 'public abstract' decl
Yair Zaslavsky has posted comments on this change.
Change subject: engine: getUpServer method moved to new class ClusterUtils
..
Patch Set 3: I would prefer that you didn't submit this
Please do not use PowerMock, we're trying
Omer Frenkel has posted comments on this change.
Change subject: core: Cleanup 'public abstract' declarations in interfaces
..
Patch Set 1: Looks good to me, approved
well i dont mind
--
To view, visit http://gerrit.ovirt.org/
Yair Zaslavsky has posted comments on this change.
Change subject: engine : Gluster volume options help command
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Please add a test to the new query (
Tal Nisan has posted comments on this change.
Change subject: core: Cleanup 'public abstract' declarations in interfaces
..
Patch Set 1:
1. Cause we have an open bug on it
https://bugzilla.redhat.com/show_bug.cgi?id=741245
2.
Omer Frenkel has posted comments on this change.
Change subject: core: Cleanup 'public abstract' declarations in interfaces
..
Patch Set 1:
why do we care its there?
--
To view, visit http://gerrit.ovirt.org/4111
To unsubscrib
Tal Nisan has submitted this change and it was merged.
Change subject: core: JAXB annotations cleanup for remaining files
..
core: JAXB annotations cleanup for remaining files
Change-Id: I4e55e9fe9f8c3154503b08e79c1f82bfd3dcfd2
Tal Nisan has posted comments on this change.
Change subject: core: JAXB annotations cleanup for remaining files
..
Patch Set 3: Verified; Looks good to me, approved
No change, just rebase
--
To view, visit http://gerrit.ovirt
Omer Frenkel has posted comments on this change.
Change subject: core: JAXB annotations cleanup for remaining files
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4103
To unsubscribe, visit
Juan Hernandez has posted comments on this change.
Change subject: core: Update to Quartz 2.1
..
Patch Set 4:
Rebased.
--
To view, visit http://gerrit.ovirt.org/3250
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerr
Juan Hernandez has posted comments on this change.
Change subject: core: Update to Quartz 2.1
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/3250
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerri
Eoghan Glynn has posted comments on this change.
Change subject: sdk: Add session support
..
Patch Set 2: Looks good to me, but someone else must approve
Thanks for the quick turnaround on the review feedback.
Cheers,
Eoghan
Juan Hernandez has posted comments on this change.
Change subject: core: Remove pubkey2ssh
..
Patch Set 13: Verified
Rebased.
--
To view, visit http://gerrit.ovirt.org/3138
To unsubscribe, visit http://gerrit.ovirt.org/setting
Tal Nisan has uploaded a new change for review.
Change subject: frontend: Converter comments removal
..
frontend: Converter comments removal
Signed-off-by: Tal Nisan
Change-Id: I383fba845e43672e588964ce23b8e42597031cb4
---
M
f
Dhandapani Gopal has uploaded a new change for review.
Change subject: engine : Gluster volume options help command
..
engine : Gluster volume options help command
Including following related to the command for "Gluster volume o
Tal Nisan has submitted this change and it was merged.
Change subject: frontend: Linq comment removal for uicommononweb module
..
frontend: Linq comment removal for uicommononweb module
Signed-off-by: Tal Nisan
Change-Id: I18b
Tal Nisan has posted comments on this change.
Change subject: frontend: Linq comment removal for uicommononweb module
..
Patch Set 3: Verified; Looks good to me, approved
No change, just rebase
--
To view, visit http://gerrit.
Juan Hernandez has posted comments on this change.
Change subject: core: Remove pubkey2ssh
..
Patch Set 12:
Rebased.
--
To view, visit http://gerrit.ovirt.org/3138
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit
Gilad Chaplik has posted comments on this change.
Change subject: frontend: Linq comment removal for uicommononweb module (784511)
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3843
To uns
Tal Nisan has uploaded a new change for review.
Change subject: core: Cleanup 'public abstract' declarations in interfaces
..
core: Cleanup 'public abstract' declarations in interfaces
Removing the 'public abstract' declarations
Juan Hernandez has posted comments on this change.
Change subject: core: Event when power down fails
..
Patch Set 2:
Rebased. No other changes from the last review.
--
To view, visit http://gerrit.ovirt.org/870
To unsubscribe,
BUILD SUCCESS
Build URL: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/761/
Project: ovirt_engine_dao_unit_tests
Date of build: Thu, 03 May 2012 05:45:43 -0400
Build duration: 31 min
CHANGE SET
Revision e98e3b57630711ec8bf264a0f6289f8cdf03603e by masayag: (core: Fix dal
broken test du
Tomas Jelinek has uploaded a new change for review.
Change subject: userportal, webadmin: NPE when server call failed
..
userportal, webadmin: NPE when server call failed
When the call to server fails for example due to insuffic
Alona Kaplan has posted comments on this change.
Change subject: webadmin: default values to appErrors
..
Patch Set 1: No score; No score
I think you should remove the AppErrors.properties of the webadmin.
And remove the keys t
BUILD FAILURE
Build URL: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/760/
Project: ovirt_engine_dao_unit_tests
Date of build: Thu, 03 May 2012 05:18:14 -0400
Build duration: 27 min
CHANGE SET
Revision 5909c3cf0428d8ac66597b6bc19d61cac0e37037 by masayag: (core: Moving
JobRepository t
Moti Asayag has submitted this change and it was merged.
Change subject: core: Fix dal broken test due to reducing column size
..
core: Fix dal broken test due to reducing column size
The test was broken by commit 880077dea59c9
Moti Asayag has posted comments on this change.
Change subject: core: Fix dal broken test due to reducing column size
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4102
To unsubs
Raksha Rao has uploaded a new change for review.
Change subject: webadmin: Support for Remove Volume
..
webadmin: Support for Remove Volume
Note: Volume has to be stopped before removing it.
Change-Id: I02eab9ad750837ca552e79bc
BUILD FAILURE
Build URL: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/759/
Project: ovirt_engine_dao_unit_tests
Date of build: Thu, 03 May 2012 04:31:09 -0400
Build duration: 47 min
CHANGE SET
Revision 0176243c77cfd06f46521ddeed0da4004d251ce6 by msalem: (core: Reloadable
Config Value
Michael Kublin has posted comments on this change.
Change subject: core: Fix dal broken test due to reducing column size
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4102
To uns
Eli Mesika has uploaded a new change for review.
Change subject: core: Adding disk changes boot_order
..
core: Adding disk changes boot_order
This patch resolve a bug when adding disk changes the boot order.
VM images are update
Tal Nisan has uploaded a new change for review.
Change subject: core: JAXB annotations cleanup for remaining files
..
core: JAXB annotations cleanup for remaining files
Change-Id: I4e55e9fe9f8c3154503b08e79c1f82bfd3dcfd22
Signed
Moti Asayag has uploaded a new change for review.
Change subject: core: Fix dal broken test due to reducing column size
..
core: Fix dal broken test due to reducing column size
The test was broken by commit 880077dea59c9ba4da0e6
Yair Zaslavsky has posted comments on this change.
Change subject: core: send mount_options only if 3.1
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3802
To unsubscribe, visit http://gerr
Moti Asayag has submitted this change and it was merged.
Change subject: core: Moving JobRepository to bll project
..
core: Moving JobRepository to bll project
The bll project is more appropriate for the JobRepository class, si
Moti Asayag has posted comments on this change.
Change subject: core: Moving JobRepository to bll project
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4096
To unsubscribe, visit
Yair Zaslavsky has posted comments on this change.
Change subject: core: Moving JobRepository to bll project
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4096
To unsubscribe, visit http:/
Eli Mesika has posted comments on this change.
Change subject: etl: separated common etl function to standalone script
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/38
Eli Mesika has posted comments on this change.
Change subject: core: Cleanup repo_files_meta_data_sp.sql
..
Patch Set 8: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4057
To unsubscribe, visit
BUILD FAILURE
Build URL: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/758/
Project: ovirt_engine_dao_unit_tests
Date of build: Thu, 03 May 2012 03:50:16 -0400
Build duration: 40 min
CHANGE SET
Revision eb3493c51402e5e425f86fa4b893f8f425e804d2 by mkublin: (core : Fixing
broken unit te
BUILD SUCCESS
Build URL: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/734/
Project: ovirt_engine_unit_tests
Date of build: Thu, 03 May 2012 03:45:12 -0400
Build duration: 33 min
CHANGE SET
Revision eb3493c51402e5e425f86fa4b893f8f425e804d2 by mkublin: (core : Fixing
broken unit tests)
c
Alex Lourie has posted comments on this change.
Change subject: packaging: Fixed creating app user on postgresql 8.4
..
Patch Set 5: Verified; Looks good to me, but someone else must approve
Acked by emesika
--
To view, visit
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: Fixed creating app user on postgresql 8.4
..
packaging: Fixed creating app user on postgresql 8.4
* Fixed creating app user on postgresql 8.
Ofer Schreiber has posted comments on this change.
Change subject: packaging: Fixed creating app user on postgresql 8.4
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4058
To unsubscribe, v
Omer Frenkel has posted comments on this change.
Change subject: new feature: Vm Payload
..
Patch Set 15: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3243
To unsubscribe, visit http://gerrit.ovirt.org/s
Ofer Schreiber has posted comments on this change.
Change subject: packaging: Fixed creating app user on postgresql 8.4
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4058
To unsubscribe, v
Muli Salem has submitted this change and it was merged.
Change subject: core: Reloadable Config Values (1)
..
core: Reloadable Config Values (1)
This patch makes sure the first batch of config values are reloaded
from the cache
Muli Salem has posted comments on this change.
Change subject: core: Reloadable Config Values (1)
..
Patch Set 4: Verified; Looks good to me, approved
Rebase.
--
To view, visit http://gerrit.ovirt.org/3039
To unsubscribe, visi
Selvasundaram has posted comments on this change.
Change subject: engine: Delete Gluster Volume
..
Patch Set 8:
Removed entries from user portal AppErrors.properties and VdsmErrors.properties
files.
--
To view, visit http://g
Muli Salem has posted comments on this change.
Change subject: core: Reloadable Config Values (1)
..
Patch Set 3: Verified; Looks good to me, approved
Rebase.
--
To view, visit http://gerrit.ovirt.org/3039
To unsubscribe, visi
BUILD FAILURE
Build URL: http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/757/
Project: ovirt_engine_dao_unit_tests
Date of build: Thu, 03 May 2012 02:58:02 -0400
Build duration: 52 min
CHANGE SET
Revision a47d0b1eee5883753f355df3d9780f87b93a0cc9 by mkolesni: (core: Add
snapshot broken s
Omer Frenkel has posted comments on this change.
Change subject: core: Removed unused license query types.
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4056
To unsubscribe, visit http://g
1 - 100 of 108 matches
Mail list logo
