Daniel Erez has posted comments on this change.
Change subject: webadmin: adding externalize check to the frontend checkstyle
..
Patch Set 11:
Indeed, since not relevant to this patch, including Constants.java and
Messages.jav
Shireesh Anjal has posted comments on this change.
Change subject: engine: Delete Gluster Volume
..
Patch Set 3: Looks good to me, but someone else must approve
(2 inline comments)
.
Omer Frenkel has posted comments on this change.
Change subject: engine: Delete Gluster Volume
..
Patch Set 3: (2 inline comments)
looks ok, some minor comments
File
backen
Yair Zaslavsky has posted comments on this change.
Change subject: core: Change code to use ImageDao
..
Patch Set 3: (5 inline comments)
Really minor comments
File
backend/
Yair Zaslavsky has posted comments on this change.
Change subject: core: Added ImageDao & tests
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3834
To unsubscribe, visit http://gerrit.ovirt
Yair Zaslavsky has posted comments on this change.
Change subject: core: Add Image business entity
..
Patch Set 3: Looks good to me, but someone else must approve
Looks Good.
Added Derez for the xml part.
--
To view, visit htt
Yair Zaslavsky has posted comments on this change.
Change subject: core: Renamed images_sp.sql to disk_images_sp.sql
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3832
To unsubscribe, visi
Yair Zaslavsky has posted comments on this change.
Change subject: engine: expose compatibility version/qemu machine type via
engine-config tool
..
Patch Set 1: Looks good to me, but someone else must approve
Looks Good to me,
Yair Zaslavsky has posted comments on this change.
Change subject: core: Failed to run VM with boot order of CD and DISK
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Although small change - thi
Selvasundaram has posted comments on this change.
Change subject: engine: Delete Gluster Volume
..
Patch Set 3:
Reverted the "delete gluster volume" changes from insert_predefined_roles.sql,
Enums.java and Enums.properties.
I
Eli Mesika has uploaded a new change for review.
Change subject: core: Failed to run VM with boot order of CD and DISK
..
core: Failed to run VM with boot order of CD and DISK
Adding a new property isRunOnceVm to VM BE that is s
Sharad Mishra has uploaded a new change for review.
Change subject: engine: expose compatibility version/qemu machine type via
engine-config tool
..
engine: expose compatibility version/qemu machine type via engine-config tool
ovirt_engine_unit_tests - Build # 680 - Fixed:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/680/console to view the
results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinf
Daniel Erez has posted comments on this change.
Change subject: core: Introducing a new constant to version class
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3831
To
Juan Hernandez has posted comments on this change.
Change subject: Run upgradeStoragePool on cluster compatibility change
..
Patch Set 9: (9 inline comments)
See my comments inside. Most of them are not very relevant.
ovirt_engine_unit_tests - Build # 679 - Still Unstable:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/679/console to view the
results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailma
Moti Asayag has submitted this change and it was merged.
Change subject: core: Fix AttachNetworkToVdsGroupCommandTest.networkExist
..
core: Fix AttachNetworkToVdsGroupCommandTest.networkExist
The test was broken due to commit I
Moti Asayag has posted comments on this change.
Change subject: core: Fix AttachNetworkToVdsGroupCommandTest.networkExist
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3886
To un
Allon Mureinik has posted comments on this change.
Change subject: core: Fix AttachNetworkToVdsGroupCommandTest.networkExist
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
Allon Mureinik has posted comments on this change.
Change subject: core: Fix AttachNetworkToVdsGroupCommandTest.networkExist
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
Moti Asayag has uploaded a new change for review.
Change subject: core: Fix AttachNetworkToVdsGroupCommandTest.networkExist
..
core: Fix AttachNetworkToVdsGroupCommandTest.networkExist
The test was broken due to commit I55f33772
Moti Asayag has submitted this change and it was merged.
Change subject: core: fix GetUserVmsByUserIdAndGroupsQueryTest
..
core: fix GetUserVmsByUserIdAndGroupsQueryTest
The test was broken due to a refactoring in the DiskImage
Moti Asayag has posted comments on this change.
Change subject: core: fix GetUserVmsByUserIdAndGroupsQueryTest
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3884
To unsubscribe,
Allon Mureinik has posted comments on this change.
Change subject: core: fix GetUserVmsByUserIdAndGroupsQueryTest
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/3884
To unsubscribe, visit http://gerrit.ovirt
Allon Mureinik has uploaded a new change for review.
Change subject: core: fix GetUserVmsByUserIdAndGroupsQueryTest
..
core: fix GetUserVmsByUserIdAndGroupsQueryTest
The test was broken due to a refactoring in the DiskImage hier
Juan Hernandez has posted comments on this change.
Change subject: Add missign storage_format_type arg to
Updatestorage_domain_static
..
Patch Set 6: (2 inline comments)
This change looks ok, but there is a lot of white space
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: adding externalize check to the frontend checkstyle
..
Patch Set 11:
On a second thought, you can push it right a way as a separate patch, and merge
i
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: adding externalize check to the frontend checkstyle
..
Patch Set 11:
tried to add the entire uicompat, doesn't worked for me, so I added what we
need.
Shireesh Anjal has posted comments on this change.
Change subject: restapi: Resource interfaces for Gluster Volume(s)
..
Patch Set 4:
Added new collection and resource interfaces for the bricks and options.
--
To view, visit h
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Consolidate Cluster/DC network dialogs
..
webadmin: Consolidate Cluster/DC network dialogs
0. UiCommon change: "MTU" and "VM network" fields/acc
Daniel Erez has posted comments on this change.
Change subject: webadmin: Consolidate Cluster/DC network dialogs
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3846
To unsubscribe
Shireesh Anjal has posted comments on this change.
Change subject: restapi: Resource interfaces for Gluster Volume(s)
..
Patch Set 3: (2 inline comments)
New patch-set to follow, with enhanced modelling.
..
Allon Mureinik has posted comments on this change.
Change subject: core: Made GetAllFloppyImagesList a user query
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/3882
To unsubscribe, visit http://gerrit.ovirt
Allon Mureinik has posted comments on this change.
Change subject: core: Made GetAllIsoImagesList a user query
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/3881
To unsubscribe, visit http://gerrit.ovirt.or
Allon Mureinik has posted comments on this change.
Change subject: core: Introducing AbstractGetAllImagesListQuery
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/3880
To unsubscribe, visit http://gerrit.ovir
Allon Mureinik has posted comments on this change.
Change subject: core: Made GetCACertificateQuery a user query
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/3874
To unsubscribe, visit http://gerrit.ovirt.
Allon Mureinik has posted comments on this change.
Change subject: core: Made GetDefaultTimeZoneQuery a user query
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/3873
To unsubscribe, visit http://gerrit.ovir
Allon Mureinik has posted comments on this change.
Change subject: core: Extracted AbstractSysprepQueryTest
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/3872
To unsubscribe, visit http://gerrit.ovirt.org/s
Allon Mureinik has posted comments on this change.
Change subject: core: Clean up imports on GetDefaultTimeZoneQuery
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/3871
To unsubscribe, visit http://gerrit.ov
Allon Mureinik has posted comments on this change.
Change subject: core: Made GetTimeZonesQuery a user query
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/3870
To unsubscribe, visit http://gerrit.ovirt.org/
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetTimeZonesQuery
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/3869
To unsubscribe, visit http://gerrit.ovirt.org/settings
Allon Mureinik has uploaded a new change for review.
Change subject: core: Introducing AbstractGetAllImagesListQuery
..
core: Introducing AbstractGetAllImagesListQuery
Extracted a common base class for GetAllFloppyImagesListQuer
ovirt_engine_unit_tests - Build # 678 - Still Unstable:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/678/console to view the
results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailma
Allon Mureinik has uploaded a new change for review.
Change subject: core: Made GetAllFloppyImagesList a user query
..
core: Made GetAllFloppyImagesList a user query
The query was flagged as user query so it could be used in the
Allon Mureinik has uploaded a new change for review.
Change subject: core: Made GetAllIsoImagesList a user query
..
core: Made GetAllIsoImagesList a user query
The query was flagged as user query so it could be used in the User
Juan Hernandez has posted comments on this change.
Change subject: packaging: Move ROOT.war to the EAR
..
Patch Set 4:
Fixed the build issue detected by Ofer in patch set 1.
--
To view, visit http://gerrit.ovirt.org/3782
To un
Maor Lipchuk has posted comments on this change.
Change subject: core,webadmin: Remove disks list from snapshots
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/3855
To unsubscribe, visit http://gerrit.ovirt.
Daniel Erez has posted comments on this change.
Change subject: core,webadmin: Remove disks list from snapshots
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3855
To u
Roy Golan has submitted this change and it was merged.
Change subject: core: add LDAPProviderType that was lost in the merge
..
core: add LDAPProviderType that was lost in the merge
Change-Id: I52cd7fb917bc73334fd7c0181ba8329a9
Roy Golan has posted comments on this change.
Change subject: core: add LDAPProviderType that was lost in the merge
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3875
To unsubscr
Michael Pasternak has posted comments on this change.
Change subject: Revert "Fix '---id' handling"
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3879
To unsubscribe, visit http:
Michael Pasternak has submitted this change and it was merged.
Change subject: Revert "Fix '---id' handling"
..
Revert "Fix '---id' handling"
This reverts commit fc39fd11f4acb349144efeb52e0296b9dc6505be.
reverting this commit
Michael Pasternak has uploaded a new change for review.
Change subject: Revert "Fix '---id' handling"
..
Revert "Fix '---id' handling"
This reverts commit fc39fd11f4acb349144efeb52e0296b9dc6505be.
reverting this commit since it
Oved Ourfali has posted comments on this change.
Change subject: core: add LDAPProviderType that was lost in the merge
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3875
To unsubscribe, vi
Ofer Schreiber has submitted this change and it was merged.
Change subject: installer: reverting Requires vds_bootstrap change
..
installer: reverting Requires vds_bootstrap change
Previous patch adds a requirement that the vds
Ofer Schreiber has posted comments on this change.
Change subject: installer: reverting Requires vds_bootstrap change
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3876
To unsubs
Roy Golan has posted comments on this change.
Change subject: core: add LDAPProviderType that was lost in the merge
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/3875
To unsubscribe, visit http://gerrit.ovi
Tomas Jelinek has uploaded a new change for review.
Change subject: userportal: VM side tab->Edit (#815412)
..
userportal: VM side tab->Edit (#815412)
part of:
https://bugzilla.redhat.com/815412
- High availability was not visi
Tomas Jelinek has uploaded a new change for review.
Change subject: userportal: VM->Run Once: don't show Linux Boot Optionas
(#815412)
..
userportal: VM->Run Once: don't show Linux Boot Optionas (#815412)
part of
https://bugzil
Omer Frenkel has posted comments on this change.
Change subject: core : Draft for using a direct lun at run vm scenario
..
Patch Set 1: (2 inline comments)
File
backend/mana
Oved Ourfali has uploaded a new change for review.
Change subject: installer: reverting Requires vds_bootstrap change
..
installer: reverting Requires vds_bootstrap change
Previous patch adds a requirement that the vds_bootstrap
Roy Golan has uploaded a new change for review.
Change subject: core: add LDAPProviderType that was lost in the merge
..
core: add LDAPProviderType that was lost in the merge
Change-Id: I52cd7fb917bc73334fd7c0181ba8329a939ff36d
ovirt_engine_unit_tests - Build # 677 - Still Unstable:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/677/console to view the
results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailma
Daniel Erez has posted comments on this change.
Change subject: webadmin: support versions for vm properties
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3652
To unsu
Mike Kolesnik has posted comments on this change.
Change subject: core : Draft for using a direct lun at run vm scenario
..
Patch Set 1: (2 inline comments)
File
backend/man
Michael Kublin has posted comments on this change.
Change subject: core : Draft for using a direct lun at run vm scenario
..
Patch Set 1: (5 inline comments)
File
backend/ma
Mike Kolesnik has posted comments on this change.
Change subject: core: Change code to use ImageDao
..
Patch Set 3: Verified
Returned last_modified_dateField to DiskImage, it will be removed in a separate
patch but for now it
Mike Kolesnik has posted comments on this change.
Change subject: core: Added ImageDao & tests
..
Patch Set 3: Verified
Rebased
--
To view, visit http://gerrit.ovirt.org/3834
To unsubscribe, visit http://gerrit.ovirt.org/setti
Mike Kolesnik has posted comments on this change.
Change subject: core: Add Image business entity
..
Patch Set 3: Verified
Match hashCode & equals methods to the fields that are used in DiskImage.
--
To view, visit http://gerr
Mike Kolesnik has posted comments on this change.
Change subject: core: Renamed images_sp.sql to disk_images_sp.sql
..
Patch Set 3: Verified
Rebased
--
To view, visit http://gerrit.ovirt.org/3832
To unsubscribe, visit http://g
Moti Asayag has submitted this change and it was merged.
Change subject: core: Retrieve job with steps by correlation ID
..
core: Retrieve job with steps by correlation ID
The patch modifies the retrieved Job entities by a corr
Moti Asayag has posted comments on this change.
Change subject: core: Retrieve job with steps by correlation ID
..
Patch Set 6: Verified; Looks good to me, approved
separate patch will be sent to address mkolesnik further comme
Juan Hernandez has posted comments on this change.
Change subject: core: Remove pubkey2ssh
..
Patch Set 10:
Fixed the issues that Ofer found with previous patch set.
--
To view, visit http://gerrit.ovirt.org/3138
To unsubscrib
Allon Mureinik has posted comments on this change.
Change subject: core: Made GetCACertificateQuery a user query
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/3874
To unsubscribe, visit http://gerrit.ovirt.
Mike Kolesnik has posted comments on this change.
Change subject: core : Draft for using a direct lun at run vm scenario
..
Patch Set 1: (7 inline comments)
File
backend/man
Allon Mureinik has posted comments on this change.
Change subject: core: Made GetDefaultTimeZoneQuery a user query
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/3873
To unsubscribe, visit http://gerrit.ovir
Allon Mureinik has posted comments on this change.
Change subject: core: Extracted AbstractSysprepQueryTest
..
Patch Set 2: Verified
fixed TWS.
--
To view, visit http://gerrit.ovirt.org/3872
To unsubscribe, visit http://gerrit
Roy Golan has submitted this change and it was merged.
Change subject: core: attach network to cluster supports update as well
..
core: attach network to cluster supports update as well
we now support updating an already attach
Roy Golan has posted comments on this change.
Change subject: core: attach network to cluster supports update as well
..
Patch Set 10: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3679
To unsub
Moti Asayag has posted comments on this change.
Change subject: core: attach network to cluster supports update as well
..
Patch Set 9: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3679
To unsu
Roy Golan has posted comments on this change.
Change subject: core: attach network to cluster supports update as well
..
Patch Set 9:
restyle SP
--
To view, visit http://gerrit.ovirt.org/3679
To unsubscribe, visit http://gerri
Allon Mureinik has posted comments on this change.
Change subject: core: Made GetCACertificateQuery a user query
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/3874
To unsubscribe, visit http://gerrit.ovirt.
Allon Mureinik has posted comments on this change.
Change subject: core: Made GetDefaultTimeZoneQuery a user query
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/3873
To unsubscribe, visit http://gerrit.ovir
Allon Mureinik has posted comments on this change.
Change subject: core: Extracted AbstractSysprepQueryTest
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/3872
To unsubscribe, visit http://gerrit.ovirt.org/s
Allon Mureinik has posted comments on this change.
Change subject: core: Clean up imports on GetDefaultTimeZoneQuery
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/3871
To unsubscribe, visit http://gerrit.ov
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: changing the VdsInstaller option of virt installation
..
engine: changing the VdsInstaller option of virt installation
Previous patch caused back
Allon Mureinik has posted comments on this change.
Change subject: core: Made GetTimeZonesQuery a user query
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/3870
To unsubscribe, visit http://gerrit.ovirt.org/
Oved Ourfali has posted comments on this change.
Change subject: engine: changing the VdsInstaller option of virt installation
..
Patch Set 3: Verified; Looks good to me, approved
Based on previous ACKs.
Fixed the typo.
--
To
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetTimeZonesQuery
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/3869
To unsubscribe, visit http://gerrit.ovirt.org/settings
Allon Mureinik has uploaded a new change for review.
Change subject: core: Made GetCACertificateQuery a user query
..
core: Made GetCACertificateQuery a user query
The query was flagged as user query so it could be used in the U
Allon Mureinik has uploaded a new change for review.
Change subject: core: Clean up imports on GetDefaultTimeZoneQuery
..
core: Clean up imports on GetDefaultTimeZoneQuery
Replaced * imports with FQCNs.
Change-Id: I23ab2fe33408
Allon Mureinik has uploaded a new change for review.
Change subject: core: Extracted AbstractSysprepQueryTest
..
core: Extracted AbstractSysprepQueryTest
Extracted a base class to handle common mocking for tests of queries
based
Allon Mureinik has uploaded a new change for review.
Change subject: core: Made GetDefaultTimeZoneQuery a user query
..
core: Made GetDefaultTimeZoneQuery a user query
The query was flagged as user query so it could be used in t
Allon Mureinik has uploaded a new change for review.
Change subject: core: Cleanup GetTimeZonesQuery
..
core: Cleanup GetTimeZonesQuery
General java cleanup - added generics, removed unused private methods.
In addition, a test c
Allon Mureinik has uploaded a new change for review.
Change subject: core: Made GetTimeZonesQuery a user query
..
core: Made GetTimeZonesQuery a user query
The query was flagged as user query so it could be used in the User
Port
Roy Golan has posted comments on this change.
Change subject: engine: changing the VdsInstaller option of virt installation
..
Patch Set 1: Looks good to me, approved
(1 inline comment)
minor typo
Roy Golan has posted comments on this change.
Change subject: engine: changing the VdsInstaller option of virt installation
..
Patch Set 1:
verified?
--
To view, visit http://gerrit.ovirt.org/3856
To unsubscribe, visit http://
Einav Cohen has posted comments on this change.
Change subject: webadmin: Consolidate Cluster/DC network dialogs
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/3846
To unsubscribe, visit http://gerrit.ovirt.
Roy Golan has posted comments on this change.
Change subject: core: attach network to cluster supports update as well
..
Patch Set 8:
add IF FOUND to to SP
styling of network_sp
--
To view, visit http://gerrit.ovirt.org/3679
T
ovirt_engine_unit_tests - Build # 676 - Unstable:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/676/console to view the
results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/list
1 - 100 of 189 matches
Mail list logo
