[Engine-patches] Change in ovirt-engine[master]: webadmin: gluster service checkbox to cluster

Gilad Chaplik has posted comments on this change. Change subject: webadmin: gluster service checkbox to cluster .. Patch Set 1: No score; No score after thinking about it a little, I'd like you to change it - Configure Local S

[Engine-patches] Change in ovirt-engine[master]: engine: Create Gluster Volume [fixed]

Shireesh Anjal has uploaded a new change for review. Change subject: engine: Create Gluster Volume [fixed] .. engine: Create Gluster Volume [fixed] Fixed bugs in Create Gluster Volume functionality. - Added more validations on

[Engine-patches] Change in ovirt-engine[master]: engine: Introducing gluster_volume_transport_types table

Shireesh Anjal has uploaded a new change for review. Change subject: engine: Introducing gluster_volume_transport_types table .. engine: Introducing gluster_volume_transport_types table Since a Gluster Volume can have multiple t

[Engine-patches] Change in ovirt-engine[master]: engine: Added gluster package to command packages list

Shireesh Anjal has uploaded a new change for review. Change subject: engine: Added gluster package to command packages list .. engine: Added gluster package to command packages list Added the package "org.ovirt.engine.core.bll.g

[Engine-patches] Change in ovirt-engine[master]: engine: Validation of collections

Shireesh Anjal has uploaded a new change for review. Change subject: engine: Validation of collections .. engine: Validation of collections Introduced a method validateCollectionForCanDoAction in CommandBase that can validate al

[Engine-patches] Change in ovirt-engine[master]: webadmin: gluster service checkbox to cluster

Raksha Rao has uploaded a new change for review. Change subject: webadmin: gluster service checkbox to cluster .. webadmin: gluster service checkbox to cluster Currently the parameter is not reflected in the backend, will be add

[Engine-patches] Change in ovirt-engine[master]: webadmin: gluster service checkbox to cluster

Gilad Chaplik has posted comments on this change. Change subject: webadmin: gluster service checkbox to cluster .. Patch Set 1: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: engine: Stop Gluster Volume

Selvasundaram has posted comments on this change. Change subject: engine: Stop Gluster Volume .. Patch Set 2: Added Junit test case for canDoAction and rebased. -- To view, visit http://gerrit.ovirt.org/3348 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: engine: Start Gluster Volume

Selvasundaram has posted comments on this change. Change subject: engine: Start Gluster Volume .. Patch Set 5: Added Junit test case for canDoAction and rebased. -- To view, visit http://gerrit.ovirt.org/3215 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[master]: engine: Start Gluster Volume

Selvasundaram has posted comments on this change. Change subject: engine: Start Gluster Volume .. Patch Set 4: Added Junit test case for canDoAction and rebased. -- To view, visit http://gerrit.ovirt.org/3215 To unsubscribe, v

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_user-gwtp - Build # 548 - Failure!

ovirt_engine_gwt_user-gwtp - Build # 548 - Failure: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_gwt_user-gwtp/548/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 579 - Fixed!

ovirt_engine_unit_tests - Build # 579 - Fixed: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/579/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinf

[Engine-patches] Change in ovirt-engine[master]: webadmin: Renaming AddDiskToVmCommand to AddDiskCommand

Michael Kublin has posted comments on this change. Change subject: webadmin: Renaming AddDiskToVmCommand to AddDiskCommand .. Patch Set 3: Verified; Looks good to me, approved already acked, no changes from previous patch -- T

[Engine-patches] Change in ovirt-engine[master]: core : Renaming of AddiskToVmCommand to AddDiskCommand

Michael Kublin has posted comments on this change. Change subject: core : Renaming of AddiskToVmCommand to AddDiskCommand .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/3390 To unsubscribe, visit http://gerr

[Engine-patches] Jenkins build is back to normal : ovirt_engine_create_rpms #239

See ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 578 - Failure!

ovirt_engine_unit_tests - Build # 578 - Failure: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/578/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listi

[Engine-patches] Build failed in Jenkins: ovirt_engine_create_rpms #238

See Changes: [mkublin] core : Able to create VM from template on illegal storage domain (#811603) [mkublin] core : Fixing broken unit test -- [...truncated 2090 lines...] [INFO] Co

[Engine-patches] Change in ovirt-engine[master]: webadmin: move/copy disks dialog - non-active sd

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: move/copy disks dialog - non-active sd .. webadmin: move/copy disks dialog - non-active sd Handling non-active storage domains on Move/Copy disk

[Engine-patches] Change in ovirt-engine[master]: webadmin: move/copy disks dialog - non-active sd

Daniel Erez has posted comments on this change. Change subject: webadmin: move/copy disks dialog - non-active sd .. Patch Set 2: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/3475 To un

[Engine-patches] Change in ovirt-engine[master]: core : Fixing broken unit test

Michael Kublin has submitted this change and it was merged. Change subject: core : Fixing broken unit test .. core : Fixing broken unit test The following patch will fix a broken MoveOrCopyDiskCommandTest A change is trivial C

[Engine-patches] Change in ovirt-engine[master]: core : Fixing broken unit test

Michael Kublin has posted comments on this change. Change subject: core : Fixing broken unit test .. Patch Set 1: Verified; Looks good to me, approved trivial change -- To view, visit http://gerrit.ovirt.org/3481 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: core : Fixing broken unit test

Michael Kublin has uploaded a new change for review. Change subject: core : Fixing broken unit test .. core : Fixing broken unit test The following patch will fix a broken MoveOrCopyDiskCommandTest A change is trivial Change-Id

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 577 - Still Unstable!

ovirt_engine_unit_tests - Build # 577 - Still Unstable: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/577/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailma

[Engine-patches] Change in ovirt-engine[master]: core : Able to create VM from template on illegal storage do...

Michael Kublin has submitted this change and it was merged. Change subject: core : Able to create VM from template on illegal storage domain (#811603) .. core : Able to create VM from template on illegal storage domain (#811603

[Engine-patches] Change in ovirt-engine[master]: core : Able to create VM from template on illegal storage do...

Michael Kublin has posted comments on this change. Change subject: core : Able to create VM from template on illegal storage domain (#811603) .. Patch Set 3: Verified; Looks good to me, approved with small changes -- To view,

[Engine-patches] Change in ovirt-engine[master]: packaging: remoteDB support

Ofer Schreiber has posted comments on this change. Change subject: packaging: remoteDB support .. Patch Set 10: Verified -- To view, visit http://gerrit.ovirt.org/3110 To unsubscribe, visit http://gerrit.ovirt.org/settings Ger

[Engine-patches] Change in ovirt-engine[master]: packaging: remoteDB support

Alex Lourie has posted comments on this change. Change subject: packaging: remoteDB support .. Patch Set 10: Verified -- To view, visit http://gerrit.ovirt.org/3110 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit

[Engine-patches] Change in ovirt-engine[master]: core: Fix DAO use with templates multiple storages

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Fix DAO use with templates multiple storages .. core: Fix DAO use with templates multiple storages The next patch has the following changes: 1. Int

[Engine-patches] Change in ovirt-engine[master]: core: Fix DAO use with templates multiple storages

Maor Lipchuk has posted comments on this change. Change subject: core: Fix DAO use with templates multiple storages .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3477 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: core: Fix DAO use with templates multiple storages

Michael Kublin has posted comments on this change. Change subject: core: Fix DAO use with templates multiple storages .. Patch Set 3: Looks good to me, approved Was agreed to push a patch as it, the unneeded checks for null wil

[Engine-patches] Change in ovirt-engine[master]: core: Fix DAO use with templates multiple storages

Michael Kublin has posted comments on this change. Change subject: core: Fix DAO use with templates multiple storages .. Patch Set 3: At each line of code we can get NullPointerException, but we don't check it is every time. B

[Engine-patches] Change in ovirt-engine[master]: core: Fix DAO use with templates multiple storages

Maor Lipchuk has posted comments on this change. Change subject: core: Fix DAO use with templates multiple storages .. Patch Set 3: Test will fail if we don't check nulls. This is part of the behaviour. It is better to check fo

[Engine-patches] Change in ovirt-engine[master]: core: Add query for getting storages

Michael Kublin has posted comments on this change. Change subject: core: Add query for getting storages .. Patch Set 1: (1 inline comment) File backend/manager/dbscripts/stor

[Engine-patches] Change in ovirt-engine[master]: core: Fix DAO use with templates multiple storages

Michael Kublin has posted comments on this change. Change subject: core: Fix DAO use with templates multiple storages .. Patch Set 3: No score I still don't understand why we need so many checks for nulls, how it can be that im

[Engine-patches] Change in ovirt-engine[master]: packaging: remoteDB support

Ofer Schreiber has posted comments on this change. Change subject: packaging: remoteDB support .. Patch Set 10: Looks good to me, approved Please add the Verified +1 if it passed all the needed tests. -- To view, visit http://

[Engine-patches] Change in ovirt-engine[master]: core: Fix DAO use with templates multiple storages

Michael Kublin has posted comments on this change. Change subject: core: Fix DAO use with templates multiple storages .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3477 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: core: Add query for getting storages

Michael Kublin has posted comments on this change. Change subject: core: Add query for getting storages .. Patch Set 1: (2 inline comments) File backend/manager/dbscripts/sto