[Engine-patches] [oVirt Jenkins] ovirt_engine_purge_maven_repo - Build # 79 - Still Failing!

2012-03-22 Thread Jenkins oVirt Server
ovirt_engine_purge_maven_repo - Build # 79 - Still Failing: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_purge_maven_repo/79/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.o

[Engine-patches] Change in ovirt-engine[master]: core: Re-fix DAO tests

2012-03-22 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Re-fix DAO tests .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3040 To unsubscribe, visit http://gerrit.ovirt.org/s

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 436 - Fixed!

2012-03-22 Thread Jenkins oVirt Server
ovirt_engine_unit_tests - Build # 436 - Fixed: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/436/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinf

[Engine-patches] Change in ovirt-engine[master]: Entity Search support for GlusterVolumeEntity

2012-03-22 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: Entity Search support for GlusterVolumeEntity .. Patch Set 2: rebased -- To view, visit http://gerrit.ovirt.org/3009 To unsubscribe, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: engine: DB scripts, entities and DAO for Gluster Volumes

2012-03-22 Thread sanjal
Shireesh Anjal has posted comments on this change. Change subject: engine: DB scripts, entities and DAO for Gluster Volumes .. Patch Set 9: rebased -- To view, visit http://gerrit.ovirt.org/2936 To unsubscribe, visit http://ge

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 435 - Still Unstable!

2012-03-22 Thread Jenkins oVirt Server
ovirt_engine_unit_tests - Build # 435 - Still Unstable: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/435/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailma

[Engine-patches] Change in ovirt-engine[master]: core: Fixing checks for storage domains

2012-03-22 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Fixing checks for storage domains .. Patch Set 3: Michael - please review. Had to fix some stuff. -- To view, visit http://gerrit.ovirt.org/3026 To unsub

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 434 - Still unstable!

2012-03-22 Thread Jenkins oVirt Server
ovirt_engine_unit_tests - Build # 434 - Still unstable: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/434/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailma

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_admin - Build # 209 - Failure!

2012-03-22 Thread Jenkins oVirt Server
ovirt_engine_gwt_admin - Build # 209 - Failure: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/209/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinf

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 433 - Failure!

2012-03-22 Thread Jenkins oVirt Server
ovirt_engine_unit_tests - Build # 433 - Failure: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/433/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listi

[Engine-patches] [oVirt Jenkins] ovirt_engine_dao_unit_tests - Build # 409 - Fixed!

2012-03-22 Thread Jenkins oVirt Server
ovirt_engine_dao_unit_tests - Build # 409 - Fixed: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/409/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 432 - Unstable!

2012-03-22 Thread Jenkins oVirt Server
ovirt_engine_unit_tests - Build # 432 - Unstable: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/432/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/list

[Engine-patches] Change in ovirt-engine[master]: Revert "core: Fixing/refactoring buildAndCheckDestStorageDom...

2012-03-22 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: Revert "core: Fixing/refactoring buildAndCheckDestStorageDomains" .. Revert "core: Fixing/refactoring buildAndCheckDestStorageDomains" This reverts co

[Engine-patches] Change in ovirt-engine[master]: Revert "core: Fixing/refactoring buildAndCheckDestStorageDom...

2012-03-22 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: Revert "core: Fixing/refactoring buildAndCheckDestStorageDomains" .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: Revert "core: Fixing/refactoring buildAndCheckDestStorageDom...

2012-03-22 Thread yzaslavs
Yair Zaslavsky has reverted this change. Change subject: Revert "core: Fixing/refactoring buildAndCheckDestStorageDomains" .. Patch Set 2: Reverted This patchset was reverted in change: I6d60fae7e82b999076dc883c614a31996c2799b

[Engine-patches] [oVirt Jenkins] ovirt_engine_dao_unit_tests - Build # 408 - Failure!

2012-03-22 Thread Jenkins oVirt Server
ovirt_engine_dao_unit_tests - Build # 408 - Failure: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/408/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailm

[Engine-patches] Change in ovirt-engine[master]: core: Fixing/refactoring buildAndCheckDestStorageDomains

2012-03-22 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fixing/refactoring buildAndCheckDestStorageDomains .. core: Fixing/refactoring buildAndCheckDestStorageDomains Fixing and refactoring buildAndChe

[Engine-patches] Change in ovirt-engine[master]: core: Fixing/refactoring buildAndCheckDestStorageDomains

2012-03-22 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Fixing/refactoring buildAndCheckDestStorageDomains .. Patch Set 2: Verified; Looks good to me, approved Acked-By Michael Kublin. Verified - a. Cloned vm

[Engine-patches] Change in ovirt-engine[master]: core: Fixing/Refactoring buildAndCheckDestStorageDomains

2012-03-22 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: core: Fixing/Refactoring buildAndCheckDestStorageDomains .. core: Fixing/Refactoring buildAndCheckDestStorageDomains Fixing and refactoring buildAndChekcDestSt

[Engine-patches] Change in ovirt-engine[master]: core: Re-fix DAO tests

2012-03-22 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Re-fix DAO tests .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/3040 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-Me

[Engine-patches] Change in ovirt-engine[master]: core: Re-fix DAO tests

2012-03-22 Thread amureini
Allon Mureinik has uploaded a new change for review. Change subject: core: Re-fix DAO tests .. core: Re-fix DAO tests The previous fix to the DAO tests (I627a3e291546b6a3c3d544c6f1914950f26298e0) wrongfully assumed that Shared D

[Engine-patches] Change in ovirt-engine[master]: core: Extract DAO call to single method

2012-03-22 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Extract DAO call to single method .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3037 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: core: Reloadable Config Values (1)

2012-03-22 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Reloadable Config Values (1) .. Patch Set 1: Actually, I was sure you're heading to a different direction (or at least I had one in mind) Do we have a Wi

[Engine-patches] Change in ovirt-engine[master]: core: Reloadable Config Values (1)

2012-03-22 Thread msalem
Muli Salem has uploaded a new change for review. Change subject: core: Reloadable Config Values (1) .. core: Reloadable Config Values (1) This patch makes sure the first batch of config values are reloaded from the cached map, e

[Engine-patches] Change in ovirt-engine[master]: engine-core: remove singleton from QuotaHelper

2012-03-22 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: engine-core: remove singleton from QuotaHelper .. Patch Set 2: It is also look good to me, just minor inline comment about private declaration of quotaDAO -- To

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 430 - Fixed!

2012-03-22 Thread Jenkins oVirt Server
ovirt_engine_unit_tests - Build # 430 - Fixed: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/430/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinf

[Engine-patches] Change in ovirt-engine[master]: core: use enum for custom audit log keys

2012-03-22 Thread rgolan
Roy Golan has submitted this change and it was merged. Change subject: core: use enum for custom audit log keys .. core: use enum for custom audit log keys Change-Id: I02a23aa4da2ebee41c9830decd9c99bd487ae6a4 --- M backend/man

[Engine-patches] Change in ovirt-engine[master]: core: clean XMl annotations for VdsNetworkInterface

2012-03-22 Thread rgolan
Roy Golan has submitted this change and it was merged. Change subject: core: clean XMl annotations for VdsNetworkInterface .. core: clean XMl annotations for VdsNetworkInterface Change-Id: Iffe30d5726d6ec0a70abc5605790fa62cbf0c

[Engine-patches] Change in ovirt-engine[master]: core: use enum for custom audit log keys

2012-03-22 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: use enum for custom audit log keys .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3005 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: core: clean XMl annotations for VdsNetworkInterface

2012-03-22 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: clean XMl annotations for VdsNetworkInterface .. Patch Set 6: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2206 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: core: added mtu support on newtorks

2012-03-22 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: added mtu support on newtorks .. Patch Set 6: Verified rebased added an update on network mtu which was missing -- To view, visit http://gerrit.ovirt.org/2207

[Engine-patches] Change in ovirt-engine[master]: core: add mtu validator

2012-03-22 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: add mtu validator .. Patch Set 3: Verified rebased fixed maxValue type to integer -- To view, visit http://gerrit.ovirt.org/2995 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: clean unused member and Linq comments

2012-03-22 Thread rgolan
Roy Golan has posted comments on this change. Change subject: clean unused member and Linq comments .. Patch Set 6: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2208 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: core: VdsUpdateRunTimeInfo break long method

2012-03-22 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: VdsUpdateRunTimeInfo break long method .. Patch Set 3: (1 inline comment) File backend/manager/modules/vd

[Engine-patches] Change in ovirt-engine[master]: core: VdsUpdateRunTimeInfo break long method

2012-03-22 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: VdsUpdateRunTimeInfo break long method .. Patch Set 3: Verified (1 inline comment) rebase File backend/

[Engine-patches] Change in ovirt-engine[master]: core: VdsUpdateRunTimeInfo - audit log when mtu on host and ...

2012-03-22 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: VdsUpdateRunTimeInfo - audit log when mtu on host and cluster differs .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/2997 To unsubscribe,

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 429 - Unstable!

2012-03-22 Thread Jenkins oVirt Server
ovirt_engine_unit_tests - Build # 429 - Unstable: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/429/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/list

[Engine-patches] Change in ovirt-engine[master]: core: add mtu to setupnetworks

2012-03-22 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: add mtu to setupnetworks .. Patch Set 3: Verified rebased the mtu was taken from iface instead of network - fixed -- To view, visit http://gerrit.ovirt.org/29

[Engine-patches] Change in ovirt-engine[master]: core: Adding test for JsonIgnore

2012-03-22 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: core: Adding test for JsonIgnore .. core: Adding test for JsonIgnore Adding this test to check JsonIgnore in context of entities. This test covers map seriali

[Engine-patches] Change in ovirt-engine[master]: REST: support setting mtu on logical network

2012-03-22 Thread rgolan
Roy Golan has posted comments on this change. Change subject: REST: support setting mtu on logical network .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/2999 To unsubscribe, visit http://gerrit.ovirt.org/se

[Engine-patches] Change in ovirt-engine[master]: REST: support setting mtu on logical network

2012-03-22 Thread rgolan
Roy Golan has posted comments on this change. Change subject: REST: support setting mtu on logical network .. Patch Set 3: added missing parts in yaml -- To view, visit http://gerrit.ovirt.org/2999 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine[master]: webadmin: Clone VM from snapshot support

2012-03-22 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Clone VM from snapshot support .. webadmin: Clone VM from snapshot support * Added Clone VM from snapshot support to gwt-common. * Implemented t

[Engine-patches] Change in ovirt-engine[master]: webadmin: Clone VM from snapshot support

2012-03-22 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Clone VM from snapshot support .. Patch Set 2: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/3018 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: webadmin: Adding Quota column to DisksAllocation

2012-03-22 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Adding Quota column to DisksAllocation .. webadmin: Adding Quota column to DisksAllocation * Adding a Quota column to DisksAllocationView. * Aff

[Engine-patches] Change in ovirt-engine[master]: webadmin: Adding Quota column to DisksAllocation

2012-03-22 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Adding Quota column to DisksAllocation .. Patch Set 2: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/3017 To un

[Engine-patches] Change in ovirt-engine[master]: webadmin: Move/Copy disks modifications

2012-03-22 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Move/Copy disks modifications .. Patch Set 2: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/3016 To unsubscribe

[Engine-patches] Change in ovirt-engine[master]: webadmin: Move/Copy disks modifications

2012-03-22 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Move/Copy disks modifications .. webadmin: Move/Copy disks modifications * Filter irrelevant storage domains on Move/Copy disks dialogs. * Add d

[Engine-patches] Change in ovirt-engine[master]: webadmin: Snapshots sub-tab structure redesign

2012-03-22 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Snapshots sub-tab structure redesign .. webadmin: Snapshots sub-tab structure redesign * Sub-tab is composed of a tree of Snapshots. * Get snaps

[Engine-patches] Change in ovirt-engine[master]: webadmin: Snapshots sub-tab structure redesign

2012-03-22 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: Snapshots sub-tab structure redesign .. Patch Set 2: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/3015 To unsu

[Engine-patches] Change in ovirt-engine[master]: webadmin: New Pool dialog - storage selection

2012-03-22 Thread derez
Daniel Erez has submitted this change and it was merged. Change subject: webadmin: New Pool dialog - storage selection .. webadmin: New Pool dialog - storage selection Added disks storage domains selection to Resource Allocatio

[Engine-patches] Change in ovirt-engine[master]: webadmin: New Pool dialog - storage selection

2012-03-22 Thread derez
Daniel Erez has posted comments on this change. Change subject: webadmin: New Pool dialog - storage selection .. Patch Set 2: Verified; Looks good to me, approved rebased -- To view, visit http://gerrit.ovirt.org/3014 To unsub

[Engine-patches] Change in ovirt-engine[master]: webadmin: Clone VM from snapshot support

2012-03-22 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: Clone VM from snapshot support .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3018 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-engine[master]: webadmin: Adding Quota column to DisksAllocation

2012-03-22 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: Adding Quota column to DisksAllocation .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3017 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: webadmin: Move/Copy disks modifications

2012-03-22 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: Move/Copy disks modifications .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3016 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: webadmin: Snapshots sub-tab structure redesign

2012-03-22 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: Snapshots sub-tab structure redesign .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3015 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: webadmin: New Pool dialog - storage selection

2012-03-22 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: New Pool dialog - storage selection .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3014 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[master]: core: Fix GetVmsInfoVDSCommand return log level

2012-03-22 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: core: Fix GetVmsInfoVDSCommand return log level .. core: Fix GetVmsInfoVDSCommand return log level The return is an OVF XML, which is too verbose to pri

[Engine-patches] Change in ovirt-engine[master]: core: Fix GetVmsInfoVDSCommand return log level

2012-03-22 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Fix GetVmsInfoVDSCommand return log level .. Patch Set 2: Verified; Looks good to me, approved Just rebased, ack (+2) by yzaslavs -- To view, visit http:/

[Engine-patches] Change in ovirt-engine[master]: core: Fix GetVmsInfoVDSCommand return log level

2012-03-22 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Fix GetVmsInfoVDSCommand return log level .. Patch Set 1: Looks good to me, approved About time :) -- To view, visit http://gerrit.ovirt.org/3023 To unsu

[Engine-patches] Change in ovirt-engine[master]: core: Add support for import/export of VM snapshots

2012-03-22 Thread mkolesni
Mike Kolesnik has uploaded a new change for review. Change subject: core: Add support for import/export of VM snapshots .. core: Add support for import/export of VM snapshots Added exporting and importing VM snapshots, which wil

[Engine-patches] Change in ovirt-engine[master]: core: Extract DAO call to single method

2012-03-22 Thread mkolesni
Mike Kolesnik has uploaded a new change for review. Change subject: core: Extract DAO call to single method .. core: Extract DAO call to single method In ImportVmCommand there are several places where SnapshotDao is needed, so e

[Engine-patches] Change in ovirt-engine[master]: core: Fix ImportVmCommand for snapshot images

2012-03-22 Thread mkolesni
Mike Kolesnik has uploaded a new change for review. Change subject: core: Fix ImportVmCommand for snapshot images .. core: Fix ImportVmCommand for snapshot images Snapshot images should be imported always as active = false, wher

[Engine-patches] Change in ovirt-engine[master]: core: Added get all vith config to SnapshotDao

2012-03-22 Thread mkolesni
Mike Kolesnik has uploaded a new change for review. Change subject: core: Added get all vith config to SnapshotDao .. core: Added get all vith config to SnapshotDao This method is needed to get all VM snapshots with their config

[Engine-patches] Change in ovirt-engine[master]: core : Introducing of AttachDiskToVmCommand

2012-03-22 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core : Introducing of AttachDiskToVmCommand .. Patch Set 3: will be send as a new patch -- To view, visit http://gerrit.ovirt.org/2732 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: core: Fixing VM get configuration by snapshot query

2012-03-22 Thread yzaslavs
Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fixing VM get configuration by snapshot query .. core: Fixing VM get configuration by snapshot query Due to merge error, SnapshotsManager got a n

[Engine-patches] Change in ovirt-engine[master]: core: Fixing VM get configuration by snapshot query

2012-03-22 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Fixing VM get configuration by snapshot query .. Patch Set 5: Verified; Looks good to me, approved Acked-By: Mike Kolesnik -- To view, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: core: Fixing import vm when there is vm with snapshots

2012-03-22 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Fixing import vm when there is vm with snapshots .. Patch Set 1: Verified Verified. Tested both with vm import, and with vm template import. -- To view,

[Engine-patches] Change in ovirt-engine[master]: core: Fixing import vm when there is vm with snapshots

2012-03-22 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: core: Fixing import vm when there is vm with snapshots .. core: Fixing import vm when there is vm with snapshots When there is VM with snapshot , there is more

[Engine-patches] Change in ovirt-engine[master]: core : Introducing of AttachDiskToVmCommand

2012-03-22 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core : Introducing of AttachDiskToVmCommand .. Patch Set 3: what about unit test for the new command ? -- To view, visit http://gerrit.ovirt.org/2732 To unsubscri

[Engine-patches] Change in ovirt-engine[master]: core : Introducing of AttachDiskToVmCommand

2012-03-22 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core : Introducing of AttachDiskToVmCommand .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2732 To unsubscribe, visit http://

[Engine-patches] [oVirt Jenkins] ovirt_engine_dao_unit_tests - Build # 403 - Fixed!

2012-03-22 Thread Jenkins oVirt Server
ovirt_engine_dao_unit_tests - Build # 403 - Fixed: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/403/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman

[Engine-patches] [oVirt Jenkins] ovirt_engine_dao_unit_tests - Build # 402 - Still Failing!

2012-03-22 Thread Jenkins oVirt Server
ovirt_engine_dao_unit_tests - Build # 402 - Still Failing: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/402/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 426 - Fixed!

2012-03-22 Thread Jenkins oVirt Server
ovirt_engine_unit_tests - Build # 426 - Fixed: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/426/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinf

[Engine-patches] Change in ovirt-engine[master]: core : Setting defauult entityId for ImagesActionsParameters...

2012-03-22 Thread mkublin
Michael Kublin has submitted this change and it was merged. Change subject: core : Setting defauult entityId for ImagesActionsParametersBase .. core : Setting defauult entityId for ImagesActionsParametersBase The following patc

[Engine-patches] Change in ovirt-engine[master]: core : Setting defauult entityId for ImagesActionsParameters...

2012-03-22 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core : Setting defauult entityId for ImagesActionsParametersBase .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/3027 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: core : Setting defauult entityId for ImagesActionsParameters...

2012-03-22 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core : Setting defauult entityId for ImagesActionsParametersBase .. Patch Set 1: Looks good to me, approved please fix commit message typos before push. -- To vie

[Engine-patches] Change in ovirt-engine[master]: core : Setting defauult entityId for ImagesActionsParameters...

2012-03-22 Thread mkublin
Michael Kublin has uploaded a new change for review. Change subject: core : Setting defauult entityId for ImagesActionsParametersBase .. core : Setting defauult entityId for ImagesActionsParametersBase The following patch will s

[Engine-patches] Change in ovirt-engine[master]: packaging: enable ovirt installation on ports lower than 102...

2012-03-22 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: packaging: enable ovirt installation on ports lower than 1024 .. Patch Set 2: Looks good to me, approved Looks OK now Please add the +1 verified (after rebase)

[Engine-patches] Change in ovirt-engine[master]: packaging: enable ovirt installation on ports lower than 102...

2012-03-22 Thread bazulay
Barak Azulay has posted comments on this change. Change subject: packaging: enable ovirt installation on ports lower than 1024 .. Patch Set 2: (1 inline comment) File packagi

[Engine-patches] Change in ovirt-engine[master]: do not submit core: Fixing checks for storage domains

2012-03-22 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: do not submit core: Fixing checks for storage domains .. Patch Set 2: Looks good to me, approved Looks ok, please verify -- To view, visit http://gerrit.ovirt.

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 425 - Unstable!

2012-03-22 Thread Jenkins oVirt Server
ovirt_engine_unit_tests - Build # 425 - Unstable: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/425/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/list

[Engine-patches] Change in ovirt-engine[master]: do not submit core: Fixing checks for storage domains

2012-03-22 Thread yzaslavs
Yair Zaslavsky has uploaded a new change for review. Change subject: do not submit core: Fixing checks for storage domains .. do not submit core: Fixing checks for storage domains Please review carefully! This patch extract met

[Engine-patches] Change in ovirt-engine[master]: core: Improve message for missing SRV record

2012-03-22 Thread msalem
Muli Salem has submitted this change and it was merged. Change subject: core: Improve message for missing SRV record .. core: Improve message for missing SRV record This patch improves the error message printed when a DNS SRV r

[Engine-patches] Change in ovirt-engine[master]: core: Improve message for missing SRV record

2012-03-22 Thread msalem
Muli Salem has posted comments on this change. Change subject: core: Improve message for missing SRV record .. Patch Set 5: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/81 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core: Fixing VM configuration by snapshot query

2012-03-22 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Fixing VM configuration by snapshot query .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3007 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: core: Improve message for missing SRV record

2012-03-22 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Improve message for missing SRV record .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/81 To unsubscribe, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: core: Improve message for missing SRV record

2012-03-22 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Improve message for missing SRV record .. Patch Set 4: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/81 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: restapi: Remove Spring Framework

2012-03-22 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: restapi: Remove Spring Framework .. Patch Set 2: Looks good to me, but someone else must approve Also, I opened a pre-integration ticket on testing my patches for

[Engine-patches] [oVirt Jenkins] ovirt_engine_dao_unit_tests - Build # 401 - Failure!

2012-03-22 Thread Jenkins oVirt Server
ovirt_engine_dao_unit_tests - Build # 401 - Failure: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/401/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailm

[Engine-patches] Change in ovirt-engine[master]: restapi: Remove Spring Framework

2012-03-22 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: restapi: Remove Spring Framework .. Patch Set 2: Good news: version 7.1.1 of JBoss AS includes version 2.3.2 of resteasy, which fixes our issues. -- To view,

[Engine-patches] Change in ovirt-engine[master]: webadmin: can't copy from textbox in Host - General subtab (...

2012-03-22 Thread tjelinek
Tomas Jelinek has uploaded a new change for review. Change subject: webadmin: can't copy from textbox in Host - General subtab (#805173) .. webadmin: can't copy from textbox in Host - General subtab (#805173) https://bugzilla.r

[Engine-patches] Change in ovirt-engine[master]: wip - don't submit - core: update to Spring 3

2012-03-22 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: wip - don't submit - core: update to Spring 3 .. Patch Set 3: Looks good to me, but someone else must approve I just saw that version 7.1.1 of JBoss AS updated

[Engine-patches] [oVirt Jenkins] ovirt_engine_dao_unit_tests - Build # 400 - Fixed!

2012-03-22 Thread Jenkins oVirt Server
ovirt_engine_dao_unit_tests - Build # 400 - Fixed: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/400/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman

[Engine-patches] Change in ovirt-engine[master]: wip - don't submit - engine: Update the standalone.xml confi...

2012-03-22 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: wip - don't submit - engine: Update the standalone.xml configuration .. Patch Set 3: Latest patch - some more fixes in the logging. -- To view, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: core: Add grant_mode attribute to permissions entity

2012-03-22 Thread lpeer
Livnat Peer has posted comments on this change. Change subject: core: Add grant_mode attribute to permissions entity .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/2978

[Engine-patches] Change in ovirt-engine[master]: wip - don't submit - core: update to Spring 3

2012-03-22 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: wip - don't submit - core: update to Spring 3 .. Patch Set 3: latest patch was a fix in the classpath in engine-manage-domains, to use spring-ldap 1.3.1 instead

[Engine-patches] Change in ovirt-engine[master]: wip - don't submit - core: update to Spring 3

2012-03-22 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: wip - don't submit - core: update to Spring 3 .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3002 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: wip - don't submit - core: removed customized naming jar

2012-03-22 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: wip - don't submit - core: removed customized naming jar .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3024 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: engine: added export date to ovf for Vm and VmTemplate

2012-03-22 Thread ofrenkel
Omer Frenkel has submitted this change and it was merged. Change subject: engine: added export date to ovf for Vm and VmTemplate .. engine: added export date to ovf for Vm and VmTemplate Change-Id: Ie7a2b0cf84322b053e65a85a448f

[Engine-patches] Change in ovirt-engine[master]: engine: added export date to ovf for Vm and VmTemplate

2012-03-22 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: engine: added export date to ovf for Vm and VmTemplate .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3006 To unsubscribe, v

  1   2   >