Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetVdsGroupByIdQuery
..
Patch Set 8: (1 inline comment)
good catch, will upload a new patchset to fix it.
...
Allon Mureinik has posted comments on this change.
Change subject: core: Fixed VdsGroupTest
..
Patch Set 8: (1 inline comment)
File
backend/manager/modules/dal/src/test/java
Allon Mureinik has posted comments on this change.
Change subject: core: Fixed VdsGroupTest
..
Patch Set 8: (1 inline comment)
answered mlipchuk's comment.
File
backend/man
Michael Kublin has posted comments on this change.
Change subject: core: upgrade fix - add missing FKs to image_domain_map table
..
Patch Set 2:
Actually, the fix is correct, the problem is that unit test is wrong and always
w
Mike Kolesnik has posted comments on this change.
Change subject: [DO NOT SUBMIT] core: Migrate snapshots data & start using table
..
Patch Set 2: Fails
Do not submit yet.
Fixed all major flows to work with the snapshots table
Mike Kolesnik has posted comments on this change.
Change subject: core: Cleanup RestoreAllSnapshotsCommand async task
..
Patch Set 2:
Just rebased
--
To view, visit http://gerrit.ovirt.org/2313
To unsubscribe, visit http://ger
Mike Kolesnik has posted comments on this change.
Change subject: core: Fixes in SnapshotsManager
..
Patch Set 2:
More fixes made so that snapshots will work, detailed in the commit message
--
To view, visit http://gerrit.ovir
Mike Kolesnik has posted comments on this change.
Change subject: core: Add method to get images with no disks
..
Patch Set 2:
Just rebased
--
To view, visit http://gerrit.ovirt.org/2311
To unsubscribe, visit http://gerrit.ovi
Mike Kolesnik has posted comments on this change.
Change subject: core: Change images_storage_domain_view to left join disks
..
Patch Set 5:
Just rebased
--
To view, visit http://gerrit.ovirt.org/2183
To unsubscribe, visit htt
Mike Kolesnik has uploaded a new change for review.
Change subject: core: Added can do action message for illegal restore
..
core: Added can do action message for illegal restore
Regular snapshot cannot be restored, unless it's
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add query get all templates by quota id
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/2334
To unsubscribe, visit http://gerrit.ovirt.
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add existing VM to FixturesTool
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/2306
To unsubscribe, visit http://gerrit.ovirt.org/sett
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add query to get disks by quota id
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/2307
To unsubscribe, visit http://gerrit.ovirt.org/s
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add query for permissions to consume qutoa
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/2308
To unsubscribe, visit http://gerrit.ovi
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add support for adding empty quota
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/2309
To unsubscribe, visit http://gerrit.ovirt.org/s
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add validation when remove quota
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/2310
To unsubscribe, visit http://gerrit.ovirt.org/set
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add validation for importVmCommand
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/2335
To unsubscribe, visit http://gerrit.ovirt.org/s
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add default quota indication field
..
Patch Set 9: Verified
--
To view, visit http://gerrit.ovirt.org/2075
To unsubscribe, visit http://gerrit.ovirt.org/s
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add quota enforcement type to storage pool
..
Patch Set 9: Verified
--
To view, visit http://gerrit.ovirt.org/2076
To unsubscribe, visit http://gerrit.ovi
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add Quota canDoActionErrors
..
Patch Set 11: Verified
--
To view, visit http://gerrit.ovirt.org/2080
To unsubscribe, visit http://gerrit.ovirt.org/setting
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add quota by storage pool Id query
..
Patch Set 11: Verified
--
To view, visit http://gerrit.ovirt.org/2092
To unsubscribe, visit http://gerrit.ovirt.org/
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add Quota helper class
..
Patch Set 11: Verified
--
To view, visit http://gerrit.ovirt.org/2082
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add quota permission
..
Patch Set 11: Verified
--
To view, visit http://gerrit.ovirt.org/2077
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerr
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add pre defined roles for consume quota
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/2109
To unsubscribe, visit http://gerrit.ovirt
Maor Lipchuk has posted comments on this change.
Change subject: engine: Create default unlimited quota for DC
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/2079
To unsubscribe, visit http://gerrit.ovirt.o
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add quota to audit log
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/2081
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add validation for quota name
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/2083
To unsubscribe, visit http://gerrit.ovirt.org/setti
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add/Edit quota commands
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/2084
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Maor Lipchuk has posted comments on this change.
Change subject: engine: Remove quota command
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/2085
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerr
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add quota id to VM parameters
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/2086
To unsubscribe, visit http://gerrit.ovirt.org/setti
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add quota id to disk image
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/2087
To unsubscribe, visit http://gerrit.ovirt.org/settings
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add quota id to vm static
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/2088
To unsubscribe, visit http://gerrit.ovirt.org/settings
Maor Lipchuk has posted comments on this change.
Change subject: frontend: Add business entities to sharedGWT
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/2090
To unsubscribe, visit http://gerrit.ovirt.or
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add search support for quota.
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/2091
To unsubscribe, visit http://gerrit.ovirt.org/setti
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add audit log messages
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/2093
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add audit log messages to CRUD commands.
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/2094
To unsubscribe, visit http://gerrit.ovir
Maor Lipchuk has posted comments on this change.
Change subject: engine: Adding fix to quota stored procedure
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/2095
To unsubscribe, visit http://gerrit.ovirt.or
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add quota manager class
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/2096
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add quota validation support commandBase
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/2097
To unsubscribe, visit http://gerrit.ovir
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add quota validation for AddVmCommand
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/2098
To unsubscribe, visit http://gerrit.ovirt.o
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add quota validation for Add Disk to VM
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/2101
To unsubscribe, visit http://gerrit.ovirt
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add quota validation for Add Vm Tempalte
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/2102
To unsubscribe, visit http://gerrit.ovir
Maor Lipchuk has posted comments on this change.
Change subject: engine:Add quota validation for RunVmCommand
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/2103
To unsubscribe, visit http://gerrit.ovirt.or
Maor Lipchuk has posted comments on this change.
Change subject: engine:Add quota validation for crateAllSnapshot
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/2105
To unsubscribe, visit http://gerrit.ovir
Maor Lipchuk has posted comments on this change.
Change subject: engine: Refactor permission subject
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/2107
To unsubscribe, visit http://gerrit.ovirt.org/setting
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add permission support for Quota consume
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/2108
To unsubscribe, visit http://gerrit.ovir
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add consume quota permission to add VM
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/2111
To unsubscribe, visit http://gerrit.ovirt.
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add consume quota permission to add Tempalte
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/2112
To unsubscribe, visit http://gerrit.
Maor Lipchuk has posted comments on this change.
Change subject: engine: Quota upgrade script
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/2078
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerr
Maor Lipchuk has posted comments on this change.
Change subject: engine: Fix quota vds group stored procedure
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/2114
To unsubscribe, visit http://gerrit.ovirt.or
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add quota queries
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/2141
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-M
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add query get all vms by quota id
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/2305
To unsubscribe, visit http://gerrit.ovirt.org/se
Maor Lipchuk has posted comments on this change.
Change subject: engine: Quota upgrade script
..
Patch Set 13:
Change this row igsdm.image_id = images.image_group_guid
to igsdm.image_id = images.image_guid in the upgrade script
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add permission support for Quota consume
..
Patch Set 13:
Changed from Admin to User as suggested in comments
--
To view, visit http://gerrit.ovirt.org/2
Maor Lipchuk has posted comments on this change.
Change subject: engine: Refactor permission subject
..
Patch Set 13:
rebase + new changes had to be made after rebase
--
To view, visit http://gerrit.ovirt.org/2107
To unsubscri
Maor Lipchuk has posted comments on this change.
Change subject: engine:Add quota validation for crateAllSnapshot
..
Patch Set 13:
rebase
--
To view, visit http://gerrit.ovirt.org/2105
To unsubscribe, visit http://gerrit.ovirt
Maor Lipchuk has posted comments on this change.
Change subject: engine:Add quota validation for RunVmCommand
..
Patch Set 13:
Added setQuotaId in execute method
--
To view, visit http://gerrit.ovirt.org/2103
To unsubscribe, v
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add quota validation for Add Vm Tempalte
..
Patch Set 13:
Updated as suggested in commments
--
To view, visit http://gerrit.ovirt.org/2102
To unsubscribe
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add quota validation for Add Disk to VM
..
Patch Set 13:
Added setQuotaId to the execute method
--
To view, visit http://gerrit.ovirt.org/2101
To unsubsc
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add quota validation for AddVmCommand
..
Patch Set 13:
Changed code as suggested in comments, also added setQuotaId when execute
--
To view, visit http:/
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add quota validation support commandBase
..
Patch Set 13:
rebase
--
To view, visit http://gerrit.ovirt.org/2097
To unsubscribe, visit http://gerrit.ovirt
Maor Lipchuk has posted comments on this change.
Change subject: engine: Adding fix to quota stored procedure
..
Patch Set 13:
rebase
--
To view, visit http://gerrit.ovirt.org/2095
To unsubscribe, visit http://gerrit.ovirt.org
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add audit log messages to CRUD commands.
..
Patch Set 13:
Changed as suggested in comments
--
To view, visit http://gerrit.ovirt.org/2094
To unsubscribe,
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add audit log messages
..
Patch Set 13:
rebase
--
To view, visit http://gerrit.ovirt.org/2093
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ger
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add search support for quota.
..
Patch Set 13:
rebase
--
To view, visit http://gerrit.ovirt.org/2091
To unsubscribe, visit http://gerrit.ovirt.org/settin
Maor Lipchuk has posted comments on this change.
Change subject: frontend: Add business entities to sharedGWT
..
Patch Set 13:
rebase
--
To view, visit http://gerrit.ovirt.org/2090
To unsubscribe, visit http://gerrit.ovirt.org
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add quota id to VM parameters
..
Patch Set 13:
Using specific parameter classes to add quotaId, instead adding it to be used
in the global parameter clas
Maor Lipchuk has posted comments on this change.
Change subject: engine: Remove quota command
..
Patch Set 13:
Removed TODO that should be referenced in later patch.
--
To view, visit http://gerrit.ovirt.org/2085
To unsubscrib
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add/Edit quota commands
..
Patch Set 13:
Changed as suggested in last review comments
--
To view, visit http://gerrit.ovirt.org/2084
To unsubscribe, visi
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add validation for quota name
..
Patch Set 13:
rebased + changing script number
--
To view, visit http://gerrit.ovirt.org/2083
To unsubscribe, visit http
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add quota to audit log
..
Patch Set 13:
Rebased
--
To view, visit http://gerrit.ovirt.org/2081
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Maor Lipchuk has posted comments on this change.
Change subject: engine: Create default unlimited quota for DC
..
Patch Set 13:
Rebased, and changed to be used with "Consumer user" role instead "consume user"
--
To view, visit
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add pre defined roles for consume quota
..
Patch Set 13:
Changed role name to consumer as suggested as part of the comments in the patch
set
--
To view,
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add quota permission
..
Patch Set 11:
rebased, changed script number
--
To view, visit http://gerrit.ovirt.org/2077
To unsubscribe, visit http://gerrit.o
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add Quota helper class
..
Patch Set 11:
Rebased no change, answered comment in patch set 9.
--
To view, visit http://gerrit.ovirt.org/2082
To unsubscribe
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add quota by storage pool Id query
..
Patch Set 11:
rebased
--
To view, visit http://gerrit.ovirt.org/2092
To unsubscribe, visit http://gerrit.ovirt.org/
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add Quota canDoActionErrors
..
Patch Set 11:
rebased
--
To view, visit http://gerrit.ovirt.org/2080
To unsubscribe, visit http://gerrit.ovirt.org/setting
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add quota enforcement type to storage pool
..
Patch Set 9:
rebased
--
To view, visit http://gerrit.ovirt.org/2076
To unsubscribe, visit http://gerrit.ovi
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add default quota indication field
..
Patch Set 9:
rebased
--
To view, visit http://gerrit.ovirt.org/2075
To unsubscribe, visit http://gerrit.ovirt.org/s
Saggi Mizrahi has posted comments on this change.
Change subject: Refactor UpdateStoragePoolCommand
..
Patch Set 1: (7 inline comments)
Please refrain for commenting on stuff that were already bad. I'm not saying I
made the co
Maor Lipchuk has uploaded a new change for review.
Change subject: engine: Add validation for importVmCommand
..
engine: Add validation for importVmCommand
Adding validate quota method to import VM command.
For now we only set t
Maor Lipchuk has uploaded a new change for review.
Change subject: engine: Add query get all templates by quota id
..
engine: Add query get all templates by quota id
Adding query to fetch all templates which are related to quota
Maor Lipchuk has posted comments on this change.
Change subject: core: Cleanup GetPermissionsByAdElementIdQuery
..
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2213
To unsubscribe, visit htt
Maor Lipchuk has posted comments on this change.
Change subject: core: Optional filtering for GetVdsGroupByIdQuery
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2190
T
Maor Lipchuk has posted comments on this change.
Change subject: core: Added Optional Filtering for VdsGroupDAO
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2189
To unsubscribe, visit htt
Maor Lipchuk has posted comments on this change.
Change subject: core: Cleanup VdsGroupDAO implementations
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2188
To unsubs
Maor Lipchuk has posted comments on this change.
Change subject: core: Cleanup GetVdsGroupByIdQuery
..
Patch Set 8: Looks good to me, approved
(1 inline comment)
Please see inline comment
.
Maor Lipchuk has posted comments on this change.
Change subject: core: Fixed VdsGroupTest
..
Patch Set 8: Looks good to me, but someone else must approve
(1 inline comment)
Maor Lipchuk has posted comments on this change.
Change subject: core: Optional filtering for GetVdsByVdsIdQuery
..
Patch Set 9: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2148
To
Maor Lipchuk has posted comments on this change.
Change subject: core: Optional filtering for VdsDAO.get
..
Patch Set 9: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2147
To unsubscr
Maor Lipchuk has posted comments on this change.
Change subject: core: Cleanup GetVdsByVdsIdQuery
..
Patch Set 9: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2145
To unsubscribe, visit http://gerrit.ovi
Maor Lipchuk has posted comments on this change.
Change subject: core: Filtering for GetStorageDomainByIdQuery
..
Patch Set 9: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2144
To un
Maor Lipchuk has posted comments on this change.
Change subject: core: Cleanup GetUserVmsByUserIdAndGroupsQuery
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2324
To unsubscribe, visit htt
Maor Lipchuk has posted comments on this change.
Change subject: core: Filter GetUserBySessionIdQuery
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2251
To unsubscribe
Eli Mesika has posted comments on this change.
Change subject: core : VmDeviceUtils fixes
..
--
To view, visit http://gerrit.ovirt.org/2330
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Ge
Moti Asayag has posted comments on this change.
Change subject: core : VmDeviceUtils fixes
..
Patch Set 1: (13 inline comments)
File
backend/manager/modules/bll/src/main/jav
Moti Asayag has posted comments on this change.
Change subject: core : UpdateVmCommand fix
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2331
To unsubscribe, visit htt
Moti Asayag has posted comments on this change.
Change subject: core: adding num of monitors to VmBase
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2327
To unsubscribe, visit http://gerri
Moti Asayag has posted comments on this change.
Change subject: core : VmDeviceUtils fixes
..
Patch Set 2: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/2330
To unsubscribe, visit http://g
Eli Mesika has posted comments on this change.
Change subject: core : UpdateVmCommand fix
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/bll/src/main/java/o
1 - 100 of 269 matches
Mail list logo
