Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Added internal param to create snapshot params
..
core: Added internal param to create snapshot params
Snapshot type is needed for internal use,
Yair Zaslavsky has posted comments on this change.
Change subject: core: Added internal param to create snapshot params
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2047
To unsu
Mike Kolesnik has posted comments on this change.
Change subject: engine-core: [autorecovery] add column to db
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2010
To un
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Exctract VM network management code
..
core: Exctract VM network management code
Extracted code that is used for add/remove of VmNetworkInterface
Mike Kolesnik has posted comments on this change.
Change subject: core: Exctract VM network management code
..
Patch Set 6: Verified; Looks good to me, approved
Rebased, already acked by yzaslavs
--
To view, visit http://gerri
Livnat Peer has posted comments on this change.
Change subject: engine: Add consume quota permission to add Tempalte
..
Patch Set 6: (1 inline comment)
File
backend/manager/
Livnat Peer has posted comments on this change.
Change subject: engine: Add permission support for Quota consume
..
Patch Set 6: (3 inline comments)
>From this patch it is not obvious why you need addQuotaPermissionSubject both
Yair Zaslavsky has posted comments on this change.
Change subject: core: Added internal param to create snapshot params
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2047
To unsu
Yair Zaslavsky has posted comments on this change.
Change subject: core: Exctract VM network management code
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1969
To unsubscribe, vi
Jonathan Choate has posted comments on this change.
Change subject: engine-core: Fixing AddVmCommand (Review Only)
..
Patch Set 1: (3 inline comments)
File
backend/manager/m
Jonathan Choate has posted comments on this change.
Change subject: engine-core: Fixing AddVmTemplateCommand for multiple storage
domains
..
Patch Set 2: (2 inline comments)
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add Quota canDoActionErrors
..
Patch Set 6:
rebase
--
To view, visit http://gerrit.ovirt.org/2080
To unsubscribe, visit http://gerrit.ovirt.org/settings
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add default quota indication field
..
Patch Set 4:
Adding is_default_quota to update sp
--
To view, visit http://gerrit.ovirt.org/2075
To unsubscribe, vi
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: dal: Removing DiskImageTemplateDAO from DAL
..
core: dal: Removing DiskImageTemplateDAO from DAL
Change-Id: I97d362095ec9af12041ea1ff3d4a33bbc5
Yair Zaslavsky has posted comments on this change.
Change subject: core: dal: Removing DiskImageTemplateDAO from DAL
..
Patch Set 21: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1572
To unsub
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: common: Removing DiskImageTemplate entity
..
core: common: Removing DiskImageTemplate entity
Change-Id: I31d5ba8badd3510ac71b7de5581673d9582a13d7
Yair Zaslavsky has posted comments on this change.
Change subject: core: common: Removing DiskImageTemplate entity
..
Patch Set 21: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1571
To unsubscr
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Using DiskImage instead of DiskImage template
..
core: Using DiskImage instead of DiskImage template
The changes in general are as follows:
1. Us
Yair Zaslavsky has posted comments on this change.
Change subject: core: Using DiskImage instead of DiskImage template
..
Patch Set 21: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1570
To unsu
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: dao removing of DiskImageTemplate
..
core: dao removing of DiskImageTemplate
This patch removes DiskImageTemplate usage
from DAL
Change-Id: I977
Yair Zaslavsky has posted comments on this change.
Change subject: core: dao removing of DiskImageTemplate
..
Patch Set 17: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1568
To unsubscribe, vis
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fixing DB conf (and conf test) files
..
core: Fixing DB conf (and conf test) files
Fixing DB engine-daos.properties and
fixtures.xml files to ref
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fixing DB conf (and conf test) files
..
Patch Set 17: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1567
To unsubscribe,
Yair Zaslavsky has posted comments on this change.
Change subject: common: Fixing entities to reflect removal of DiskImageTemplate
..
--
To view, visit http://gerrit.ovirt.org/1569
To unsubscribe, visit http://gerrit.ovirt.org
Yair Zaslavsky has submitted this change and it was merged.
Change subject: common: Fixing entities to reflect removal of DiskImageTemplate
..
common: Fixing entities to reflect removal of DiskImageTemplate
VmTemplate holds now
Yair Zaslavsky has posted comments on this change.
Change subject: common: Fixing entities to reflect removal of DiskImageTemplate
..
Patch Set 17: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/
Yair Zaslavsky has posted comments on this change.
Change subject: common: introducing VmEntityType
..
Patch Set 12: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1882
To unsubscribe, visit http
Yair Zaslavsky has submitted this change and it was merged.
Change subject: common: introducing VmEntityType
..
common: introducing VmEntityType
This enum will help destinguish between entities if they
are associated with VM or
Yair Zaslavsky has posted comments on this change.
Change subject: webadmin: Changes in webadmin
..
Patch Set 17: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1566
To unsubscribe, visit http://
Yair Zaslavsky has submitted this change and it was merged.
Change subject: webadmin: Changes in webadmin
..
webadmin: Changes in webadmin
This patch removes refence to DiskImageTeplated from
SharedGwt.gwt.xl and introduces the
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: db scripts for removing disk image template
..
core: db scripts for removing disk image template
Patch in order to remove template_images (which
Yair Zaslavsky has posted comments on this change.
Change subject: core: db scripts for removing disk image template
..
Patch Set 16: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1565
To unsubs
Omer Frenkel has posted comments on this change.
Change subject: engine: Add default quota indication field
..
Patch Set 3:
missing change to update quota stored procedure
--
To view, visit http://gerrit.ovirt.org/2075
To unsu
Danny Rankevich has submitted this change and it was merged.
Change subject: webadmin: integrating reports to webadmin (commnets fixes)
..
webadmin: integrating reports to webadmin (commnets fixes)
no bz
- Getting Reports.xml
Danny Rankevich has posted comments on this change.
Change subject: webadmin: integrating reports to webadmin (commnets fixes)
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1952
Omer Frenkel has posted comments on this change.
Change subject: engine: Add permission support for Quota consume
..
Patch Set 5: (2 inline comments)
File
backend/manager/mo
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Tab UI reuse concept
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2120
To unsubscribe, vis
Alona Kaplan has posted comments on this change.
Change subject: reports: added reports directory xml
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2125
To u
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add permission support for Quota consume
..
Patch Set 5:
changed action to actionGroup
Removed the use of quota consume and add a helper method in the quo
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Filtering for StorageDoaminDAO.get
..
core: Filtering for StorageDoaminDAO.get
Added optional permission filtering to the get(Guid) method and the
Ofer Schreiber has posted comments on this change.
Change subject: packaging: add controller class (plugins step 3/3)
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/1867
To unsubscribe, visit http://gerrit.o
Allon Mureinik has posted comments on this change.
Change subject: core: Filtering for StorageDoaminDAO.get
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/2128
To unsubscribe, visit http://gerrit.ovirt.org/s
Mike Kolesnik has posted comments on this change.
Change subject: core: Filtering for StorageDoaminDAO.get
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2128
To unsubscribe, visit http://g
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Cleanup GetStorageDomainByIdQuery
..
core: Cleanup GetStorageDomainByIdQuery
Cleaned up * imports using Eclipse IDE.
Change-Id: I38a3ea417b7671e2
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Filter GetStorageDomainsByStoragePoolIdQuery
..
core: Filter GetStorageDomainsByStoragePoolIdQuery
Added optional permission filtering to
GetStora
Allon Mureinik has posted comments on this change.
Change subject: core: Filter GetStorageDomainsByStoragePoolIdQuery
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/2117
To unsubscribe, visit http://gerrit.o
Mike Kolesnik has posted comments on this change.
Change subject: core: Cleanup GetStorageDomainByIdQuery
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2118
To unsubscribe, visit http://ge
Mike Kolesnik has posted comments on this change.
Change subject: core: Filter GetStorageDomainsByStoragePoolIdQuery
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2117
To unsubscribe, visi
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Ffiltering for StorageDomainDAO
..
core: Ffiltering for StorageDomainDAO
Added optional permission filtering for
StorageDomainDAO.getAllForStorage
Mike Kolesnik has posted comments on this change.
Change subject: core: Ffiltering for StorageDomainDAO
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2116
To unsubscribe, visit http://gerr
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Cleanup StorageDoaminDAO's implementations
..
core: Cleanup StorageDoaminDAO's implementations
Cleaned up warnings (mostly missplaced @SuppressWar
Mike Kolesnik has posted comments on this change.
Change subject: core: Cleanup StorageDoaminDAO's implementations
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2062
To unsubscribe, visit
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Clean GetStorageDomainsByStoragePoolIdQuery
..
core: Clean GetStorageDomainsByStoragePoolIdQuery
Replace * imports with specific imports with Ecli
Mike Kolesnik has posted comments on this change.
Change subject: core: Clean GetStorageDomainsByStoragePoolIdQuery
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2061
To unsubscribe, visit
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Added filtering to GetStoragePoolByIdQuery
..
core: Added filtering to GetStoragePoolByIdQuery
Added optional filtering according to user permissi
Mike Kolesnik has posted comments on this change.
Change subject: core: Added filtering to GetStoragePoolByIdQuery
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2046
To unsubscribe, visit
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Add filtering to StoragePoolDAO
..
core: Add filtering to StoragePoolDAO
Added optional permissions filtering to StoragePoolDAO and undelying
stor
Mike Kolesnik has posted comments on this change.
Change subject: core: Add filtering to StoragePoolDAO
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2045
To unsubscribe, visit http://gerr
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Cleanup StoragePoolDAO implementations
..
core: Cleanup StoragePoolDAO implementations
Cleanup warnings, dead code pieces
Change-Id: I92c157aec04
Mike Kolesnik has posted comments on this change.
Change subject: core: Cleanup StoragePoolDAO implementations
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2044
To unsubscribe, visit http
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Cleanup GetStoragePoolByIdQuery
..
core: Cleanup GetStoragePoolByIdQuery
Remove wildcard imports.
Change-Id: Iddf1f8ac84ee4c3e6c8596d17c8110cf400
Mike Kolesnik has posted comments on this change.
Change subject: core: Cleanup GetStoragePoolByIdQuery
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2043
To unsubscribe, visit http://gerr
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Filtering GetAllNetworksByClusterIdQuery
..
core: Filtering GetAllNetworksByClusterIdQuery
Refactored GetAllNetworksByClusterIdQuery to use new AP
Mike Kolesnik has posted comments on this change.
Change subject: core: Filtering GetAllNetworksByClusterIdQuery
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2042
To unsubscribe, visit ht
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Add optional filtering to NetworkDAO
..
core: Add optional filtering to NetworkDAO
Filtering was added to the DAO's API and the stored procedure t
Mike Kolesnik has posted comments on this change.
Change subject: core: Add optional filtering to NetworkDAO
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2041
To unsubscribe, visit http:/
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Fix typos in NetworkDAOTest
..
core: Fix typos in NetworkDAOTest
Change-Id: Ib1f4f3210d3c7be71832375feeb1b7188a848e22
---
M
backend/manager/modul
Mike Kolesnik has posted comments on this change.
Change subject: core: Fix typos in NetworkDAOTest
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2040
To unsubscribe, visit http://gerrit.o
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Cleanup GetAllNetworkByClusterId
..
core: Cleanup GetAllNetworkByClusterId
Changed query to select all the fields of network_cluster instead of
th
Mike Kolesnik has posted comments on this change.
Change subject: core: Cleanup GetAllNetworkByClusterId
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2039
To unsubscribe, visit http://ger
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Cleanup warnings on NetworkDAODbFacadeImpl
..
core: Cleanup warnings on NetworkDAODbFacadeImpl
Removed useless @SupressWarning("unchecked"), empty
Mike Kolesnik has posted comments on this change.
Change subject: core: Cleanup warnings on NetworkDAODbFacadeImpl
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2038
To unsubscribe, visit
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Imports for GetAllNetworksByClusterIdQuery
..
core: Imports for GetAllNetworksByClusterIdQuery
Cleaned up the * improts using Eclipse IDE's automa
Mike Kolesnik has posted comments on this change.
Change subject: core: Imports for GetAllNetworksByClusterIdQuery
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2037
To unsubscribe, visit
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Move user ID constants to BaseDAOTestCase
..
core: Move user ID constants to BaseDAOTestCase
Constants were pulled up so they could be used by tes
Mike Kolesnik has posted comments on this change.
Change subject: core: Move user ID constants to BaseDAOTestCase
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2036
To unsubscribe, visit h
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Filtering for GetAllVmSnapshotsByDriveQuery
..
core: Filtering for GetAllVmSnapshotsByDriveQuery
Permission filtering according to the user who is
Mike Kolesnik has posted comments on this change.
Change subject: core: Filtering for GetAllVmSnapshotsByDriveQuery
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1993
To unsubscribe, visit
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Refactoring GetAllVmSnapshotsByDriveQuery
..
core: Refactoring GetAllVmSnapshotsByDriveQuery
Call DiskImageDAO directly and then feed the results
Mike Kolesnik has posted comments on this change.
Change subject: core: Refactoring GetAllVmSnapshotsByDriveQuery
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1992
To unsubscribe, visit h
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Cleanup GetAllVmSnapshotsByDriveQuery
..
core: Cleanup GetAllVmSnapshotsByDriveQuery
removed useless logger, suppressed warnings that we're prepar
Mike Kolesnik has posted comments on this change.
Change subject: core: Cleanup GetAllVmSnapshotsByDriveQuery
..
Patch Set 10: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1910
To unsubscribe, visit http
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Permissions for GetAllDisksByVmIdQuery
..
core: Permissions for GetAllDisksByVmIdQuery
Use the permission filtering API in GetAllDisksByVmIdQuery.
Mike Kolesnik has posted comments on this change.
Change subject: core: Permissions for GetAllDisksByVmIdQuery
..
Patch Set 14: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1872
To unsubscribe, visit htt
Yaniv Dary has posted comments on this change.
Change subject: reports: added reports directory xml
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2125
To uns
Yaniv Dary has posted comments on this change.
Change subject: reports: changed dates order to desc
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2126
To uns
Yair Zaslavsky has posted comments on this change.
Change subject: core: DO NOT SUBMIT dal: Removing DiskImageTemplateDAO from
DAL
..
Patch Set 19:
Mike - following your last comment - it was ineeded removed from
engine-dao
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Add filtering to VmDeviceDAO
..
core: Add filtering to VmDeviceDAO
Added overloaded versions of required methods with filtering
parameters, and th
Mike Kolesnik has posted comments on this change.
Change subject: core: Add filtering to VmDeviceDAO
..
Patch Set 16: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1845
To unsubscribe, visit http://gerrit
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Added filtering option to DiskImageDAO
..
core: Added filtering option to DiskImageDAO
Overloaded DiskImageDAO.getAllForVM with filtering paramete
Mike Kolesnik has posted comments on this change.
Change subject: core: Added filtering option to DiskImageDAO
..
Patch Set 17: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1841
To unsubscribe, visit htt
Mike Kolesnik has posted comments on this change.
Change subject: core: DO NOT SUBMIT dal: Removing DiskImageTemplateDAO from
DAL
..
Patch Set 19:
Don't you need to remove it from the DAOs properties file also?
--
To view,
Mike Kolesnik has posted comments on this change.
Change subject: core: DO NOT SUBMIT common: Removing DiskImageTemplate entity
..
Patch Set 19: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1571
To unsub
Mike Kolesnik has posted comments on this change.
Change subject: core: DO NOT SUBMIT BLL: Using DiskImage instead of DiskImage
template
..
Patch Set 19: (1 inline comment)
Mike Kolesnik has posted comments on this change.
Change subject: core: DO NOT SUBMIT DAL: removing of DiskImageTemplate
..
Patch Set 15: (1 inline comment)
File
backend/man
Mike Kolesnik has posted comments on this change.
Change subject: core: DO NOT SUBMIT Fixing DB conf (and conf test) files
..
Patch Set 15: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1567
To unsubscrib
Mike Kolesnik has posted comments on this change.
Change subject: common: DO NOT SUBMIT Fixing entities to reflect removal of
DiskImageTemplate
..
Patch Set 15: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.
Mike Kolesnik has posted comments on this change.
Change subject: common: DO NOT SUBMIT common introducing VmEntityType
..
Patch Set 10: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1882
To unsubscribe,
Mike Kolesnik has posted comments on this change.
Change subject: core: DO NOT SUBMIT db scripts for removing disk image template
..
Patch Set 15: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1565
To uns
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup GetStorageDomainByIdQuery
..
Patch Set 3: Verified
no changes since mkolesni's approval - just a rebase.
--
To view, visit http://gerrit.ovirt.or
1 - 100 of 270 matches
Mail list logo
