Yair Zaslavsky has posted comments on this change.
Change subject: engine-core: adding ensureDomainMap to ImportVmTemplateCommand
..
Patch Set 1: Verified
The code looks fine (I also tested it myself, after all :) ).
I have a q
Roy Golan has abandoned this change.
Change subject: engine-core: Add support for async calls to VDSM
..
Patch Set 1: Abandoned
a different solution has been posted
--
To view, visit http://gerrit.ovirt.org/1361
To unsubscribe
Maor Lipchuk has uploaded a new change for review.
Change subject: engine: Add audit log messages
..
engine: Add audit log messages
Change-Id: Ib0a9fba6b4d061ddd0df524517f0d298877f432f
---
M
backend/manager/modules/common/src/m
Maor Lipchuk has uploaded a new change for review.
Change subject: engine: Add audit log messages to CRUD commands.
..
engine: Add audit log messages to CRUD commands.
Change-Id: I677aab915c3aba11f1e895db9ad6a6c8cf77b9a1
---
M
Maor Lipchuk has uploaded a new change for review.
Change subject: engine: Add quota manager
..
engine: Add quota manager
In the next patch I introduced quota manager.
Quota manager is responsible for validating operation which
Maor Lipchuk has uploaded a new change for review.
Change subject: engine: Adding fix to quota stored procedure
..
engine: Adding fix to quota stored procedure
In the next patch I changed the stored procedure to retrieve quota
l
Maor Lipchuk has uploaded a new change for review.
Change subject: engine: Add quota validation to commands
..
engine: Add quota validation to commands
The next patch adds the use of quota validation (using QuotaManager),
when r
Maor Lipchuk has uploaded a new change for review.
Change subject: engine: Add quota CRUD commands to vdcActionType
..
engine: Add quota CRUD commands to vdcActionType
Adding the CRUD commands of quota to VdcObjectType, to be ca
Maor Lipchuk has uploaded a new change for review.
Change subject: Adding get Quota by storage pool Id
..
Adding get Quota by storage pool Id
Change-Id: I90dea961e80cb2f1a7288bf01a832e5c09fe184a
---
M
backend/manager/modules/da
Yair Zaslavsky has posted comments on this change.
Change subject: core: Views for handling query permissions
..
Patch Set 5: I would prefer that you didn't submit this
Trailing whitespaces, please remove them.
--
To view, vis
Yair Zaslavsky has posted comments on this change.
Change subject: compat: notify of removed/added elements on Observable List
changes
..
Patch Set 1:
Danny,
Why are we inserting more code to compat? (backend side) - we're try
Yair Zaslavsky has posted comments on this change.
Change subject: core: [DO NOT SUBMIT] Task Manager Queries
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1742
To uns
Jonathan Choate has posted comments on this change.
Change subject: engine-core: Copy Disk Command
..
Patch Set 7:
Changes were necessary due to NPE fix commit
--
To view, visit http://gerrit.ovirt.org/1628
To unsubscribe, vis
Jonathan Choate has posted comments on this change.
Change subject: engine-core: Move disk command
..
Patch Set 8:
Changes were necessary due to NPE fix commit
--
To view, visit http://gerrit.ovirt.org/1608
To unsubscribe, vis
Jonathan Choate has uploaded a new change for review.
Change subject: engine-core: adding ensureDomainMap to ImportVmTemplateCommand
..
engine-core: adding ensureDomainMap to ImportVmTemplateCommand
Part of fixing the NPE. Also
Moti Asayag has uploaded a new change for review.
Change subject: core: [DO NOT SUBMIT] Task Manager Queries
..
core: [DO NOT SUBMIT] Task Manager Queries
The patch adds the Queries for Job entities retrieval.
The patch will be
Alan Pevec has posted comments on this change.
Change subject: packaging: add sequences to engine-setup (plugins step 2/3)
..
Patch Set 3:
some whitespace errors, have a look in gerrit
--
To view, visit http://gerrit.ovirt.org
Alan Pevec has posted comments on this change.
Change subject: packaging: add sequences to engine-setup (plugins step 2/3)
..
Patch Set 3: (2 inline comments)
File packaging/
Moti Asayag has submitted this change and it was merged.
Change subject: core: Task Manager Add Jobs handling on server startup
..
core: Task Manager Add Jobs handling on server startup
The patch handles uncompleted Jobs on ser
Moti Asayag has posted comments on this change.
Change subject: core: Task Manager Add Jobs handling on server startup
..
Patch Set 8: Verified; Looks good to me, approved
Acked by Livnat Peer
--
To view, visit http://gerrit.o
Moti Asayag has submitted this change and it was merged.
Change subject: core: Task Manager Add JobRepositoryFactory
..
core: Task Manager Add JobRepositoryFactory
Adds a factory to initialize the JobRepository.
Change-Id: Ie3
Moti Asayag has posted comments on this change.
Change subject: core: Task Manager Add JobRepositoryFactory
..
Patch Set 9: Verified; Looks good to me, approved
Acked by Livnat Peer
--
To view, visit http://gerrit.ovirt.org/10
Moti Asayag has submitted this change and it was merged.
Change subject: core: Task Manager Add JobRepository
..
core: Task Manager Add JobRepository
The patch adds the JobRepository interface and its implementation,
responsibl
Moti Asayag has posted comments on this change.
Change subject: core: Task Manager Add JobRepository
..
Patch Set 6: Verified; Looks good to me, approved
Acked by Livnat Peer
--
To view, visit http://gerrit.ovirt.org/1236
To u
Jonathan Choate has posted comments on this change.
Change subject: engine-core: Copy Disk Command
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1628
To unsubscribe, visit http:/
Jonathan Choate has posted comments on this change.
Change subject: engine-core: Move disk command
..
Patch Set 7:
at the request of the UI, added storage domain name to DiskImage object and
updated views and DAOs to populate
Daniel Erez has posted comments on this change.
Change subject: compat: notify of removed/added elements on Observable List
changes
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Detail (sub-tab) support for side-tabs
..
Patch Set 1:
Note: when you select VM side-tab within Extended main tab, initially all VM
table action but
Vojtech Szocs has uploaded a new change for review.
Change subject: userportal: Detail (sub-tab) support for side-tabs
..
userportal: Detail (sub-tab) support for side-tabs
This patch adds some general GWTP-related infrastructur
Vojtech Szocs has uploaded a new change for review.
Change subject: userportal: UiCommon model activation upon tab selection
..
userportal: UiCommon model activation upon tab selection
1. Added base presenter for UiCommon list m
Vojtech Szocs has submitted this change and it was merged.
Change subject: userportal: VM side-tab table initial implementation
..
userportal: VM side-tab table initial implementation
Summary of changes:
1. Added necessary wid
Vojtech Szocs has posted comments on this change.
Change subject: userportal: VM side-tab table initial implementation
..
Patch Set 2: Verified; Looks good to me, approved
Rebased and verified. Updated according to changes intr
Livnat Peer has posted comments on this change.
Change subject: core: Task Manager Support monitoring of VDSM tasks
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1094
To unsubscribe, visit
Livnat Peer has posted comments on this change.
Change subject: core: Task Manager Add Job Support to Multiple Action
..
Patch Set 7: Looks good to me, approved
(1 inline comment)
..
Michael Kublin has posted comments on this change.
Change subject: engine-core: Copy Disk Command
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1628
To unsubscribe, visit http://gerrit.ovi
Livnat Peer has posted comments on this change.
Change subject: core: Task Manager VDSM tasks monitoring - cont.
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1237
To unsubscribe, visit ht
Michael Kublin has posted comments on this change.
Change subject: engine-core: Move disk command
..
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1608
To unsubscribe, visit http://gerrit.ovi
Jonathan Choate has posted comments on this change.
Change subject: engine-core: Copy Disk Command
..
Patch Set 4: (1 inline comment)
File
backend/manager/modules/common/src
Livnat Peer has posted comments on this change.
Change subject: core: Task Manager Define Actions as Non-Monitored
..
Patch Set 7: Looks good to me, approved
(1 inline comment)
.
Livnat Peer has posted comments on this change.
Change subject: core: Modify commands invocation with compansation context
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1710
To unsubscribe
Livnat Peer has posted comments on this change.
Change subject: core: Modify internal backend API to use CommandContext
..
Patch Set 1: Looks good to me, approved
(1 inline comment)
This patch requires a follow upto encapsulat
Michael Kublin has posted comments on this change.
Change subject: engine-core: Copy Disk Command
..
Patch Set 4: (1 inline comment)
File
backend/manager/modules/common/src/
Michael Kublin has posted comments on this change.
Change subject: engine-core: Move disk command
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1608
To unsubscribe, visit http://gerrit.ovi
Livnat Peer has posted comments on this change.
Change subject: core: Add ExecutionMessageDirector for job messages
..
Patch Set 2: Looks good to me, approved
I agree with Kublin's comment, please fix them before pushing.
--
T
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine-core: fixing NPE in import VM command
..
engine-core: fixing NPE in import VM command
Fixing the NPE when checking disk space on storage domains
Yair Zaslavsky has posted comments on this change.
Change subject: engine-core: fixing NPE in import VM command
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1731
To unsubscribe,
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine-core: fixing NPE in ImportVmTemplateCommand
..
engine-core: fixing NPE in ImportVmTemplateCommand
This is not the ideal fix but until it is work
Yair Zaslavsky has posted comments on this change.
Change subject: engine-core: fixing NPE in ImportVmTemplateCommand
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1688
To unsubs
Yair Zaslavsky has posted comments on this change.
Change subject: engine-core: fixing NPE in ImportVmTemplateCommand
..
--
To view, visit http://gerrit.ovirt.org/1688
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ge
Livnat Peer has posted comments on this change.
Change subject: core: Task Manager Add Jobs handling on server startup
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1087
To unsubscribe, vi
Livnat Peer has posted comments on this change.
Change subject: core: Task Manager Add JobRepositoryFactory
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1088
To unsubscribe, visit http://
Livnat Peer has posted comments on this change.
Change subject: core: Task Manager Add JobRepository
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1236
To unsubscribe, visit http://gerrit.
Jonathan Choate has posted comments on this change.
Change subject: engine-core: Move disk command
..
Patch Set 4: (1 inline comment)
File
backend/manager/modules/common/src
Michael Kublin has posted comments on this change.
Change subject: engine-core: Move disk command
..
Patch Set 4: (1 inline comment)
File
backend/manager/modules/common/src/
Omer Frenkel has posted comments on this change.
Change subject: engine-core: Uniting 2 Commands (Review Only)
..
Patch Set 2: (3 inline comments)
File
backend/manager/modul
Omer Frenkel has posted comments on this change.
Change subject: [DO NOT SUBMIT!] core: Simplify RemoveSnapshot command to get id
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1130
To unsu
Omer Frenkel has posted comments on this change.
Change subject: [DO NOT SUBMIT!] core: Cleanup of parameters - remove the JAXB
annotations
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1
Jonathan Choate has uploaded a new change for review.
Change subject: engine-core: fixing NPE in import templagte command
..
engine-core: fixing NPE in import templagte command
Fixing the NPE when checking disk space on storage
Alex Lourie has posted comments on this change.
Change subject: packaging: add sequences to engine-setup (plugins step 2/3)
..
Patch Set 4: (2 inline comments)
Please review comments.
..
Omer Frenkel has posted comments on this change.
Change subject: [DO NOT SUBMIT!] core: Rename audit log & can do action messages
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1128
To unsu
Michael Pasternak has posted comments on this change.
Change subject: rest-api: exposing setupnetworks action under
/api/hosts/{id}/nics
..
Patch Set 6: (7 inline comments)
Ronen Angluster has posted comments on this change.
Change subject: packaging: copy engine-encryptutils.jar
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/173
Omer Frenkel has posted comments on this change.
Change subject: [DO NOT SUBMIT!] core: Rename MergeSnapshot to RemoveSnapshot
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1127
To unsubsc
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: Rename engine war to ovirtengine
..
packaging: Rename engine war to ovirtengine
Rename engineager.war to ovirtengine.war according to
6ce392
Ofer Schreiber has posted comments on this change.
Change subject: packaging: Rename engine war to ovirtengine
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1729
To unsubscribe, visit http
Ronen Angluster has posted comments on this change.
Change subject: packaging: Rename engine war to ovirtengine
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
Michael Kublin has submitted this change and it was merged.
Change subject: core: use new SessionDataContainer.getUser()
..
core: use new SessionDataContainer.getUser()
Refactor all the usages io getData("VdcUser") to the new
g
Michael Kublin has posted comments on this change.
Change subject: core: use new SessionDataContainer.getUser()
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1724
To unsubscribe,
Michael Kublin has submitted this change and it was merged.
Change subject: core: SessionDataContainer: add getUser method
..
core: SessionDataContainer: add getUser method
SessionDataContainer is used to store the current user
Michael Kublin has posted comments on this change.
Change subject: core: SessionDataContainer: add getUser method
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1723
To unsubscrib
Michael Kublin has posted comments on this change.
Change subject: core: Cleanup CustomMapSqlParameterSource
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1706
To unsubscribe, vi
Michael Kublin has submitted this change and it was merged.
Change subject: core: Cleanup CustomMapSqlParameterSource
..
core: Cleanup CustomMapSqlParameterSource
Remvoed warnings detected by Eclipse IDE.
Added test suite to pr
Michael Kublin has posted comments on this change.
Change subject: engine-core: Adding non-blocking VDSM api
..
Patch Set 2: (9 inline comments)
File
backend/manager/modules
Roy Golan has uploaded a new change for review.
Change subject: packaging: copy engine-encryptutils.jar
..
packaging: copy engine-encryptutils.jar
Change-Id: I878617a469275e203fd62ad35de4926c0ad3c085
---
M Makefile
1 file change
Ofer Schreiber has posted comments on this change.
Change subject: packaging: Rename engine war to ovirtengine
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/1729
To unsubscribe, visit http://gerrit.ovirt.or
Ofer Schreiber has uploaded a new change for review.
Change subject: packaging: Rename engine war to ovirtengine
..
packaging: Rename engine war to ovirtengine
Rename engineager.war to ovirtengine.war according to
6ce3923824aab0
Roy Golan has posted comments on this change.
Change subject: rest-api: exposing setupnetworks action under
/api/hosts/{id}/nics
..
Patch Set 6:
added a fix for missing BootProtocol.None and fetch network by its ID
--
To view
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: Rename engine war to ovirtengine
..
packaging: Rename engine war to ovirtengine
Rename engineager.war to ovirtengine.war according to
6ce392
Ofer Schreiber has posted comments on this change.
Change subject: packaging: Rename engine war to ovirtengine
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1725
To unsubscribe,
Doron Fediuck has posted comments on this change.
Change subject: packaging: Rename engine war to ovirtengine
..
Patch Set 1: Verified; Looks good to me, approved
Should be verified using setup as well.
--
To view, visit http:
Michael Kublin has posted comments on this change.
Change subject: core: Task Manager Add JobRepository
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1236
To unsubscri
Moti Asayag has posted comments on this change.
Change subject: engine-core: clean and fix typos
..
Patch Set 9: (1 inline comment)
File
backend/manager/modules/bll/src/main
Roy Golan has uploaded a new change for review.
Change subject: engine-core: Adding non-blocking VDSM api
..
engine-core: Adding non-blocking VDSM api
Change-Id: I6d84e13fd075397a7152afee866b9767c72ca720
---
M
backend/manager/m
Ofer Schreiber has uploaded a new change for review.
Change subject: packaging: Rename engine war to ovirtengine
..
packaging: Rename engine war to ovirtengine
Rename engineager.war to ovirtengine.war according to
6ce3923824aab0
Moti Asayag has posted comments on this change.
Change subject: core: Task Manager Add Default Command Monitoring
..
Patch Set 7: (1 inline comment)
File
backend/manager/mod
Moti Asayag has posted comments on this change.
Change subject: core: Add ExecutionMessageDirector for job messages
..
Patch Set 2: (1 inline comment)
File
backend/manager/m
Michael Kublin has posted comments on this change.
Change subject: core: Cleanup CustomMapSqlParameterSource
..
--
To view, visit http://gerrit.ovirt.org/1706
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Mess
Michael Kublin has posted comments on this change.
Change subject: core: use new SessionDataContainer.getUser()
..
--
To view, visit http://gerrit.ovirt.org/1724
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-M
Michael Kublin has posted comments on this change.
Change subject: core: SessionDataContainer: add getUser method
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/1723
To unsubscribe, visit http://gerrit.ovirt
Michael Kublin has posted comments on this change.
Change subject: core: SessionDataContainer: add getUser method
..
--
To view, visit http://gerrit.ovirt.org/1723
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit
Michael Kublin has posted comments on this change.
Change subject: core: Task Manager Add Default Command Monitoring
..
Patch Set 7: (2 inline comments)
File
backend/manager
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup CustomMapSqlParameterSource
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/1706
To unsubscribe, visit http://gerrit.ovirt.org/
Michael Kublin has posted comments on this change.
Change subject: core: Cleanup CustomMapSqlParameterSource
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1706
To unsubscribe, visit http:/
Allon Mureinik has posted comments on this change.
Change subject: core: use new SessionDataContainer.getUser()
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/1724
To unsubscribe, visit http://gerrit.ovirt.o
Allon Mureinik has posted comments on this change.
Change subject: core: SessionDataContainer: add getUser method
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/1723
To unsubscribe, visit http://gerrit.ovirt
Michael Kublin has posted comments on this change.
Change subject: core: use new SessionDataContainer.getUser()
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1724
To unsubscribe, visit htt
Michael Kublin has posted comments on this change.
Change subject: core: SessionDataContainer: add getUser method
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1723
To unsubscribe, visit h
Michael Kublin has posted comments on this change.
Change subject: core : Added indication for plug/unplugged disk at
GetAllDisksByVmIdQuery
..
Patch Set 2: Verified; Looks good to me, approved
merging it
--
To view, visit ht
Michael Kublin has submitted this change and it was merged.
Change subject: core : Added indication for plug/unplugged disk at
GetAllDisksByVmIdQuery
..
core : Added indication for plug/unplugged disk at GetAllDisksByVmIdQuery
Doron Fediuck has posted comments on this change.
Change subject: VdsInstaller: drop netconsole code
..
Patch Set 3: Looks good to me, approved
Looks right, so ack on the code change.
In order to /verity/ it, please open a tic
1 - 100 of 146 matches
Mail list logo
