Shahar Havivi has posted comments on this change.
Change subject: backend: Allow duplicate MACs in the system
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/1587
To unsubscribe, visit http://gerrit.ovirt.org
Eli Mesika has uploaded a new change for review.
Change subject: core : Enabling NULL values for vm_device is_polugged column
..
core : Enabling NULL values for vm_device is_polugged column
is_plugged should be true for Disk/Int
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
ovirt_engine_dao_unit_tests - Build # 110 - Still Failing:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/110/console to view
the results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org
Moti Asayag has submitted this change and it was merged.
Change subject: core: Minor clean up of VDSStatus
..
core: Minor clean up of VDSStatus
Removed jaxb annotation and merged split line.
Change-Id: I7fa2a7163ad170f7186ce9f
Moti Asayag has posted comments on this change.
Change subject: core: Minor clean up of VDSStatus
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1617
To unsubscribe, visit http://
Roy Golan has posted comments on this change.
Change subject: core: Minor clean up of VDSStatus
..
--
To view, visit http://gerrit.ovirt.org/1617
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comm
Roy Golan has posted comments on this change.
Change subject: core: Minor clean up of VDSStatus
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1617
To unsubscribe, visit http://gerrit.ovirt
Michael Kublin has posted comments on this change.
Change subject: engine-core: Uniting 2 Commands (Review Only)
..
Patch Set 2: (7 inline comments)
File
backend/manager/mod
Dan Kenigsberg has posted comments on this change.
Change subject: VdsInstaller: drop netconsole code
..
Patch Set 3:
I'm just following orders.
--
To view, visit http://gerrit.ovirt.org/1689
To unsubscribe, visit http://gerri
Jaroslav Henner has posted comments on this change.
Change subject: sdk: Add HTTP request and response hooks.
..
Patch Set 3: (1 inline comment)
File src/ovirtsdk/infrastruct
Muli Salem has uploaded a new change for review.
Change subject: engine-core: Uniting 2 Commands (Review Only)
..
engine-core: Uniting 2 Commands (Review Only)
This patch unites the AttachUserToVmCommand with the
AttachUserToVmA
Yair Zaslavsky has posted comments on this change.
Change subject: core: DO NOT SUBMIT common: Fixing entities to reflect removal
of DiskImageTemplate
..
Patch Set 3: (1 inline comment)
Moti Asayag has uploaded a new change for review.
Change subject: core: Modify commands invocation with compansation context
..
core: Modify commands invocation with compansation context
The patch modifies invocation of commands
Moti Asayag has uploaded a new change for review.
Change subject: core: Modify internal backend API to use CommandContext
..
core: Modify internal backend API to use CommandContext
The patch modifies the internal backend API to
Moti Asayag has uploaded a new change for review.
Change subject: core: Introduce CommandContext class
..
core: Introduce CommandContext class
The CommandContext class encapsulates the context of command execution,
both for comp
Doron Fediuck has posted comments on this change.
Change subject: VdsInstaller: drop netconsole code
..
Patch Set 2:
Dan,
ConfigValues includes defaults to all keys we have in vdc_options.
Removing it only in the Java code and
ovirt_engine_dao_unit_tests - Build # 109 - Still Failing:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/109/console to view
the results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
Omer Frenkel has posted comments on this change.
Change subject: core: DO NOT SUBMIT common: Fixing entities to reflect removal
of DiskImageTemplate
..
Patch Set 3: (1 inline comment)
..
Yair Zaslavsky has posted comments on this change.
Change subject: core: DO NOT SUBMIT common: Fixing entities to reflect removal
of DiskImageTemplate
..
Patch Set 3: (1 inline comment)
Allon Mureinik has uploaded a new change for review.
Change subject: core: Cleanup CustomMapSqlParameterSource
..
core: Cleanup CustomMapSqlParameterSource
Remvoed warnings detected by Eclipse IDE.
Added test suite to prove that
Daniel Erez has posted comments on this change.
Change subject: engine-core: Move disk command
..
Patch Set 4: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1608
To unsubscr
Doron Fediuck has uploaded a new change for review.
Change subject: tools: restore notification service streams
..
tools: restore notification service streams
This is a manual revert to the fix done for Bug 737814.
The reason is
Omer Frenkel has posted comments on this change.
Change subject: core: DO NOT SUBMIT common: Fixing entities to reflect removal
of DiskImageTemplate
..
Patch Set 3: (2 inline comments)
.
Yair Zaslavsky has posted comments on this change.
Change subject: core: DO NOT SUBMIT db scripts for removing disk image template
..
Patch Set 3: (1 inline comment)
File
ba
Omer Frenkel has posted comments on this change.
Change subject: core: DO NOT SUBMIT DAL: removing of DiskImageTemplate
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1
Michael Kublin has submitted this change and it was merged.
Change subject: core : Fix default values of is_plugged property for devices
..
core : Fix default values of is_plugged property for devices
Disk & Interface should h
Michael Kublin has posted comments on this change.
Change subject: core : Fix default values of is_plugged property for devices
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1704
Michael Pasternak has posted comments on this change.
Change subject: sdk: Add HTTP request and response hooks.
..
Patch Set 3: Do not submit
(2 inline comments)
File src/ov
Omer Frenkel has posted comments on this change.
Change subject: core: DO NOT SUBMIT Fixing DB conf (and conf test) files
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
Eli Mesika has uploaded a new change for review.
Change subject: core : Fix default values of is_plugged property for devices
..
core : Fix default values of is_plugged property for devices
Disk & Interface should have is_plugg
Omer Frenkel has posted comments on this change.
Change subject: core: DO NOT SUBMIT db scripts for removing disk image template
..
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
..
ovirt_engine_dao_unit_tests - Build # 108 - Still Failing:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/108/console to view
the results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org
Omer Frenkel has posted comments on this change.
Change subject: engine-core: fixing NPE in ImportVmTemplateCommand
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1688
To unsubscribe, visit
Barak Azulay has posted comments on this change.
Change subject: packaging: classify params and groups (plugins step 1/3)
..
Patch Set 4: (3 inline comments)
please fix comments
Michael Kublin has submitted this change and it was merged.
Change subject: core: Cleanup warnings in CommandBase
..
core: Cleanup warnings in CommandBase
(Already approved by mkublin - resent due to merging issues, no code
cha
Michael Kublin has submitted this change and it was merged.
Change subject: core: Take 2: Prepration for query permissions
..
core: Take 2: Prepration for query permissions
Allowing typing of queries as admin/user and add runAs
Michael Kublin has submitted this change and it was merged.
Change subject: core: Clean up warnings on Backend
..
core: Clean up warnings on Backend
warnings were detected with Eclipse IDE's mechanism.
No logic changes - just a
Michael Kublin has submitted this change and it was merged.
Change subject: core: addUserTheadContext in SessionDataContainer
..
core: addUserTheadContext in SessionDataContainer
Move addUserToThreadContext from CommandBase to
Michael Kublin has submitted this change and it was merged.
Change subject: core: Cleanup to basic query classes
..
core: Cleanup to basic query classes
Answer review, clean up tests
(Already approved by mkublin - resent due t
Michael Kublin has submitted this change and it was merged.
Change subject: core: Test suite for SessionDataContainer
..
core: Test suite for SessionDataContainer
(Already approved by mkublin - resent due to merging issues, no
Michael Kublin has submitted this change and it was merged.
Change subject: core: Introduce notion of internal queries
..
core: Introduce notion of internal queries
currently, this is only a property (which can be set and queri
Michael Kublin has posted comments on this change.
Change subject: core: Take 2: Prepration for query permissions
..
Patch Set 9: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1272
To unsubscrib
Michael Kublin has posted comments on this change.
Change subject: core: Cleanup warnings in CommandBase
..
Patch Set 10: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1316
To unsubscribe, visit
Michael Kublin has posted comments on this change.
Change subject: core: addUserTheadContext in SessionDataContainer
..
Patch Set 11: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1317
To unsubs
Michael Kublin has posted comments on this change.
Change subject: core: Cleanup to basic query classes
..
Patch Set 11: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1293
To unsubscribe, visit
Michael Kublin has posted comments on this change.
Change subject: core: Clean up warnings on Backend
..
Patch Set 10: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1375
To unsubscribe, visit ht
Michael Kublin has posted comments on this change.
Change subject: core: Introduce notion of internal queries
..
Patch Set 9: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1386
To unsubscribe, visit http:
Michael Kublin has posted comments on this change.
Change subject: core: Introduce notion of internal queries
..
Patch Set 9: Verified
--
To view, visit http://gerrit.ovirt.org/1386
To unsubscribe, visit http://gerrit.ovirt.org
Michael Kublin has posted comments on this change.
Change subject: core: Test suite for SessionDataContainer
..
Patch Set 12: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1315
To unsubscribe, v
Omer Frenkel has posted comments on this change.
Change subject: core: Adding version dependant config values for version 3.1
..
Patch Set 2: (1 inline comment)
File
backend
Alona Kaplan has abandoned this change.
Change subject: webadmin: initial code for jasper dashboard
..
Patch Set 1: Abandoned
added to integrating reports commit
--
To view, visit http://gerrit.ovirt.org/1025
To unsubscribe, v
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: integarating report into webadmin
..
webadmin: integarating report into webadmin
no bz
Adding to webadmin the option to view jasper reports-
on dashbo
Jonathan Choate has posted comments on this change.
Change subject: engine-core: Copy Disk Command
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/common/src
Jonathan Choate has posted comments on this change.
Change subject: engine-core: Move disk command
..
Patch Set 3: (1 inline comment)
File
backend/manager/modules/common/src
Michael Kublin has posted comments on this change.
Change subject: core: Cleanup warnings in CommandBase
..
--
To view, visit http://gerrit.ovirt.org/1316
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageT
Michael Kublin has posted comments on this change.
Change subject: core: addUserTheadContext in SessionDataContainer
..
--
To view, visit http://gerrit.ovirt.org/1317
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ger
Michael Kublin has posted comments on this change.
Change subject: core: Cleanup to basic query classes
..
--
To view, visit http://gerrit.ovirt.org/1293
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageTy
Michael Kublin has posted comments on this change.
Change subject: core: Clean up warnings on Backend
..
Patch Set 9: Verified
--
To view, visit http://gerrit.ovirt.org/1375
To unsubscribe, visit http://gerrit.ovirt.org/setting
Michael Kublin has posted comments on this change.
Change subject: core: Introduce notion of internal queries
..
--
To view, visit http://gerrit.ovirt.org/1386
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Mes
Michael Kublin has posted comments on this change.
Change subject: core: Checking permissions when executing queries
..
Patch Set 8: Verified
--
To view, visit http://gerrit.ovirt.org/1585
To unsubscribe, visit http://gerrit.ov
Michael Kublin has posted comments on this change.
Change subject: core: Take 2: Prepration for query permissions
..
--
To view, visit http://gerrit.ovirt.org/1272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit
Allon Mureinik has posted comments on this change.
Change subject: core: Checking permissions when executing queries
..
Patch Set 8: Verified
--
To view, visit http://gerrit.ovirt.org/1585
To unsubscribe, visit http://gerrit.ov
Allon Mureinik has posted comments on this change.
Change subject: core: Introduce notion of internal queries
..
Patch Set 8: Verified; No score
--
To view, visit http://gerrit.ovirt.org/1386
To unsubscribe, visit http://gerrit
Allon Mureinik has posted comments on this change.
Change subject: core: Clean up warnings on Backend
..
Patch Set 9: Verified; No score
--
To view, visit http://gerrit.ovirt.org/1375
To unsubscribe, visit http://gerrit.ovirt.o
ovirt_engine_dao_unit_tests - Build # 107 - Failure:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/107/console to view
the results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailm
Allon Mureinik has posted comments on this change.
Change subject: core: addUserTheadContext in SessionDataContainer
..
Patch Set 10: Verified
--
To view, visit http://gerrit.ovirt.org/1317
To unsubscribe, visit http://gerrit.o
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup warnings in CommandBase
..
Patch Set 9: Verified
--
To view, visit http://gerrit.ovirt.org/1316
To unsubscribe, visit http://gerrit.ovirt.org/sett
Allon Mureinik has posted comments on this change.
Change subject: core: Test suite for SessionDataContainer
..
Patch Set 11: Verified
--
To view, visit http://gerrit.ovirt.org/1315
To unsubscribe, visit http://gerrit.ovirt.org
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup to basic query classes
..
Patch Set 10: Verified
--
To view, visit http://gerrit.ovirt.org/1293
To unsubscribe, visit http://gerrit.ovirt.org/sett
Allon Mureinik has posted comments on this change.
Change subject: core: Take 2: Prepration for query permissions
..
--
To view, visit http://gerrit.ovirt.org/1272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit
Allon Mureinik has posted comments on this change.
Change subject: core: Take 2: Prepration for query permissions
..
Patch Set 8: Verified
--
To view, visit http://gerrit.ovirt.org/1272
To unsubscribe, visit http://gerrit.ovirt
Omer Frenkel has posted comments on this change.
Change subject: [DO NOT SUBMIT!] core: Simplify RemoveSnapshot command to get id
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1130
To unsu
Yair Zaslavsky has posted comments on this change.
Change subject: engine-core: host with same name/address (#786104)
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1648
To unsubs
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine-core: host with same name/address (#786104)
..
engine-core: host with same name/address (#786104)
https://bugzilla.redhat.com/show_bug.cgi?id=78
Omer Frenkel has posted comments on this change.
Change subject: [DO NOT SUBMIT!] core: Cleanup of parameters - remove the JAXB
annotations
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1
Omer Frenkel has posted comments on this change.
Change subject: [DO NOT SUBMIT!] core: Rename audit log & can do action messages
..
Patch Set 2: (1 inline comment)
File
bac
Omer Frenkel has posted comments on this change.
Change subject: [DO NOT SUBMIT!] core: Rename MergeSnapshot to RemoveSnapshot
..
Patch Set 2: (2 inline comments)
File
backe
Michael Kublin has submitted this change and it was merged.
Change subject: engine : Hotplug feature - db scripts
..
engine : Hotplug feature - db scripts
The following commit will perform a needed changes at db level.
The chan
Michael Kublin has submitted this change and it was merged.
Change subject: Enginne : Hotplug feature - changes at api
..
Enginne : Hotplug feature - changes at api
The following changes are done in API, because of a new field
Michael Kublin has submitted this change and it was merged.
Change subject: engine : Hotplug - a new command added, main logic
..
engine : Hotplug - a new command added, main logic
The following patch caontains a new added comm
Michael Kublin has submitted this change and it was merged.
Change subject: engine : Hotplug - vdsbroker changes
..
engine : Hotplug - vdsbroker changes
This change is dine on vdsBroker level in order to allow an rpc call with
Michael Kublin has submitted this change and it was merged.
Change subject: Engine : Hotplug feature - error messages
..
Engine : Hotplug feature - error messages
The following patch contains a newally added error messages and
Michael Kublin has posted comments on this change.
Change subject: engine : Hotplug feature - db scripts
..
Patch Set 3: Verified; Looks good to me, approved
already acked, rebase
--
To view, visit http://gerrit.ovirt.org/1631
Michael Kublin has posted comments on this change.
Change subject: Engine : Hotplug feature - error messages
..
Patch Set 3: Verified; Looks good to me, approved
already acked, rebase
--
To view, visit http://gerrit.ovirt.org/
Michael Kublin has posted comments on this change.
Change subject: Enginne : Hotplug feature - changes at api
..
Patch Set 3: Verified; Looks good to me, approved
already acked, rebase
--
To view, visit http://gerrit.ovirt.org
Michael Kublin has posted comments on this change.
Change subject: engine : Hotplug - vdsbroker changes
..
Patch Set 3: Verified; Looks good to me, approved
already acked, rebase
--
To view, visit http://gerrit.ovirt.org/1634
Michael Kublin has posted comments on this change.
Change subject: engine : Hotplug - a new command added, main logic
..
Patch Set 4: Verified; Looks good to me, approved
already acked, rebase
--
To view, visit http://gerrit.o
ol...@redhat.com has uploaded a new change for review.
Change subject: restapi: Vm Start Time Displayed When Vm is Down
..
restapi: Vm Start Time Displayed When Vm is Down
Change-Id: Ide3aed65480d2cbfa2096d37a070c190ba637a94
---
Omer Frenkel has posted comments on this change.
Change subject: engine-core: host with same name/address (#786104)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1648
Michael Kublin has posted comments on this change.
Change subject: core: Checking permissions when executing queries
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1585
To unsubscribe, visi
Omer Frenkel has posted comments on this change.
Change subject: engine : Hotplug - a new command added, main logic
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1635
To unsubscribe, visit
Michael Kublin has posted comments on this change.
Change subject: core: Take 2: Prepration for query permissions
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1272
To unsubscribe, visit h
Omer Frenkel has posted comments on this change.
Change subject: engine : Hotplug - vdsbroker changes
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1634
To unsubscribe, visit http://gerrit
Omer Frenkel has posted comments on this change.
Change subject: Engine : Hotplug feature - error messages
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1632
To unsubscribe, visit http://g
Doron Fediuck has posted comments on this change.
Change subject: VdsInstaller: drop netconsole code
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Hi Dan, thanks.
This is still not ready to be s
Omer Frenkel has posted comments on this change.
Change subject: engine : Hotplug feature - db scripts
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1631
To unsubscribe, visit http://gerri
Omer Frenkel has posted comments on this change.
Change subject: engine : Hotplug - a new command added, main logic
..
Patch Set 2: (1 inline comment)
File
backend/manager/m
Michael Kublin has posted comments on this change.
Change subject: core: Clean up warnings on Backend
..
Patch Set 9: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1375
To unsubscribe, visit http://gerrit
1 - 100 of 153 matches
Mail list logo
