Moti Asayag has posted comments on this change.
Change subject: core: Task Manager Add business entities
..
Patch Set 5: (4 inline comments)
File
backend/manager/modules/com
Livnat Peer has posted comments on this change.
Change subject: core: Task Manager Add DAO objects
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1086
To unsubscribe, visit http://gerrit.ov
Livnat Peer has posted comments on this change.
Change subject: core: Task Manager Add ExecutionContext
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1235
To unsubscribe, visit http://gerr
Juan Hernandez has uploaded a new change for review.
Change subject: restapi: Remove Spring Framework (#NA)
..
restapi: Remove Spring Framework (#NA)
No bug.
Remove the dependency on the Spring Framework.
Change-Id: I3f27d3402
Livnat Peer has posted comments on this change.
Change subject: core: Task Manager Add business entities
..
Patch Set 5: (4 inline comments)
2 general comments for this patch -
1. I would use long instead of Date for the differ
Vojtech Szocs has submitted this change and it was merged.
Change subject: userportal: infrastructure and basic view
..
userportal: infrastructure and basic view
Includes:
- split panel with details and list view
- list view c
Vojtech Szocs has posted comments on this change.
Change subject: userportal: infrastructure and basic view
..
Patch Set 2: Verified; Looks good to me, approved
Included infrastructure changes from previous unmerged patches.
-
Maor Lipchuk has submitted this change and it was merged.
Change subject: engine: Remove transient keyword from quota entities
..
engine: Remove transient keyword from quota entities
In the next patch I removed transient keywor
Maor Lipchuk has posted comments on this change.
Change subject: engine: Remove transient keyword from quota entities
..
Patch Set 2: Verified; Looks good to me, approved
Already acked by Omer and Gilad
--
To view, visit http:
Maor Lipchuk has submitted this change and it was merged.
Change subject: engine: Add quota enforcement to quota entity
..
engine: Add quota enforcement to quota entity
The transient quota enforcement type to quota entity, for
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add quota enforcement to quota entity
..
Patch Set 3: Verified; Looks good to me, approved
Already acked by Omer and Gilad
--
To view, visit http://gerri
Omer Frenkel has posted comments on this change.
Change subject: engine-core: poll vds while setupnetwork is running
..
Patch Set 6: (1 inline comment)
File
backend/manager/
Omer Frenkel has posted comments on this change.
Change subject: engine-core: poll vds while setupnetwork is running
..
Patch Set 6: (1 inline comment)
File
backend/manager/
Omer Frenkel has posted comments on this change.
Change subject: engine-core: poll vds while setupnetwork is running
..
--
To view, visit http://gerrit.ovirt.org/880
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerr
Omer Frenkel has posted comments on this change.
Change subject: Revert "engine-core: log the host name when can't connect
(#766287)"
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1384
To
Omer Frenkel has posted comments on this change.
Change subject: engine: Add quota enforcement to quota entity
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1380
To unsubscribe, visit http
Gilad Chaplik has posted comments on this change.
Change subject: engine: Add quota enforcement to quota entity
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
Allon Mureinik has uploaded a new change for review.
Change subject: Introduce notion of internal queries
..
Introduce notion of internal queries
currently, this is only a property (which can be set and queried)
applied to a que
Ronen Angluster has posted comments on this change.
Change subject: packaging: fix engine-encryptutils.jar in Makefile
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ov
Roy Golan has uploaded a new change for review.
Change subject: packaging: fix engine-encryptutils.jar in Makefile
..
packaging: fix engine-encryptutils.jar in Makefile
Change-Id: I85bb6c938e194f51ae95c2ad1f22605eb817456d
---
M
Doron Fediuck has uploaded a new change for review.
Change subject: Revert "engine-core: log the host name when can't connect
(#766287)"
..
Revert "engine-core: log the host name when can't connect (#766287)"
This reverts commi
Ofer Schreiber has posted comments on this change.
Change subject: packaging: add userportal-gwtp.war to spec file
..
--
To view, visit http://gerrit.ovirt.org/1382
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerri
Ofer Schreiber has posted comments on this change.
Change subject: packaging: add userportal-gwtp.war to spec file
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1382
To unsubscri
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: Fix RHDS UPN query
..
engine: Fix RHDS UPN query
RHDS doesn't have the notion of UPN (User PrincipalName).
Thus, a new query formatter is added,
Oved Ourfali has posted comments on this change.
Change subject: engine: Fix RHDS UPN query
..
Patch Set 2: Verified; Looks good to me, approved
Based on previous ACK.
This patch only changes the comments to be in javadoc forma
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add quota enforcement to quota entity
..
Patch Set 2:
Remove transient keyword from business entities
--
To view, visit http://gerrit.ovirt.org/1380
To u
Maor Lipchuk has uploaded a new change for review.
Change subject: engine: Remove transient keyword from quota entities
..
engine: Remove transient keyword from quota entities
In the next patch I removed transient keyword from t
Roy Golan has posted comments on this change.
Change subject: engine: Fix RHDS UPN query
..
Patch Set 1: Looks good to me, approved
(2 inline comments)
minor comments
File
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add quota enforcement to quota entity
..
Patch Set 1:
Since that is what was decided in the design.
DC is referenced as quotable or not, GUI is counting o
Gilad Chaplik has posted comments on this change.
Change subject: engine: Add quota enforcement to quota entity
..
Patch Set 1:
not sure if transient field will be serializabled to client side.
--
To view, visit http://gerrit.
Ronen Angluster has uploaded a new change for review.
Change subject: packaging: add userportal-gwtp.war to spec file
..
packaging: add userportal-gwtp.war to spec file
add a definition for userportal-gwtp.war in the spec file
Jonathan Choate has posted comments on this change.
Change subject: engine-core: create a VM from a template
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1068
To unsubscribe, vi
Jonathan Choate has submitted this change and it was merged.
Change subject: engine-core: create a VM from a template
..
engine-core: create a VM from a template
Made a change to AddVmFromTemplateCommand to ensure that
VM disks
Ronen Angluster has abandoned this change.
Change subject: packging: add userportal-gwtp.war to spec file
..
Patch Set 1: Abandoned
done by mistake
--
To view, visit http://gerrit.ovirt.org/1381
To unsubscribe, visit http://ge
Ronen Angluster has uploaded a new change for review.
Change subject: packging: add userportal-gwtp.war to spec file
..
packging: add userportal-gwtp.war to spec file
add a line for userportal-gwtp.war in the spec file
Change-I
Omer Frenkel has posted comments on this change.
Change subject: engine: Add quota enforcement to quota entity
..
Patch Set 1:
why in the first place its a dc property and not a quota property?
--
To view, visit http://gerrit.
Jonathan Choate has posted comments on this change.
Change subject: engine-core: Multiple storage domains when importing VM
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1067
To
Jonathan Choate has submitted this change and it was merged.
Change subject: engine-core: Multiple storage domains when importing VM
..
engine-core: Multiple storage domains when importing VM
Fixing ImportVmCommand and ImportVm
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add quota enforcement to quota entity
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/1380
To unsubscribe, visit http://gerrit.ovirt.or
Maor Lipchuk has uploaded a new change for review.
Change subject: engine: Add quota enforcement to quota entity
..
engine: Add quota enforcement to quota entity
The transient quota enforcement type to quota entity, for GUI pour
Tomas Jelinek has uploaded a new change for review.
Change subject: userportal: basic implementation of basic view
..
userportal: basic implementation of basic view
Includes:
- split panel with details and list view
- list view
Omer Frenkel has posted comments on this change.
Change subject: Revert "engine-core: log the host name when can't connect
(#766287)"
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1369
To
Ronen Angluster has uploaded a new change for review.
Change subject: packaging: use files instead of pipe in execCmd
..
packaging: use files instead of pipe in execCmd
Add a flag for common_utils.execCmd to use real files inste
Gilad Chaplik has submitted this change and it was merged.
Change subject: engine: Implement getQueryableId to quota entities.
..
engine: Implement getQueryableId to quota entities.
Since quota business entities implement IVdcQ
Gilad Chaplik has posted comments on this change.
Change subject: engine: Implement getQueryableId to quota entities.
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1376
To unsubs
Maor Lipchuk has uploaded a new change for review.
Change subject: engine: Implent getQueryableId to quota entities.
..
engine: Implent getQueryableId to quota entities.
Since quota business entities implement IVdcQueriable, the
Yaniv Dary has posted comments on this change.
Change subject: reports: fixed br6\13 query (#770267)
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1312
To un
Yaniv Dary has posted comments on this change.
Change subject: reports: added localization to br13
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1374
To unsu
Yaniv Dary has posted comments on this change.
Change subject: reports: replaced all tabs with spaces.
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1338
To
Allon Mureinik has uploaded a new change for review.
Change subject: Clean up warnings on Backend
..
Clean up warnings on Backend
warnings were detected with Eclipse IDE's mechanism.
No logic changes - just adding Override(), fi
Yaniv Dary has uploaded a new change for review.
Change subject: reports: added localization to br13
..
reports: added localization to br13
Change-Id: Ibdd6211f9c73a547bc5b0d6fc5ecc9262c65e90f
---
M
reports/repository_files/res
Moti Asayag has abandoned this change.
Change subject: core: Organize VdcActionParametersBase class
..
Patch Set 1: Abandoned
Same patch was submitted earlier:
http://gerrit.ovirt.org/#change,1113
--
To view, visit http://gerr
Moti Asayag has abandoned this change.
Change subject: core: Clear C# annotations from VdcActionParametersBase
..
Patch Set 1: Abandoned
the changes were submitted by Jon's patch:
http://gerrit.ovirt.org/#change,1113
--
To vie
Roy Golan has submitted this change and it was merged.
Change subject: remove scripts dependencies on specific jar versions
..
remove scripts dependencies on specific jar versions
Change-Id: Ib1dc9733159cf9a542c3846e3e304216d5f
Roy Golan has posted comments on this change.
Change subject: remove scripts dependencies on specific jar versions
..
Patch Set 10: Verified; Looks good to me, approved
rebase push
--
To view, visit http://gerrit.ovirt.org/837
Livnat Peer has posted comments on this change.
Change subject: core: Organize VdcActionParametersBase class
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1081
To unsubscribe, visit http:/
Livnat Peer has posted comments on this change.
Change subject: core: Clear C# annotations from VdcActionParametersBase
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1080
To unsubscribe, v
Oved Ourfali has posted comments on this change.
Change subject: remove scripts dependencies on specific jar versions
..
Patch Set 9: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/837
To unsubsc
Vojtech Szocs has posted comments on this change.
Change subject: userportal: implemented login automatically
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1372
To unsubscribe, v
Vojtech Szocs has submitted this change and it was merged.
Change subject: userportal: implemented login automatically
..
userportal: implemented login automatically
This included the change of the usage of the LoginModel to
Us
Vojtech Szocs has posted comments on this change.
Change subject: userportal: implemented login automatically
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1372
To unsubscribe, v
Roy Golan has posted comments on this change.
Change subject: remove scripts dependencies on specific jar versions
..
Patch Set 9:
rebase patch
--
To view, visit http://gerrit.ovirt.org/837
To unsubscribe, visit http://gerrit.
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Context sensitive help links (#748227)
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1343
To unsubscri
Douglas Schilling Landgraf has posted comments on this change.
Change subject: virt-engine: Support RHEVManager url
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1120
Tomas Jelinek has uploaded a new change for review.
Change subject: userportal: implemented login automatically
..
userportal: implemented login automatically
This included the change of the usage of the LoginModel to
UserPortal
Roy Golan has posted comments on this change.
Change subject: virt-engine: Support RHEVManager url
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/1120
To unsubscribe, visit http://gerrit.ovirt.org/settings
Roy Golan has posted comments on this change.
Change subject: virt-engine: Support RHEVManager url
..
--
To view, visit http://gerrit.ovirt.org/1120
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: c
Roy Golan has posted comments on this change.
Change subject: virt-engine: Support RHEVManager url
..
Patch Set 6: Verified
Both offer and I verified it.
--
To view, visit http://gerrit.ovirt.org/1120
To unsubscribe, visit htt
Moti Asayag has posted comments on this change.
Change subject: Revert "engine-core: log the host name when can't connect
(#766287)"
..
Patch Set 1:
Why do you wish to revert it ?
--
To view, visit http://gerrit.ovirt.org/136
Alona Kaplan has uploaded a new change for review.
Change subject: webadmin: Storage VM/Template Import subtabs shows blinking
squares forever
..
webadmin: Storage VM/Template Import subtabs shows blinking squares forever
https
Roy Golan has posted comments on this change.
Change subject: engine-core: clean and fix typos
..
Patch Set 6: (1 inline comment)
File
backend/manager/modules/common/src/mai
Ofer Schreiber has posted comments on this change.
Change subject: virt-engine: Support RHEVManager url
..
Patch Set 6: No score
--
To view, visit http://gerrit.ovirt.org/1120
To unsubscribe, visit http://gerrit.ovirt.org/setti
Moti Asayag has posted comments on this change.
Change subject: engine-core: clean and fix typos
..
Patch Set 6: (8 inline comments)
File
backend/manager/modules/common/src/
Doron Fediuck has posted comments on this change.
Change subject: virt-engine: Support RHEVManager url
..
Patch Set 6: (1 inline comment)
Needs some cleanups and verification.
Ofer, I see you set the verify flag.
This means th
Eli Mesika has submitted this change and it was merged.
Change subject: engine-core: cleaning up paramter classes
..
engine-core: cleaning up paramter classes
1) moving ctors to the top
2) moving members below ctors
Eli Mesika has posted comments on this change.
Change subject: engine-core: cleaning up paramter classes
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1113
To unsubscribe, visit
Doron Fediuck has posted comments on this change.
Change subject: add openssh-clients requires in spec file
..
Patch Set 1: Fails; I would prefer that you didn't submit this
Joey,
Engine core does not use SSH client for SSH con
Moti Asayag has posted comments on this change.
Change subject: engine-core: cleaning up paramter classes
..
Patch Set 2:
since intended to work closely on the VdcActionParameterBase I'm adding this
patch for review on as exte
Moti Asayag has posted comments on this change.
Change subject: engine-core: cleaning up paramter classes
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/1113
To unsubscribe, visit http://gerrit.ovirt.org/set
Moti Asayag has submitted this change and it was merged.
Change subject: ovirt-engine: Add config value for docs base URL
..
ovirt-engine: Add config value for docs base URL
Added 'DocsURL' configuration value - the base URL fo
Moti Asayag has posted comments on this change.
Change subject: ovirt-engine: Add config value for docs base URL
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1342
To unsubscribe
81 matches
Mail list logo
