Re: [PATCH] Fix thread-safety for elfutils

ts? I noticed that the split-up branch resides on what appears to be your personal space at https://code.wildebeest.org/git/user/mjw/elfutils/log/?h=thread-safety. I'm uncertain whether I have the necessary access for making commits there. Best regards, Heather McIntyre On Sat, Oct 14, 2023 at 10:

Re: [PATCH 02/16] libelf: Make elf_version thread-safe

: > Hi Heather, > > On Tue, 2023-10-10 at 15:42 +0200, Mark Wielaard wrote: > > From: Heather McIntyre > > > > * elf_version.c (version_once): Define once. > > (initialize_version): New static function. > > (elf_version): Use initialize_vers

Re: [PATCH 03/16] libelf: Fix deadlock in __libelf_readall

s after I am done testing other fixes since I want to ensure that everything works together cohesively. On Tue, Oct 10, 2023 at 10:06 AM Mark Wielaard wrote: > Hi Heather, > > On Tue, 2023-10-10 at 15:42 +0200, Mark Wielaard wrote: > > From: Heather McIntyre > >

Re: [PATCH 04/16] libelf: Fix deadlock in elf_cntl

You are right. I changed the code to just rely on if (__libelf_readall (elf) == NULL) and this seems to work just fine. On Tue, Oct 10, 2023 at 10:23 AM Mark Wielaard wrote: > Hi Heather, > > On Tue, 2023-10-10 at 15:42 +0200, Mark Wielaard wrote: > > From: H

Re: [PATCH 09/16] src: Use eu-search in nm and findtextrel.

her, > > On Tue, Oct 10, 2023 at 03:42:53PM +0200, Mark Wielaard wrote: > > From: Heather McIntyre > > > > * src/Makefile.am: Add USE_LOCKS condition for -pthread. > > * src/findtextrel.c: Add eu-search.h and remove search.h. > > Change calls

Re: [PATCH 10/16] libdw: make dwarf_getalt thread-safe

Since it wasn't too complicated to do, I implemented a dwarf object lock (per struct dwarf lock) instead of having the static global lock. As per your suggestion, I placed the lock over the whole dwarf_getalt function, so now find_debug_altlink is called with the lock already acquired. In addition,

Re: [PATCH 11/16] libdw: Add locking around __libdw_dieabbrev for dwarf_hasattr

multiple calls to __libdw_dieabbrev will be working on different dwarf objects. On Tue, Oct 10, 2023 at 8:44 AM Mark Wielaard wrote: > Hi Heather, > > On Tue, 2023-10-10 at 15:42 +0200, Mark Wielaard wrote: > From: Heather McIntyre > > * libdw/dwarf_hasattr.c (dwarf_hasattr): U

Re: [PATCH 12/16] libdw: Make libdw_find_split_unit thread-safe

Hi Mark, As per your suggestion, I have placed the lock around the entire __libdw_find_split_unit function call. On Wed, Oct 11, 2023 at 12:17 PM Mark Wielaard wrote: > Hi Heather, > > On Tue, Oct 10, 2023 at 03:42:56PM +0200, Mark Wielaard wrote: > > From: H

Re: [PATCH 13/16] libdw: Make libdw_findcu thread-safe

well. On Thu, Oct 12, 2023 at 5:03 PM Mark Wielaard wrote: > Hi Heather, > > On Tue, Oct 10, 2023 at 03:42:57PM +0200, Mark Wielaard wrote: > > From: Heather McIntyre > > > > * libdw/libdw_findcu.c (findcu_cb): Use eu_tsearch. > > (__libdw_findcu): Use e

Re: [PATCH 07/16] lib: Add eu_tsearch and eu_tfind

then get back to you. Best, Heather On Tue, Oct 10, 2023 at 11:51 AM Mark Wielaard wrote: > Hi Heather, > > On Tue, 2023-10-10 at 15:42 +0200, Mark Wielaard wrote: > > From: Heather McIntyre > > > > * lib/eu-search.h: New file. > > Declarations for

Deadlock from --enable-thread-safety

I've been making --enable-thread-safety (USE_LOCKS) more viable by fixing deadlocks throughout the libelf library. This has required minimal code changes so far. However, I've hit a snag where "__elf64_updatenull_wrlock" calls "elf64_getchdr," which leads to "elf64_getshdr." This sequence attempts

[PATCH] Fix thread-safety for elfutils

e to provide feedback. I am available for any clarifications or modifications needed. Best regards, Heather McIntyre 0001-Fix-thread-safety-for-elfutils.patch Description: Binary data