Re: elfutils does not compile with gcc 12.2.0

2022-08-24 Thread Dmitry V. Levin
On Wed, Aug 24, 2022 at 10:51:13PM +0200, Nick via Elfutils-devel wrote: > I try to compile elfutils on OpenWrt with the newest gcc 12.2.0 version. > However, it fails due to -Werror=use-after-free. A workaround is a patch > that I found on the mailinglist, to disable -Werror > (https://sourcewa

Re: [PATCH][RFC] readelf: partial support of ZSTD compression

2022-10-24 Thread Dmitry V. Levin
On Mon, Oct 24, 2022 at 01:09:59PM +0200, Martin Liška wrote: [...] > One TODO I see is that: > +libelf_so_LDLIBS = $(libelf_so_DEPS) -lz -lzstd > > should be conditional based on HAVE_ZSTD. But I don't know how to do that? I suppose you're talking about libzstd_LIBS. [...] > diff --git a/m4/zst

Re: [PATCH][RFC] readelf: partial support of ZSTD compression

2022-10-24 Thread Dmitry V. Levin
On Mon, Oct 24, 2022 at 02:17:17PM +0200, Martin Liška wrote: > On 10/24/22 13:41, Dmitry V. Levin wrote: > > On Mon, Oct 24, 2022 at 01:09:59PM +0200, Martin Liška wrote: > > [...] > >> One TODO I see is that: > >> +libelf_so_LDLIBS = $(libelf_so_DEPS) -lz -lzst

Re: [PATCH] config: Make sure profile.sh succeeds with set -e and set -o pipefail

2024-03-26 Thread Dmitry V. Levin
On Tue, Mar 26, 2024 at 09:49:48PM +0100, Mark Wielaard wrote: > profile.sh might fail with set -o pipefail because: > > cat /dev/null "${prefix}/etc/debuginfod"/*.urls 2>/dev/null | tr '\n' ' ' > > might fail when there isn't an *.urls file the first command in the > pipe fails (the 2>/dev/null

Re: [PATCH] Fix 'make coverage' when used with lcov version 2.0+

2024-05-06 Thread Dmitry V. Levin
Hi, On Mon, May 06, 2024 at 04:45:27PM -0400, Aaron Merey wrote: > Starting with version 2.0, various lcov warnings now trigger an error > exit. This results in 'make coverage' terminating before completion. > > Fix this by invoking lcov and genhtml with --ignore-errors to prevent > the error ex

Re: [PATCH] Fix 'make coverage' when used with lcov version 2.0+

2024-05-09 Thread Dmitry V. Levin
On Wed, May 08, 2024 at 12:28:04PM -0400, Aaron Merey wrote: > On Mon, May 6, 2024 at 4:45 PM Aaron Merey wrote: > > > > Starting with version 2.0, various lcov warnings now trigger an error > > exit. This results in 'make coverage' terminating before completion. > > > > Fix this by invoking lcov

Re: [PATCH] Fix 'make coverage' when used with lcov version 2.0+

2024-05-09 Thread Dmitry V. Levin
On Thu, May 09, 2024 at 06:08:05PM -0400, Frank Ch. Eigler wrote: > Hi - > > On Fri, May 10, 2024 at 12:53:39AM +0300, Dmitry V. Levin wrote: > > > Pushed as commit ca8ad4648197 > > > > What's the purpose of sending proposed patches to the mailing list

Re: [COMMITTED] Makefile.am: Avoid code duplication

2024-05-09 Thread Dmitry V. Levin
On Thu, May 09, 2024 at 07:24:26PM -0400, Aaron Merey wrote: > On Thu, May 9, 2024 at 6:59 PM Dmitry V. Levin wrote: > > On Thu, May 09, 2024 at 06:08:05PM -0400, Frank Ch. Eigler wrote: > > > On Fri, May 10, 2024 at 12:53:39AM +0300, Dmitry V. Levin wrote: > > > > &

Re: [PATCH] Fix 'make coverage' when used with lcov version 2.0+

2024-05-09 Thread Dmitry V. Levin
Hi Frank, On Thu, May 09, 2024 at 07:03:47PM -0400, Frank Ch. Eigler wrote: > Hi - > > > > > What's the purpose of sending proposed patches to the mailing list > > > > if reviews are silently ignored? > > > > > > Please be collegial and don't exaggerate. > > > > The fact is that the review was

Re: [PATCH] Support nullglob in profile.sh.in

2024-05-13 Thread Dmitry V. Levin
On Mon, May 13, 2024 at 02:04:04PM +0200, Andreas Schwab wrote: > Don't block on stdin when /etc/debuginfod/*.certpath expands to nothing. > > Signed-off-by: Andreas Schwab > --- > config/profile.sh.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/config/profile.sh.in

Re: [PATCH 1/2] libdwfl: specify optional sysroot to search for shared libraries and binaries

2024-07-02 Thread Dmitry V. Levin
On Mon, Jul 01, 2024 at 06:56:21PM +0200, Michal Sekletar wrote: [...] > --- a/libdwfl/link_map.c > +++ b/libdwfl/link_map.c > @@ -416,8 +416,22 @@ report_r_debug (uint_fast8_t elfclass, uint_fast8_t > elfdata, >if (name != NULL) > { > /* This code is mostly inlined dwfl_repo

Re: [PATCH v2 1/3] libdwfl: specify optional sysroot to search for shared libraries and binaries

2024-07-03 Thread Dmitry V. Levin
On Tue, Jul 02, 2024 at 07:30:58PM +0200, Michal Sekletar wrote: [...] > +int > +dwfl_set_sysroot (Dwfl *dwfl, const char *sysroot) > +{ > + if (!sysroot) > +{ > + free (dwfl->sysroot); > + dwfl->sysroot = NULL; > + return 0; > +} > + > + char *r, *s; > + r = realpath (sys

Re: [PATCH] Include sys/types.h before fts.h

2017-04-20 Thread Dmitry V. Levin
On Thu, Apr 20, 2017 at 03:26:47PM +0200, Ulf Hermann wrote: > The bad fts not only needs to be included before config.h, but also > requires various special types without including sys/types.h. Please do not include before unconditionally. If bad fts needs , then do it [BAD_FTS]. -- ldv si

Re: [COMMITTED] backends: Swap sys/ptrace.h and asm/ptrace.h include order on s390.

2017-07-17 Thread Dmitry V. Levin
On Mon, Jul 17, 2017 at 05:44:54PM +0200, Mark Wielaard wrote: > glibc 2.26 changed the sys/ptrace.h header so that it cannot be included > after asm/ptrace.h. We still need to include the kernel asm/ptrace.h for > the ptrace_area definition. Including it after sys/ptrace.h works against > both old

Re: [COMMITTED] backends: Swap sys/ptrace.h and asm/ptrace.h include order on s390.

2017-07-17 Thread Dmitry V. Levin
On Mon, Jul 17, 2017 at 06:41:47PM +0200, Mark Wielaard wrote: > On Mon, 2017-07-17 at 19:29 +0300, Dmitry V. Levin wrote: > > On Mon, Jul 17, 2017 at 05:44:54PM +0200, Mark Wielaard wrote: > > > glibc 2.26 changed the sys/ptrace.h header so that it cannot be included > >

[PATCH] tests: robustify run-strip-nothing.sh against unstripped libc_nonshared.a

2017-08-08 Thread Dmitry V. Levin
When glibc's libc_nonshared.a contains objects with debug info, this debug info is leaked into every output file produced by gcc. Change run-strip-nothing.sh to use "gcc -s" instead of plain "gcc" for producing objects without debug info. Signed-off-by: Dmitry V. Le

Re: [COMMITTED] Include sys/ptrace.h as early as possible.

2018-02-15 Thread Dmitry V. Levin
On Thu, Feb 15, 2018 at 03:44:40PM +0100, Mark Wielaard wrote: > On some systems, at least on Fedora 27 ppc64le with glibc 2.26-24 and > kernel 4.14.18-300, including sys/ptrace.h late (after signal.h or > sys/wait.h for example) will cause issues and produce errors like: > > In file included from

[PATCH] Specify a custom git merge driver for ChangeLog files

2018-03-19 Thread Dmitry V. Levin
Signed-off-by: Dmitry V. Levin --- .gitattributes | 1 + ChangeLog | 4 2 files changed, 5 insertions(+) create mode 100644 .gitattributes diff --git a/.gitattributes b/.gitattributes new file mode 100644 index 000..ca4ea27 --- /dev/null +++ b/.gitattributes @@ -0,0 +1

Re: [PATCH] Specify a custom git merge driver for ChangeLog files

2018-03-20 Thread Dmitry V. Levin
On Wed, Mar 21, 2018 at 12:03:53AM +0100, Mark Wielaard wrote: > I am not against this, but it could use a bit more documentation > in at least the commit message, so people know what they should > setup in their gitconfig. The advantage of adding .gitattributes file to repository is that no gitco

Re: [PATCH] libdwfl: Use process_vm_readv when available.

2018-03-20 Thread Dmitry V. Levin
On Sun, Mar 18, 2018 at 01:43:23AM +0100, Mark Wielaard wrote: [...] > @@ -115,12 +116,80 @@ __libdwfl_ptrace_attach (pid_t tid, bool > *tid_was_stoppedp) >return true; > } > > +#ifdef HAVE_PROCESS_VM_READV > +static bool > +read_cached_memory (struct __libdwfl_pid_arg *pid_arg, > +

Re: [PATCH] Specify a custom git merge driver for ChangeLog files

2018-03-20 Thread Dmitry V. Levin
On Wed, Mar 21, 2018 at 02:20:51AM +0300, Dmitry V. Levin wrote: > On Wed, Mar 21, 2018 at 12:03:53AM +0100, Mark Wielaard wrote: > > I am not against this, but it could use a bit more documentation > > in at least the commit message, so people know what they should > > set

Re: [PATCH] libdwfl: Use process_vm_readv when available.

2018-03-28 Thread Dmitry V. Levin
On Wed, Mar 28, 2018 at 04:33:26PM +0200, Mark Wielaard wrote: > On Tue, 2018-03-20 at 23:32 +0100, Mark Wielaard wrote: > > On Sun, Mar 18, 2018 at 01:43:23AM +0100, Mark Wielaard wrote: > > > If possible use process_vm_readv to read 4K blocks instead of fetching > > > each word individually with

[PATCH] elflint: fix typo in error diagnostics

2018-05-15 Thread Dmitry V. Levin
diff --git a/src/ChangeLog b/src/ChangeLog index 419fa20..8a664da 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,3 +1,7 @@ +2018-05-15 Dmitry V. Levin + + * elflint.c (check_elf_header): Fix typo in error diagnostics. + 2018-05-15 Mark Wielaard * readelf.c

[PATCH v2] elflint: fix typo in error diagnostics

2018-05-15 Thread Dmitry V. Levin
Signed-off-by: Dmitry V. Levin --- src/ChangeLog | 4 src/elflint.c | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/ChangeLog b/src/ChangeLog index 419fa20..8a664da 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,3 +1,7 @@ +2018-05-15 Dmitry V. Levin

Re: [PATCHv1 1/2] libdwfl: specify optional sysroot to search for shared libraries

2019-01-20 Thread Dmitry V. Levin
On Sun, Jan 20, 2019 at 03:00:45PM +, Luke Diamand wrote: > When searching the list of modules in a core file, if the core was > generated on a different system to the current one, we need to look > in a sysroot for the various shared objects. > > For example, we might be looking at a core fil

Re: [PATCH] tests: check gcc

2019-05-21 Thread Dmitry V. Levin
On Tue, May 21, 2019 at 03:00:31PM +0800, mingli...@windriver.com wrote: > From: Mingli Yu > > Both run-disasm-x86-64.sh and run-disasm-x86.sh > need gcc, so check gcc before run the test. There are several dozens more tests that invoke gcc, why these two need a check? -- ldv

Re: [PATCH] libelf: Fix some 32bit offset/size issues that break updating 4G+ files.

2019-06-19 Thread Dmitry V. Levin
On Thu, Jun 20, 2019 at 01:10:53AM +0200, Mark Wielaard wrote: > On Wed, 2019-06-19 at 02:04 +0200, Mark Wielaard wrote: > > The patch also contains a testcase. But since it is necessary to create > > and process a 4GB+ file it is guarded by some checks to make sure the > > machine has enough disk

Re: [PATCH] elfclassify tool

2019-07-19 Thread Dmitry V. Levin
On Fri, Jul 19, 2019 at 02:47:09PM +0200, Mark Wielaard wrote: [...] > +static bool > +is_shared (void) > +{ > + if (!is_loadable ()) > +return false; > + > + /* The ELF type is very clear: this is an executable. */ > + if (elf_type == ET_EXEC) > +return false; > + > + /* If the object

Re: [PATCH] elfclassify tool

2019-07-19 Thread Dmitry V. Levin
On Fri, Jul 19, 2019 at 04:21:53PM +0200, Mark wrote: > On Fri, 2019-07-19 at 16:43 +0300, Dmitry V. Levin wrote: > > On Fri, Jul 19, 2019 at 02:47:09PM +0200, Mark Wielaard wrote: > > [...] > > > +static bool > > > +is_shared (void) > > > +{ > > &

Re: [PATCH] elfclassify tool

2019-07-19 Thread Dmitry V. Levin
On Fri, Jul 19, 2019 at 11:00:49PM +0200, Florian Weimer wrote: > * Dmitry V. Levin: > > >> So, I don't think the code is wrong. We might want to tweak the comment > >> a bit though, to make it less definitive? > > > > What I'm saying is that ha

Re: [PATCH] elfclassify tool

2019-07-19 Thread Dmitry V. Levin
On Fri, Jul 19, 2019 at 11:36:53PM +0200, Mark Wielaard wrote: > On Sat, Jul 20, 2019 at 12:23:08AM +0300, Dmitry V. Levin wrote: > > On Fri, Jul 19, 2019 at 11:00:49PM +0200, Florian Weimer wrote: > > > * Dmitry V. Levin: > > > > > > >> So, I don't

Re: [PATCH] elfclassify: Add --library classification.

2019-07-26 Thread Dmitry V. Levin
On Fri, Jul 26, 2019 at 12:39:32AM +0200, Mark Wielaard wrote: > > Maybe you are looking for another goal/classification? For example I > > added --program which does classify those special files as programs > > (even though --shared also says they are shared libraries). Maybe you > > are looking

Re: [PATCH] elfclassify tool

2019-07-26 Thread Dmitry V. Levin
On Sat, Jul 20, 2019 at 11:51:16PM +0200, Mark Wielaard wrote: > On Sat, Jul 20, 2019 at 01:57:27AM +0300, Dmitry V. Levin wrote: [...] > > btw, I think it would be appropriate to move the has_dynamic check before > > the first check in is_shared that returns true. > > Yes,

[PATCH] config/elfutils.spec.in: package eu-elfclassify

2019-08-14 Thread Dmitry V. Levin
Package the new tool introduced by commit elfutils-0.177~1. Signed-off-by: Dmitry V. Levin --- I have no idea whether this file is actually used as a specfile. If not, let's add eu-elfclassify there for consistency. P.S. Thanks for the nice tool! config/ChangeLog| 4 c

[PATCH] elflint, readelf: enhance error diagnostics

2019-09-30 Thread Dmitry V. Levin
When an input file cannot be opened, include its name into the error diagnostics. Signed-off-by: Dmitry V. Levin --- src/ChangeLog | 6 ++ src/elflint.c | 6 +++--- src/readelf.c | 2 +- 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src/ChangeLog b/src/ChangeLog index

[PATCH] Do not install libdebuginfod.pc unless debuginfod is enabled

2020-01-01 Thread Dmitry V. Levin
Fixes: 288f6b199 ("debuginfod 1/2: client side") Signed-off-by: Dmitry V. Levin --- config/ChangeLog | 5 + config/Makefile.am | 5 - 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/config/ChangeLog b/config/ChangeLog index cc4187bf..2296e815 100644 --- a/config

Re: [PATCH] libebl: Don't install libebl.a, libebl.h and remove backends from spec.

2020-01-01 Thread Dmitry V. Levin
Hi, On Thu, Aug 29, 2019 at 11:43:58PM +0200, Mark Wielaard wrote: > All archive members from libebl.a are now in libdw.a. We don't generate > separate backend shared libraries anymore. So remove them from the > elfutils.spec file. > > Signed-off-by: Mark Wielaard > --- > config/ChangeLog

Re: [PATCH] libebl: Don't install libebl.a, libebl.h and remove backends from spec.

2020-01-08 Thread Dmitry V. Levin
Hi Mark, On Wed, Jan 08, 2020 at 03:09:32PM +0100, Mark Wielaard wrote: > On Thu, 2020-01-02 at 03:02 +0300, Dmitry V. Levin wrote: > > On Thu, Aug 29, 2019 at 11:43:58PM +0200, Mark Wielaard wrote: > > > All archive members from libebl.a are now in libdw.a. We don't

[PATCH] libdwfl: do not dlopen libdebuginfod.so in --disable-libdebuginfod mode

2020-08-20 Thread Dmitry V. Levin
-debuginfo.c | 2 ++ 7 files changed, 31 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index c6b526fe..0f00fade 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2020-08-20 Dmitry V. Levin + + * configure.ac (--enable-libdebuginfod): AC_DEFINE

Re: [PATCH] libdwfl: do not dlopen libdebuginfod.so in --disable-libdebuginfod mode

2020-08-30 Thread Dmitry V. Levin
Hi Mark, On Sun, Aug 30, 2020 at 10:40:29PM +0200, Mark Wielaard wrote: > Hi Dmitry, > > On Thu, Aug 20, 2020 at 11:27:24PM +0300, Dmitry V. Levin wrote: > > debuginfod-client.c used to try to dlopen libdebuginfod.so even if > > libdebuginfod was completely disabled using --

Re: [PATCH] libdw: Remove duplicate local wildcards from map file.

2020-09-03 Thread Dmitry V. Levin
On Thu, Sep 03, 2020 at 03:00:36PM +0200, Mark Wielaard wrote: > We only need one local: * entry to capture all private local symbols. Yes, the first one (inside ELFUTILS_0.122) is enough. > Signed-off-by: Mark Wielaard > --- > libdw/ChangeLog | 8 > libdw/libdw.map | 10 -- >

Re: [PATCH] Support building when fts and obstack aren't part of libc.

2020-10-26 Thread Dmitry V. Levin
On Sun, Oct 25, 2020 at 11:41:12PM -0300, Érico Nogueira via Elfutils-devel wrote: > - Make configure.ac test for fts and obstack availability; > - Add fts and obstack ldflags to all files that need them; > - Add missing argp ldflags to programs in debuginfod/. > > Signed-off-by: Érico Rolim > -

Re: [PATCH] Stop depending on strndupa.

2020-10-26 Thread Dmitry V. Levin
On Mon, Oct 26, 2020 at 11:51:21AM -0300, Érico Nogueira via Elfutils-devel wrote: [...] > +error (EXIT_FAILURE, 0, _("path is too long '%s'"), path); I suggest the following alternative: error (EXIT_FAILURE, ENAMETOOLONG, "%s", path); -- ldv

Re: [PATCH] Don't use __BEGIN_DECLS macros from glibc.

2020-10-26 Thread Dmitry V. Levin
On Mon, Oct 26, 2020 at 05:44:24PM -0300, Érico Nogueira via Elfutils-devel wrote: > From: Érico Rolim > > These macros are mostly internal to glibc and require the inclusion of > (here included indirectly via ), which isn't a > standard header. > > Since they are only required once, replacing

[PATCH] Do not install profile.d/debuginfod.*sh files unless debuginfod is enabled

2020-10-31 Thread Dmitry V. Levin
Fixes: 94708e964601 ("PR25461: add /etc/profile.d files for default $DEBUGINFOD_URLS") Fixes: fee123fb771f ("PR25461: uninstall /etc/profile.d files for distuninstallcheck") Signed-off-by: Dmitry V. Levin --- config/ChangeLog | 5 + config/Makefile.am | 2 +-

[PATCH] config: Conditionalize on LIBDEBUGINFOD instead of DEBUGINFOD

2020-11-02 Thread Dmitry V. Levin
od.pc unless debuginfod is enabled") Fixes: b503c358dde8 ("Do not install profile.d/debuginfod.*sh files unless debuginfod is enabled") Signed-off-by: Dmitry V. Levin --- config/ChangeLog | 5 + config/Makefile.am | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-)

Re: [PATCH] config: Conditionalize on LIBDEBUGINFOD instead of DEBUGINFOD

2020-11-03 Thread Dmitry V. Levin
Hi, On Tue, Nov 03, 2020 at 06:26:07PM +0100, Mark Wielaard wrote: > Hi Frank, > > On Tue, 2020-11-03 at 12:07 -0500, Frank Ch. Eigler via Elfutils-devel > wrote: > > > While packaging I noticed that we install the profiles.d files even > > > when the DEBUGINFOD_URLS is empty. I think we should a

Re: [PATCH v2] Support building when fts and obstack aren't part of libc.

2020-11-03 Thread Dmitry V. Levin
On Sun, Nov 01, 2020 at 09:48:50PM -0300, Érico Nogueira via Elfutils-devel wrote: > From: Érico Rolim > > - Make configure.ac test for fts and obstack availability; > - Add fts and obstack ldflags to all files that need them; > - Add missing argp ldflags to programs in debuginfod/. > > Signed-

[PATCH 2/1] config: do not define DEBUGINFOD_URLS environment variable unnecessarily

2020-11-04 Thread Dmitry V. Levin
work. Change these scripts to avoid defining the DEBUGINFOD_URLS environment variable unless configured using --enable-debuginfod-urls. Signed-off-by: Dmitry V. Levin --- config/ChangeLog | 5 + config/profile.csh.in | 13 +++-- config/profile.sh.in | 7 --- 3 files changed

[PATCH] Drop $(EXEEXT) suffix from shared libraries

2020-11-30 Thread Dmitry V. Levin
According to GNU Automake documentation [1], $(EXEEXT) is the suffix that should be used for executables, it is not applicable for shared libraries. [1] https://www.gnu.org/software/automake/manual/html_node/EXEEXT.html Signed-off-by: Dmitry V. Levin --- debuginfod/ChangeLog | 4

[PATCH] debuginfod: export DEBUGINFOD_SONAME macro in debuginfod.h

2020-11-30 Thread Dmitry V. Levin
Add DEBUGINFOD_SONAME macro to API for use by those of libdebuginfod clients that would like to dlopen the library in the same way as __libdwfl_debuginfod_init does. Signed-off-by: Dmitry V. Levin --- ChangeLog| 5 + configure.ac

Re: [PATCH] debuginfod: export DEBUGINFOD_SONAME macro in debuginfod.h

2020-12-06 Thread Dmitry V. Levin
Hi Mark, On Sun, Dec 06, 2020 at 01:06:42PM +0100, Mark Wielaard wrote: > Hi Dmitry, > > On Mon, 2020-11-30 at 09:00 +0000, Dmitry V. Levin wrote: > > Add DEBUGINFOD_SONAME macro to API for use by those of libdebuginfod > > clients that would like to dlopen the libra

Re: [PATCH] debuginfod: export DEBUGINFOD_SONAME macro in debuginfod.h

2020-12-06 Thread Dmitry V. Levin
On Sun, Dec 06, 2020 at 08:32:43AM -0500, Frank Ch. Eigler wrote: > Hi - > > > Thanks, I think libdwfl/debuginfod-client.c should use the versioned name > > only, and it shouldn't fallback to "libdebuginfod.so" as it does now. > > I believe the code falls back to the unversioned soname because on

[PATCH v2 1/3] debuginfod: export DEBUGINFOD_SONAME macro in debuginfod.h

2020-12-06 Thread Dmitry V. Levin
Add DEBUGINFOD_SONAME macro to API for use by those of libdebuginfod clients that would like to dlopen the library in the same way as __libdwfl_debuginfod_init does. Signed-off-by: Dmitry V. Levin --- ChangeLog| 5 + configure.ac

[PATCH v2 2/3] debuginfod: create the fully versioned libdebuginfod file name during build

2020-12-06 Thread Dmitry V. Levin
When the fully versioned file name is available, the fall back to dlopen of "libdebuginfod.so" in __libdwfl_debuginfod_init is no longer needed. Signed-off-by: Dmitry V. Levin --- debuginfod/ChangeLog | 7 +++ debuginfod/Makefile.am | 10 ++ 2 files changed, 13 insert

[PATCH v2 3/3] libdwfl: do not fall back to dlopen of libdebuginfod.so

2020-12-06 Thread Dmitry V. Levin
The fully versioned libdebuginfod file name should always be available. Signed-off-by: Dmitry V. Levin --- libdwfl/ChangeLog | 5 + libdwfl/debuginfod-client.c | 3 --- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/libdwfl/ChangeLog b/libdwfl/ChangeLog index

[PATCH v2 4/3] debuginfod: create libdebuginfod files using a race-free method

2020-12-06 Thread Dmitry V. Levin
/ChangeLog index 27abdfda..03eabb6b 100644 --- a/debuginfod/ChangeLog +++ b/debuginfod/ChangeLog @@ -1,5 +1,9 @@ 2020-12-06 Dmitry V. Levin + * Makefile.am [LIBDEBUGINFOD]: Create the fully versioned + libdebuginfod file name first, turn the soname and libdebuginfod.so + into

Re: [PATCH] debuginfod: export DEBUGINFOD_SONAME macro in debuginfod.h

2020-12-08 Thread Dmitry V. Levin
On Tue, Dec 08, 2020 at 01:02:41PM +0100, Mark Wielaard wrote: > On Sun, 2020-12-06 at 15:28 +0300, Dmitry V. Levin wrote: > > On Sun, Dec 06, 2020 at 01:06:42PM +0100, Mark Wielaard wrote: [...] > > > Don't we need both versioned and versionless names (at least dwfl tries

Re: [PATCH] debuginfod: export DEBUGINFOD_SONAME macro in debuginfod.h

2020-12-08 Thread Dmitry V. Levin
On Tue, Dec 08, 2020 at 01:02:41PM +0100, Mark Wielaard wrote: > On Sun, 2020-12-06 at 15:28 +0300, Dmitry V. Levin wrote: > > On Sun, Dec 06, 2020 at 01:06:42PM +0100, Mark Wielaard wrote: [...] > > > Finally, I am actually using the Makefile VERSION variable in a > > &g

Re: [PATCH] debuginfod: export DEBUGINFOD_SONAME macro in debuginfod.h

2020-12-08 Thread Dmitry V. Levin
Hi Mark, On Wed, Dec 09, 2020 at 12:07:04AM +0100, Mark Wielaard wrote: > Hi Dmitry, > > On Tue, Dec 08, 2020 at 06:15:40PM +0300, Dmitry V. Levin wrote: > > On Tue, Dec 08, 2020 at 01:02:41PM +0100, Mark Wielaard wrote: > > > On Sun, 2020-12-06 at 15:28 +0300, Dmitry V.

[PATCH v3 1/3] debuginfod: export DEBUGINFOD_SONAME macro in debuginfod.h

2020-12-08 Thread Dmitry V. Levin
Add DEBUGINFOD_SONAME macro to API for use by those of libdebuginfod clients that would like to dlopen the library in the same way as __libdwfl_debuginfod_init does. Signed-off-by: Dmitry V. Levin --- ChangeLog| 5 + configure.ac

[PATCH v3 2/3] debuginfod: create libdebuginfod.so.1 before libdebuginfod.so

2020-12-08 Thread Dmitry V. Levin
This would allow to switch from "libdebuginfod-" VERSION ".so" to DEBUGINFOD_SONAME in __libdwfl_debuginfod_init, and to remove the fall back to dlopen of "libdebuginfod.so" which is no longer needed. Signed-off-by: Dmitry V. Levin --- debuginfod/ChangeLog | 5

[PATCH v3 3/3] libdwfl: switch to DEBUGINFOD_SONAME, remove libdebuginfod.so fallback

2020-12-08 Thread Dmitry V. Levin
Since DEBUGINFOD_SONAME is as good as ("libdebuginfod-" VERSION ".so") for dlopen, switch to use the name which is a part of the API. Given that DEBUGINFOD_SONAME is always available now, remove the no longer needed fall back to dlopen of "libdebuginfod.so".

Re: [PATCH v3 2/3] debuginfod: create libdebuginfod.so.1 before libdebuginfod.so

2020-12-08 Thread Dmitry V. Levin
On Wed, Dec 09, 2020 at 03:13:12AM +0300, Dmitry V. Levin wrote: > This would allow to switch from "libdebuginfod-" VERSION ".so" > to DEBUGINFOD_SONAME in __libdwfl_debuginfod_init, and to remove the > fall back to dlopen of "libdebuginfod.so" which is no lo

Re: [PATCH] libdwfl: Do not dlopen libdebuginfod if DEBUGINFOD_URLS is unset or empty

2020-12-09 Thread Dmitry V. Levin
Hi, On Mon, Nov 09, 2020 at 09:57:57AM -0500, Frank Ch. Eigler via Elfutils-devel wrote: > Hi - > > > [...] The problem with doing the dlopen late is that we also need > > libcurl and initializing libcurl (as done by libdebuginfod) is not > > thread-safe. > > From reading libcurl code, and that

Re: [PATCH] Drop $(EXEEXT) suffix from shared libraries

2020-12-09 Thread Dmitry V. Levin
On Wed, Dec 09, 2020 at 08:55:23PM +0100, Mark Wielaard wrote: > On Sun, 2020-12-06 at 12:49 +0100, Mark Wielaard wrote: > > On Mon, 2020-11-30 at 21:35 +0100, Mark Wielaard wrote: > > > On Mon, Nov 30, 2020 at 08:00:00AM +0000, Dmitry V. Levin wrote: > > >

Re: [PATCH] Drop $(EXEEXT) suffix from shared libraries

2020-12-09 Thread Dmitry V. Levin
On Thu, Dec 10, 2020 at 01:04:14AM +0300, Dmitry V. Levin wrote: > On Wed, Dec 09, 2020 at 08:55:23PM +0100, Mark Wielaard wrote: > > On Sun, 2020-12-06 at 12:49 +0100, Mark Wielaard wrote: > > > On Mon, 2020-11-30 at 21:35 +0100, Mark Wielaard wrote: > > > > On M

Re: [PATCH] Drop $(EXEEXT) suffix from shared libraries

2020-12-09 Thread Dmitry V. Levin
On Wed, Dec 09, 2020 at 11:42:44PM +0100, Mark Wielaard wrote: > Hi Dmitry, > > On Thu, 2020-12-10 at 01:20 +0300, Dmitry V. Levin wrote: > > OK, there was no mystery at all: > > > > $ git grep '_PROGRAMS.*_LIBRARIES' > > libasm/Makefile.am:noin

[PATCH] Fix automake warnings

2020-12-09 Thread Dmitry V. Levin
f.so$(EXEEXT)' Fix this by renaming noinst_PROGRAMS to noinst_DATA and removing no longer needed lib{asm,dw,elf}_so_SOURCES variables. Reported-by: Mark Wielaard Fixes: 2f02e8151094 ("Drop $(EXEEXT) suffix from shared libraries") Signed-off-by: Dmitry V. Levin --- libasm/Cha

Re: [PATCH] Fix automake warnings

2020-12-10 Thread Dmitry V. Levin
On Thu, Dec 10, 2020 at 11:09:21AM +0100, Mark Wielaard wrote: > On Thu, 2020-12-10 at 02:34 +0300, Dmitry V. Levin wrote: > > Apparently, commit 2f02e81510946a4c8e9157ad0b72d92894b9acd7 that > > removed > > $(EXEEXT) suffix from shared libraries was incomplete: it missed t

Re: [PATCH] Fix automake warnings

2020-12-10 Thread Dmitry V. Levin
On Thu, Dec 10, 2020 at 12:28:35PM +0100, Mark Wielaard wrote: > Hi Dmitry, > > On Thu, 2020-12-10 at 13:30 +0300, Dmitry V. Levin wrote: > > On Thu, Dec 10, 2020 at 11:09:21AM +0100, Mark Wielaard wrote: > > > Very nice. I have one small issue, with automake 1.13.4 whe

[PATCH] Remove unused Makefile variable GCC_INCLUDE

2020-12-10 Thread Dmitry V. Levin
It appears to be unused since the first commit in the revision history. Signed-off-by: Dmitry V. Levin --- libasm/ChangeLog | 4 libasm/Makefile.am | 1 - libelf/ChangeLog | 4 libelf/Makefile.am | 2 +- 4 files changed, 9 insertions(+), 2 deletions(-) diff --git a/libasm

[PATCH] configure.ac: fix typo in error diagnostics

2020-12-10 Thread Dmitry V. Levin
Fixes: da855fc9c ("Support building when fts and obstack aren't part of libc") Signed-off-by: Dmitry V. Levin --- ChangeLog| 4 configure.ac | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 71e80a25..563af0d2 100644 --- a/

[PATCH] configure.ac: simplify argp check

2020-12-10 Thread Dmitry V. Levin
Rewrite argp check using the same AC_SEARCH_LIBS based method used earlier in the fts check. Signed-off-by: Dmitry V. Levin --- ChangeLog| 2 ++ configure.ac | 31 --- 2 files changed, 10 insertions(+), 23 deletions(-) diff --git a/ChangeLog b/ChangeLog index

[PATCH] Remove unused tests/configure.ac

2020-12-10 Thread Dmitry V. Levin
644 tests/configure.ac diff --git a/ChangeLog b/ChangeLog index def6279a..92efa22f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,7 @@ 2020-12-11 Dmitry V. Levin + * configure.ac (AM_CONDITIONAL): Remove HAVE_LIBASM and STANDALONE. + * configure.ac: Rewrite argp ch

[PATCH] doc: fix spelling typos

2020-12-11 Thread Dmitry V. Levin
filesytem -> filesystem requries -> requires hte -> the recieve -> receive varients -> variants preceeded -> preceded Signed-off-by: Dmitry V. Levin --- doc/ChangeLog | 7 +++ doc/debuginfod.8| 2 +- doc/debuginfod_find_debuginfo

[PATCH] libdwelf: fix spelling typos in strings returned by dwelf_elf_e_machine_string

2020-12-11 Thread Dmitry V. Levin
embeded -> embedded Semicondutor -> Semiconductor Signed-off-by: Dmitry V. Levin --- libdwelf/ChangeLog| 5 + libdwelf/dwelf_elf_e_machine_string.c | 6 +++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/libdwelf/ChangeLog b/libdwelf/ChangeLog

[PATCH] src: fix spelling typos in argp help text and error diagnostics

2020-12-11 Thread Dmitry V. Levin
Since all these help text strings are marked for translation, apply the fixes to translation strings as well, this helps to avoid translations becoming fuzzy. lenght -> length occured -> occurred endianess -> endianness reversable -> reversible Signed-off-by: Dmitry V. Levin ---

[PATCH 00/12] Fix spelling typos in comments, tests, and text files

2020-12-12 Thread Dmitry V. Levin
This is the least significant part of all spelling fixes, most users won't notice any difference at all, but it still makes sense to use correct spelling. Dmitry V. Levin (12): debuginfod: fix spelling typos in error diagnostics and comments backends: fix spelling typos in comments c

[PATCH 01/12] debuginfod: fix spelling typos in error diagnostics and comments

2020-12-12 Thread Dmitry V. Levin
Initalize -> Initialize Unsucessful -> Unsuccessful expession -> expression incompatiblity -> incompatibility Signed-off-by: Dmitry V. Levin --- debuginfod/ChangeLog | 7 +++ debuginfod/debuginfod-client.c | 4 ++-- debuginfod/debuginfod.cxx | 6 +++--- 3 files

[PATCH 02/12] backends: fix spelling typos in comments

2020-12-12 Thread Dmitry V. Levin
adress -> address sigle -> single Signed-off-by: Dmitry V. Levin --- backends/ChangeLog| 6 ++ backends/aarch64_retval.c | 2 +- backends/ppc_cfi.c| 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/backends/ChangeLog b/backends/ChangeLog index e8

[PATCH 03/12] config: fix spelling typos in comments and %changelog

2020-12-12 Thread Dmitry V. Levin
directoy -> directory fo -> for funtions -> functions ist -> is mutliple -> multiple priviliges -> privileges reenable -> re-enable Signed-off-by: Dmitry V. Levin --- config/10-default-yama-scope.conf | 2 +- config/ChangeLog | 6 ++ config/elfutils.s

[PATCH 04/12] libasm: fix spelling typos in comments

2020-12-12 Thread Dmitry V. Levin
endianess -> endianness setion -> section Signed-off-by: Dmitry V. Levin --- libasm/ChangeLog | 5 + libasm/asm_begin.c | 2 +- libasm/asm_end.c | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/libasm/ChangeLog b/libasm/ChangeLog index 6268b26c..78f1baa4

[PATCH 05/12] libcpu: fix spelling typos in comments

2020-12-12 Thread Dmitry V. Levin
layed -> laid adressing -> addressing Signed-off-by: Dmitry V. Levin --- libcpu/ChangeLog | 5 + libcpu/bpf_disasm.c | 2 +- libcpu/i386_disasm.c | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/libcpu/ChangeLog b/libcpu/ChangeLog index a342b7f6..000105bf

[PATCH 06/12] libdw: fix spelling typos in comments and ChangeLog

2020-12-12 Thread Dmitry V. Levin
Retieve -> Retrieve apporiate -> appropriate distinquish -> distinguish dynamicly -> dynamically indeces -> indices lenght -> length minium -> minimum occured -> occurred setion -> section unknow -> unknown Signed-off-by: Dmitry V. Levin --- libdw/ChangeLog

[PATCH 07/12] libdwelf: fix spelling typos in comments

2020-12-12 Thread Dmitry V. Levin
algorith -> algorithm occured -> occurred Signed-off-by: Dmitry V. Levin --- libdwelf/ChangeLog | 3 +++ libdwelf/dwelf_strtab.c | 2 +- libdwelf/libdwelf.h | 4 ++-- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/libdwelf/ChangeLog b/libdwelf/ChangeLog index 9d

[PATCH 08/12] libdwfl: fix spelling typos in comments and ChangeLog

2020-12-12 Thread Dmitry V. Levin
adresses -> addresses boundery -> boundary explictly -> explicitly fo -> for layed -> laid partical -> particular setion -> section substract -> subtract wil -> will Signed-off-by: Dmitry V. Levin --- libdwfl/ChangeLog | 13 ++--- libdwfl/

[PATCH 09/12] libelf: fix spelling typos in comments

2020-12-12 Thread Dmitry V. Levin
Auxialiary -> Auxiliary constucted -> constructed desriptor -> descriptor endianess -> endianness responsibilty -> responsibility sufficent -> sufficient elf.h comes from glibc and therefore is excluded. Signed-off-by: Dmitry V. Levin --- libelf/ChangeLog | 11 +

[PATCH 10/12] src: fix spelling typos in comments and ChangeLog

2020-12-12 Thread Dmitry V. Levin
Indeces -> Indices adress -> address affort -> afford dont' -> don't futher -> further higest -> highest indeces -> indices interate -> iterate occured -> occurred overlow -> overflow sectin -> section succesful -> successful teminated -> ter

[PATCH 11/12] tests: fix spelling typos in error diagnostics and comments

2020-12-12 Thread Dmitry V. Levin
Cannnot -> Cannot decriptors -> descriptors experssions -> expressions explit -> explicit falg -> flag irrelevent -> irrelevant mininum -> minimum outselves -> ourselves proces -> process versio -> version Signed-off-by: Dmitry V. Levin --- tests/Ch

[PATCH 12/12] Fix spelling typos in NEWS, NOTES, TODO, and in comments of configure.ac

2020-12-12 Thread Dmitry V. Levin
rely suport -> support tranformation -> transformation Signed-off-by: Dmitry V. Levin --- ChangeLog| 7 +++ NEWS | 18 +- NOTES| 4 ++-- TODO | 2 +- configure.ac | 6 +++--- libebl/ChangeLog | 2 +- 6 files changed, 23

[PATCH 1/2] configure.ac: remove unneeded AC_CONFIG_MACRO_DIR([m4])

2020-12-15 Thread Dmitry V. Levin
Makefile.am already contains "ACLOCAL_AMFLAGS = -I m4", that is enough for autoreconf to do the right thing. Tested with autoreconf -if && ./configure --enable-maintainer-mode && make && make distcheck Signed-off-by: Dmitry V. Levin --- ChangeLog| 4

[PATCH 2/2] m4: remove unneeded Makefile.am

2020-12-15 Thread Dmitry V. Levin
m4 files do not have to listed in EXTRA_DIST, in fact, biarch.m4 has not been listed since its very beginning in 2013, and nobody seems to have noticed so far. Tested with autoreconf -if && ./configure --enable-maintainer-mode && make && make distcheck Signed

Re: [PATCH 1/2] configure.ac: remove unneeded AC_CONFIG_MACRO_DIR([m4])

2020-12-15 Thread Dmitry V. Levin
On Tue, Dec 15, 2020 at 04:07:02PM +0100, Mark Wielaard wrote: > On Tue, 2020-12-15 at 17:40 +0300, Dmitry V. Levin wrote: > > Makefile.am already contains "ACLOCAL_AMFLAGS = -I m4", > > that is enough for autoreconf to do the right thing. > > But is that a goo

Re: [PATCH 1/2] configure.ac: remove unneeded AC_CONFIG_MACRO_DIR([m4])

2020-12-15 Thread Dmitry V. Levin
Hi, On Tue, Dec 15, 2020 at 03:14:27PM -0500, Frank Ch. Eigler wrote: > Hi - > > > I think it is too early to switch to autoconf 2.70. Currently we > > require autoconf 2.63 and automake 1.11. We could probably upgrade to > > autconf 2.69 and automake 1.13, but that doesn't seem to help with > >

Re: [PATCH] elflint: Always print symbol name (if known) in error messages.

2020-12-15 Thread Dmitry V. Levin
On Tue, Dec 15, 2020 at 09:52:40PM +0100, Mark Wielaard wrote: > Adding the symbol name associated with the symbol index number > makes the error messages a little bit more useful. We used to say: > > section [59] '.symtab': symbol 9: st_value out of bounds > > But now says: > > section [59] '.s

Re: [PATCH] elflint: Always print symbol name (if known) in error messages.

2020-12-15 Thread Dmitry V. Levin
Hi Mark, On Tue, Dec 15, 2020 at 11:53:48PM +0100, Mark Wielaard wrote: > Hi Dmitry, > > On Wed, Dec 16, 2020 at 12:44:05AM +0300, Dmitry V. Levin wrote: > > This is nice, thanks. > > I have one question about the patch: > > > > [...] > > > ---

Q: splitting the top level .gitignore file

2020-12-15 Thread Dmitry V. Levin
On Wed, Dec 16, 2020 at 02:40:32AM +0300, Dmitry V. Levin wrote: [...] > Use this opportunity to create separate .gitignore files for m4/ and po/ > directories. By the way, what do you think about moving subdirectory parts of the top level .gitignore file into subdirectories? This wo

[PATCH] libebl: consistently use _(Str) instead of gettext(Str)

2020-12-15 Thread Dmitry V. Levin
-git a/libebl/ChangeLog b/libebl/ChangeLog index 04e9cd49..e0862ec3 100644 --- a/libebl/ChangeLog +++ b/libebl/ChangeLog @@ -1,3 +1,17 @@ +2020-12-15 Dmitry V. Levin + + * eblbackendname.c (ebl_backend_name): Replace gettext(...) with _(...). + * eblcorenotetypename.c (ebl_core_

[PATCH 1/4] Consistently define _(Str) using dgettext ("elfutils", Str)

2020-12-16 Thread Dmitry V. Levin
) and _(Str) macros from other files to avoid conflicts and redundancies. The next step is to replace all uses of gettext(Str) with _(Str). Signed-off-by: Dmitry V. Levin --- lib/ChangeLog | 5 + lib/eu-config.h | 3 ++- lib/xmalloc.c | 4 libasm/ChangeLog| 4

  1   2   >