[Bug general/32682] in configure, __asm__ should be used instead of asm

2025-02-12 Thread mark at klomp dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=32682 Mark Wielaard changed: What|Removed |Added Resolution|--- |NOTABUG Status|UNCONFIRME

Re: [PATCH 01/10 v2] Change type of dwarf_lock from rwlock to mutex

2025-02-12 Thread Mark Wielaard
On Tue, 2025-02-04 at 16:50 -0500, Aaron Merey wrote: > Change type of dwarf_lock to mutex in order to take advantage of > built-in support for recursive locking. > > * lib/locks.h: Add macros for locking, unlocking, initializing > and destroying mutexes. > * libdw/dwarf_begin_el

Re: [PATCH 02/10 v2] dwarf_filesrc.c: Add locking

2025-02-12 Thread Mark Wielaard
Hi Aaron, On Tue, 2025-02-04 at 16:50 -0500, Aaron Merey wrote: > * libdw/dwarf_getsrclines.c (read_srcfiles): Initialize Dwarf > member. > * libdw/dwarf_filesrc.c (dwarf_filesrc): Use dwarf_lock. > * libdw/libdwP.h (struct Dwarf_Files_s): Add Dwarf member. > > Signed-off-

Re: [PATCH 04/10 v2] dwarf_offdie.c: Add locking

2025-02-12 Thread Mark Wielaard
Hi Aaron, On Tue, 2025-02-04 at 16:50 -0500, Aaron Merey wrote: > * libdw/dwarf_offdie.c (__libdw_offdie): Use dwarf_lock. > > Signed-off-by: Aaron Merey > --- > v2 changes: Lock only for the duration of __libdw_findcu. __libdw_findcu already has internal locking. Isn't that enough? > l

Re: [PATCH 05/10 v2] Add configure option --enable-helgrind

2025-02-12 Thread Mark Wielaard
Hi Aaron, On Tue, 2025-02-04 at 16:50 -0500, Aaron Merey wrote: > Like --enable-valgrind but uses helgrind instead of memcheck. > > If both --enable-valgrind and --enable-helgrind are given then > helgrind takes priority. > > --enable-helgrind requires --enable-valgrind-annotations. > > *

Re: [PATCH 03/10 v2] libdw: Add locking to dwarf_getsrcfiles and dwarf_getsrclines

2025-02-12 Thread Mark Wielaard
Hi Aaron, On Tue, 2025-02-04 at 16:50 -0500, Aaron Merey wrote: > * libdw/dwarf_getsrcfiles.c (dwarf_getsrcfiles): Use dwarf_lock. > * libdw/dwarf_getsrclines.c (dwarf_getsrclines): Use dwarf_lock. > > Signed-off-by: Aaron Merey > --- > v2 changes: Combined from v1 patches 04/15 and

Re: [PATCH 06/10 v2] Add tests/thread-safety-subr.sh

2025-02-12 Thread Mark Wielaard
Hi Aaron, On Tue, 2025-02-04 at 16:50 -0500, Aaron Merey wrote: > thread-safety-subr.sh contains subroutine check_thread_safety_enabled > which skips further testing when USE_LOCKS is false. > > * tests/Makefile.am (EXTRA_DIST): Add thread-safety-subr.sh. > * tests/thread-safety-subr.

[Bug backends/32684] New: aarch64 linux 4 build failure: struct user_pac_mask not defined

2025-02-12 Thread me at harmenstoppels dot nl
https://sourceware.org/bugzilla/show_bug.cgi?id=32684 Bug ID: 32684 Summary: aarch64 linux 4 build failure: struct user_pac_mask not defined Product: elfutils Version: unspecified Status: UNCONFIRMED Severity: n

[PATCH] libelf: Handle elf_strptr on section without any data

2025-02-12 Thread Mark Wielaard
In the unlikely situation that elf_strptr was called on a section with sh_size already set, but that doesn't have any data yet we could crash trying to verify the string to return. This could happen for example when a new section was created with elf_newscn, but no data having been added yet.