[PATCH] srcfiles.cxx: Prevent fd and entry leak

2024-11-18 Thread Aaron Merey
Make sure to free fd and the archive entry if an error is encountered while adding source files to the archive. Signed-off-by: Aaron Merey --- src/srcfiles.cxx | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/src/srcfiles.cxx b/src/srcfiles.cxx index c46

[PATCH] libdw: Don't use ATOMIC_VAR_INIT

2024-11-18 Thread Mark Wielaard
ATOMIC_VAR_INIT was introduced in C11, but not deemed necessary to implement atomics. So deprecated in C17 and removed in C23. Normal initialization syntax should be sufficient. * libdw/libdw_alloc.c (next_id): Initialize to zero without using ATOMIC_VAR_INIT. Signed-off-by: Mark

[PATCH] Cleanup Makefile.am CLEANFILES definitions

2024-11-18 Thread Mark Wielaard
Since b2f225d6bff8 ("Consolidate and add files to clean target variables") autoreconf (automake) produces these warnings: debuginfod/Makefile.am:130: warning: CLEANFILES multiply defined in condition TRUE ... config/eu.am:138: ... 'CLEANFILES' previously defined here debuginfod/Makefile.am:32:

Re: [PATCH] Cleanup Makefile.am CLEANFILES definitions

2024-11-18 Thread Aaron Merey
On Mon, Nov 18, 2024 at 1:12 PM Mark Wielaard wrote: > > Since b2f225d6bff8 ("Consolidate and add files to clean target variables") > autoreconf (automake) produces these warnings: > > debuginfod/Makefile.am:130: warning: CLEANFILES multiply defined in condition > TRUE ... > config/eu.am:138: ...

Re: [PATCH] Cleanup Makefile.am CLEANFILES definitions

2024-11-18 Thread Michael Pratt
Hi Mark, > Since b2f225d6bff8 ("Consolidate and add files to clean target variables") > autoreconf (automake) produces these warnings: oops, sorry... > This is because config/eu.am defines a default CLEANFILES. So those > Makefile.am files should add to CLEANFILES with += instead of > redef

Re: [PATCH] libdw: Don't use ATOMIC_VAR_INIT

2024-11-18 Thread Aaron Merey
Hi Mark, On Mon, Nov 18, 2024 at 1:56 PM Mark Wielaard wrote: > > ATOMIC_VAR_INIT was introduced in C11, but not deemed necessary to > implement atomics. So deprecated in C17 and removed in C23. Normal > initialization syntax should be sufficient. > > * libdw/libdw_alloc.c (next_id): Init