Re: [PATCH 2/9 v2] doc: Add elf32_fsize.3 and elf64_fsize.3

Hi Aaron, On Wed, 2024-10-02 at 22:26 -0400, Aaron Merey wrote: > Signed-off-by: Aaron Merey > > --- > v2 changes: > Reword description. > > State EV_CURRENT is the only valid version. > > Mention possibility of integer overflow. > > On Tue, Aug 27, 2024 at 12:32 PM Mark Wielaard wrote: > >

Re: [PATCH 3/9 v2] doc: Add elf32_getchdr.3 and elf64_getchdr.3

Hi Aaron, On Wed, 2024-10-02 at 22:26 -0400, Aaron Merey wrote: > Signed-off-by: Aaron Merey > --- > > v2 changes: > > Mention that SHF_COMPRESSED must be set. > > Add elf_compress (3) to SEE ALSO. > > Remove "This elfutils libelf function may not be > found in other libelf implementations".

Re: [PATCH 1/6] lib: Add missing config.h include to next_prime.c

Hi Mark, On Monday, October 14th, 2024 at 16:38, Mark Wielaard wrote: > > > There isn't much code in this file. What kind of build issue are you > seeing without this? Does config.h contain some construct that affects > the build of this file? Like I mentioned in the cover letter, we inco

Re: [PATCH 1/9 v2] doc: Add elf32_checksum.3 and elf64_checksum.3

Hi Aaron, On Wed, 2024-10-02 at 22:26 -0400, Aaron Merey wrote: > Signed-off-by: Aaron Merey > > --- > v2 changes: > elf64_checksum.3 now refers to elf32_checksum.3. > > Explained which sections are used to calculate the checksum. > > Mentioned DT_CHECKSUM. > > Mentioned that the checksum is

Re: [PATCH 5/9 v2] doc: Add elf32_getshdr.3 and elf64_getshdr.3

Hi Aaron, On Wed, 2024-10-02 at 22:26 -0400, Aaron Merey wrote: > Signed-off-by: Aaron Merey > --- > > v2 changes: > Mention elf_flagshdr. > > Mention NULL is returned if scn is NULL. This version looks good to me. Thanks, Mark

Re: [PATCH 7/9 v2] doc: Add elf32_newphdr.3 and elf64_newphdr.3

Hi Aaron, On Wed, 2024-10-02 at 22:26 -0400, Aaron Merey wrote: > v2 changes: > Mention new program header table is zero'ed out and that > NULL is returned if elf is NULL. Looks good. Thanks, Mark

Re: [PATCH 4/9 v2] doc: Add elf32_getphdr.3 and elf64_getphdr.3

Hi Aaron, On Wed, 2024-10-02 at 22:26 -0400, Aaron Merey wrote: > Signed-off-by: Aaron Merey > --- > v2 changes: > Improved description. > > Mention that NULL is returned if there is no program header. > > Add elf_getphdrnum and elf32_newphdr to SEE ALSO. This version looks good to me. Thanks

Re: [PATCH 6/9 v2] doc: Add elf32_newehdr.3 and elf64_newehdr.3

Hi Aaron, On Wed, 2024-10-02 at 22:26 -0400, Aaron Merey wrote: > v2 changes: > Mention that the existing header will be returned if one is > already present. > > Mention that an ELF header must be present before callling > elf_newscn or elf_newphdr Looks good to me. Thanks, Mark

Re: [PATCH] PR32218: debuginfod-client: support very long source file

Hi Frank, On Thu, 2024-10-10 at 17:24 -0400, Frank Ch. Eigler wrote: > From be79d138989b9968f9c687ef62cc91b5b93e32b5 Mon Sep 17 00:00:00 2001 > From: "Frank Ch. Eigler" > Date: Thu, 10 Oct 2024 16:30:19 -0400 > Subject: [PATCH] PR32218: debuginfod-client: support very long source file > names >

[PATCH 1/4] eu-stacktrace: add eu-stacktrace tool

eu-stacktrace is a utility to process a stream of raw stack samples (such as those obtained from the Linux kernel's PERF_SAMPLE_STACK facility) into a stream of stack traces (such as those obtained from PERF_SAMPLE_CALLCHAIN), freeing other profiling utilities from having to implement their own bac

[PATCH 2/4] eu-stacktrace: configury for initial version (x86/sysprof only)

Due to the x86-specific code in the initial version the configury has significant restrictions. If --enable-stacktrace is not explicitly provided, then eu-stacktrace will be disabled by default when x86 architecture or sysprof headers are absent. The way we test for x86 is a bit unusual. What we a

[PATCH 3/4] eu-stacktrace: add unwind origin diagnostics

Track the method used to unwind each Dwfl_Frame using an enum field unwound_source; provide access to the field. Then use that in eu-stacktrace to display the unwind methods used for each process. This is an important diagnostic to verify how many processes are adequately covered by the eh_frame u

[PATCH 4/4] eu-stacktrace: add unwind origin diagnostics to eu-stack

Since we obtain diagnostics about unwind method, another logical place to show them is in eu-stack. This requires an additional pseudo-unwind type DWFL_UNWOUND_INLINE to clarify what happens with entries for inlined functions (which eu-stacktrace does not display) based on the same Dwfl_Frame. *

Re: [PATCH 6/6] Use file stream or format variants of stdio print functions

Hi again, On Monday, October 14th, 2024 at 17:30, Mark Wielaard wrote: > > > If we are trying to be more consistent then I think I would prefer we > use putchar, puts, and printf, instead of adding stdout to all these > calls. I don't really have a preference, you could even throw out th

Re: [PATCH 8/9 v2] doc: Add elf{32, 64}_xlatetof.3 and elf{32, 64}_xlatetom.3

Hi Aaron, On Wed, Oct 02, 2024 at 10:26:09PM -0400, Aaron Merey wrote: > v2 changes: > Merge xlatetof and xlatetom man pages. > > Added additional details suggested in Mark's review > https://sourceware.org/pipermail/elfutils-devel/2024q3/007377.html I like this version. One small wording questi

Re: Preparing for the 0.192 release on Friday October 18

On Thu, Oct 3, 2024, at 12:22 PM, Aaron Merey wrote: > If your patch is still under review [1] or you have other patches you'd > like merged before the release, please let us know. I posted a cleaned-up patch series for eu-stacktrace this morning [2]. Hoping that can make it in. [2]: https://pa

Re: [PATCH 9/9] doc/Makefile.am: Add man pages

Hi Aaron, On Wed, Oct 02, 2024 at 10:26:10PM -0400, Aaron Merey wrote: > Add the following man pages to notrans_dist_man3_MANS: > > elf32_xlatetom.3 elf64_xlatetom.3 elf32_xlatetof.3 elf64_xlatetof.3 > elf32_newphdr.3 elf64_newphdr.3 elf32_newehdr.3 elf64_newehdr.3 > elf32_getshdr.3 elf64_getshdr

Re: [PATCH] PR32218: debuginfod-client: support very long source file

Hi - > Hi Frank, Thanks for the review. > Maybe add the bugzilla URL as an example of this. > I see it is in the subject, but it is nice to just click on something. Done. > [...] > Is this 4-byte hash enough to prevent accidental collisions? Yeah, it only needs to be uniqueish among source fi

Re: [PATCH 6/6] Use file stream or format variants of stdio print functions

Hi Michael, On Tue, Oct 15, 2024 at 03:10:16PM +, Michael Pratt wrote: > > If we are trying to be more consistent then I think I would prefer we > > use putchar, puts, and printf, instead of adding stdout to all these > > calls. > > I don't really have a preference, you could even throw out t