Re: [PATCH] readelf: Don't print average number of tests when no tests are done

2023-11-20 Thread Mark Wielaard
Hi, On Wed, 2023-11-15 at 17:41 +0100, Mark Wielaard wrote: > If the symbol hash table only contains lenght zero chains, no lookup > tests need to be done and eu-readelf -I would print out bogus numbers > for the number of tests that were successful/unsuccessful. > > e.g. for an "empty" program l

Re: [PATCH 2/2] tests: Add test for duplicate entries in archive

2023-11-20 Thread Aleksei Vetrov
Hello Mark, On Sat, Nov 18, 2023 at 10:50 PM Mark Wielaard wrote: > Do note that you also have to add the new test file to > EXTRA_DIST so it actually gets into the dist. Thanks, will do in [PATCH v2].

Re: [PATCH 1/2] libdwfl: handle duplicate ELFs when reporting archives

2023-11-20 Thread Aleksei Vetrov
Hello Mark, On Sat, Nov 18, 2023 at 10:47 PM Mark Wielaard wrote: > If we goto overlap here don't we still have a problem? overlap will > set m->gc = true; and return NULL. So the caller will think they > still owns the elf handle and will probably close it. But then when > the module is GCed in

[PATCH v2 1/2] libdwfl: handle duplicate ELFs when reporting archives

2023-11-20 Thread Aleksei Vetrov
When archive is processed in process_archive (libdwfl/offline.c), it creates an Elf object for each archive member. Then in process_archive_member it calls process_file to create a Dwfl_Module through __libdwfl_report_elf. The ownership of the Elf object is expected to be: * either transfered to

[PATCH v2 2/2] tests: Add test for duplicate entries in archive

2023-11-20 Thread Aleksei Vetrov
Test dwfl-report-offline-memory against an archive that contains non-relocatable ELFs with the same name and contents. * tests/test-ar-duplicates.a.bz2: New test file. * tests/run-dwfl-report-offline-memory.sh: Test new test-ar-duplicates.a.bz2. * tests/Makefile.am (EXTRA_DIST):