[Bug libdw/30047] libdw unable to handle DW_TAG_unspecified_type

2023-02-14 Thread mliska at suse dot cz via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=30047 --- Comment #7 from Martin Liska --- Thank you, Mark. Can you please commit the patch so that very can cherry-pick it? -- You are receiving this mail because: You are on the CC list for the bug.

Re: (subset) [PATCH v3 1/4] tests: Ignore dwfl-report-offline-memory

2023-02-14 Thread Mark Wielaard
On Mon, 13 Feb 2023 17:45:48 +0100, Ilya Leoshkevich wrote: > It's showing up in git status when configuring in the source directory. > > Applied, thanks! [1/4] tests: Ignore dwfl-report-offline-memory commit: 8ececddf9de612bc556b16df234254291196a65d Best regards, -- Mark Wielaard

Re: (subset) [PATCH v3 2/4] printversion: Fix unused variable

2023-02-14 Thread Mark Wielaard
On Mon, 13 Feb 2023 17:45:49 +0100, Ilya Leoshkevich wrote: > clang complains: > > debuginfod.cxx:354:1: error: unused variable 'apba__' > [-Werror,-Wunused-const-variable] > ARGP_PROGRAM_BUG_ADDRESS_DEF = PACKAGE_BUGREPORT; > ^ > ../lib/printversion.h:47:21: note: expanded from m

Re: [PATCH v3 3/4] backends: Support returning lvalue and rvalue references

2023-02-14 Thread Mark Wielaard
Hi Ilya, On Mon, 2023-02-13 at 17:45 +0100, Ilya Leoshkevich wrote: > On the low level, they are the same as pointers. The change needs to be > done for all backends, so define a function and a macro to avoid > repetition. Also add a native test, which has to be implemented in C++. > Add the confi

Re: [PATCH v3 4/4] configure: Add --enable-sanitize-memory

2023-02-14 Thread Mark Wielaard
Hi Ilya, On Mon, 2023-02-13 at 17:45 +0100, Ilya Leoshkevich wrote: > Add support for clang Memory Sanitizer [1], which detects the usage of > uninitialized values. While elfutils itself is already checked with > valgrind, checking code that depends on elfutils requires elfutils to > be built with

[Bug libdw/30047] libdw unable to handle DW_TAG_unspecified_type

2023-02-14 Thread mark at klomp dot org via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=30047 Mark Wielaard changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED

Re: [PATCH v2] libdw: check memory access in get_(u|s)leb128

2023-02-14 Thread Mark Wielaard
Hi Aleksei, On Mon, 2023-02-13 at 20:10 +, Aleksei Vetrov via Elfutils-devel wrote: > __libdw_get_uleb128 and __libdw_get_sleb128 should check if addrp has > already reached the end before unrolling the first step. It is done by > moving __libdw_max_len to the beginning of the function, which

☠ Buildbot (Sourceware): elfutils - failed test (failure) (master)

2023-02-14 Thread builder--- via Elfutils-devel
A new failure has been detected on builder elfutils-debian-ppc64 while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/63/builds/145 Build state: failed test (failure) Revision: 8ececddf9de612bc556b16df234254291196a65d Worker: debian-ppc64

Re: [PATCH] libdw: Handle DW_OP_GNU_uninit in dwarf_getlocation

2023-02-14 Thread Mark Wielaard
Hi, On Fri, 2023-02-10 at 14:01 +0100, Mark Wielaard wrote: > dwarf_getlocation would return an error when it saw a > DW_OP_GNU_uninit. Handle it by simply recognizing as a no argument > operation. > > DW_OP_GNU_uninit is emitted by GCC as a marker to flag the location > expression as referring t

Re: ☠ Buildbot (Sourceware): elfutils - failed test (failure) (master)

2023-02-14 Thread Mark Wielaard
Hi, On Tue, 2023-02-14 at 16:14 +, builder--- via Elfutils-devel wrote: > A new failure has been detected on builder elfutils-debian-ppc64 while > building elfutils. > > Full details are available at: > https://builder.sourceware.org/buildbot/#builders/63/builds/145 > > Build state: fai

☺ Buildbot (Sourceware): elfutils - build successful (master)

2023-02-14 Thread builder--- via Elfutils-devel
A restored build has been detected on builder elfutils-debian-ppc64 while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/63/builds/149 Build state: build successful Revision: f2c522567ad63ac293535fba9704895e685ab5bc Worker: debian-ppc64 Bu

☠ Buildbot (Sourceware): elfutils - failed test (failure) (master)

2023-02-14 Thread builder--- via Elfutils-devel
A new failure has been detected on builder elfutils-opensuseleap-x86_64 while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/90/builds/119 Build state: failed test (failure) Revision: e444d60a341b7b9bc3ae763a843d3e7190234ca9 Worker: bb2-2

☠ Buildbot (Sourceware): elfutils - failed test (failure) (master)

2023-02-14 Thread builder--- via Elfutils-devel
A new failure has been detected on builder elfutils-debian-armhf while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/6/builds/143 Build state: failed test (failure) Revision: 922068cebba6ed0dfc2da0a9e40e3e1b63e0aca9 Worker: debian-armhf B

Re: ☠ Buildbot (Sourceware): elfutils - failed test (failure) (master)

2023-02-14 Thread Mark Wielaard
On Tue, Feb 14, 2023 at 04:56:39PM +, builder--- via Elfutils-devel wrote: > A new failure has been detected on builder elfutils-opensuseleap-x86_64 while > building elfutils. > > Full details are available at: > https://builder.sourceware.org/buildbot/#builders/90/builds/119 > > Build s

Re: ☠ Buildbot (Sourceware): elfutils - failed test (failure) (master)

2023-02-14 Thread Mark Wielaard
On Tue, Feb 14, 2023 at 05:02:06PM +, builder--- via Elfutils-devel wrote: > A new failure has been detected on builder elfutils-debian-armhf while > building elfutils. > > Full details are available at: > https://builder.sourceware.org/buildbot/#builders/6/builds/143 > > Build state: fa

[COMMITTED] libdw: Correct data end checkfor deref_type operand in dwarf_getlocation

2023-02-14 Thread Mark Wielaard
In __libdw_intern_expression we checked for one byte too many. We only need one byte for the size and (at least one) for the uleb128 DIE reference. Signed-off-by: Mark Wielaard --- This wrong check caused the recent buildbot failure on some arches. libdw/ChangeLog | 5 + libdw/dw

☺ Buildbot (Sourceware): elfutils - build successful (master)

2023-02-14 Thread builder--- via Elfutils-devel
A restored build has been detected on builder elfutils-debian-armhf while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/6/builds/145 Build state: build successful Revision: 0e8306768a6d0195c01644e7c5a6fff027fd19f2 Worker: debian-armhf Bui

[PATCH] libdw: check that DWARF strings are null-terminated

2023-02-14 Thread Aleksei Vetrov via Elfutils-devel
From: Aleksei Vetrov It is expected from libdw to return strings that are null-terminated to avoid overflowing ELF data. * Add calculation of a safe prefix inside string sections, where any string will be null-terminated. * Check if offset overflows the safe prefix in dwarf_formstring. Signe

[COMMITTED] doc: Add .TP before -g in debuginfod.8

2023-02-14 Thread Mark Wielaard
Fixes indentation of -g option. Signed-off-by: Mark Wielaard --- doc/ChangeLog| 4 doc/debuginfod.8 | 1 + 2 files changed, 5 insertions(+) diff --git a/doc/ChangeLog b/doc/ChangeLog index b2ef357a..7f2d6ff4 100644 --- a/doc/ChangeLog +++ b/doc/ChangeLog @@ -1,3 +1,7 @@ +2023-02-14 Ma

[PATCH v2 0/1] libdw: check that DWARF strings are null-terminated

2023-02-14 Thread Aleksei Vetrov via Elfutils-devel
Hello, In the first version of the patch was typo "secton" everywhere. Reuploading fixed version. Aleksei Vetrov (1): libdw: check that DWARF strings are null-terminated libdw/dwarf_begin_elf.c | 37 + libdw/dwarf_formstring.c | 5 - libdw/libdwP.h

[PATCH v2 1/1] libdw: check that DWARF strings are null-terminated

2023-02-14 Thread Aleksei Vetrov via Elfutils-devel
It is expected from libdw to return strings that are null-terminated to avoid overflowing ELF data. * Add calculation of a safe prefix inside string sections, where any string will be null-terminated. * Check if offset overflows the safe prefix in dwarf_formstring. Signed-off-by: Aleksei Vetro

☺ Buildbot (Sourceware): elfutils - build successful (master)

2023-02-14 Thread builder--- via Elfutils-devel
A restored build has been detected on builder elfutils-debian-ppc64 while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/63/builds/154 Build state: build successful Revision: 67199e1c974db37f2bd200dcca7d7103f42ed06e Worker: debian-ppc64 Bu