[Bug libdw/30047] libdw unable to handle DW_TAG_unspecified_type

2023-02-07 Thread mark at klomp dot org via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=30047 Mark Wielaard changed: What|Removed |Added Attachment #14633|0 |1 is obsolete|

Re: [PATCH] libdw: check memory access in get_(u|s)leb128

2023-02-07 Thread Aleksei Vetrov via Elfutils-devel
Hi Mark, > Did you actually find situations where these functions were called with addrp > >= endp? Yes, for example libdw/libdw_form.c:91:7. > It turns out that get_[su]leb128 dominates some operations and really does > have to be as fast as possible. So I do like to know what the impact is of

Re: [PATCH] libdw: check memory access in get_(u|s)leb128

2023-02-07 Thread Mark Wielaard
Hi Aleksei, On Tue, 2023-02-07 at 16:17 +, Aleksei Vetrov wrote: > > Did you actually find situations where these functions were called > > with addrp > > > = endp? > > Yes, for example libdw/libdw_form.c:91:7. > Urgh. There are actually 3 places in that function that need a guard. Then I s

Re: [PATCH RFC 00/11] Add Memory Sanitizer support

2023-02-07 Thread Mark Wielaard
Hi Ilya, On Mon, Feb 06, 2023 at 11:25:02PM +0100, Ilya Leoshkevich via Elfutils-devel wrote: > This series adds minimalistic support for Memory Sanitizer (MSan) [1]. > MSan is compiler instrumentation for detecting accesses to > uninitialized memory. > > The motivation behind this is to be able

Re: [PATCH RFC 01/11] libdwfl: Fix debuginfod_client redefinition

2023-02-07 Thread Mark Wielaard
Hi Ilyam On Mon, Feb 06, 2023 at 11:25:03PM +0100, Ilya Leoshkevich via Elfutils-devel wrote: > clang complains: > > In file included from debuginfod-client.c:38: > ./../debuginfod/debuginfod.h:47:34: error: redefinition of typedef > 'debuginfod_client' is a C11 feature [-Werror,-Wtyped

Re: [PATCH RFC 02/11] libasm: Fix xdefault_pattern initialization

2023-02-07 Thread Mark Wielaard
Hi Ilya, On Mon, Feb 06, 2023 at 11:25:04PM +0100, Ilya Leoshkevich via Elfutils-devel wrote: > clang complains: > > asm_newscn.c:48:22: error: field 'pattern' with variable sized type > 'struct FillPattern' not at the end of a struct or class is a GNU extension > [-Werror,-Wgnu-variable-s

Re: [PATCH RFC 01/11] libdwfl: Fix debuginfod_client redefinition

2023-02-07 Thread Ilya Leoshkevich via Elfutils-devel
On Tue, 2023-02-07 at 20:22 +0100, Mark Wielaard wrote: > Hi Ilyam > > On Mon, Feb 06, 2023 at 11:25:03PM +0100, Ilya Leoshkevich via > Elfutils-devel wrote: > > clang complains: > > > >     In file included from debuginfod-client.c:38: > >     ./../debuginfod/debuginfod.h:47:34: error: redefinit

Re: [PATCH RFC 00/11] Add Memory Sanitizer support

2023-02-07 Thread Ilya Leoshkevich via Elfutils-devel
On Tue, 2023-02-07 at 20:05 +0100, Mark Wielaard wrote: > Hi Ilya, > > On Mon, Feb 06, 2023 at 11:25:02PM +0100, Ilya Leoshkevich via > Elfutils-devel wrote: > > This series adds minimalistic support for Memory Sanitizer (MSan) > > [1]. > > MSan is compiler instrumentation for detecting accesses t

Re: [PATCH RFC 02/11] libasm: Fix xdefault_pattern initialization

2023-02-07 Thread Ilya Leoshkevich via Elfutils-devel
On Tue, 2023-02-07 at 20:41 +0100, Mark Wielaard wrote: > Hi Ilya, > > On Mon, Feb 06, 2023 at 11:25:04PM +0100, Ilya Leoshkevich via > Elfutils-devel wrote: > > clang complains: > > > >     asm_newscn.c:48:22: error: field 'pattern' with variable sized > > type 'struct FillPattern' not at the en

Re: [PATCH RFC 03/11] printversion: Fix unused variable

2023-02-07 Thread Mark Wielaard
Hi Ilya (CC Frank), On Mon, Feb 06, 2023 at 11:25:05PM +0100, Ilya Leoshkevich via Elfutils-devel wrote: > clang complains: > > debuginfod.cxx:354:1: error: unused variable 'apba__' > [-Werror,-Wunused-const-variable] > ARGP_PROGRAM_BUG_ADDRESS_DEF = PACKAGE_BUGREPORT; > ^ > ../

[OB PATCH] debuginfod-client.c: Download section even if cached executable didn't contain it.

2023-02-07 Thread Aaron Merey via Elfutils-devel
Committing as obvious. Before attempting to download a section, cache_find_section tries to extract the section from existing files in the cache. If it's determined that the section must not exist, cache_find_section returns -ENOENT to indicate that the download should be skipped. This patch fixe

☠ Buildbot (Sourceware): elfutils - failed test (failure) (master)

2023-02-07 Thread builder--- via Elfutils-devel
A new failure has been detected on builder elfutils-gentoo-sparc while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/225/builds/10 Build state: failed test (failure) Revision: 53b596ef4018693403395d702045c15762af3da7 Worker: gentoo-sparc

Re: ☠ Buildbot (Sourceware): elfutils - failed test (failure) (master)

2023-02-07 Thread Aaron Merey via Elfutils-devel
On Tue, Feb 7, 2023 at 9:43 PM builder--- via Elfutils-devel wrote: > > A new failure has been detected on builder elfutils-gentoo-sparc while > building elfutils. > > Full details are available at: > https://builder.sourceware.org/buildbot/#builders/225/builds/10 > > Build state: failed test