Re: ☠ Buildbot (GNU Toolchain): elfutils-try-debian-armhf - failed compile (failure) (users/marxin/try-zstd-support-v2)

2022-12-22 Thread Martin Liška
On 12/22/22 00:38, Mark Wielaard wrote: > Hi Martin, > > On Wed, Dec 21, 2022 at 07:29:19PM +0100, Martin Liška wrote: >>> What goes wrong is that this debian old stable arm setup has libzstd >>> containing a ZSTD_compressStream2 symbol... >>> >>> 40: d349 264 FUNCGLOBAL DEFAULT 11

[PATCHv2] support ZSTD compression algorithm

2022-12-22 Thread Martin Liška
Hi. > Is the abort () at the second call site because that cannot happen? Or > should that also goto cleanup? Yes, it can't happen. There's V2 (including ChangeLog) where all issues apart from the libzstd configure.ac detection should be addressed. Cheers, Martin config/ChangeLog: *

Re: ☠ Buildbot (GNU Toolchain): elfutils-try-debian-armhf - failed compile (failure) (users/marxin/try-zstd-support-v2)

2022-12-22 Thread Mark Wielaard
On Thu, 2022-12-22 at 10:09 +0100, Martin Liška wrote: > On 12/22/22 00:38, Mark Wielaard wrote: > > Hi Martin, > > > > On Wed, Dec 21, 2022 at 07:29:19PM +0100, Martin Liška wrote: > > > > What goes wrong is that this debian old stable arm setup has > > > > libzstd > > > > containing a ZSTD_compr

Re: [PATCHv2] support ZSTD compression algorithm

2022-12-22 Thread Mark Wielaard
Hi Martin, On Thu, 2022-12-22 at 10:17 +0100, Martin Liška wrote: > Is the abort () at the second call site because that cannot happen? > > Or should that also goto cleanup? > > Yes, it can't happen. Aha, because it should already have seen that section before, in which case it would have errore