Re: [PATCHv2] support ZSTD compression algorithm

2022-12-21 Thread Martin Liška
On 12/19/22 16:16, Mark Wielaard wrote: > Hi Martin, > > On Mon, 2022-12-19 at 15:21 +0100, Martin Liška wrote: + else +error (0, 0, "Couldn't get chdr for section %zd", ndx); >>> >>> Shouldn't this error be fatal? >> >> What do you use for fatal errors? > > Depends a bit on co

Re: [PATCHv2] support ZSTD compression algorithm

2022-12-21 Thread Martin Liška
On 12/19/22 16:09, Mark Wielaard wrote: > Hi Martin, > > On Mon, 2022-12-19 at 15:19 +0100, Martin Liška wrote: >> On 12/15/22 14:17, Mark Wielaard wrote: >>> Is there a particular way you are running eu-readelf? Is it with >>> generic -w or -a, or decoding a specific section type? >> >> Hello. >>

[PATCH v4] Add support for Synopsys ARCv2 processors

2022-12-21 Thread Shahab Vahedi via Elfutils-devel
There is no regression in tests for an x86_64 build, while the new hello_arc_hs4.ko is added as well. This is the only meaningful test that I could add at the moment, given the features supported by this port. $ cat tests/test-suite.log == elfutils 0

Re: [PATCH 1/1] support cross compilation

2022-12-21 Thread Mark Wielaard
Hi, It looks like I missed this. Sorry. On Wed, 2021-05-26 at 19:34 +0300, Petr Ovtchenkov wrote: > On Wed, 26 May 2021 12:41:51 -0300 > Érico Nogueira wrote: > > > > > Yes, we really cross. > > It doesn't matter because > > > We always use the release tarballs, which already have the %_dis.

[Bug general/28891] Cross compilation for ARM fails when trying to run i386_gendis

2022-12-21 Thread mark at klomp dot org via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=28891 --- Comment #2 from Mark Wielaard --- So a solution for people trying to do cross builds directly from git might simply be to do a make dist first and then do a cross from that? -- You are receiving this mail because: You are on the CC list

[Bug libdw/29434] Memory leak in `dwarf_getscopes`

2022-12-21 Thread mark at klomp dot org via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=29434 --- Comment #16 from Mark Wielaard --- Sorry this is a bit difficult to debug. Would you be able to show the start of the log? It should show how you are calling dwarf_getscopes. I think I have found the RHEL7 glibc debug file. So I can matc

Re: ☠ Buildbot (GNU Toolchain): elfutils-try-debian-armhf - failed compile (failure) (users/marxin/try-zstd-support-v2)

2022-12-21 Thread Martin Liška
On 12/21/22 12:15, buil...@sourceware.org wrote: > A failed build has been detected on builder elfutils-try-debian-armhf while > building elfutils. > > Full details are available at: > https://builder.sourceware.org/buildbot/#builders/201/builds/47 > > Build state: failed compile (failure) >

Re: ☠ Buildbot (GNU Toolchain): elfutils-try-debian-armhf - failed compile (failure) (users/marxin/try-zstd-support-v2)

2022-12-21 Thread Mark Wielaard
Hi Martin, On Wed, 2022-12-21 at 15:20 +0100, Martin Liška wrote: > On 12/21/22 12:15, buil...@sourceware.org wrote: > > A failed build has been detected on builder elfutils-try-debian- > > armhf while building elfutils. > > > > Full details are available at: > > https://builder.sourceware.or

Re: ☠ Buildbot (GNU Toolchain): elfutils-try-debian-armhf - failed compile (failure) (users/marxin/try-zstd-support-v2)

2022-12-21 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > [...] > Unfortunately buildbot itself doesn't show the config.log. > Trying to get that... Ah darn. It would have been saved in bunsen, but the buildbot configuration means that a make-stage failure means it won't even try. - FChE

Re: ☠ Buildbot (GNU Toolchain): elfutils-try-debian-armhf - failed compile (failure) (users/marxin/try-zstd-support-v2)

2022-12-21 Thread Mark Wielaard
Hi, On Wed, 2022-12-21 at 15:42 +0100, Mark Wielaard wrote: > > Unfortunately buildbot itself doesn't show the config.log. > Trying to get that... > > configure:6961: checking for library containing ZSTD_compressStream2 > configure:6992: gcc -o conftest -D_FORTIFY_SOURCE=3 -g -O2 > -fsanitize=un

[Bug debuginfod/29926] New: debuginfod using deprecated curl (since 7.55.0) curl API, fails to build with 7.87.0

2022-12-21 Thread andrew at ishiboo dot com via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=29926 Bug ID: 29926 Summary: debuginfod using deprecated curl (since 7.55.0) curl API, fails to build with 7.87.0 Product: elfutils Version: unspecified Status: UNCONFIRMED

[PATCH] libdwfl: Don't undef _

2022-12-21 Thread Mark Wielaard
A couple of files undefined _, which is defined in lib/eu-config.h as gettext helper macro. This seems unnecessary and arbitrary. Signed-off-by: Mark Wielaard --- libdwfl/ChangeLog| 7 +++ libdwfl/core-file.c | 1 - libdwfl/dwfl_segment_report_module.c |

[Bug debuginfod/29926] debuginfod using deprecated curl (since 7.55.0) curl API, fails to build with 7.87.0

2022-12-21 Thread andrew at ishiboo dot com via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=29926 --- Comment #1 from Andrew Paprocki --- Created attachment 14535 --> https://sourceware.org/bugzilla/attachment.cgi?id=14535&action=edit Fix selection of non-deprecated Curl API The `CURLINFO_SIZE_DOWNLOAD_T` and `CURLINFO_CONTENT_LENGTH_DO

[Bug debuginfod/29926] debuginfod using deprecated curl (since 7.55.0) API, fails to build with 7.87.0

2022-12-21 Thread andrew at ishiboo dot com via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=29926 Andrew Paprocki changed: What|Removed |Added Summary|debuginfod using deprecated |debuginfod using deprecated

[Bug debuginfod/29926] debuginfod using deprecated curl (since 7.55.0) API, fails to build with 7.87.0

2022-12-21 Thread fche at redhat dot com via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=29926 Frank Ch. Eigler changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

Re: [PATCH 08/25] Use configure to detect HAVE_DECL_MMAP and use it for system doesn't provide sys/mman.h

2022-12-21 Thread Mark Wielaard
Hi, On Wed, 2022-12-21 at 00:30 +0800, 罗勇刚(Yonggang Luo) via Elfutils-devel wrote: > On Tue, Dec 20, 2022 at 10:04 PM Mark Wielaard > wrot > > I have to think what it means for a system that doesn't have mmap > > since > > the mmap extensions are part of the public interface. And various > > par

☠ Buildbot (GNU Toolchain): elfutils - failed compile (failure) (master)

2022-12-21 Thread builder--- via Elfutils-devel
A new failure has been detected on builder elfutils-centos-x86_64 while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/39/builds/117 Build state: failed compile (failure) Revision: d2bf497b12fbd49b4996ccf0744303ffd67735b1 Worker: centos-x8

Re: ☠ Buildbot (GNU Toolchain): elfutils - failed compile (failure) (master)

2022-12-21 Thread Mark Wielaard
On Wed, 2022-12-21 at 17:04 +, builder--- via Elfutils-devel wrote: > A new failure has been detected on builder elfutils-centos-x86_64 > while building elfutils. > > Full details are available at: > https://builder.sourceware.org/buildbot/#builders/39/builds/117 > > Build state: failed c

Re: [PATCH v2 05/16] libcpu: Remove the need of NMNES by using enum

2022-12-21 Thread Mark Wielaard
Hi, On Sun, 2022-12-18 at 00:52 +0800, Yonggang Luo via Elfutils-devel wrote: > Signed-off-by: Yonggang Luo > --- > libcpu/Makefile.am | 2 +- > libcpu/i386_disasm.c | 14 +- > libcpu/i386_mne.h| 36 > libcpu/i386_parse.y | 9 +++-- >

Re: [PATCH v2 06/16] libcpu: Use __asm instead asm that can be recognized by both clang-cl and gcc

2022-12-21 Thread Mark Wielaard
On Sun, 2022-12-18 at 00:52 +0800, Yonggang Luo via Elfutils-devel wrote: > This block of code can not be removed. As it's contains a goto label > enomem that been used elsewhere aha, that certainly explains why gcc gets confused about whether those variables are used. It is slightly ugly code :{

Re: [PATCH v2 12/16] libasm/debuginfod: fchmod doesn't present on win32

2022-12-21 Thread Mark Wielaard
Hi, On Sun, 2022-12-18 at 00:52 +0800, Yonggang Luo via Elfutils-devel wrote: > index 8873fcc8..7a67a440 100644 > --- a/debuginfod/debuginfod-client.c > +++ b/debuginfod/debuginfod-client.c > @@ -1708,9 +1708,11 @@ debuginfod_query_server (debuginfod_client *c, >tvs[0].tv_usec = tvs[1].tv_usec

☠ Buildbot (GNU Toolchain): elfutils - failed test (failure) (master)

2022-12-21 Thread builder--- via Elfutils-devel
A new failure has been detected on builder elfutils-debian-i386 while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/17/builds/116 Build state: failed test (failure) Revision: 304741e11018c29e7ff17751e05dcc5c786a3fd9 Worker: debian-i386-2

Re: ☠ Buildbot (GNU Toolchain): elfutils-try-debian-armhf - failed compile (failure) (users/marxin/try-zstd-support-v2)

2022-12-21 Thread Martin Liška
On 12/21/22 16:21, Mark Wielaard wrote: > Hi, > > On Wed, 2022-12-21 at 15:42 +0100, Mark Wielaard wrote: >> >> Unfortunately buildbot itself doesn't show the config.log. >> Trying to get that... >> >> configure:6961: checking for library containing ZSTD_compressStream2 >> configure:6992: gcc -o c

☺ Buildbot (GNU Toolchain): elfutils - build successful (master)

2022-12-21 Thread builder--- via Elfutils-devel
A restored build has been detected on builder elfutils-debian-i386 while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/17/builds/117 Build state: build successful Revision: 1984819d6ee2dc56583d3f11b9f6e3b2f491f62e Worker: debian-i386-2 Bu

Re: [PATCH v2 15/16] libelf: F_GETFD may not predefined with msvc/mingw, guard the usage of it

2022-12-21 Thread Mark Wielaard
Hi, On Sun, Dec 18, 2022 at 12:52:12AM +0800, Yonggang Luo via Elfutils-devel wrote: > Signed-off-by: Yonggang Luo > --- > libelf/elf_begin.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/libelf/elf_begin.c b/libelf/elf_begin.c > index 6d31882e..3d324694 100644 > --- a/libelf/

Re: [PATCH] lib: Remove -ffunction-sections for xmalloc

2022-12-21 Thread Mark Wielaard
On Tue, Dec 20, 2022 at 11:22:23PM +0100, Mark Wielaard wrote: > The build used -ffunction-sections just for one file. > > +2022-12-20 Mark Wielaard > + > + * Makefile.am (xmalloc_CFLAGS): Remove. Pushed.

Re: [PATCH v2 16/16] lib: Use HAVE_LIBINTL_H to guard #include

2022-12-21 Thread Mark Wielaard
Hi, On Sun, Dec 18, 2022 at 12:52:13AM +0800, Yonggang Luo via Elfutils-devel wrote: > MSVC doesn't have libintl.h, so use macro to guard it. > > Signed-off-by: Yonggang Luo > --- > configure.ac| 2 ++ > lib/eu-config.h | 7 +++ > 2 files changed, 9 insertions(+) > > diff --git a/confi

Re: [PATCHv2] support ZSTD compression algorithm

2022-12-21 Thread Mark Wielaard
Hi Martin, On Wed, Dec 21, 2022 at 12:09:21PM +0100, Martin Liška wrote: > > Or you return a special value from the function (assuming all callers > > check for an error here). And/Or if the program needs a cleanup you'll > > goto cleanup (as is done in process_file). > > I think it's fine as we

Re: [PATCH v4] Add support for Synopsys ARCv2 processors

2022-12-21 Thread Mark Wielaard
Hi Shahab, On Wed, Dec 21, 2022 at 12:27:05PM +0100, Shahab Vahedi via Elfutils-devel wrote: > There is no regression in tests for an x86_64 build, while the new > hello_arc_hs4.ko is added as well. This is the only meaningful > test that I could add at the moment, given the features supported >

Re: [PATCH] libdwfl: Don't undef _

2022-12-21 Thread Mark Wielaard
On Wed, Dec 21, 2022 at 04:43:05PM +0100, Mark Wielaard wrote: > A couple of files undefined _, which is defined in lib/eu-config.h as > gettext helper macro. This seems unnecessary and arbitrary. Pushed.

Re: ☠ Buildbot (GNU Toolchain): elfutils-try-debian-armhf - failed compile (failure) (users/marxin/try-zstd-support-v2)

2022-12-21 Thread Mark Wielaard
Hi Martin, On Wed, Dec 21, 2022 at 07:29:19PM +0100, Martin Liška wrote: > > What goes wrong is that this debian old stable arm setup has libzstd > > containing a ZSTD_compressStream2 symbol... > > > > 40: d349 264 FUNCGLOBAL DEFAULT 11 ZSTD_compressStream2 > > > > But the zstd.h

Re: [PATCH 08/25] Use configure to detect HAVE_DECL_MMAP and use it for system doesn't provide sys/mman.h

2022-12-21 Thread Yonggang Luo
On Thu, Dec 22, 2022 at 12:54 AM Mark Wielaard wrote: > > Hi, > > On Wed, 2022-12-21 at 00:30 +0800, 罗勇刚(Yonggang Luo) via Elfutils-devel > wrote: > > On Tue, Dec 20, 2022 at 10:04 PM Mark Wielaard > > wrot > > > I have to think what it means for a system that doesn't have mmap > > > since > > >