Re: [PATCH] Add support for LoongArch

Hi, Mark: Any comments? Thanks. With this patch, pahole is now able to convert dwarf to BTF on LoongArch machine. cheers, -- Hengqi On Sat, Dec 3, 2022 at 9:47 PM Hengqi Chen wrote: > > This implements initial support for the LoongArch architecture. > > Signed-off-by: Hengqi Chen > --- > b

Re: [PATCH 10/25] libcpu: Remove the need of NMNES by using enum

Hi, On Fri, 2022-10-21 at 02:25 +0800, Yonggang Luo via Elfutils-devel wrote: > Signed-off-by: Yonggang Luo > --- > libcpu/Makefile.am | 2 +- > libcpu/i386_parse.y | 13 + > 2 files changed, 10 insertions(+), 5 deletions(-) > > diff --git a/libcpu/Makefile.am b/libcpu/Makefile.am

Re: [PATCH 11/25] libcpu: Use __asm instead asm that can be recognized by both clang-cl and gcc

Hi, On Fri, 2022-10-21 at 02:25 +0800, Yonggang Luo via Elfutils-devel wrote: > Signed-off-by: Yonggang Luo > --- > libcpu/i386_disasm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libcpu/i386_disasm.c b/libcpu/i386_disasm.c > index 599d1654..cc75a7b1 100644 > --- a

Re: [PATCH 12/25] libcpu: Use "#define FCT_mod$64r_m FCT_mod$r_m" is enough and can be recognized by clang-cl on windows in i386_data.h

Hi, On Fri, 2022-10-21 at 02:25 +0800, Yonggang Luo via Elfutils-devel wrote: > Signed-off-by: Yonggang Luo > --- > libcpu/i386_data.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libcpu/i386_data.h b/libcpu/i386_data.h > index 06356b8a..fe3c4ae1 100644 > --- a/libcp

Re: [PATCH 13/25] libdw: typeof -> __typeof that can be recognized by both clang-cl and gcc

Hi, We seem to use __typeof everywhere except in memory-access.h. So this seems like an OK change. Added a ChangeLog entry and pushed as: commit 78dd3b32edf55fc8bdc6268163d5d743a84b1075 Author: Yonggang Luo Date: Fri Oct 21 02:25:52 2022 +0800 libdw: Change typeof -> __typeof in memory-a

Re: [PATCH 14/25] libdw: check __OPTIMIZE__ in dwarf_whatattr.c and dwarf_whatform.c to match the header

Hi, On Fri, 2022-10-21 at 02:25 +0800, Yonggang Luo via Elfutils-devel wrote: > - > +#ifndef __OPTIMIZE__ > unsigned int > dwarf_whatattr (Dwarf_Attribute *attr) > { >return attr == NULL ? 0 : attr->code; > } > +#endif > diff --git a/libdw/dwarf_whatform.c b/libdw/dwarf_whatform.c > index

☠ Buildbot (GNU Toolchain): elfutils - failed configure (failure) (master)

A new failure has been detected on builder elfutils-debian-ppc64 while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/63/builds/113 Build state: failed configure (failure) Revision: dab89fba0e84c948fb270e541d1d1313afd2c2c3 Worker: debian-p

Re: ☠ Buildbot (GNU Toolchain): elfutils - failed configure (failure) (master)

Hi, On Mon, Dec 12, 2022 at 02:01:49PM +, builder--- via Elfutils-devel wrote: > A new failure has been detected on builder elfutils-debian-ppc64 while > building elfutils. > > Full details are available at: > https://builder.sourceware.org/buildbot/#builders/63/builds/113 > > Build sta

☠ Buildbot (GNU Toolchain): elfutils - failed test (failure) (master)

A new failure has been detected on builder elfutils-rawhide-x86_64 while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/140/builds/74 Build state: failed test (failure) Revision: 78dd3b32edf55fc8bdc6268163d5d743a84b1075 Worker: bb1-2 Build

Re: [PATCH 15/25] lib: Implement error properly even when not HAVE_ERR_H

Hi, On Fri, 2022-10-21 at 02:25 +0800, Yonggang Luo via Elfutils-devel wrote: > on win32, there is no err.h > [...] > +#else > + (void)status; > + vfprintf(stderr, format, argp); > +#endif >va_end(argp); That doesn't look like a valid implementation of error, it ignores errno and doesn't ex

Re: [PATCH 16/25] libeu: Move the implementation of pwrite_retry, write_retry and pread_retry from header to source

Hi, Why is this necessary? Thanks, Mark

Re: [PATCH 19/25] libelf: F_GETFD may not predefined with msvc/mingw, guard the usage of it

Hi, On Fri, 2022-10-21 at 02:25 +0800, Yonggang Luo via Elfutils-devel wrote: > Signed-off-by: Yonggang Luo > --- > libelf/elf_begin.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libelf/elf_begin.c b/libelf/elf_begin.c > index 6d31882e..d867cd6f 100644 > --- a/libelf/elf_begin.c

Re: ☠ Buildbot (GNU Toolchain): elfutils - failed configure (failure) (master)

Hi Mark, Mark Wielaard writes: > On Mon, Dec 12, 2022 at 02:01:49PM +, builder--- via Elfutils-devel wrote: >> A new failure has been detected on builder elfutils-debian-ppc64 while >> building elfutils. >> >> Full details are available at: >> https://builder.sourceware.org/buildbot/#b

☺ Buildbot (GNU Toolchain): elfutils - build successful (master)

A restored build has been detected on builder elfutils-debian-ppc64 while building elfutils. Full details are available at: https://builder.sourceware.org/buildbot/#builders/63/builds/115 Build state: build successful Revision: 78dd3b32edf55fc8bdc6268163d5d743a84b1075 Worker: debian-ppc64 Bu