Hello,
Here is an updated patch, using memmove. Much smaller.
Thanks for the suggestions,
Noah Sanci
On Thu, Aug 26, 2021 at 5:02 PM Frank Ch. Eigler wrote:
>
> Hi -
>
> >/* PR28034 escape characters in completed url to %hh format. */
> > - char *escaped_string;
> > -
Hello
Update 2, no longer append nulls unnecessarily.
-Noah Sanci
On Fri, Aug 27, 2021 at 10:44 AM Noah Sanci wrote:
>
> Hello,
>
> Here is an updated patch, using memmove. Much smaller.
>
> Thanks for the suggestions,
>
> Noah Sanci
>
>
> On Thu, Aug 26, 2021 at 5:02 PM Frank Ch. Eigler wrote
Hi Saleem,
On Mon, 2021-08-23 at 08:23 -0700, Saleem Abdulrasool via Elfutils-
devel wrote:
> Yes, it seems that `STROF` can be removed as well. However, I'd
> prefer to do that in a separate change. This way the change is a
> separate clean up rather than just happens to come along with the
> s
Hi Saleem,
On Fri, 2021-08-20 at 18:21 +, Saleem Abdulrasool via Elfutils-devel wrote:
> `error.h`'s inclusion was centralised into the `system.h` header. As
> the implementation currently includes `system.h` already, the inclusion
> of `error.h` is unnecessary. This prepares for a future po
This definition was in the fallback path, where `sys/cdefs.h` is not
available. Now that we have a single path through here, this macro gets
defined, though is unused. Remove the unused macro definition.
Signed-off-by: Saleem Abdulrasool
---
lib/ChangeLog | 4
lib/fixedsizehash.h |
I think that this is not exactly ideal, as it will introduce a local
error_message_count in each translation unit, rather than giving it
vague linkage as I had hoped. I think it may be better to introduce a new
source file here. I can move the implementation around though.
A second issue is that
Hello,
Next update, removed redundant if statement.
-Noah Sanci
On Fri, Aug 27, 2021 at 11:07 AM Noah Sanci wrote:
>
> Hello
>
> Update 2, no longer append nulls unnecessarily.
>
> -Noah Sanci
>
> On Fri, Aug 27, 2021 at 10:44 AM Noah Sanci wrote:
> >
> > Hello,
> >
> > Here is an updated patc
Introduce a configure time check for the presence of `error.h`. In the
case that `error.h` is not available, we can fall back to `err.h`.
Although `err.h` is not a C standard header (it is a BSD extension),
many libc implementations provide. If there are targets which do not
provide an implementa
Hi Saleem,
On Fri, 2021-08-27 at 08:24 -0700, Saleem Abdulrasool via Elfutils-devel wrote:
> I think that this is not exactly ideal, as it will introduce a local
> error_message_count in each translation unit, rather than giving it
> vague linkage as I had hoped. I think it may be better to intro
We have two choices:
- revert and use the updated patch I already sent
- I can do a follow up change to migrate the code
I don't particularly have a strong opinion on which approach we take, since
the commit has already been done. Since glibc systems are completely
untouched by the changes neithe
This properly homes the fallback function into a translation unit rather
than trying to define an inline common definition for the fallback path.
The intent of the original approach was to actually simply avoid adding
a new source file that is used for the fallback path. However, that may
cause tr
Hi Saleem,
On Fri, 2021-08-27 at 15:20 +, Saleem Abdulrasool via Elfutils-devel wrote:
> This definition was in the fallback path, where `sys/cdefs.h` is not
> available. Now that we have a single path through here, this macro gets
> defined, though is unused. Remove the unused macro definit
Hi Saleem,
On Fri, 2021-08-27 at 15:51 +, Saleem Abdulrasool via Elfutils-devel wrote:
> This properly homes the fallback function into a translation unit rather
> than trying to define an inline common definition for the fallback path.
> The intent of the original approach was to actually sim
https://sourceware.org/bugzilla/show_bug.cgi?id=21008
Mark Wielaard changed:
What|Removed |Added
CC||mark at klomp dot org
Sta
https://sourceware.org/bugzilla/show_bug.cgi?id=21002
Bug 21002 depends on bug 21008, which changed state.
Bug 21008 Summary: Incompatible with MUSL libc: error.h and error() not provided
https://sourceware.org/bugzilla/show_bug.cgi?id=21008
What|Removed |Added
Hi dichen,
On Fri, 2021-08-20 at 20:44 +0800, Di Chen via Elfutils-devel wrote:
> 1) moved the XFF check to handle_buildid.
> 2) replace "livelock" with "deadlock" in the commit message.
This looks very good, thanks not just for the code but for also
including documentation and a testcase.
I did
https://sourceware.org/bugzilla/show_bug.cgi?id=27917
Mark Wielaard changed:
What|Removed |Added
Resolution|--- |FIXED
CC|
Hello,
Here is the patch which prints the http headers when verbose.
-Noah Sanci
On Tue, Aug 24, 2021 at 4:19 AM Mark Wielaard wrote:
>
> Hi Noah,
>
> On Mon, 2021-08-23 at 11:11 -0400, Noah Sanci wrote:
> > I'm back to working on this patch, thanks for your patience and
> > comments.
> >
> > O
https://sourceware.org/bugzilla/show_bug.cgi?id=28284
Bug ID: 28284
Summary: support description functionality through HEAD
Product: elfutils
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Compone
https://sourceware.org/bugzilla/show_bug.cgi?id=28284
Noah Sanci changed:
What|Removed |Added
Assignee|unassigned at sourceware dot org |nsanci at redhat dot com
--
You
https://sourceware.org/bugzilla/show_bug.cgi?id=28284
Frank Ch. Eigler changed:
What|Removed |Added
CC||fche at redhat dot com
--- Comment
The Buildbot has detected a new failure on builder elfutils-centos-x86_64 while
building elfutils.
Full details are available at:
https://builder.wildebeest.org/buildbot/#builders/1/builds/807
Buildbot URL: https://builder.wildebeest.org/buildbot/
Worker for this Build: centos-x86_64
Build
The Buildbot has detected a new failure on builder elfutils-debian-amd64 while
building elfutils.
Full details are available at:
https://builder.wildebeest.org/buildbot/#builders/2/builds/803
Buildbot URL: https://builder.wildebeest.org/buildbot/
Worker for this Build: debian-amd64
Build Re
23 matches
Mail list logo
