Re: [PATCH] lib: remove usage of `sys/cdefs.h`

2021-08-23 Thread Érico Nogueira via Elfutils-devel
On Fri Aug 20, 2021 at 3:20 PM -03, Saleem Abdulrasool via Elfutils-devel wrote: > This header is a BSD header that is also available in glibc. However, > this is a not a standard C header and was used for `__CONCAT`. Because > this is not a standard header, not all libc implementations provide the

Re: [Bug debuginfod/27277] Describe retrieved files when verbose

2021-08-23 Thread Noah Sanci via Elfutils-devel
Hello, I'm back to working on this patch, thanks for your patience and comments. On Mon, Aug 9, 2021 at 5:27 AM Mark Wielaard wrote: > Yes, separate the verbose printing of http headers (which I really do > like) from providing an interface to query what needs to be done to get > some file (is i

Re: [PATCH] lib: remove usage of `sys/cdefs.h`

2021-08-23 Thread Saleem Abdulrasool via Elfutils-devel
Hi Érico, Yes, it seems that `STROF` can be removed as well. However, I'd prefer to do that in a separate change. This way the change is a separate clean up rather than just happens to come along with the sys/cdefs.h removal. On Mon, Aug 23, 2021 at 5:48 AM Érico Nogueira wrote: > > On Fri Aug

Re: [PATCH] configure.ac: drop unnecessary gnu99 extension checks

2021-08-23 Thread Mark Wielaard
Hi Adrian, On Tue, Aug 10, 2021 at 03:56:51PM +0300, Adrian Ratiu via Elfutils-devel wrote: > So in the interest of enabling Clang builds we remove the only > remaining blocker: the configure checks for nested functions and > variable length arrays which are also unused. Can we just remove the wh

Re: Buildbot failure in Wildebeest Builder on whole buildset

2021-08-23 Thread Mark Wielaard
Hi, On Wed, Aug 11, 2021 at 11:16:18PM +, build...@builder.wildebeest.org wrote: > The Buildbot has detected a new failure on builder elfutils-centos-x86_64 > while building elfutils. > Full details are available at: > https://builder.wildebeest.org/buildbot/#builders/1/builds/799 Just f

Re: Using dwarf_getfuncs to get function from object stored in memory

2021-08-23 Thread Mark Wielaard
Hi Jeff, On Tue, Aug 17, 2021 at 03:40:08AM +, Jeff Lin via Elfutils-devel wrote: > I’ve written code to extract function from a shared object with > dwarf_begin api that finds the dwarf objects with the file > descriptor using dwarf_getfuncs. However, when I tried to parse the > same object

Re: Using dwarf_getfuncs to get function from object stored in memory

2021-08-23 Thread Jeff Lin via Elfutils-devel
Hi Mark, I tracked down the issue to the copy in memory was actually different. However, because dwarf_begin_elf was still providing the offset to the top cus, I did not suspect that was the issue. Dwarf_getfuncs did return -1, but I did not look at dwarf_errmsg. After I ensured the copy in m