[PATCH] debuginfod-client: Don't compare a double to a long

2021-03-04 Thread Timm Bäder via Elfutils-devel
From: Timm Bäder clang warns about this: ../../debuginfod/debuginfod-client.c:899:28: error: implicit conversion from 'long' to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Werror,-Wimplicit-int-float-conversion] pa = (dl > LONG_MAX ? LONG_MAX : (lon

debuginfod-client: Fix typo in curl feature detection

2021-03-04 Thread Timm Bäder via Elfutils-devel
I just looked at this for too long and became confused by the naming. It seems like there's one CURLINFO_ too much in there. Googling seems to confirm. - Timm

[PATCH] debginfod-client: Fix typo in curl feature detection

2021-03-04 Thread Timm Bäder via Elfutils-devel
From: Timm Bäder CURLINFO_CURLINFO_CONTENT_LENGTH_DOWNLOAD_T is one CURLINFO_ too much. Signed-off-by: Timm Bäder --- debuginfod/debuginfod-client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debuginfod/debuginfod-client.c b/debuginfod/debuginfod-client.c index df238e0

Re: [PATCH] define SHT_LLVM_ADDRSIG section rather than error out

2021-03-04 Thread Timm Bäder via Elfutils-devel
On 18/11/2020 06:34, Navin P via Elfutils-devel wrote: diff --git a/src/elflint.c b/src/elflint.c index ef3e3732..62663800 100644 --- a/src/elflint.c +++ b/src/elflint.c @@ -3905,6 +3905,7 @@ section [%2zu] '%s': size not multiple of entry size\n"), && shdr->sh_type != SHT_GNU_ATTRIBUTES

Re: [PATCH] define SHT_LLVM_ADDRSIG section rather than error out

2021-03-04 Thread Mark Wielaard
Hi Timm, On Thu, 2021-03-04 at 14:44 +0100, Timm Bäder wrote: > any update on this? I see that SHT_LLVM_ADDRSIG is still not in upstream > glibc. Are you working on that, Navin? > > As for the checks, I'm not sure we can do anything here since elfutils > can't know whether a symbol is rightfully

Re: [PATCH] define SHT_LLVM_ADDRSIG section rather than error out

2021-03-04 Thread Navin P via Elfutils-devel
On Thu, Mar 4, 2021 at 7:14 PM Timm Bäder wrote: > > On 18/11/2020 06:34, Navin P via Elfutils-devel wrote: > >>> diff --git a/src/elflint.c b/src/elflint.c > >>> index ef3e3732..62663800 100644 > >>> --- a/src/elflint.c > >>> +++ b/src/elflint.c > >>> @@ -3905,6 +3905,7 @@ section [%2zu] '%s': si