Re: [PATCH 1/2] elflint: Pull pos() info file scope

Hi Timm, On Wed, 2021-02-17 at 09:42 +0100, Timm Bäder via Elfutils-devel wrote: > Rename it to buffer_pos() to be a bit more descriptive and get rid of a > nested function this way. Added a ChangeLog entry and pushed. Thanks, Mark

Re: [PATCH 2/2] elflint: Pull left() in file scope

Hi Timm, On Wed, 2021-02-17 at 09:42 +0100, Timm Bäder via Elfutils-devel wrote: > And rename it to buffer_left() to be a bit more descriptive Added a ChangeLog entry and pushed. Thanks, Mark

Re: [PATCH 1/5] unstrip: Pull adjust_reloc() into file scope

Hi Timm, On Wed, 2021-02-17 at 09:43 +0100, Timm Bäder via Elfutils-devel wrote: > Get rid of a nested function this way. Added a ChangeLog entry and pushed. Thanks, Mark

Re: [PATCH 2/5] unstrip: Pull check_match() into file scope

Hi Timm, On Wed, 2021-02-17 at 09:43 +0100, Timm Bäder via Elfutils-devel wrote: > Get rid of a nested function this way. Adding a ChangeLog entry explaining the new logic used and pushed. Thanks, Mark

Re: [PATCH 3/5] unstrip: Inline find_unalloc_section() into only caller

Hi Timm, On Wed, 2021-02-17 at 09:43 +0100, Timm Bäder via Elfutils-devel wrote: > Get rid of an unnecessary nested function this way. It took me a while to see why this was correct. Explained it in a new ChangeLog entry that I added before pushing. Thanks, Mark

Re: [PATCH 4/5] unstrip: Pull warn() into file scope

Hi Timm, On Wed, 2021-02-17 at 09:43 +0100, Timm Bäder via Elfutils-devel wrote: > Get rid of a nested function this way. Made one line smaller than 80 chars and added a ChangeLog entry. Pushed, Mark

Re: [PATCH 5/5] unstrip: Remove nested next() function

Hi Timm, On Wed, 2021-02-17 at 09:43 +0100, Timm Bäder via Elfutils-devel wrote: > This is a simple one-liner, so inline this into the few callers. > Get rid of a nested function this way. Added a ChangeLog entry and pushed. Thanks, Mark

Buildbot failure in Wildebeest Builder on whole buildset

The Buildbot has detected a failed build on builder whole buildset while building elfutils. Full details are available at: https://builder.wildebeest.org/buildbot/#builders/10/builds/693 Buildbot URL: https://builder.wildebeest.org/buildbot/ Worker for this Build: fedora-s390x Build Reason:

Re: [PATCH 1/4] elfcompress: Pull set_section() into file scope

Hi Timm, On Wed, 2021-02-17 at 09:45 +0100, Timm Bäder via Elfutils-devel wrote: > Get rid of a nested function this way. Added a ChangeLog entry and pushed. Thanks, Mark

Re: [PATCH 2/4] elfcompress: Pull get_section() into file scope

Hi Timm, On Wed, 2021-02-17 at 09:45 +0100, Timm Bäder via Elfutils-devel wrote: > Get rid of a nested function this way. Added a ChangeLog entry and pushed. Thanks, Mark

Re: [PATCH 3/4] elfcompress: Pull get_sections() into file scope

Hi Timm, On Wed, 2021-02-17 at 09:45 +0100, Timm Bäder via Elfutils-devel wrote: > Get rid of a nested function this way. Added a ChangeLog entry and pushed. Thanks, Mark

Re: [PATCH 4/4] elfcompress: Replace cleanup() with label

Hi Timm, On Wed, 2021-02-17 at 09:45 +0100, Timm Bäder via Elfutils-devel wrote: > From: Timm Bäder > > Get rid of a nested function this way. It would be nice to get a ChangeLog entry with this. > diff --git a/src/elfcompress.c b/src/elfcompress.c > index 65e28f0e..ba08e73f 100644 > --- a/src

Re: Buildbot failure in Wildebeest Builder on whole buildset

On Mon, 2021-03-01 at 19:56 +, build...@builder.wildebeest.org wrote: > The Buildbot has detected a failed build on builder whole buildset > while building elfutils. > Full details are available at: > https://builder.wildebeest.org/buildbot/#builders/10/builds/693 > > Buildbot URL: https:/

Re: [PATCH 1/2] elfstrmerge: Pull newsecndx() info file scope

Hi Timm, On Wed, 2021-02-17 at 09:46 +0100, Timm Bäder via Elfutils-devel wrote: > Get rid of a nested function this way. Reworded the commit subject slightly to show this is about the tests and added a ChangeLog entry. Having to add 3 extra arguments to the function is a little ugly. But it is j

Re: [PATCH 2/2] elfstrmerge: Pull new_data_buf() into file scope

Hi Timm, On Wed, 2021-02-17 at 09:46 +0100, Timm Bäder via Elfutils-devel wrote: > Get rid of a nested function this way. Same comments as the last one. 4 extra arguments is pushing it a bit. But still pushed :) Thanks, Mark

Buildbot failure in Wildebeest Builder on whole buildset

The Buildbot has detected a failed build on builder whole buildset while building elfutils. Full details are available at: https://builder.wildebeest.org/buildbot/#builders/10/builds/700 Buildbot URL: https://builder.wildebeest.org/buildbot/ Worker for this Build: fedora-s390x Build Reason: