Makefile.am already contains "ACLOCAL_AMFLAGS = -I m4",
that is enough for autoreconf to do the right thing.
Tested with
autoreconf -if && ./configure --enable-maintainer-mode && make && make distcheck
Signed-off-by: Dmitry V. Levin
---
ChangeLog| 4
configure.ac | 1 -
2 files changed
m4 files do not have to listed in EXTRA_DIST, in fact,
biarch.m4 has not been listed since its very beginning in 2013,
and nobody seems to have noticed so far.
Tested with
autoreconf -if && ./configure --enable-maintainer-mode && make && make distcheck
Signed-off-by: Dmitry V. Levin
---
ChangeL
On Tue, 2020-12-15 at 17:40 +0300, Dmitry V. Levin wrote:
> Makefile.am already contains "ACLOCAL_AMFLAGS = -I m4",
> that is enough for autoreconf to do the right thing.
But is that a good thing to rely on?
The autoconf manual says "be aware that future Automake releases might
start flagging ACL
On Tue, Dec 15, 2020 at 04:07:02PM +0100, Mark Wielaard wrote:
> On Tue, 2020-12-15 at 17:40 +0300, Dmitry V. Levin wrote:
> > Makefile.am already contains "ACLOCAL_AMFLAGS = -I m4",
> > that is enough for autoreconf to do the right thing.
>
> But is that a good thing to rely on?
Looks like that'
Hi Dmitry,
On Tue, 2020-12-15 at 20:01 +0300, Dmitry V. Levin wrote:
> Hmm, despite all these recommendation, virtually every project that
> uses
> automake also uses ACLOCAL_AMFLAGS, and very few use
> AC_CONFIG_MACRO_DIR.
>
> The documentation on AC_CONFIG_MACRO_DIR says that
> "you must also s
Hi -
> I think it is too early to switch to autoconf 2.70. Currently we
> require autoconf 2.63 and automake 1.11. We could probably upgrade to
> autconf 2.69 and automake 1.13, but that doesn't seem to help with
> AC_CONFIG_MACRO_DIR/ACLOCAL_AMFLAGS.
>
> Since AC_CONFIG_MACRO_DIR is deprecated i
Hi Dmitry,
On Tue, 2020-12-15 at 17:40 +0300, Dmitry V. Levin wrote:
> m4 files do not have to listed in EXTRA_DIST, in fact,
> biarch.m4 has not been listed since its very beginning in 2013,
> and nobody seems to have noticed so far.
Looks like you are right, the m4 macro files are automatically
Hi,
On Tue, Dec 15, 2020 at 03:14:27PM -0500, Frank Ch. Eigler wrote:
> Hi -
>
> > I think it is too early to switch to autoconf 2.70. Currently we
> > require autoconf 2.63 and automake 1.11. We could probably upgrade to
> > autconf 2.69 and automake 1.13, but that doesn't seem to help with
> >
Adding the symbol name associated with the symbol index number
makes the error messages a little bit more useful. We used to say:
section [59] '.symtab': symbol 9: st_value out of bounds
But now says:
section [59] '.symtab': symbol 9 (.annobin_size.c.hot): st_value out of bounds
Signed-off-by:
Hi,
On Tue, 2020-12-15 at 23:31 +0300, Dmitry V. Levin wrote:
> On Tue, Dec 15, 2020 at 03:14:27PM -0500, Frank Ch. Eigler wrote:
> > Note that since we do not commit auto*-generated code into the repo,
> > we don't really upgrade elfutils autoconf/automake versions. We are
> > subject to the whi
Hi Dmitry,
On Tue, 2020-12-15 at 23:56 +0300, Dmitry V. Levin wrote:
> Remove translation files that do not contain any translation strings,
> not even a single fuzzy one. These files are also unused because they
> are not listed in the LINGUAS file.
Thanks for noticing. How odd, they were actua
On Tue, Dec 15, 2020 at 09:52:40PM +0100, Mark Wielaard wrote:
> Adding the symbol name associated with the symbol index number
> makes the error messages a little bit more useful. We used to say:
>
> section [59] '.symtab': symbol 9: st_value out of bounds
>
> But now says:
>
> section [59] '.s
Hi Dmitry,
On Wed, Dec 16, 2020 at 12:44:05AM +0300, Dmitry V. Levin wrote:
> This is nice, thanks.
> I have one question about the patch:
>
> [...]
> > --- a/src/elflint.c
> > +++ b/src/elflint.c
> > @@ -706,7 +706,7 @@ section [%2d] '%s': XINDEX for zeroth entry not
> > zero\n"),
> > con
Hi Mark,
On Tue, Dec 15, 2020 at 11:53:48PM +0100, Mark Wielaard wrote:
> Hi Dmitry,
>
> On Wed, Dec 16, 2020 at 12:44:05AM +0300, Dmitry V. Levin wrote:
> > This is nice, thanks.
> > I have one question about the patch:
> >
> > [...]
> > > --- a/src/elflint.c
> > > +++ b/src/elflint.c
> > > @@
On Wed, Dec 16, 2020 at 02:40:32AM +0300, Dmitry V. Levin wrote:
[...]
> Use this opportunity to create separate .gitignore files for m4/ and po/
> directories.
By the way, what do you think about moving subdirectory parts of the top
level .gitignore file into subdirectories? This would be consis
libeblP.h defines _(Str) to dgettext ("elfutils", Str) instead of
a simple gettext (Str) for a reason: the library might be indirectly
used by clients that called bindtextdomain with a domain different
from "elfutils".
The change was made automatically using the following command:
$ git grep -l '\
https://sourceware.org/bugzilla/show_bug.cgi?id=27076
Bug ID: 27076
Summary: heap-buffer-overflow when calling file_read_elf
function in elf_begin.c in libelf
Product: elfutils
Version: unspecified
Status: UNCONFIRMED
17 matches
Mail list logo
