Re: Remove nested functions from libdwfl V2

2020-11-25 Thread Mark Wielaard
Hi Timm, On Mon, 2020-11-23 at 13:27 +0100, Timm Bäder via Elfutils-devel wrote: > version 2 of this patch set. I removed segmend_read() entirely now, > which meant modifying a bunch of later patches. Other than that, they > are the same. > > Hope the --from to git send-email worked out, too. It

Re: patch: debuginfod sqlite3 metrics

2020-11-25 Thread Mark Wielaard
Hi Frank, On Mon, 2020-11-23 at 20:07 -0500, Frank Ch. Eigler via Elfutils-devel wrote: > From 0b61f4c758a507fcc2243357363e44140bd13d82 Mon Sep 17 00:00:00 > 2001 ?!??!! > From: "Frank Ch. Eigler" > Date: Mon, 23 Nov 2020 19:58:10 -0500 > Subject: [PATCH] debuginfod: sqlite3 metrics > > Add metr

Re: patch: debuginfod sqlite3 metrics

2020-11-25 Thread Frank Ch. Eigler via Elfutils-devel
Hi - > Looks good. Just one question about the RAII timing metrics. > It is using gettimeofday which I believe might jump around since it > tracks "human time". Might it be better to use clock_gettime > (CLOCK_MONOTONIC) instead? Note that uses nanoseconds instead of > microseconds, so needs adjus

patches obv debuginfod

2020-11-25 Thread Frank Ch. Eigler via Elfutils-devel
Hi - Committed these as obvious: commit 841bd252a065d65eee9cff38430bc240cab3d1af (HEAD -> master) Author: Frank Ch. Eigler Date: Wed Nov 25 21:20:27 2020 -0500 debuginfod: correct prometheus metric typo The "-" character is not allowed in a metric label_name, whoops, so use