Re: [PATCH 03/14] segment_report_module: Remove nested finish() function

2020-11-19 Thread Mark Wielaard
On Thu, 2020-11-12 at 16:04 +0100, Timm Bäder via Elfutils-devel wrote: > This works just as well with a goto-out style label. And is more in line with how we do error handling in other parts of the code. I added a ChangeLog entry and pushed. Thanks, Mark

Re: [PATCH 04/14] segment_report_module: Remove nested release_buffer() function

2020-11-19 Thread Mark Wielaard
Hi Timm, On Thu, 2020-11-12 at 16:04 +0100, Timm Bäder via Elfutils-devel wrote: > diff --git a/libdwfl/dwfl_segment_report_module.c > b/libdwfl/dwfl_segment_report_module.c > index d06d0ba0..ba11b60a 100644 > --- a/libdwfl/dwfl_segment_report_module.c > +++ b/libdwfl/dwfl_segment_report_module.c

Re: [PATCH 05/14] segment_report_module: Pull finish_portion() info file scope

2020-11-19 Thread Mark Wielaard
Hi Timm, On Thu, 2020-11-12 at 16:04 +0100, Timm Bäder via Elfutils-devel wrote: > +static inline void > +finish_portion (Dwfl *dwfl, > +Dwfl_Memory_Callback *memory_callback, > +void *memory_callback_arg, > +void **data, size_t *data_size) > +{ > +

Buildbot failure in Wildebeest Builder on whole buildset

2020-11-19 Thread buildbot
The Buildbot has detected a failed build on builder whole buildset while building elfutils. Full details are available at: https://builder.wildebeest.org/buildbot/#builders/10/builds/591 Buildbot URL: https://builder.wildebeest.org/buildbot/ Worker for this Build: fedora-s390x Build Reason:

Re: Buildbot failure in Wildebeest Builder on whole buildset

2020-11-19 Thread Mark Wielaard
On Thu, 2020-11-19 at 13:26 +, build...@builder.wildebeest.org wrote: > The Buildbot has detected a failed build on builder whole buildset > while building elfutils. > Full details are available at: > https://builder.wildebeest.org/buildbot/#builders/10/builds/591 > > Buildbot URL: https:/

[Bug libdw/26921] New: dwarf_getalt () not thread-safe

2020-11-19 Thread mark at klomp dot org via Elfutils-devel
https://sourceware.org/bugzilla/show_bug.cgi?id=26921 Bug ID: 26921 Summary: dwarf_getalt () not thread-safe Product: elfutils Version: unspecified Status: NEW Severity: normal Priority: P2 Component: libdw

[patch] debuginfod more metrics

2020-11-19 Thread Frank Ch. Eigler via Elfutils-devel
Hi - >From 135162e03b2939e1fec484d276b9c34364fc566d Mon Sep 17 00:00:00 2001 From: "Frank Ch. Eigler" Date: Thu, 19 Nov 2020 13:16:10 -0500 Subject: [PATCH] debuginfod: add thread-busy metrics to webapi service Improve monitoring of debuginfod instances by tracking thread_busy status for the th

[PATCH 1/1] IBM Z: Fix endianess problem in pid_memory_read

2020-11-19 Thread Andreas Krebbel via Elfutils-devel
The cached reads lack the big endian adjustments done in the fallback path. Signed-off-by: Andreas Krebbel --- libdwfl/ChangeLog | 5 + libdwfl/linux-pid-attach.c | 10 +- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/libdwfl/ChangeLog b/libdwfl/ChangeLog i

Re: [PATCH 1/1] IBM Z: Fix endianess problem in pid_memory_read

2020-11-19 Thread Mark Wielaard
Hi Andreas, On Thu, Nov 19, 2020 at 08:32:24PM +0100, Andreas Krebbel via Elfutils-devel wrote: > The cached reads lack the big endian adjustments done in the fallback > path. Thanks for finding this. Did you find this by code inspection or by having a 31bit binary backtrace on a 64bit system fa

Re: [PATCH 1/1] IBM Z: Fix endianess problem in pid_memory_read

2020-11-19 Thread Andreas Krebbel via Elfutils-devel
On 20.11.20 01:33, Mark Wielaard wrote: > Hi Andreas, > > On Thu, Nov 19, 2020 at 08:32:24PM +0100, Andreas Krebbel via Elfutils-devel > wrote: >> The cached reads lack the big endian adjustments done in the fallback >> path. > > Thanks for finding this. Did you find this by code inspection or b