Re: patch 1/2 debuginfod client

Hi - > [...libdw* debuginfod_find_* calls] > But given that they are almost similar, I would suggest to move both > into their own file sharing most of the code to do the dlopen dance. Where? It can't be in the solib. We're talking about sharing, what, two copies of three or four lines of code

Re: patch 2/2 debuginfod server etc.

Hi - > > +++ b/config/debuginfod.service > > +[Service] > > +Group=debuginfod > > +#CacheDirectory=debuginfod > > +ExecStart=/usr/bin/debuginfod -d /var/cache/debuginfod/debuginfod.sqlite > > -p $DEBUGINFOD_PORT $DEBUGINFOD_VERBOSE $DEBUGINFOD_PATHS > Why is CacheDirectory commented out, I canno

Re: patch 2/2 debuginfod server etc.

Hi - > Like with the client manpages, I think they should go into the doc/ dir > just because all manpages are there at the moment. OK. > > -bin_PROGRAMS = debuginfod-find > > +bin_PROGRAMS = debuginfod debuginfod-find > > +debuginfod_SOURCES = debuginfod.cxx > > +debuginfod_cxx_CXXFLAGS = -Wno-

[PATCH] dwelf_elf_e_machine_string: Clear errno before calling strtol

Avoid spurious failure if errno is modified by any other library call in the test. Signed-off-by: Andreas Schwab --- tests/ChangeLog| 5 + tests/dwelf_elf_e_machine_string.c | 1 + 2 files changed, 6 insertions(+) diff --git a/tests/ChangeLog b/tests/ChangeLog index 97b8

[PATCH] run-large-elf-file.sh: skip if free memory information is not available

--- tests/ChangeLog | 5 + tests/run-large-elf-file.sh | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/tests/ChangeLog b/tests/ChangeLog index 97b8dedb..f37f6cd6 100644 --- a/tests/ChangeLog +++ b/tests/ChangeLog @@ -1,3 +1,8 @@ +2019-11-14 Andreas Schwab

Re: patch 2/2 debuginfod server etc.

Hi, On Mon, 2019-10-28 at 15:07 -0400, Frank Ch. Eigler wrote: > Add the server to the debuginfod/ subdirectory. This is a highly > multithreaded c++11 program (still buildable on rhel7's gcc 4.8, > which is only partly c++11 compliant). Includes an initial suite > of tests, man pages, and a sam

Re: [PATCH] dwelf_elf_e_machine_string: Clear errno before calling strtol

On Thu, Nov 14, 2019 at 02:54:58PM +0100, Andreas Schwab wrote: > Avoid spurious failure if errno is modified by any other library call in > the test. Looks correct. Pushed to master. Thanks, Mark

Re: [PATCH] run-large-elf-file.sh: skip if free memory information is not available

On Thu, Nov 14, 2019 at 04:50:26PM +0100, Andreas Schwab wrote: > +2019-11-14 Andreas Schwab > + > + * run-large-elf-file.sh: Skip if available memory cannot be > + determined. Yes, good idea. When /usr/bin/free isn't installed we would otherwise always run the test. Pushed to master.