Re: [PATCH] elfclassify tool

2019-07-26 Thread Mark Wielaard
Hi, On Mon, Jul 22, 2019 at 05:54:57PM +0200, Florian Weimer wrote: > I went through these patches, albeit in a somewhat cursory fashion, and > they look okay to me. > > Do you think this is enough to port over RPM's find-debuginfo.sh? Yes, I think this would make it possible to drop reliance on

Re: [PATCH] elfclassify: Add --library classification.

2019-07-26 Thread Dmitry V. Levin
On Fri, Jul 26, 2019 at 12:39:32AM +0200, Mark Wielaard wrote: > > Maybe you are looking for another goal/classification? For example I > > added --program which does classify those special files as programs > > (even though --shared also says they are shared libraries). Maybe you > > are looking

Re: [PATCH] elfclassify tool

2019-07-26 Thread Dmitry V. Levin
On Sat, Jul 20, 2019 at 11:51:16PM +0200, Mark Wielaard wrote: > On Sat, Jul 20, 2019 at 01:57:27AM +0300, Dmitry V. Levin wrote: [...] > > btw, I think it would be appropriate to move the has_dynamic check before > > the first check in is_shared that returns true. > > Yes, that is probably fine,