[COMMITTED] tests: Don't printf a known NULL symname in backtrace-dwarf.c.

2019-05-01 Thread Mark Wielaard
GCC9 on 32bit systems might warn about '%s' directive argument is null for symname in backtrace-dwarf.c. Just check whether symname is NULL. This is an identical fix for the same issue as found in backtrace.c, but now in backtrace-dwarf.c Signed-off-by: Mark Wielaard --- tests/ChangeLog

[PATCH] libelf: Add n_namesz offset overflow check to gelf_get_note.

2019-05-01 Thread Mark Wielaard
During fuzzing of the new xlate_notes testcase I noticed that gelf_get_note didn't check whether the n_namesz of a note was too big. This could lead to offset wrapping around. Causing an infinite loop going over all ELF notes. Fix by adding an overflow check before updating offset. Signed-off-by:

Re: Dwarf_Op

2019-05-01 Thread Sasha Da Rocha Pinheiro
Hi Mark, yes, I did use dwarf_frame_register(), I believe I mentioned that :). In the case I brought up you're saying it was an elfutils' libdw decision to provide negative number as DW_OP_plus_uconst (unsigned constant)? So there would be no harm to cast it to a signed int?? Do you know if the

[Bug tools/24509] New: eu-readelf does not know how to dissect DW_AT_discr_list

2019-05-01 Thread tromey at sourceware dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=24509 Bug ID: 24509 Summary: eu-readelf does not know how to dissect DW_AT_discr_list Product: elfutils Version: unspecified Status: NEW Severity: normal

[Bug tools/24509] eu-readelf does not know how to dissect DW_AT_discr_list

2019-05-01 Thread mark at klomp dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=24509 Mark Wielaard changed: What|Removed |Added CC||mark at klomp dot org --- Comment #1

Re: Dwarf_Op

2019-05-01 Thread Mark Wielaard
On Wed, May 01, 2019 at 05:08:15PM +, Sasha Da Rocha Pinheiro wrote: > yes, I did use dwarf_frame_register(), I believe I mentioned that :). Sorry, I missed that. > In the case I brought up you're saying it was an elfutils' libdw > decision to provide negative number as DW_OP_plus_uconst (uns