[PATCH] readelf: Report error when decl_file or call_file attribute is invalid.

2018-03-20 Thread Mark Wielaard
Report an error for why the DW_AT_decl_file or DW_AT_call_file cannot be resolved to a file name. This is likely invalid DWARF, a missing DW_AT_stmt_list attribute on the CU or a missing .debug_line section. Signed-off-by: Mark Wielaard --- src/ChangeLog | 5 + src/readelf.c | 18 ++

[Bug general/22976] global-buffer-overflow in ebl_dynamic_tag_name (libebl/ebldynamictagname.c)

2018-03-20 Thread mark at klomp dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=22976 Mark Wielaard changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|---

Re: How to associate Elf with Dwfl_Module returned by dwfl_report_module

2018-03-20 Thread Mark Wielaard
Hi Milian, On Sat, Mar 17, 2018 at 02:14:48PM +0100, Milian Wolff wrote: > a recurring issue in the libdwfl integration of perf and perfparser are > supposedly overlapping modules. The perf data file contains the exact > mappings > for all files corresponding to the actual mmap events that occu

Re: [PATCH] libdwfl: Use process_vm_readv when available.

2018-03-20 Thread Mark Wielaard
On Sun, Mar 18, 2018 at 01:43:23AM +0100, Mark Wielaard wrote: > If possible use process_vm_readv to read 4K blocks instead of fetching > each word individually with ptrace. For unwinding this often means we > only have to do one process_vm_readv of the stack instead of dozens of > ptrace calls. Th

Re: [PATCH] Specify a custom git merge driver for ChangeLog files

2018-03-20 Thread Mark Wielaard
I am not against this, but it could use a bit more documentation in at least the commit message, so people know what they should setup in their gitconfig. Also isn't it better to have something like the following in your local ~/.gitconfig: [core] attributesfile = ~/.gitattributes And th

Re: [PATCH] Specify a custom git merge driver for ChangeLog files

2018-03-20 Thread Dmitry V. Levin
On Wed, Mar 21, 2018 at 12:03:53AM +0100, Mark Wielaard wrote: > I am not against this, but it could use a bit more documentation > in at least the commit message, so people know what they should > setup in their gitconfig. The advantage of adding .gitattributes file to repository is that no gitco

Re: [PATCH] libdwfl: Use process_vm_readv when available.

2018-03-20 Thread Dmitry V. Levin
On Sun, Mar 18, 2018 at 01:43:23AM +0100, Mark Wielaard wrote: [...] > @@ -115,12 +116,80 @@ __libdwfl_ptrace_attach (pid_t tid, bool > *tid_was_stoppedp) >return true; > } > > +#ifdef HAVE_PROCESS_VM_READV > +static bool > +read_cached_memory (struct __libdwfl_pid_arg *pid_arg, > +

Re: [PATCH] Specify a custom git merge driver for ChangeLog files

2018-03-20 Thread Dmitry V. Levin
On Wed, Mar 21, 2018 at 02:20:51AM +0300, Dmitry V. Levin wrote: > On Wed, Mar 21, 2018 at 12:03:53AM +0100, Mark Wielaard wrote: > > I am not against this, but it could use a bit more documentation > > in at least the commit message, so people know what they should > > setup in their gitconfig. >

Re: [PATCH] Specify a custom git merge driver for ChangeLog files

2018-03-20 Thread Mark Wielaard
On Wed, Mar 21, 2018 at 02:20:51AM +0300, Dmitry V. Levin wrote: > On Wed, Mar 21, 2018 at 12:03:53AM +0100, Mark Wielaard wrote: > > I am not against this, but it could use a bit more documentation > > in at least the commit message, so people know what they should > > setup in their gitconfig. >

Re: [PATCH] libdwfl: Use process_vm_readv when available.

2018-03-20 Thread Mark Wielaard
On Wed, Mar 21, 2018 at 02:28:48AM +0300, Dmitry V. Levin wrote: > On Sun, Mar 18, 2018 at 01:43:23AM +0100, Mark Wielaard wrote: > > + /* Let the ptrace fallback deal with the corner case of the address > > + possibly crossing a page boundery. */ > > + if ((addr & ((Dwarf_Addr)__LIBDWFL_REM