[Bug libdw/22546] dwarf_aggregate_size() doesn't work for multi-dimensional arrays

2017-12-12 Thread sourceware at dima dot secretsauce.net
https://sourceware.org/bugzilla/show_bug.cgi?id=22546 --- Comment #7 from dima kogan --- Thanks for looking at it. I submitted the patch. -- You are receiving this mail because: You are on the CC list for the bug.

Re: [PATCH] Fix 22546: dwarf_aggregate_size() works with multi-dimensional arrays

2017-12-12 Thread Mark Wielaard
On Mon, 2017-12-11 at 21:57 -0800, Dima Kogan wrote: > If we have a multidimensional array of dimensions (a,b,c) the number of > elements > should be a*b*c, but prior to this patch dwarf_aggregate_size() would report > a+b+c instead. > > This patch fixes the bug and adds a test that demonstrates

[PATCH] libdw: dwarf_aggregate_size should not don't peel the given DIE.

2017-12-12 Thread Mark Wielaard
Reserve memory for a new DIE first. The caller might not care, but it isn't really nice to change the DIE the caller gave us. See also https://sourceware.org/bugzilla/show_bug.cgi?id=22546#c5 Signed-off-by: Mark Wielaard --- libdw/ChangeLog | 5 + libdw/dwarf_aggregate_size.c |

[Bug libdw/22546] dwarf_aggregate_size() doesn't work for multi-dimensional arrays

2017-12-12 Thread mark at klomp dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=22546 Mark Wielaard changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

Re: [PATCH] config: Add pkgincludedir to Cflags

2017-12-12 Thread Namhyung Kim
Hello, On Tue, Dec 12, 2017 at 8:13 AM, Mark Wielaard wrote: > On Fri, 2017-12-08 at 15:17 +0900, Namhyung Kim wrote: >> The libelf and libdw uses pkginclude_HEADERS but the pkg-config file >> misses to have it the Cflags. This was a problem for libdw users since >> it gave nothing to include, b