[Bug libdw/22546] dwarf_aggregate_size() doesn't work for multi-dimensional arrays

2017-12-11 Thread mark at klomp dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=22546 Mark Wielaard changed: What|Removed |Added CC||mark at klomp dot org --- Comment #5

[Bug libdw/22546] dwarf_aggregate_size() doesn't work for multi-dimensional arrays

2017-12-11 Thread mark at klomp dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=22546 --- Comment #6 from Mark Wielaard --- I believe your fix is correct. And we really do want to calculate the stride only once based on the array element type, not for each dimension. I am not sure what the original code tried to do. It probably

Re: [PATCH] readelf: Print arguments to DW_OP_call2 and DW_OP_call4 as DIE offsets.

2017-12-11 Thread Mark Wielaard
On Thu, 2017-12-07 at 22:39 +0100, Mark Wielaard wrote: > DW_OP_call2 and DW_OP_call4 didn't correctly advance the data pointer. > This caused print_ops to produce garbage operands. Also format the > arguments as DIE offsets. That makes it easier to follow the call to > the actual dwarf_procedure D

Re: [PATCH] config: Add pkgincludedir to Cflags

2017-12-11 Thread Mark Wielaard
On Fri, 2017-12-08 at 15:17 +0900, Namhyung Kim wrote: > The libelf and libdw uses pkginclude_HEADERS but the pkg-config file > misses to have it the Cflags.  This was a problem for libdw users since > it gave nothing to include, but one needs to add /usr/include/elfutils > directory to use the lib

[PATCH] Fix 22546: dwarf_aggregate_size() works with multi-dimensional arrays

2017-12-11 Thread Dima Kogan
This fixes https://sourceware.org/bugzilla/show_bug.cgi?id=22546 >From 5f65148409fa08613f21280c5aea026d8b78366f Mon Sep 17 00:00:00 2001 From: Dima Kogan Date: Fri, 8 Dec 2017 01:45:10 -0800 Subject: [PATCH] libdw: dwarf_aggregate_size() works with multi-dimensional arrays If we have a multidi