Re: [PATCH] ppc64: Add minimal fallback unwinder.

2017-05-30 Thread Naveen N. Rao
On 2017/05/24 10:05PM, Mark Wielaard wrote: > This adds a minimal fallback unwinder for ppc64[le] in case we cannot find > CFI for a particular address. It simply always sets the program counter to > the link register, picks the previous stack pointer from the backchain, > and the previous link reg

Re: [PATCH] ppc64: Add minimal fallback unwinder.

2017-05-30 Thread Mark Wielaard
On Tue, 2017-05-30 at 13:28 +0530, Naveen N. Rao wrote: > > + if (! readfunc(sp + LR_OFFSET, &newLr, arg)) > > should this be newSp + LR_OFFSET, since the LR save area is in the > caller's stack frame? Of course. You are entirely right. This also explains why the testcase didn't seem to work c

Re: [PATCH] ppc64: Add minimal fallback unwinder.

2017-05-30 Thread Paolo Bonzini
On 30/05/2017 16:37, Mark Wielaard wrote: > On Tue, 2017-05-30 at 13:28 +0530, Naveen N. Rao wrote: >>> + if (! readfunc(sp + LR_OFFSET, &newLr, arg)) >> >> should this be newSp + LR_OFFSET, since the LR save area is in the >> caller's stack frame? > > Of course. You are entirely right. > > T