Re: patch rfc: debuginfod -Z (generalized archive) support

2020-02-10 Thread Frank Ch. Eigler
Hi - > > My C++ is pretty terrible, but couldn't you handle that with something > > like: > > Ah, yes, good eye, pclose and fclose are interchangeable function > pointers. (close(2) along the lines of your other suggestion wouldn't > be.) pushed to master, with another instance of this improvem

Re: patch rfc: debuginfod -Z (generalized archive) support

2020-02-07 Thread Frank Ch. Eigler
Hi - > My C++ is pretty terrible, but couldn't you handle that with something > like: Ah, yes, good eye, pclose and fclose are interchangeable function pointers. (close(2) along the lines of your other suggestion wouldn't be.) - FChE

Re: patch rfc: debuginfod -Z (generalized archive) support

2020-02-07 Thread Mark Wielaard
Hi Frank, On Fri, 2020-02-07 at 08:57 -0500, Frank Ch. Eigler wrote: > > Yes, lets make =CMD optional. But why assume "cat"? Can't you then > > simply use fopen instaed of popen in the code to get the FILE* to pass > > to archive_read_open_FILE? Or even just open and archive_read_open_fd? > > One

Re: patch rfc: debuginfod -Z (generalized archive) support

2020-02-07 Thread Frank Ch. Eigler
Hi - > Yes, lets make =CMD optional. But why assume "cat"? Can't you then > simply use fopen instaed of popen in the code to get the FILE* to pass > to archive_read_open_FILE? Or even just open and archive_read_open_fd? One reason: the defer_dtor<>-based auto-closing of these objects is different

Re: patch rfc: debuginfod -Z (generalized archive) support

2020-02-07 Thread Frank Ch. Eigler
Hi - > Yes, lets make =CMD optional. But why assume "cat"? Can't you then > simply use fopen instaed of popen in the code to get the FILE* to pass > to archive_read_open_FILE? Or even just open and archive_read_open_fd? Sounds like a plan. - FChE

Re: patch rfc: debuginfod -Z (generalized archive) support

2020-02-07 Thread Mark Wielaard
Hi Frank, On Fri, Feb 07, 2020 at 06:44:02AM -0500, Frank Ch. Eigler wrote: > > [...] I think it would be better if you could simply leave off the > > conversion CMD and just provide an EXT (without =). This would then > > just pass the file with the given extension to libarchive directly > > (the

Re: patch rfc: debuginfod -Z (generalized archive) support

2020-02-07 Thread Frank Ch. Eigler
Hi - > I really like how simple adding this feature is. Shows the design for > adding new formats was done with some foresight. Thanks! > [...] I think it would be better if you could simply leave off the > conversion CMD and just provide an EXT (without =). This would then > just pass the file

Re: patch rfc: debuginfod -Z (generalized archive) support

2020-02-07 Thread Mark Wielaard
Hi Frank, On Wed, Feb 05, 2020 at 03:09:18PM -0500, Frank Ch. Eigler wrote: > A little extension lets us process arch-linux archives. Awaiting > for some small test .pkg's from the arch folks for the elfutils > testsuite. However, hand-testing on severa larger files works! > > commit b51ae89bef

patch rfc: debuginfod -Z (generalized archive) support

2020-02-05 Thread Frank Ch. Eigler
Hi - A little extension lets us process arch-linux archives. Awaiting for some small test .pkg's from the arch folks for the elfutils testsuite. However, hand-testing on severa larger files works! commit b51ae89befeb81c8b51b15b7168c6e616255b486 (fche/pacman-Z) Author: Frank Ch. Eigler Date: