Re: RFCv2: debuginfod debian archive support

2019-12-22 Thread Mark Wielaard
Hi Frank, On Fri, 2019-12-13 at 14:25 -0500, Frank Ch. Eigler wrote: > > I see, I missed that both functions are only called after first > > checking the archive type. I think it might be helpful/clearer if > > both methods would be called with the intended archive type then, > > also because that

Re: RFCv2: debuginfod debian archive support

2019-12-13 Thread Frank Ch. Eigler
Hi - > I see, I missed that both functions are only called after first > checking the archive type. I think it might be helpful/clearer if both > methods would be called with the intended archive type then, also > because that might make it simpler to... The archive subtype (rpm vs deb) is not st

Re: RFCv2: debuginfod debian archive support

2019-12-11 Thread Mark Wielaard
Hi Frank, On Fri, 2019-12-06 at 22:03 -0500, Frank Ch. Eigler wrote: > @@ -851,7 +867,11 @@ handle_buildid_r_match (int64_t b_mtime, > > >return 0; > > > } > > > > > > - string popen_cmd = string("rpm2cpio " + shell_escape(b_source0)); > > > + string archive_decoder = "/dev/null";

Re: RFCv2: debuginfod debian archive support

2019-12-11 Thread Mark Wielaard
Hi, On Fri, 2019-12-06 at 16:17 -0500, Frank Ch. Eigler wrote: > Presenting testing for the debuginfod .deb/.ddeb support patch, after > finding a good debian-packaging tutorial, and generating a workable > basic set of test deb's on a Ubuntu box. According to Matthias on irc there should be no d

Re: RFCv2: debuginfod debian archive support

2019-12-06 Thread Frank Ch. Eigler
Hi - Thanks for the review! > I looked at some distros, but the only ones that provide consistent > debug[info] packages do so in rpm or deb format. Yeah. > What is the difference between a .deb and a .ddeb file/archive? AIUI, .ddeb = debugging .deb ... although the "-dbgsym" substring already

Re: RFCv2: debuginfod debian archive support

2019-12-06 Thread Mark Wielaard
Hi Frank, On Mon, 2019-12-02 at 17:54 -0500, Frank Ch. Eigler wrote: > If anyone knows of a distro or ISV who is using standard .zip or .tar > or somesuch archive formats as their distribution mechanism, it would > be a tiny effort more to add another option, say "-A" (any archive), > because liba

Re: RFCv2: debuginfod debian archive support

2019-12-06 Thread Frank Ch. Eigler
Hi - Presenting testing for the debuginfod .deb/.ddeb support patch, after finding a good debian-packaging tutorial, and generating a workable basic set of test deb's on a Ubuntu box. This patch is also on the elfutils.git fche/debuginfod-deb branch. In the absence of objections, I plan to merge

Re: RFCv2: debuginfod debian archive support

2019-12-05 Thread Mark Wielaard
Hi Kurt and Matthias, On Mon, 2019-12-02 at 17:54 -0500, Frank Ch. Eigler wrote: > On second thought, generalized the code & terminology. This may be > ready for merging, except that it'd be awesome if a > debian/ubuntu-literate person could create some test .deb/.ddeb files > matching the tests/