Re: PR29472: debuginfod metadata query

Hi Frank, On Wed, 2023-04-12 at 16:31 -0400, Frank Ch. Eigler via Elfutils-devel wrote: > At long last, for your review, an updated & merged patch for $SUBJECT. > "git diff -s" against git/master follows, code also on > users/fche/try-pr29472e. > > > Author: Frank Ch. Eigler > Date: Tue Apr 1

Re: PR29472: debuginfod metadata query

Hi Frank, And finally the debuginfod server code itself. On Wed, 2023-04-12 at 16:31 -0400, Frank Ch. Eigler via Elfutils-devel wrote: > + * debuginfod.cxx (DEBUGINFOD_SQLITE_DDL): Add an index or two. > + (metadata_maxtime_s, parse_opt): New parameter for load control. > + (add_clien

Re: PR29472: debuginfod metadata query

Hi Frank, Skipping debuginfod.cxx itself for now. Review of everything else left. On Wed, 2023-04-12 at 16:31 -0400, Frank Ch. Eigler via Elfutils-devel wrote: > + * debuginfod.h.in (debuginfod_find_metadata): New decl. > + * libdebuginfod.map: Export it under ELFUTILS_0.190. > [...] > >

Re: PR29472: debuginfod metadata query

Hi Frank, A quick review of debuginfod-find. On Wed, 2023-04-12 at 16:31 -0400, Frank Ch. Eigler via Elfutils-devel wrote: > + * debuginfod-find.c (main): Handle metadata queries. > > diff --git a/debuginfod/debuginfod-find.c b/debuginfod/debuginfod-find.c > index 307310988c4c..2df6436d99a2

Re: PR29472: debuginfod metadata query

Hi Frank, On Wed, Apr 12, 2023 at 04:31:49PM -0400, Frank Ch. Eigler via Elfutils-devel wrote: > index f13c28d5c6f7..ac3fd6aa862f 100644 > --- a/debuginfod/ChangeLog > +++ b/debuginfod/ChangeLog > @@ -1,3 +1,26 @@ > +2023-04-12 Ryan Golberg , Frank Ch. Eigler > > + > + PR29472: debuginfod

Re: PR29472: debuginfod metadata query

Hi Frank, On Wed, 2023-04-12 at 16:31 -0400, Frank Ch. Eigler via Elfutils-devel wrote: > At long last, for your review, an updated & merged patch for $SUBJECT. > "git diff -s" against git/master follows, code also on > users/fche/try-pr29472e. Apologies for the delay in review. This is mainly be