Re: [PATCH v2] Improve building with LTO

2021-11-09 Thread Mark Wielaard
Hi Martin, On Tue, 2021-11-09 at 14:31 +0100, Martin Liška wrote: > > What do the test results look like? Do they all PASS with -ffat- > > lto-objects? > > > > Could you try the proposed patch for > > https://sourceware.org/bugzilla/show_bug.cgi?id=27367 > > https://sourceware.org/pipermail/elfut

Re: [PATCH v2] Improve building with LTO

2021-11-09 Thread Martin Liška
On 11/9/21 14:31, Martin Liška wrote: Correct, I'm not using: s/not/now

Re: [PATCH v2] Improve building with LTO

2021-11-09 Thread Martin Liška
On 11/9/21 12:45, Mark Wielaard wrote: Hi Martin, On Tue, 2021-11-09 at 10:04 +0100, Martin Liška wrote: On 11/9/21 09:58, Dmitry V. Levin wrote: Yes, but those who build elfutils with -flto are likely using -ffat-lto-objects if they build static libraries. Yes, I can confirm that we do that

Re: [PATCH v2] Improve building with LTO

2021-11-09 Thread Mark Wielaard
Hi Martin, On Tue, 2021-11-09 at 10:04 +0100, Martin Liška wrote: > On 11/9/21 09:58, Dmitry V. Levin wrote: > > Yes, but those who build elfutils with -flto are likely using > > -ffat-lto-objects if they build static libraries. > > Yes, I can confirm that we do that as openSUSE, we actually buil

Re: [PATCH v2] Improve building with LTO

2021-11-09 Thread Martin Liška
On 11/9/21 10:09, Dmitry V. Levin wrote: On Tue, Nov 09, 2021 at 10:04:57AM +0100, Martin Liška wrote: On 11/9/21 09:58, Dmitry V. Levin wrote: Yes, but those who build elfutils with -flto are likely using -ffat-lto-objects if they build static libraries. Yes, I can confirm that we do that as

Re: [PATCH v2] Improve building with LTO

2021-11-09 Thread Dmitry V. Levin
On Tue, Nov 09, 2021 at 10:04:57AM +0100, Martin Liška wrote: > On 11/9/21 09:58, Dmitry V. Levin wrote: > > Yes, but those who build elfutils with -flto are likely using > > -ffat-lto-objects if they build static libraries. > > Yes, I can confirm that we do that as openSUSE, we actually build wit

Re: [PATCH v2] Improve building with LTO

2021-11-09 Thread Martin Liška
On 11/9/21 09:58, Dmitry V. Levin wrote: Yes, but those who build elfutils with -flto are likely using -ffat-lto-objects if they build static libraries. Yes, I can confirm that we do that as openSUSE, we actually build with: -flto -flto-partition=none -Wno-error=stack-usage= -ffat-lto-objects

Re: [PATCH v2] Improve building with LTO

2021-11-09 Thread Dmitry V. Levin
Hi Mark, On Tue, Nov 09, 2021 at 12:18:31AM +0100, Mark Wielaard wrote: > Hi Dmitry, > > On Mon, Nov 08, 2021 at 01:02:28PM +0300, Dmitry V. Levin wrote: > > > Thanks. This patch was indeed one reason I kept postponing the release, > > > because I didn't have have time to properly review it. > >

Re: [PATCH v2] Improve building with LTO

2021-11-08 Thread Mark Wielaard
Hi Dmitry, On Mon, Nov 08, 2021 at 01:02:28PM +0300, Dmitry V. Levin wrote: > > Thanks. This patch was indeed one reason I kept postponing the release, > > because I didn't have have time to properly review it. > > > > Which gcc versions have you tried this against (with/without -flto?) > > I te

Re: [PATCH v2] Improve building with LTO

2021-11-08 Thread Dmitry V. Levin
Hi Mark, On Thu, Nov 04, 2021 at 01:12:29PM +0100, Mark Wielaard wrote: > Hi Dmitry, > > On Thu, 2021-11-04 at 14:23 +0300, Dmitry V. Levin wrote: > > On Sat, Aug 28, 2021 at 12:31:43PM +0300, Dmitry V. Levin wrote: > > > On Thu, Feb 18, 2021 at 03:38:56AM +0100, Alexander Miller via > > > Elfuti

Re: [PATCH v2] Improve building with LTO

2021-11-04 Thread Mark Wielaard
Hi Dmitry, On Thu, 2021-11-04 at 14:23 +0300, Dmitry V. Levin wrote: > On Sat, Aug 28, 2021 at 12:31:43PM +0300, Dmitry V. Levin wrote: > > On Thu, Feb 18, 2021 at 03:38:56AM +0100, Alexander Miller via > > Elfutils-devel wrote: > > > From: Alexander Miller > > > > > > Use symver attribute for s

Re: [PATCH v2] Improve building with LTO

2021-11-04 Thread Dmitry V. Levin
On Sat, Aug 28, 2021 at 12:31:43PM +0300, Dmitry V. Levin wrote: > On Thu, Feb 18, 2021 at 03:38:56AM +0100, Alexander Miller via Elfutils-devel > wrote: > > From: Alexander Miller > > > > Use symver attribute for symbol versioning instead of .symver > > assembler directive when available. Conve

Re: [PATCH v2] Improve building with LTO

2021-08-28 Thread Dmitry V. Levin
On Thu, Feb 18, 2021 at 03:38:56AM +0100, Alexander Miller via Elfutils-devel wrote: > From: Alexander Miller > > Use symver attribute for symbol versioning instead of .symver > assembler directive when available. Convert to use double @ syntax > for default version in all cases (required when u